Paul POULAIN [Fri, 30 May 2008 14:33:38 +0000 (16:33 +0200)]
add borrower note to check-in
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 30 May 2008 14:33:36 +0000 (16:33 +0200)]
enhance the patron note on check-out (was not enough visible, now is red)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 28 May 2008 20:33:56 +0000 (22:33 +0200)]
If the catalogue contains a value that is not in authorised values and it should, display the code
very usefull for us (UNIMARC) to find languages that are in the database but not in the auth values.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 28 May 2008 16:48:11 +0000 (18:48 +0200)]
Displaying branchcode and notes fields in full serials issue table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 28 May 2008 16:48:10 +0000 (18:48 +0200)]
Respect BiblioDefaultView when search returns only 1 result & jump directly to the detail
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 28 May 2008 16:48:09 +0000 (18:48 +0200)]
small (UNIMARC) fix, error in regexp writing
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 28 May 2008 16:48:08 +0000 (18:48 +0200)]
change in button description to explain that we will import into catalogue
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Fri, 30 May 2008 16:15:05 +0000 (18:15 +0200)]
add script to install koha on a fresh debian.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 30 May 2008 16:36:04 +0000 (11:36 -0500)]
nomenclature cleanup: s/Branch/Library/ s/Document Type/Item Type/
Henri-Damien LAURENT [Mon, 26 May 2008 14:37:07 +0000 (16:37 +0200)]
Adding branchcode to opac-full-serial-issues
Suggestion : We may add some jquery ordering on those tables
Can we owen ?
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 30 May 2008 16:17:21 +0000 (11:17 -0500)]
DB Revision 087
Mason James [Thu, 22 May 2008 09:23:43 +0000 (21:23 +1200)]
adding default 'account details' notice.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Mason James [Thu, 22 May 2008 09:23:36 +0000 (21:23 +1200)]
bug-2149, var fix - changing borr.cardnumber to borr.userid.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Mason James [Thu, 22 May 2008 09:23:24 +0000 (21:23 +1200)]
bug-2149, added 'AutoEmailOpacUser' and 'AutoEmailPrimaryAddress' sysprefs
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Mason James [Thu, 22 May 2008 09:23:14 +0000 (21:23 +1200)]
bug-2149, added new block to C4::Letters::SendAlerts() to email 'account creation' notice, and new block in memberentry.pl to call SendAlerts().
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 29 May 2008 18:15:23 +0000 (13:15 -0500)]
Repair Labels code to accomodate patroncards. Purged EXPR.
Major FIXME's still remain, like the use of GET instead of POST.
The code is also a bit too INCLUDE-happy to net good performance.
The entire mechanism of adding to a batch should probably be proper
AJAX instead of the GET-centric opener.location approach.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 29 May 2008 14:59:35 +0000 (09:59 -0500)]
Fixing some typos, including, I believe, Bug 2174 ("spelling error in web installer")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 29 May 2008 13:59:25 +0000 (08:59 -0500)]
minor cleanup, remove $sth->finish's. No documentation impact.
For details: see http://search.cpan.org/~timb/DBI-1.14/DBI.pm
"There's no need to call finish if you're about to destroy or re-execute the statement handle."
In all these cases the sth is falling out of scope, about to be destroyed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 29 May 2008 13:59:24 +0000 (08:59 -0500)]
is_ajax function added. pagination_bar now intelligent: it has
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 29 May 2008 12:17:59 +0000 (07:17 -0500)]
Removing dbh line altogether as discussed on koha-patches
Henri-Damien LAURENT [Tue, 20 May 2008 15:40:24 +0000 (17:40 +0200)]
Bug Fix : Creating a new authority type would fail on creating subfield_structure
removing "link" field which has been removed from table auth_subfield_structure
Removing a $dbh->disconnect
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 28 May 2008 17:08:47 +0000 (12:08 -0500)]
kohabug 2164 - display of guarantor relationship
When editing a child or professional patron, display
the drop-down of relationship types only if at least
one relationship type is defined by the borrowerRelationship
syspref.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 29 May 2008 01:31:28 +0000 (20:31 -0500)]
Tags AJAX integration on OPAC details page, so it behaves like results.
Also, prevent duplicate tags (same user, biblio and term). Strip
leading/trailing whitespace from term. Block whitespace terms.
The CSS for details could be enhanced to emphasize tagstatus more.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 28 May 2008 20:33:07 +0000 (15:33 -0500)]
Make printslip and printpage buttons use popup.
This bug was reported by existing users.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 28 May 2008 20:33:06 +0000 (15:33 -0500)]
Correct typo "printslilp" to "printslip"
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:06:01 +0000 (18:06 -0500)]
Fines repair. Make fines2.pl work, give feedback, improve comments and perldoc.
Remove $dbh->disconnect statements as counterproductive.
Prevent description field from begining with whitespace.
Added robust debug elements. Test script behavior with:
perl misc/cronjobs/fines2.pl -v
and:
mysql> select * from accountlines;
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:06:00 +0000 (18:06 -0500)]
Adding basic get_filters to Tags, centralizing "counts" code for Terms Summary.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:05:59 +0000 (18:05 -0500)]
Remove string processing (redundant to new pagination_bar)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:05:58 +0000 (18:05 -0500)]
Single FIXME comment inserted.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:05:57 +0000 (18:05 -0500)]
Commented out fixaccounts (not used anywhere). Also improved getnextacctno.
You can test getnextacctno like:
perl -e 'use C4::Accounts; print getnextacctno(33), "\n";'
where 33 is a borrowernumber out of the accountlines table. Get that number like:
mysql> select borrowernumber,accountno from accountlines LIMIT 100;
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:04:13 +0000 (18:04 -0500)]
Correct number of args to getnextacctno.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 27 May 2008 23:04:12 +0000 (18:04 -0500)]
Corrected wrong number of arguments to getnextacctno.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 22 May 2008 20:10:22 +0000 (15:10 -0500)]
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients. Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback. Other popups are likely
to exhibit this same defective behavior.
Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 22 May 2008 15:24:09 +0000 (10:24 -0500)]
Bugfix 1978 - if invalid duedate specified, return error, do not issue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Michael Hafen [Tue, 27 May 2008 18:11:21 +0000 (12:11 -0600)]
fixed session cookie name in opac-logout.pl
Session Cookie name is CGISESSID in Auth.pm
Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Fri, 23 May 2008 07:40:49 +0000 (02:40 -0500)]
Unescape Comment, now that we trust Scrubber to block bad markup.
Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
br b i em big small strong
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 21 May 2008 06:36:05 +0000 (01:36 -0500)]
Tags AJAX and JSON for OPAC side.
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples. The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 22:03:11 +0000 (17:03 -0500)]
Single slash added in test text string.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 21:23:38 +0000 (16:23 -0500)]
Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 21:23:37 +0000 (16:23 -0500)]
Initial commit for Tags back-end moderation. Requires AJAX functions from Output.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 21:23:36 +0000 (16:23 -0500)]
New subs for moderation, fixed bug to allow multiple sort fields, added POD.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 21:23:35 +0000 (16:23 -0500)]
Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.
The loop_context_vars will be very useful in display. They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 25 May 2008 06:21:42 +0000 (01:21 -0500)]
Add cn_source to authorised values dropdown in marc structure editor.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 22 May 2008 20:47:25 +0000 (22:47 +0200)]
small update to french translation
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 22 May 2008 20:47:23 +0000 (22:47 +0200)]
fixing the css property for tablesorter js
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 22 May 2008 20:47:21 +0000 (22:47 +0200)]
BUGFIXING authority link in detail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 22 May 2008 20:47:20 +0000 (22:47 +0200)]
small fix for UNIMARC 600$a that is also subject
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 22 May 2008 20:47:19 +0000 (22:47 +0200)]
Adding Image::Magick version info
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 25 May 2008 20:54:21 +0000 (15:54 -0500)]
Update Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21 010 and 050. / Update labels to reflect 3.0 terminology.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 25 May 2008 07:54:18 +0000 (02:54 -0500)]
Fill statistics table properly for renewals; and issue->checkout, return->checkin
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 25 May 2008 06:21:56 +0000 (01:21 -0500)]
Add ANSCR to default cn_source list.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 25 May 2008 06:21:17 +0000 (01:21 -0500)]
Fix pagination error on subfield structure editor
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sat, 24 May 2008 19:35:08 +0000 (14:35 -0500)]
add URLLinkText syspref to opac detail, and add some extra handling for MARC 21 urls.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sat, 24 May 2008 19:35:07 +0000 (14:35 -0500)]
Show 856$3 (materials specified) by default in MARC21 .
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Thu, 22 May 2008 14:26:56 +0000 (09:26 -0500)]
Update MARC21 simple frameworks with biblio.serial and items.enumchron
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Tue, 20 May 2008 20:30:41 +0000 (22:30 +0200)]
Translatable facets in librarian interface
Pushes modified facets display from OPAC to librarian interface.
Corrects also OPAC version which were omitting Titles facet.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Tue, 20 May 2008 20:06:58 +0000 (22:06 +0200)]
Facets (current) translatable via template
This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 23 May 2008 18:35:33 +0000 (13:35 -0500)]
removing warnings from C4::Members::GetMember
C4::Members::GetMember emitted a few unnecessary warnings when no $type was passed in. This patch prevents that.
No functional or documentation changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 23 May 2008 17:36:30 +0000 (12:36 -0500)]
Bug 2047: some tests for C4::Biblio::get_biblio_authorised_values
I had these tests laying around for a while. I just forgot to commit them.
No functional or documentation changes needed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 23 May 2008 20:49:14 +0000 (15:49 -0500)]
Adding bookfund search to aqbudget.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 23 May 2008 20:49:01 +0000 (15:49 -0500)]
Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 23 May 2008 20:48:48 +0000 (15:48 -0500)]
Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:50:19 +0000 (09:50 -0500)]
Fix for Bug 2120, "
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:50:10 +0000 (09:50 -0500)]
Authorities detail page was missing toolbar, breadcrumbs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:49:58 +0000 (09:49 -0500)]
Markup error caused layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:49:51 +0000 (09:49 -0500)]
Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:49:40 +0000 (09:49 -0500)]
Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:49:27 +0000 (09:49 -0500)]
Adding breadcrumbs to advanced search screen to get us a Home link.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:48:40 +0000 (09:48 -0500)]
Adding table sorter to holds queue report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 22 May 2008 14:48:31 +0000 (09:48 -0500)]
Tweak to OPAC search bar to help prevent wrapping.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 20 May 2008 19:28:04 +0000 (14:28 -0500)]
Minor change to improve layout at lower resolutions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 20 May 2008 19:27:55 +0000 (14:27 -0500)]
Interface improvements to Holds Queue report and changes to the script provided by jmf
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 20 May 2008 19:27:47 +0000 (14:27 -0500)]
Fix for Bug 2147, "Search Results aligned top on staff side."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Tue, 20 May 2008 16:41:35 +0000 (18:41 +0200)]
Fix an encoding issue on circulation autocompletion
ysearch.pl returns a list of borrower details for circulation
autocomplete widget. Accented characters wasn't displayed
correctly.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 20 May 2008 16:21:11 +0000 (18:21 +0200)]
fix for #1788 : Locations do not sort alphabetically by name in list on "Set" location
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 20 May 2008 16:21:10 +0000 (18:21 +0200)]
bugfixing batchupdateISBN.pl
pls, someone from MARC21 confirm.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Tue, 20 May 2008 16:09:16 +0000 (11:09 -0500)]
various bugfixes for MARC21 Z39.50 targets
[1] Added MARC-8 as an encoding choice on the target
administration page.
[2] Fixed TMPL coding errors.
[3] Set the correct encoding (as it happens, 'MARC-8')
for all of the English sample Z39.50 targets.
Documentation note: due to this patch and the ones from
Frederic, screenshots of the page for editing a Z39.50
target should be redone.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Tue, 20 May 2008 15:48:00 +0000 (10:48 -0500)]
kohabug 2048 - improve zebraqueue_daemon performance
[1] Increase sleep interval between checks of zebraqueue
from 0.01 seconds to 0.50.
[2] Batch up commits of changes to the zebraqueue table
[3] If the same record appears multiple times in the queue,
handle only once.
[4] Properly postpone failures to process record deletes to
avoid spinning.
[5] Correct how queue entries are marked done - avoid skipping
an authority record update, e.g., if it has the same
ID number as a bib that was updated.
[6] Added a FIXME about a possible later enhancement to
batch up updates so that Zebra isn't told to commit
after each record.
No documentation changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 20 May 2008 12:50:22 +0000 (07:50 -0500)]
Allowing delete-biblio menu item to trigger javascript warning. Style now mimicsa disabled menu item. Addresses Bug 2135, "Cannot Delete MARC Records."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Tue, 20 May 2008 17:36:40 +0000 (12:36 -0500)]
Final update to holds queue work: adds link to holds queue
from circulation dashboard, creates new sysprefs, assigns
the sysprefs to the proper tab in sysprefs (Circulation),
updatedatabase changes to do the previous, and fixing one
redundent limit in the query for build_holds_queue.pl
Note: still need to address item-level holds
Joshua Ferraro [Tue, 20 May 2008 15:58:24 +0000 (10:58 -0500)]
Adds a cron script to be run periodically that populates
the tmp_holdsqueue table. This is an alternative holds
targeting workflow that is more suitable for multi-location
libraries than the default holds picklist report.
Note to documentation writers: this summary should be
added to any holds documentation as an overview of
the avaialable methods for holds fulfillment.
This alternative holds workflow assumes an
expectation that the system should target a specific
item for a given hold request, attempt to fulfill the
hold with that item, and if unable to fulfill, select
an available item at another location to fulfill the
hold.
This is quite different than the default Koha behavior
which uses a 'broadcast' method of hold fulfillment.
How it works:
This script weights available locations for holds based
on options specified in two system preferences:
StaticHoldsQueueWeight
Allows the library to specify a list of library
location codes -- if used alone, it will rank the
list statically, selecting the top-ranking available
location to be added to the picklist.
RandomizeHoldsQueueWeight
If RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
are set, the list of library codes in the
StaticHoldsQueueWeight syspref are randomized rather
than statically ranked. If RandomizeHoldsQueueWeight
alone is set, the list of all available library codes
is used to randomize the weight.
If neither syspref is set, the list is statically
ranked according to how they are pulled out of the system
database.
NOTE: This has not yet been tested with item-level holds
Joshua Ferraro [Tue, 20 May 2008 14:36:26 +0000 (09:36 -0500)]
DB Update .086: adding new table tmp_holdsqueue,
used for reporting picklist for holds in multi-location
libraries. This is a temporary workaround to a longer-term
post-3.0 cleanup of the holds process.
Following this will be a cron job for managing the
holds picklist queue as well as a report for viewing
the list of items from circulation
Joshua Ferraro [Tue, 20 May 2008 00:11:19 +0000 (19:11 -0500)]
Fix for Bug 1955: Remove noOPACUserLogin system preference
Joshua Ferraro [Tue, 20 May 2008 00:05:44 +0000 (19:05 -0500)]
Fix for bug 1952: OPACUserCSS preference has incorrect description
Galen Charlton [Mon, 19 May 2008 19:28:37 +0000 (14:28 -0500)]
correct path to 404.pl in opac-details.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 19 May 2008 19:28:36 +0000 (14:28 -0500)]
kohabug 2141 - avoid carp on display of details of deleted bib
When displaying details of bib in staff interface, check
that bib actually exists and display 404 page if not. Avoids
following fatal error:
Can't call method "field" on an undefined value at /home/gmc/koha/dev/C4/Biblio.pm line 944.
This situtation can arise when running Zebra; if a bib is deleted,
Zebra will not necessarily be reindexed instantly, allowing a link
from a search result list to point to a missing record.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 19 May 2008 19:28:35 +0000 (14:28 -0500)]
minor POD improvement
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 19 May 2008 20:36:37 +0000 (15:36 -0500)]
BUGFIX - pagination bar was not in template, so only the first 20 hits were
pagination bar was not in template, so only the first 20 hits were
visible. Probably it wasn't included because the script referenced a bogus base URL.
Also debugified warn statement in script. Note FIXME for bogus template reference.
We probably don't need that template or the related selector lines for it.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Mon, 19 May 2008 20:27:21 +0000 (15:27 -0500)]
Adding RenewSerialAddsSuggestion syspref to Acquisitions tab
Galen Charlton [Mon, 19 May 2008 14:59:02 +0000 (09:59 -0500)]
test suite: allow skipping of expensive tests
Defined a function attribute for KohaTest and subclasses
called 'Expensive'. When a test method has that attribute,
it is skipped unless the RUN_EXPENSIVE_TESTS environment
variable is true.
To mark a test method, expensive, do this:
sub test_foo : Tests(4) Expensive { ... }
To mark a whole class and its subclasses expensive,
define a SKIP_CLASS sub (with empty body) with the
Expensive attribute:
sub SKIP_CLASS : Expensive { }
Updated the t/Makefile so that 'make test' runs
nonexpensive tests, while 'make fulltest' runs both
cheap and expensive tests.
Marked KohaTest::Installer test class expensive.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 19 May 2008 15:05:04 +0000 (10:05 -0500)]
CSS fix for Internet Explorer display problem caused by previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 19 May 2008 14:34:59 +0000 (09:34 -0500)]
Template restructuring to allow option of styling OPAC with fixed-width layout. This commit doesn't change the default OPAC appearance.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 19 May 2008 14:34:46 +0000 (09:34 -0500)]
Adding padding to <p> to improve some readability issues; Correcting terminology in the cart (shelf -> list); Minor punctuation change in results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 19 May 2008 14:34:16 +0000 (09:34 -0500)]
A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 19 May 2008 14:34:04 +0000 (09:34 -0500)]
Trying again to fix tab issues in Internet Explorer.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Mon, 19 May 2008 18:05:49 +0000 (14:05 -0400)]
Minor updates to XSL display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sun, 18 May 2008 12:02:11 +0000 (08:02 -0400)]
Enhancement Jacket Covers in Shelf Browser should link to bib record, not to source of image
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sun, 18 May 2008 11:37:59 +0000 (07:37 -0400)]
Fixing isbn regex to not match unless isbn is valid
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Mon, 19 May 2008 18:01:04 +0000 (13:01 -0500)]
Don't display Acquisitions and Serials links if the user
doesn't have permission to view them
Joshua Ferraro [Mon, 19 May 2008 16:34:12 +0000 (11:34 -0500)]
Adding pipe (|) as delimitor option