Chris Cormack [Mon, 21 Mar 2011 07:39:05 +0000 (20:39 +1300)]
Merge remote branch 'kc/master' into new/enh/bug_5917
Frédéric Demians [Wed, 16 Mar 2011 19:25:54 +0000 (15:25 -0400)]
Bug 5065 Add ability to choose framework on import
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 21 Mar 2011 07:02:15 +0000 (20:02 +1300)]
Bug 5917 : Converted templates
Chris Cormack [Mon, 21 Mar 2011 06:54:11 +0000 (19:54 +1300)]
Merge remote branch 'kc/master' into new/enh/bug_5917
Conflicts:
installer/data/mysql/en/mandatory/sysprefs.sql
Colin Campbell [Fri, 18 Mar 2011 16:11:02 +0000 (17:11 +0100)]
Bug 5466 On new orders get currency from vendor
Previous patch for this bug was ignoring vendor currency on
new orders. In most cases should be the default
Changed variable name from cur to active_currency
Clarity is a virtue!
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Savitra Sirohi [Fri, 18 Mar 2011 16:11:01 +0000 (17:11 +0100)]
Bug 5466 - Acquisitions - ability to set currency in order screens
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jesse Weaver [Fri, 18 Mar 2011 15:10:19 +0000 (16:10 +0100)]
Bug 4878 - Command-line tool for getting and setting sysprefs
New script misc/admin/koha-preferences - Allows getting and setting of
sysprefs one-at-a-time or in bulk. More info:
misc/admin/koha-preferences help
or:
misc/admin/koha-preferences manual
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 21 Mar 2011 03:42:49 +0000 (16:42 +1300)]
Adding 2 more developers to the history 137 now!
Salvador Zaragoza Rubio [Fri, 18 Mar 2011 15:07:04 +0000 (11:07 -0400)]
Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer
It has been detected an incompatibility with Internet Explorer in the ajax.js
file that cause a javascript error for this browser that prevents proper
operation.
The error occurs because the "localName" is not supported by Internet Explorer
and returns "undefined".
Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer
Fix error on comma for IE
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Fri, 18 Mar 2011 14:30:05 +0000 (15:30 +0100)]
Bug 5892 : opac-user: minor spelling/html changes
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Julian Maurice [Fri, 18 Mar 2011 13:02:12 +0000 (13:02 +0000)]
Bug 5893: Removed duplicate entry in sysprefs.sql
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Julian Maurice [Fri, 18 Mar 2011 10:15:08 +0000 (10:15 +0000)]
Bug 5864: link biblio => serials subscription is wrong
The GetSubscription function can be called with 3 parameters : title,
issn, biblionumber.
In biblio view (both opac & staff interface), the link to jump from the
biblio to the subscription(s) was done using title.
The result was that for a title like "Science", all subscriptions
containing "science" in the title were linked.
That's too much and that's false.
This commit fixes this problem by calling GetSubscription with
biblionumber only where applicable.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Tue, 4 Jan 2011 20:51:24 +0000 (21:51 +0100)]
Bug 4330 : Adding some copyright BibLibre statements
Paul Poulain [Tue, 4 Jan 2011 20:28:10 +0000 (21:28 +0100)]
Bug 4330 : Fixing copyright and removing unconditional warn chris c mail 2010-12-16 on patches ML
Paul Poulain [Tue, 4 Jan 2011 20:26:38 +0000 (21:26 +0100)]
Bug 4330 : fixing copyright mail from chris c 2010-12-16 on patches ML
Marcel de Rooy [Thu, 17 Mar 2011 14:37:59 +0000 (10:37 -0400)]
Bug 3735: Wrong search results for a few fields in ccl.properties
This patch corrects a syntax error in the definition of bath attributes in
ccl.properties. In particular, it adds the search prefixes 'isbn', 'issn',
'name', and 'notes'. In order to make use of this patch, ccl.properties must be
updated.
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Marcel de Rooy [Thu, 17 Mar 2011 14:22:43 +0000 (10:22 -0400)]
5622: Improve display of MARC21 773 field in XSLT detail view
Applies change to OPAC and staff detail view.
Chops punctuation. Adds 773g. Strips MARC org code from URL.
Utils code is used as basis for patches #5662 and #5663 too.
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 17 Mar 2011 10:34:52 +0000 (10:34 +0000)]
Bug 5890 Correct Mismatched operator in comparison
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 17 Mar 2011 21:46:01 +0000 (10:46 +1300)]
Merge remote branch 'kc/new/enh/bug_5848' into kcmaster
Julian Maurice [Thu, 17 Mar 2011 07:41:28 +0000 (07:41 +0000)]
Bug 5848: Remove duplicated tabs in opac details for Unimarc
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 17 Mar 2011 21:38:56 +0000 (10:38 +1300)]
Merge remote branch 'kc/new/bug_5879' into kcmaster
Chris Cormack [Thu, 17 Mar 2011 21:38:40 +0000 (10:38 +1300)]
Merge remote branch 'kc/new/bug_4218' into kcmaster
Owen Leonard [Wed, 16 Mar 2011 15:40:41 +0000 (10:40 -0500)]
Follow-up fix for Bug 4218 - Staff client detail page doesn't show hold status
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Wed, 16 Mar 2011 11:06:37 +0000 (12:06 +0100)]
Bug 5879 : Biblio.pm : fix isbd syspref and default location
- the systempreference is isbd, not ISBD
- when preparing the ItemRecord (for acq or serials recieving), there was no default value calculated for location. Fixing that
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Sophie Meynieux [Thu, 17 Mar 2011 10:46:26 +0000 (11:46 +0100)]
Bug 5889: Messages name in english for notifications on public interface.
Modification of template to allow multilanguage support. Alsa fixing columns
overflow.
BibLibre bug #5939
Tests: It works. Messages strings can now be extracted and placed in .po file
for translation.
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Tue, 15 Mar 2011 14:03:30 +0000 (15:03 +0100)]
Bug 5646: Translated sql files break messaging
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Wed, 16 Mar 2011 14:41:11 +0000 (10:41 -0400)]
Bug 5882 : catalogue/moredetails (minor) changes
MT3288 moredetail.tmpl Lost and Damaged first choice is empty
First choice was the first value of the authorised value list
This is not handy for users.
Rather than showing the first value, inserting a new empty value for users to see what to do
Term "Total Renewals" misleading, change to "Current Renewals"
In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tmpl under History,
there's a Total Renewals entry: seems to indicate a cumulative count of renewals on
the item, which it is not, contrary to "Total Issues" just below.
Moved the line up outside "history", and renamed it "Current Renewals".
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Julian Maurice [Thu, 17 Mar 2011 13:33:02 +0000 (14:33 +0100)]
Follow up for bug 5880: Improved unit test
The unit test Koha.t now skip tests of the two subroutines if the insert
query failed.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Julian Maurice [Thu, 17 Mar 2011 11:30:53 +0000 (12:30 +0100)]
Follow up for bug 5880: Added unit tests for the two new subroutines
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Wed, 16 Mar 2011 10:36:49 +0000 (11:36 +0100)]
Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues
just for convenience
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 17 Mar 2011 01:37:00 +0000 (14:37 +1300)]
Merge remote branch 'kc/new/enh/bug_5869' into kcmaster
Katrin Fischer [Wed, 16 Mar 2011 07:49:37 +0000 (08:49 +0100)]
Bug 5861: items.stocknumber not saved correctly
The field was missing in Items.pm.
It will still act strangely if you enter a stocknumber that
already exists in the database. (see Bug 5860)
Adding/editing items with stocknumbers you have not used before
should work as expected.
[F. Demians] Was able to reproduce the bug on an UNIMARC DB. The patch works.
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole C. Engard [Tue, 15 Mar 2011 17:05:09 +0000 (13:05 -0400)]
Follow Up Bug 5869 Update Report Page Title
The title said Checkout Stats - updated to say Holds Stats
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole C. Engard [Tue, 15 Mar 2011 17:01:24 +0000 (13:01 -0400)]
Follow Up Bug 5869 Fix String Errors
This patch fixes all occurences of 'reserves' to 'holds.' It also
added Holds to the menu include and updates capitalization and spacing.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 15 Mar 2011 17:01:06 +0000 (13:01 -0400)]
Bug 5869 - Follow up patch, fixing copyring and s/reserves/holds/
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Tue, 15 Mar 2011 17:00:17 +0000 (13:00 -0400)]
Bug 5869 : Adding a reserve report
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Tue, 15 Mar 2011 13:40:23 +0000 (14:40 +0100)]
Bug 5485: Add script to run Test::Perl::Critic
Tests are run if TEST_QA environment variable is set
and Test::Perl::Critic is installed
e.g.
TEST_QA=1 prove =l t/00-testcritic.t
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Tue, 15 Mar 2011 07:26:24 +0000 (03:26 -0400)]
Bug 5816: XSLT doesn't display enhanced contents
This patch corrects and standardizes the display of enhanced contents (MARC 505
with ind2='0').
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Marcel de Rooy [Tue, 15 Mar 2011 05:45:14 +0000 (01:45 -0400)]
Bug 5863: Add to Your Cart disappeared if login disabled on opac detail
Resolving an error in ready function by additional conditionals.
Moving a line from ready to html just as in other view templates, correcting the order of menu options at the same time.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 16 Mar 2011 20:22:46 +0000 (09:22 +1300)]
Merge remote branch 'kc/new/bug_3326' into kcmaster
Jared Camins-Esakov [Wed, 16 Mar 2011 15:09:46 +0000 (15:09 +0000)]
Follow up for Bug 3326: previous fix broke searches when
This fix ensures that searches will still work when -x is not used when
reindexing Zebra.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Magnus Enger <magnus@bibkat.no>
Signed-off-by: Jane Wagner <jwagner@ptfs.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Tue, 15 Mar 2011 11:03:21 +0000 (12:03 +0100)]
Bug 3810: Ensure all calls to Mail::Sendmail handled consistently
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
ruth@bywatersolutions.com [Fri, 4 Mar 2011 19:04:43 +0000 (13:04 -0600)]
Bug 3595 (partial): Items seen at checkin are not filling holds well
In Liz's second comment on this bug, she points out that local-only
holds (and also no-holds) items are being used to fill the first hold
in the queue, no matter where located, transitting if necessary. If
all the items on a biblio are set to no-holds types, this problem
would never arise, as no holds could be *placed*. But if you have
one or more unlimitedor local-hold items, then holds are getting
filled by the first item to cross a scanner, no matter what.
This patch will check during C4::Reserves::CheckReserves to make sure
that the hold being handed back to AddReturn is actually fillable by
the item just scanned. One caveat: If CircControl is set to "the library
you are logged in at", this will cause items checked in at
other-than-their-home-library to fill local holds at the library where
scanned. This is, however, an edge case!
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Tue, 15 Mar 2011 02:14:19 +0000 (22:14 -0400)]
Bug 3326: Work around Zebra's handling of & entities
When using XSLT mode, the OPAC results display will show "&" instead of "&"
when Zebra is indexing in XML mode. This patch works around this by replacing
"&" with "&" and then extends the previous fix to apply to all occurrences
of "& " instead of just the first.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 16 Mar 2011 03:28:00 +0000 (16:28 +1300)]
Revert "Merge remote branch 'kc/new/bug_5734' into kcmaster"
This reverts commit
b18ae6dee66f5bbba3d5d78ce6885a6d34cbcecd, reversing
changes made to
a52d4e8a70783fdf9cf4429931c2d133331d7ef5.
Stéphane Delaune [Mon, 14 Mar 2011 06:13:03 +0000 (07:13 +0100)]
Bug 5750: (MT #4095) add exact matching filter for categorycode and branchcode fields in search members's result
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
No searching borrowers by categorycode or branchcode will only bring up
exact matches. Before searches for Staff (S) would also bring up
Students and Schools (SC, ST). Same for branchcodes.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 15 Mar 2011 09:01:45 +0000 (22:01 +1300)]
Merge remote branch 'kc/new/enh/bug_3495' into kcmaster
Katrin Fischer [Sun, 13 Mar 2011 20:12:57 +0000 (16:12 -0400)]
Bug 3495: Fast bib record add at circulation
The link to the Fast add framework was never shown.
Now the link is shown if you have the right permissions (fast cataloging or superlibrarian).
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Nighswonger [Mon, 14 Mar 2011 20:27:17 +0000 (16:27 -0400)]
Bug 5865 - Labels wrap incorrectly when paper width is greater than height
This is due to the incorrect use of string comparators to compare numeric values.
This patch corrects that.
Note: This should be backported to 3.2.x
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 15 Mar 2011 02:58:26 +0000 (15:58 +1300)]
Merge remote branch 'kc/new/enh/bug_3659' into kcmaster
Owen Leonard [Tue, 15 Mar 2011 02:08:57 +0000 (21:08 -0500)]
Fix for Bug 3659, Add place hold option from patron checkout tab
Adds a button on patron-related pages, "Search to hold"
Clicking search to hold sets a cookie with the patron's
borrowernumber and sends the user to the search page.
On subsequent search results pages the user will have
the option to place holds specifically for the remembered
patron. This works on the search results page (single
and multiple hold) and on the detail page.
The saved cookie will time out after 10 minutes or
be erased when a new patron is loaded by circulation.pl
New jQuery plugin added: jquery.cookie.min.js
Revision fixes some markup and corrects an error that would lead
to the hold being initiated for the remembered patron when this
was not intended.
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 14 Mar 2011 21:04:38 +0000 (10:04 +1300)]
Merge remote branch 'kc/new/bug_5693' into kcmaster
Chris Cormack [Mon, 14 Mar 2011 20:55:06 +0000 (16:55 -0400)]
Bug 5693 : Follow up patch, escaping HTML in limit_cgi so "" dont break hrefs
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 14 Mar 2011 08:11:30 +0000 (21:11 +1300)]
Bumping database version
Nicole Engard [Fri, 11 Mar 2011 10:14:49 +0000 (11:14 +0100)]
Bug 3670: change 'Item DUE' to 'Item Due' in English dbs
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Janusz Kaczmarek [Mon, 14 Mar 2011 06:21:47 +0000 (07:21 +0100)]
Bug 5819 : No toolbar in record view when quotes present in title - fix
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Was able to reproduce problem by surrounding 245$a with "".
Patch fixed the problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Marcel de Rooy [Sun, 13 Mar 2011 20:13:01 +0000 (21:13 +0100)]
Bug 5848: Same position for the tabs of Normal, MARC and ISBD view in opac detail
Adjusts three opac detail templates. Moves few styles to css.
Removes duplicate view info from XSLT file.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 14 Mar 2011 07:48:50 +0000 (20:48 +1300)]
Merge remote branch 'kc/new/bug_4438' into kcmaster
Henri-Damien LAURENT [Sun, 13 Mar 2011 19:52:44 +0000 (20:52 +0100)]
bug4438/MT5496 budget Exceeds total allocation
This is a followup :
When editing a budget, the check for the total allocation would take into account the budget itself.
Showing an improper error message
The problem was solved when adding a child budget but not when editing the same budget.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 14 Mar 2011 03:22:28 +0000 (16:22 +1300)]
Bumping db version
Chris Cormack [Tue, 1 Feb 2011 08:55:17 +0000 (09:55 +0100)]
Bug 5669: Adding a system preference to control whether a user can select a pick branch for their hold or not
Default is on
Part of bug 5609
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 13 Mar 2011 07:31:38 +0000 (20:31 +1300)]
Merge remote branch 'kc/new/bug_5595' into kcmaster
Chris Cormack [Sun, 13 Mar 2011 07:30:13 +0000 (20:30 +1300)]
Bug 5595 : Fixing a security glitch (please always use placeholders or
dbh->quote and fixing the tests
Chris Cormack [Sun, 13 Mar 2011 02:19:31 +0000 (15:19 +1300)]
Bumping the database version
Jane Wagner [Sat, 12 Mar 2011 19:35:50 +0000 (14:35 -0500)]
Bug 5810 revision to fix author search link
Signed-off-by: Jane Wagner <jwagner@ptfs.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Sat, 12 Mar 2011 19:35:49 +0000 (14:35 -0500)]
Bug 5810: Subject tracings search complete subfields
This patch adds the syspref TraceCompleteSubfields. When TraceCompleteSubfields
is set to "force," clicking on links in non-authority controlled subject
tracings will only find other records where the entire subfields match. Leaving
it at "don't force" keeps the current behavior of doing a keyword search of the
subject indexes.
This patch implements complete-subfield subject tracings in MARC21 XSLTs (OPAC
and Staff) and all Normal mode interfaces. UNIMARC XSLTs have not been updated.
This patch also adds the syspref UseAuthoritiesForTracings. When set to "Do not"
tracings in the XSLT detail displays will never generate links using authority
numbers, but rather use the heading strings (NB: the tracings currently use only
subfield 'a' for generating links).
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jane Wagner <jwagner@ptfs.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 13 Mar 2011 01:13:33 +0000 (14:13 +1300)]
Adding release dates and 2 new developers
Chris Cormack [Sun, 13 Mar 2011 01:02:06 +0000 (14:02 +1300)]
Merge remote branch 'kc/new/bug_3013' into kcmaster
Janusz Kaczmarek [Thu, 10 Mar 2011 15:45:40 +0000 (16:45 +0100)]
Bug 5569: Corrections to addbiblio.tmpl to be able to delete repetable mandatory subfields
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Thu, 10 Mar 2011 17:29:11 +0000 (11:29 -0600)]
Bug 4072 Lost items aren't hidden on OPAC result page
When hidelostitems system preference is enabled, lost items are hidden on OPAC
detail page but are shown on result page. This patch modify MARC21/UNIMARC XSL
in order to take into account hidelostitems syspref on OPAC result page.
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 9 Mar 2011 22:14:56 +0000 (17:14 -0500)]
bug 5846: fix detection of Javascript to compress by mod_gzip
Update to default Apache config; should result in a slight
performance benefit.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Stéphane Delaune [Tue, 8 Mar 2011 03:34:19 +0000 (22:34 -0500)]
Bug 5595: (MT #5757)adding additional attributes support on patrons's search
Restores ability to search on extended borrower attributes that are configured to be searchable
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Tue, 8 Mar 2011 02:41:13 +0000 (21:41 -0500)]
bug_5064 Rework data retrieval in booksellers.pl
loops were slightly illogical and db accesss was excessive
and repetitive. caused it not to scale well on large datasets
Routines in Acquisition.pm seem to have inconsistent views
of the data.
rework logic to utilize db and processing better
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Tomás Cohen Arazi [Fri, 11 Mar 2011 11:05:12 +0000 (12:05 +0100)]
update INSTALL* to acknowledge the use of mod_deflate
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Tue, 8 Mar 2011 02:30:25 +0000 (21:30 -0500)]
Bug5063: C4::Bookseller Changes
Merge unfao changes to C4::Bookseller
Enable warnings in Bookseller.pm
Some cleanups in Bookseller code
Do not export everything by default
Display vendors more rationally
Was displaying by id make it name as the searchstring is for all
embedded substrings
Have removed "if mysql" logic as we want to deal with this by
abstracting the DB interaction and it makes cleaner code until then
Sponsered by UN FAO, Rome
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Mon, 7 Mar 2011 21:30:21 +0000 (15:30 -0600)]
Bug 1962: Follow-up: Add fine notification during check-in
Don't show message when patron has no fines.
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Mon, 7 Mar 2011 18:50:48 +0000 (13:50 -0500)]
Bug 5527: Fix some problems in inactive borrowers report
- 'Not checked out since:' date was not added to query
- borrowers with only checkouts and no returns since this date were considered inactive
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédérick Capovilla [Mon, 7 Mar 2011 18:18:41 +0000 (13:18 -0500)]
Bug 5703: Hide the $9 subfield (linked authid) when showing series for a MARC record in normal view.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Fri, 11 Mar 2011 19:15:17 +0000 (08:15 +1300)]
Bug 3624 : Follow up patch, to catch any installs that still have the missing columns
Paul Poulain [Mon, 7 Mar 2011 18:12:44 +0000 (13:12 -0500)]
BZ3624, proposed patch for kohastructure.sql rewritten
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Mon, 7 Mar 2011 16:44:03 +0000 (11:44 -0500)]
Bug 5830 Using XSLT on OPAC Lists page
On OPAC Lists page (opac-shelves.pl), biblio records are now displayed
accordingly to OPACXSLTResultsDisplay system preference.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 7 Mar 2011 19:28:42 +0000 (08:28 +1300)]
Merge remote branch 'kc/master' into new/bug_3013
Salvador Zaragoza Rubio [Mon, 7 Mar 2011 16:37:45 +0000 (11:37 -0500)]
Bug 3013 - Value builder for 006 and 008 need choices for all format types
Modification of the intranet cataloguing plugin for 006/008 fields to allow
select a type of material and change the positions available to enter the data.
Data are hard stored in xml files to allow easy translation and processing through
Javascript and JQuery-AJAX.
Bug 3013 - Fix selection of combo and trailing whitespace
Bug 3013 - Fix selection of combo
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 7 Mar 2011 02:13:53 +0000 (15:13 +1300)]
Bumping database version
Chris Cormack [Mon, 7 Mar 2011 02:10:37 +0000 (15:10 +1300)]
Merge remote branch 'kc/new/enh/bug_5783' into kcmaster
Galen Charlton [Thu, 3 Mar 2011 21:54:02 +0000 (16:54 -0500)]
bug 5783: follow-up system preferences tweaks
* add the AuthoritiesLog system preference to all
language installer SQL scripts
* options for a 'YesNo' should be '', not '0'
* fix wording glitch on preferences page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 3 Mar 2011 21:54:01 +0000 (16:54 -0500)]
bug 5783: follow-up - fix logging of modifications
Fix so that modifying an authority record is not logged
as both an ADD and a MODIFY.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Tomas Cohen Arazi [Thu, 3 Mar 2011 21:54:00 +0000 (16:54 -0500)]
bug 5783: Authorities edit logging
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 3 Mar 2011 19:52:47 +0000 (14:52 -0500)]
bug 2975: whitespace and formatting cleanup
Not part of the bugfix per se, but taking this chance
to clean up some inconsistent tabbing.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Thu, 3 Mar 2011 19:52:46 +0000 (14:52 -0500)]
bug 2975: fix calculation of due dates by offline circ
Offline circ no longer tries to calculate the due date
directly, instead relying on the AddIssue and AddRenewal
APIs to do so. This corrects a bug where the due date
would be calculated incorrectly if the item-level_itypes
system preference is turned on.
This change also has the effect of causing the issue date
for loans uploaded via offline circulation to be set
to the time stamp recorded by the offline circulation client.
Test plan:
* Turn on item-level_itypes
* Create an example item whose loan policy per
the item's item type would be different from
the default policy based on the bib-level type.
* Create a test KOC file with a loan of the test
item and the checkout date artificially set
to yesterday.
* Upload the file:
- Before the fix, the due date would be set
to the default due date. Also, the issue date
will be set to the date of the upload.
- After the fix, the due date would be calculated
correctly based on the item's item type. Also,
the issue date will be set to the date recorded
by the offline circulation client.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Tue, 14 Dec 2010 23:01:04 +0000 (00:01 +0100)]
Bug 5835 : adding a class to index <select>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Ian Walls [Fri, 4 Mar 2011 20:08:22 +0000 (15:08 -0500)]
Bug 5831: rebuild_zebra.pl doesn't respect -r
Reimplements support for -r, as well for -reset
Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole C. Engard [Thu, 3 Mar 2011 14:17:19 +0000 (09:17 -0500)]
Bug 5820: Change language to 'Fund' over 'Budget'
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Reed Wade [Fri, 4 Mar 2011 04:13:00 +0000 (23:13 -0500)]
bug 5693 - mc-ccode parens fix
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nahuel ANGELINETTI [Tue, 1 Mar 2011 20:55:38 +0000 (21:55 +0100)]
(bug #5157) fix borrowers top issues
this fix filters of borrowers top issues that doesn't work really well... perhaps because reports scripts need too much improvment.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 1 Mar 2011 20:19:16 +0000 (21:19 +0100)]
Fix for Bug 4853 - Rights needed to renew a document
Correcting check for circulation permission. Also updating
updateitem.pl (for setting lost and damaged statuses) with
circulate permissions.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 1 Mar 2011 13:01:32 +0000 (14:01 +0100)]
Fix for Bug 4290 - search for author in repository
Reimplementation of Nahuel's patch from 2010-03-02
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédérick Capovilla [Sat, 5 Mar 2011 19:15:04 +0000 (08:15 +1300)]
Bug 3341: Fines calculation erroneous when a repeatable holiday is added
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sat, 5 Mar 2011 19:05:40 +0000 (08:05 +1300)]
Fixing a utf8 issue with the translator tests
Ian Walls [Thu, 3 Mar 2011 23:13:26 +0000 (18:13 -0500)]
Bug 5824: Creating a circ rule for a specific library causes anomalies
The variable name for the current branch being edited was the same as the variable used in
cat-search.inc, which passed along the circ-rule library to circulation.pl, and then overriding
the set library from there.
This patch renames the template variable 'current_branch', so that it does not populate the 'branch'
param in cat-search.inc
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>