]> git.koha-community.org Git - koha.git/log
koha.git
16 years agoFix for bug 1740, opac reserves
Chris Cormack [Sun, 6 Jan 2008 21:30:38 +0000 (15:30 -0600)]
Fix for bug 1740, opac reserves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 1395, opac user update not working
Chris Cormack [Sun, 6 Jan 2008 21:05:45 +0000 (15:05 -0600)]
Fix for bug 1395, opac user update not working

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed typo in 044 DB update SQL
Galen Charlton [Sun, 6 Jan 2008 06:05:49 +0000 (00:05 -0600)]
fixed typo in 044 DB update SQL

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding Armenian translation (Tigran Zargaryan <tigran@flib.sci.am> )
Joshua Ferraro [Mon, 7 Jan 2008 07:49:09 +0000 (02:49 -0500)]
adding Armenian translation (Tigran Zargaryan <tigran@flib.sci.am> )

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding download link v3.00.00-alpha
Joshua Ferraro [Sat, 5 Jan 2008 08:57:12 +0000 (03:57 -0500)]
adding download link

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoWARNING: BIG I18N PATCH, you must import the subtag_registry.sql after this upgrade...
Joshua Ferraro [Sat, 5 Jan 2008 08:44:53 +0000 (03:44 -0500)]
WARNING: BIG I18N PATCH, you must import the subtag_registry.sql after this upgrade to benefit from the new features ... if you don't everything will work as before.

bugfixing I18N language selection from staff and OPAC, adding BiDi
support

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadditional updates to language support
Joshua Ferraro [Sat, 5 Jan 2008 06:50:45 +0000 (00:50 -0600)]
additional updates to language support

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixes to installer with changes to language management
Joshua Ferraro [Mon, 12 Nov 2007 01:41:48 +0000 (19:41 -0600)]
Fixes to installer with changes to language management

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agorefactoring changelanguage, better var names, etc.
Joshua Ferraro [Sun, 11 Nov 2007 05:58:46 +0000 (23:58 -0600)]
refactoring changelanguage, better var names, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoving warns from Output.pm
Joshua Ferraro [Sun, 11 Nov 2007 04:09:47 +0000 (22:09 -0600)]
removing warns from Output.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix the 'current language' change language display
Joshua Ferraro [Sun, 11 Nov 2007 04:09:12 +0000 (22:09 -0600)]
fix the 'current language' change language display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotemplate improvement: fall back on english if the template file doesn't exist
Joshua Ferraro [Sun, 11 Nov 2007 03:57:29 +0000 (21:57 -0600)]
template improvement: fall back on english if the template file doesn't exist

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoImprovements to handling language subtags
Joshua Ferraro [Sun, 11 Nov 2007 03:27:10 +0000 (21:27 -0600)]
Improvements to handling language subtags

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agorename internal function
Joshua Ferraro [Sat, 10 Nov 2007 21:35:57 +0000 (15:35 -0600)]
rename internal function

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadd xml language entities
Joshua Ferraro [Sat, 10 Nov 2007 21:26:54 +0000 (15:26 -0600)]
add xml language entities

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremove warn
Joshua Ferraro [Sat, 10 Nov 2007 15:06:28 +0000 (09:06 -0600)]
remove warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding support for indicating 'current' language
Joshua Ferraro [Sat, 10 Nov 2007 14:56:16 +0000 (08:56 -0600)]
adding support for indicating 'current' language

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding bi-directional support to the OPAC based on the language
Joshua Ferraro [Sat, 10 Nov 2007 14:51:40 +0000 (08:51 -0600)]
adding bi-directional support to the OPAC based on the language

selected (Hebrew and Arabic currently set)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSwitching Languages.pm to EXPORT_OK -- don't export
Joshua Ferraro [Sat, 10 Nov 2007 14:24:56 +0000 (08:24 -0600)]
Switching Languages.pm to EXPORT_OK -- don't export

all functions by default. Adding languages_loop to all
templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agosynching deletedborrowers table with borrowers table
Joshua Ferraro [Sat, 5 Jan 2008 03:25:32 +0000 (22:25 -0500)]
synching deletedborrowers table with borrowers table

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 1697, as well as repairing inability to change category to Staff
Joshua Ferraro [Sat, 5 Jan 2008 03:14:34 +0000 (22:14 -0500)]
fix for bug 1697, as well as repairing inability to change category to Staff

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadditional fixes to permissions
Joshua Ferraro [Sat, 5 Jan 2008 02:31:05 +0000 (21:31 -0500)]
additional fixes to permissions

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRudimentary import of MARC21 authorities
Joshua Ferraro [Sat, 5 Jan 2008 01:59:43 +0000 (20:59 -0500)]
Rudimentary import of MARC21 authorities

Also adding support for ingesting format MARCXML in bulkmarcimport and bulkauthimport

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing permissions requirements on mainpage.pl
Joshua Ferraro [Sat, 5 Jan 2008 01:58:44 +0000 (20:58 -0500)]
fixing permissions requirements on mainpage.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing incorrect URL for unapi
Joshua Ferraro [Sat, 5 Jan 2008 00:44:48 +0000 (19:44 -0500)]
fixing incorrect URL for unapi

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadded C4/AuthoritesMarc/*.pm missed in previous patch
Galen Charlton [Sat, 5 Jan 2008 01:07:08 +0000 (19:07 -0600)]
added C4/AuthoritesMarc/*.pm missed in previous patch

oops!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agostart of big MARC21 authorities work
Galen Charlton [Fri, 4 Jan 2008 22:59:38 +0000 (16:59 -0600)]
start of big MARC21 authorities work

* Defined local field 942$a to store the authority type
  for MARC21 instead of 152$b
* Added 942$b to MARC21 authority framework.
* Added auth_header.authid and auth_header.authtypecode
  to appropriate subfields in MARC21 authority framework.
* Started work on two new modules:
    C4::AuthoritiesMarc::MARC21
    C4::AuthoritiesMarc::UNIMARC
  These modules will be used to extract MARC-format-specific
  behavior out of C4::AuthoritiesMarc
* Updated Zebra config for MARC21 to use only the 942$a
  for the authority type.
* For MARC21, added logic to move 152$b to 942$a for
  existing authority records.  Specifically, AddAuthority
  now does this move when a record is saved, while
  GetAuthority and GetAuthorityXML do this when
  extracting a record for other use.  This logic
  is temporary, and can hopefully be removed later, once
  use of 152$b in MARC21 authorities is confirmed to be
  absent for Koha users.  I will also create a batch
  job to do this update in one fell swoop.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agominor POD correction
Galen Charlton [Fri, 4 Jan 2008 22:59:37 +0000 (16:59 -0600)]
minor POD correction

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoinstaller: added update_zebra_conf target
Galen Charlton [Fri, 4 Jan 2008 22:59:36 +0000 (16:59 -0600)]
installer: added update_zebra_conf target

This target is meant to allow the easy updating
of the Zebra configuration files from an installation
package.

This has been tested for a 'dev' mode install, not
for the other types.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agolot of fixes to french translation
Paul POULAIN [Fri, 4 Jan 2008 16:48:49 +0000 (17:48 +0100)]
lot of fixes to french translation

Note that online help is mostly *not* translated, but OPAC & all staff screens are

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agos/waiting/pending/
Paul POULAIN [Fri, 4 Jan 2008 16:41:30 +0000 (17:41 +0100)]
s/waiting/pending/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agos/receive/receive order/
Paul POULAIN [Fri, 4 Jan 2008 16:41:21 +0000 (17:41 +0100)]
s/receive/receive order/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoinverting currencies & budget arrays, as budget is more frequently looked at
Paul POULAIN [Fri, 4 Jan 2008 16:41:08 +0000 (17:41 +0100)]
inverting currencies & budget arrays, as budget is more frequently looked at

and for libraries with only 1 currency, the table is useless

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding some missing _() for translator
Paul POULAIN [Fri, 4 Jan 2008 16:40:08 +0000 (17:40 +0100)]
adding some missing _() for translator

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotmpl_if are forbidden inside html elements or the translator go mad
Paul POULAIN [Fri, 4 Jan 2008 15:54:24 +0000 (16:54 +0100)]
tmpl_if are forbidden inside html elements or the translator go mad

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoreplacing " by ' to avoid the translator being troubled
Paul POULAIN [Fri, 4 Jan 2008 11:20:48 +0000 (12:20 +0100)]
replacing " by ' to avoid the translator being troubled

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years ago2 missing spaces that causes trouble to the translator
Paul POULAIN [Fri, 4 Jan 2008 11:20:26 +0000 (12:20 +0100)]
2 missing spaces that causes trouble to the translator

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFirst adaptation of an xsl stylesheet.
Henri-Damien LAURENT [Fri, 4 Jan 2008 19:06:53 +0000 (13:06 -0600)]
First adaptation of an xsl stylesheet.

I saw no process for ISBN
and no series information or serial information
in this stylesheet treatment
is it OK ?

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMinor markup changes for translator-friendliness
Owen Leonard [Fri, 4 Jan 2008 19:06:52 +0000 (13:06 -0600)]
Minor markup changes for translator-friendliness

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fix : Fewer Options would not show less options
Henri-Damien LAURENT [Fri, 4 Jan 2008 19:06:51 +0000 (13:06 -0600)]
Bug Fix : Fewer Options would not show less options

opac-advsearch.tmpl uses include for subtypes_unimarc now.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoopac-rss was adding an unnecessary q=
Henri-Damien LAURENT [Fri, 4 Jan 2008 19:06:50 +0000 (13:06 -0600)]
opac-rss was adding an unnecessary q=

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing : title not displayed in UNIMARC
Henri-Damien LAURENT [Fri, 4 Jan 2008 19:06:49 +0000 (13:06 -0600)]
Bug Fixing : title not displayed in UNIMARC

use of record->title() for UNIMARC is not correct, since MARC::Record functions are based
on MARC21 marckup.
What should be used instead is : GetBiblioData

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUG 1580, subscription irregularities and volume type, not passed when editing subscr...
Mason James [Fri, 4 Jan 2008 06:00:16 +0000 (00:00 -0600)]
BUG 1580, subscription irregularities and volume type, not passed when editing subscription

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOnline Help for Transfers to Recieve - Circ Reports
Russel Garlick [Fri, 4 Jan 2008 06:00:15 +0000 (00:00 -0600)]
Online Help for Transfers to Recieve - Circ Reports

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOnline help for Transfers To Do - Circ Reports
Russel Garlick [Fri, 4 Jan 2008 06:00:14 +0000 (00:00 -0600)]
Online help for Transfers To Do - Circ Reports

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOnline help for Pending Reserves
Russel Garlick [Fri, 4 Jan 2008 06:00:13 +0000 (00:00 -0600)]
Online help for Pending Reserves

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMaking a start on Authorities Online Help
Russel Garlick [Fri, 4 Jan 2008 06:00:12 +0000 (00:00 -0600)]
Making a start on Authorities Online Help

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoWorking on help files
Russel Garlick [Fri, 4 Jan 2008 06:00:11 +0000 (00:00 -0600)]
Working on help files

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix for bug 1736: Zebra searching, " " quotes cannot access second page when used
Joshua Ferraro [Fri, 4 Jan 2008 05:27:25 +0000 (00:27 -0500)]
fix for bug 1736: Zebra searching, " " quotes cannot access second page when used

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix misspelling on release nots
Joshua Ferraro [Fri, 4 Jan 2008 03:35:08 +0000 (22:35 -0500)]
fix misspelling on release nots

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoimprovements to INSTALL.debian, adding Symbols for currencies adding \n to make bulkm...
Joshua Ferraro [Fri, 4 Jan 2008 03:21:51 +0000 (22:21 -0500)]
improvements to INSTALL.debian, adding Symbols for currencies adding \n to make bulkmarcimport.pl prettier

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding three new variables for installation:
Joshua Ferraro [Fri, 4 Jan 2008 02:17:02 +0000 (21:17 -0500)]
adding three new variables for installation:

  'ZEBRA_SRU_HOST'    => 'localhost',
  'ZEBRA_SRU_BIBLIOS_PORT'    => '9998',
  'ZEBRA_SRU_AUTHORITIES_PORT'    => '9999',

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing incorrect reference to opaclanguages syspref
Joshua Ferraro [Fri, 4 Jan 2008 00:02:05 +0000 (19:02 -0500)]
fixing incorrect reference to opaclanguages syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadd INIT block to import C4::Items
Galen Charlton [Fri, 4 Jan 2008 00:46:12 +0000 (18:46 -0600)]
add INIT block to import C4::Items

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Circulation - ensure that certain modules always get imported
Galen Charlton [Fri, 4 Jan 2008 00:43:39 +0000 (18:43 -0600)]
C4::Circulation - ensure that certain modules always get imported

For some reason currently unclear to me, a use 'C4::XXX' does
not seem to guarantee that the contents of C4::XXX's
@EXPORT gets imported into C4::Circulation's symbol table.

Added an INIT block to ensure that this gets done as
part of runtime initialization.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed variable masking warnings found by perl -w
Galen Charlton [Fri, 4 Jan 2008 00:43:38 +0000 (18:43 -0600)]
fixed variable masking warnings found by perl -w

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoreplaced incorrect '=>' with '='
Galen Charlton [Fri, 4 Jan 2008 00:43:37 +0000 (18:43 -0600)]
replaced incorrect '=>' with '='

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agomisc/cronjobs/update_items.pl: fixed syntax errors
Galen Charlton [Fri, 4 Jan 2008 00:43:36 +0000 (18:43 -0600)]
misc/cronjobs/update_items.pl: fixed syntax errors

Fixed syntax errors preventing compilation; however,
unsure whether this is a dead utility that should be
removed outright.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoupdatedatabase - DB version to 043 for 2 new columns in currency table
Joe Atzberger [Fri, 4 Jan 2008 00:20:38 +0000 (18:20 -0600)]
updatedatabase - DB version to 043 for 2 new columns in currency table

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocurrency expansion - symbol and timestamp. PLEASE VERIFY SQL edit. Should be equivale...
Joe Atzberger [Fri, 4 Jan 2008 00:20:37 +0000 (18:20 -0600)]
currency expansion - symbol and timestamp. PLEASE VERIFY SQL edit. Should be equivalent to: ALTER TABLE `currency` ADD `symbol` varchar(5) default NULL, ADD `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP;

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocirc/stats.pl - debugify warnings
Joe Atzberger [Fri, 4 Jan 2008 00:20:36 +0000 (18:20 -0600)]
circ/stats.pl - debugify warnings

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopendingreserves.pl - debugify warn
Joe Atzberger [Fri, 4 Jan 2008 00:20:35 +0000 (18:20 -0600)]
pendingreserves.pl - debugify warn

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoboraccount.tmpl - remove double conditional
Joe Atzberger [Fri, 4 Jan 2008 00:20:34 +0000 (18:20 -0600)]
boraccount.tmpl - remove double conditional

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMicroformat support:
Joshua Ferraro [Thu, 3 Jan 2008 23:50:45 +0000 (17:50 -0600)]
Microformat support:

Needed to restore OpenSearch capabilities, and did the following while
I was at it:

  * add support for unAPI: http://unapi.info/
  * add basic support for COinS and OpenURL:
    http://ocoins.info;
    http://www.niso.org/committees/committee_ax.html
  * ^^ Gives us Zotero Support!
  * adding some XSLT stylesheets for handling additional transformations
    NOTE: English and MARC21 specific unfortunately
  * adding back opensearch/rss feed <link>s for autodiscovery

TODO: after the installation, to get the Zebra system running on an external
port it's necessary to hand-edit the configs. I'm looking into Virtual Hosts
which could solve that problem (run on both the socket and a port).

Need to add better error handling to the unapi and opensearch scripts

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for Bug 1726 (re-selecting another 'status' value should hide the 'add serials...
Owen Leonard [Thu, 3 Jan 2008 22:21:24 +0000 (16:21 -0600)]
Fix for Bug 1726 (re-selecting another 'status' value should hide the 'add serials' table again).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLots of reformatting of reports forms. Improvements to breadcrumbs. XHTML-compliance...
Owen Leonard [Thu, 3 Jan 2008 22:21:23 +0000 (16:21 -0600)]
Lots of reformatting of reports forms. Improvements to breadcrumbs. XHTML-compliance corrections. Fix to itemslost.pl for Bug 1733 (just a typo).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding patron's home branch to circ-menu sidebar display, minor markup change to...
Owen Leonard [Thu, 3 Jan 2008 22:21:22 +0000 (16:21 -0600)]
Adding patron's home branch to circ-menu sidebar display, minor markup change to /acui/histsearch.tmpl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMarkup corrections and formatting dialogs.
Owen Leonard [Thu, 3 Jan 2008 22:21:21 +0000 (16:21 -0600)]
Markup corrections and formatting dialogs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLabels overhaul - labels were largely broken (and still are somewhat), but this overh...
Joe Atzberger [Thu, 3 Jan 2008 20:46:20 +0000 (14:46 -0600)]
Labels overhaul - labels were largely broken (and still are somewhat), but this overhaul addresses Add, Delete, deduplication, messages to user, debug, etc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLabels.pm - add deduplicate_batch sub
Joe Atzberger [Thu, 3 Jan 2008 20:46:19 +0000 (14:46 -0600)]
Labels.pm - add deduplicate_batch sub

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agostart of test suite for C4::Items
Galen Charlton [Thu, 3 Jan 2008 18:36:45 +0000 (12:36 -0600)]
start of test suite for C4::Items

Only functions that do not touch the DB
are currently tested.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: correct '' for various status fields
Galen Charlton [Thu, 3 Jan 2008 18:36:44 +0000 (12:36 -0600)]
item rework: correct '' for various status fields

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobatch import: do not ersatz MARC item fields
Galen Charlton [Thu, 3 Jan 2008 18:36:43 +0000 (12:36 -0600)]
batch import: do not ersatz MARC item fields

Batch import was not removing item fields (e.g., 952
or 995) from MARC records.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agospeed boost: tools stage and commit bib records
Galen Charlton [Thu, 3 Jan 2008 18:36:42 +0000 (12:36 -0600)]
speed boost: tools stage and commit bib records

Turned off autocommit; commit every 50 records.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agospeed boost: command-line stage and commit biblios
Galen Charlton [Thu, 3 Jan 2008 18:36:41 +0000 (12:36 -0600)]
speed boost: command-line stage and commit biblios

Turned off autocommit and commit every 100 records.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: replaced AddBiblioAndItems
Galen Charlton [Thu, 3 Jan 2008 18:36:40 +0000 (12:36 -0600)]
item rework: replaced AddBiblioAndItems

Replace C4::Biblio::AddBiblioAndItems with two
things:

* An option to C4::Biblio::AddBiblio to defer writing
  biblioitems.marc and biblioitems.marcxml.  This
  option was created to give a significant
  speed boost to bulkmarcimport.pl, but is *not*
  recommended for general use.
* C4::Items::AddItemBatchFromMarc

This refactoring removes the need to have functions
in C4::Biblio and C4::Items that call each other's
private functions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved more redundant 'my' causing variable masking warnings
Galen Charlton [Thu, 3 Jan 2008 18:36:39 +0000 (12:36 -0600)]
removed more redundant 'my' causing variable masking warnings

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved extra 'my' that was causing a masking warning
Galen Charlton [Thu, 3 Jan 2008 18:36:38 +0000 (12:36 -0600)]
removed extra 'my' that was causing a masking warning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: various changes
Galen Charlton [Thu, 3 Jan 2008 18:36:37 +0000 (12:36 -0600)]
item rework: various changes

* Move CheckItemPreSave to C4::Items (from C4::Biblio)
* Modified C4::Biblio::AddBiblioAndItems to use appropriate
   internal routines from C4::Items
* Moved GetItemnumberFromBarcode to C4::Items
* Removed duplicate C4::Biblio::_koha_new_items
* Removed disused C4::Biblio::MARCitemchange

Currently AddBiblioAndItems is a special routine that
uses private subs from both C4::Biblio and C4::Items.
This needs to be refactored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved 'use' that was causing redefined sub warning
Galen Charlton [Thu, 3 Jan 2008 18:36:36 +0000 (12:36 -0600)]
removed 'use' that was causing redefined sub warning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved duplicate call to C4::Context->marcfromkohafield
Galen Charlton [Thu, 3 Jan 2008 18:36:35 +0000 (12:36 -0600)]
removed duplicate call to C4::Context->marcfromkohafield

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: moved DelItem
Galen Charlton [Thu, 3 Jan 2008 18:36:34 +0000 (12:36 -0600)]
item rework: moved DelItem

Moved from C4::Biblio to C4::Items

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: moved various accessor functions
Galen Charlton [Thu, 3 Jan 2008 18:36:33 +0000 (12:36 -0600)]
item rework: moved various accessor functions

Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agostaff results detail print: use itemcallnumber
Galen Charlton [Thu, 3 Jan 2008 18:36:32 +0000 (12:36 -0600)]
staff results detail print: use itemcallnumber

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agolabels item search: build item list correctly
Galen Charlton [Thu, 3 Jan 2008 18:36:31 +0000 (12:36 -0600)]
labels item search: build item list correctly

Do not merge in a field mapped from the MARC biblio
if it already has been brought in from the item.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOPAC detail print: use correct API to build item list
Galen Charlton [Thu, 3 Jan 2008 18:36:30 +0000 (12:36 -0600)]
OPAC detail print: use correct API to build item list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoOPAC detail print: get call number from items.itemcallnumber
Galen Charlton [Thu, 3 Jan 2008 18:36:29 +0000 (12:36 -0600)]
OPAC detail print: get call number from items.itemcallnumber

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved reports/inventory.pl
Galen Charlton [Thu, 3 Jan 2008 18:36:28 +0000 (12:36 -0600)]
removed reports/inventory.pl

This had been moved to tools/ when 3.0 HEAD
was created, but the vestiges of the older
version had not been removed completely.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: replace direct SQL update of items
Galen Charlton [Thu, 3 Jan 2008 18:36:27 +0000 (12:36 -0600)]
item rework: replace direct SQL update of items

with ModItem calls

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocheck for undefined values when mapping item to MARC
Galen Charlton [Thu, 3 Jan 2008 18:36:26 +0000 (12:36 -0600)]
check for undefined values when mapping item to MARC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoinventory: two fixes
Galen Charlton [Thu, 3 Jan 2008 18:36:25 +0000 (12:36 -0600)]
inventory: two fixes

* Replaced direct "update items" with ModItem call
* fixed problem in template that prevent barcode file upload
  from working

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: POD and comments improvement
Galen Charlton [Thu, 3 Jan 2008 18:36:24 +0000 (12:36 -0600)]
item rework: POD and comments improvement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years ago_replace_item_field_in_biblio now handles missing item field
Galen Charlton [Thu, 3 Jan 2008 18:36:23 +0000 (12:36 -0600)]
_replace_item_field_in_biblio now handles missing item field

If an item field with the appropriate itemnumber does not
exist in the MARC bib, the incoming item field is now
just added instead of being ignored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved erroneous comment
Galen Charlton [Thu, 3 Jan 2008 18:36:22 +0000 (12:36 -0600)]
removed erroneous comment

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: moved GetItem
Galen Charlton [Thu, 3 Jan 2008 18:36:21 +0000 (12:36 -0600)]
item rework: moved GetItem

Moved from C4::Biblio to C4::Items.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoquell warning if updating itemnote whose original value is NULL
Galen Charlton [Thu, 3 Jan 2008 18:36:20 +0000 (12:36 -0600)]
quell warning if updating itemnote whose original value is NULL

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: moved GetMarcItem
Galen Charlton [Thu, 3 Jan 2008 18:36:19 +0000 (12:36 -0600)]
item rework: moved GetMarcItem

Moved this function from an exported function in
C4::Biblio to a public but unexported function
in C4::Items.  Added comment noting that this
is used only by additem.pl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: do not allow bulkedit to update items
Galen Charlton [Thu, 3 Jan 2008 18:36:18 +0000 (12:36 -0600)]
item rework: do not allow bulkedit to update items

This patch is meant to guarantee that a bulkedit
does not try to edit an item tag embedded in a MARC
biblio without updating the items feature.  It is
not a comprehensive fix of the bulkedit feature, which
currently does not appear to be functional and
needs some thought:

* The general search results is probably not the
  best place to put this feature -- it should
  probably be in tools.
* A bulk edit of something like items is desireable,
  but needs to be designed so that it respects
  business logic for circulation and acquisitions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitem rework: moved ModItemInMarc
Galen Charlton [Thu, 3 Jan 2008 18:36:17 +0000 (12:36 -0600)]
item rework: moved ModItemInMarc

* Moved exported ModItemInMarc from C4::Biblio to
  C4::Items and renamed to _replace_item_field_in_biblio.
  Function is now private and is not exported, as
  ModItem is now the sole entry point for updating
  an item record.
* Replaced calls to ModItemInMarc in C4::Circulation
  with appropriate ModItem calls.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoitems rework: fix several non-NULL columns during ModItem
Galen Charlton [Thu, 3 Jan 2008 18:36:16 +0000 (12:36 -0600)]
items rework: fix several non-NULL columns during ModItem

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>