]> git.koha-community.org Git - koha.git/log
koha.git
5 years agoBug 16251: Fix value of material select for Rancor 008 widget
Julian Maurice [Wed, 6 Mar 2019 07:58:03 +0000 (08:58 +0100)]
Bug 16251: Fix value of material select for Rancor 008 widget

The material type is selected in accordance with the leader (06-07)

Test plan:
1. Create a new record using the advanced editor
2. Set the leader 6th position to 'c'
3. Save the record and reload the page
4. 'Music' should be automatically selected for 008
5. Try other values for the leader 6th and 7th positions

See comment 0 of this bug for the complete mapping

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: DBRev 18.12.00.022
Nick Clemens [Thu, 7 Mar 2019 20:40:53 +0000 (20:40 +0000)]
Bug 15774: DBRev 18.12.00.022

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (QA follow-up) Remove asset of datables.css, and corresponding plugins
Josef Moravec [Thu, 28 Feb 2019 07:45:13 +0000 (07:45 +0000)]
Bug 15774: (QA follow-up) Remove asset of datables.css, and corresponding plugins

It is now part of doc-head-close.inc

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (QA follow-up) Fix use statemenets
Josef Moravec [Thu, 28 Feb 2019 07:44:52 +0000 (07:44 +0000)]
Bug 15774: (QA follow-up) Fix use statemenets

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (follow-up) fix rebase issues
Nick Clemens [Wed, 27 Feb 2019 18:22:31 +0000 (13:22 -0500)]
Bug 15774: (follow-up) fix rebase issues

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Add permission for managing additional fields
Nick Clemens [Tue, 18 Dec 2018 12:05:10 +0000 (12:05 +0000)]
Bug 15774: Add permission for managing additional fields

To test:
 1 - Have three borrowers, one with order_manage permission, one with
 edit_subscription permisson, andone with both
 2 - Apply patch, updatedatabase
 3 - Verify all three now have the manage_additional_fields permission
 4 - Visit the admin page with these users, they should all see the
 'Manage additional fields' link
 5 - Click the link
 6 - User with order_manage should see 'Order baskest'
 7 - User with edit_subscription should see 'Subscriptions'
 8 - User with both should see both
 9 - Remove the additional permissions from a user - they should see a
 note about needing additional permissions

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Remove unecessary returned value for ->delete
Jonathan Druart [Thu, 1 Nov 2018 20:58:14 +0000 (17:58 -0300)]
Bug 15774: Remove unecessary returned value for ->delete

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Do not fetch additional fields from GetSubscription
Jonathan Druart [Thu, 1 Nov 2018 20:57:54 +0000 (17:57 -0300)]
Bug 15774: Do not fetch additional fields from GetSubscription

Finally we do not want that, they should be fetch when needed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Fix and unify additional_fields in C4::Serials
Jonathan Druart [Thu, 1 Nov 2018 20:57:24 +0000 (17:57 -0300)]
Bug 15774: Fix and unify additional_fields in C4::Serials

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields
Jonathan Druart [Thu, 1 Nov 2018 20:54:43 +0000 (17:54 -0300)]
Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Fix insert and update for subscription
Jonathan Druart [Thu, 1 Nov 2018 20:51:56 +0000 (17:51 -0300)]
Bug 15774: Fix insert and update for subscription

Call it a typo

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Use the include file to display the subscription's additional fields
Jonathan Druart [Thu, 1 Nov 2018 20:41:37 +0000 (17:41 -0300)]
Bug 15774: Use the include file to display the subscription's additional fields

We have it, why not to use it?

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (follow-up) Address QA issues
Nick Clemens [Thu, 1 Nov 2018 18:32:05 +0000 (18:32 +0000)]
Bug 15774: (follow-up) Address QA issues

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Fix JS check when AV and MARC field are both selected
Jonathan Druart [Tue, 16 Oct 2018 19:55:18 +0000 (16:55 -0300)]
Bug 15774: Fix JS check when AV and MARC field are both selected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (follow-up) Add html filters
Nick Clemens [Thu, 4 Oct 2018 19:46:53 +0000 (19:46 +0000)]
Bug 15774: (follow-up) Add html filters

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Show additional field values in edit form
Julian Maurice [Wed, 16 May 2018 07:30:42 +0000 (09:30 +0200)]
Bug 15774: Show additional field values in edit form

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Add POD and license notices
Julian Maurice [Tue, 15 May 2018 15:16:34 +0000 (17:16 +0200)]
Bug 15774: Add POD and license notices

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Use Koha::Object(s) for additional fields
Julian Maurice [Fri, 4 May 2018 15:35:45 +0000 (17:35 +0200)]
Bug 15774: Use Koha::Object(s) for additional fields

A lot of code can be removed just by using Koha::Object

It also makes fetching and updating additional field values easier.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Fix additional fields filters
Julian Maurice [Thu, 22 Feb 2018 12:52:10 +0000 (13:52 +0100)]
Bug 15774: Fix additional fields filters

Addresses the following QA comments:

1/ Regression:
On serials/serials-search.pl, the filters are not filled with what the
users searched for and the additional fields linked to an AV are not
displayed as a dropdown list.

4/ When searching an order, there is no way not to set a "all" value for
additional fields linked to AV.

5/ When searching an order and the search does not return any results,
the field should contain what the user filled in.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: (QA follow-up) Make sure that tablename is correctly saved
Jesse Weaver [Thu, 21 Jul 2016 19:34:26 +0000 (13:34 -0600)]
Bug 15774: (QA follow-up) Make sure that tablename is correctly saved

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 15774: Add additional fields to order baskets
Jesse Weaver [Wed, 10 Feb 2016 19:29:06 +0000 (12:29 -0700)]
Bug 15774: Add additional fields to order baskets

This also moves the admin page for additional fields for all tables to a
single common screen, and factors out display/input parsing logic.

Test plan:
  1. Create an additional field for a subscription (under Serials -> Add
     subscription fields).
  2. Apply patch.
  3. Visit Additional fields under administration, and verify that
     the field created above still shows under the list for the
     subscription table.
  4. Create at least four fields for aqbasket for each combination of
     searchable/not-searchable and with/without an authorized value.
  5. Create an order basket, and verify that all fields are visible and
     correctly save.
  6. Edit the basket, verifying that changes to these additional fields
     are saved.
  7. Add an order to the basket (contents are irrelevant).
  8. Go to advanced search within acquisitions.
  9. Verify that only the searchable fields show in the form, and that
     their contents may be searched.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22466: Replace existing occurrences
Jonathan Druart [Wed, 6 Mar 2019 14:59:58 +0000 (11:59 -0300)]
Bug 22466: Replace existing occurrences

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22466: Do not ask for TT methods to be filtered
Jonathan Druart [Wed, 6 Mar 2019 14:59:55 +0000 (11:59 -0300)]
Bug 22466: Do not ask for TT methods to be filtered

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22466: Add tests
Jonathan Druart [Wed, 6 Mar 2019 14:59:35 +0000 (11:59 -0300)]
Bug 22466: Add tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: DBRev 18.12.00.021
Nick Clemens [Thu, 7 Mar 2019 17:27:05 +0000 (17:27 +0000)]
Bug 20912: DBRev 18.12.00.021

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Add on_editing to $Price filter
Martin Renvoize [Thu, 7 Mar 2019 17:18:02 +0000 (17:18 +0000)]
Bug 20912: (QA follow-up) Add on_editing to $Price filter

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Rebase error corrections
Martin Renvoize [Thu, 7 Mar 2019 08:39:30 +0000 (08:39 +0000)]
Bug 20912: (QA follow-up) Rebase error corrections

The automatic rebase after bug 21206 required a helping hand.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees
Kyle M Hall [Mon, 25 Feb 2019 16:04:15 +0000 (11:04 -0500)]
Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (follow-up) Prevent double charging on renewal
Martin Renvoize [Wed, 20 Feb 2019 08:49:44 +0000 (08:49 +0000)]
Bug 20912: (follow-up) Prevent double charging on renewal

This patch updates the tests the ensure we do not double charge for
renewals that take place before the original due date and fixes the
corresponding loging in C4::Circulation::AddRenewal.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) The default rule already has renewalsallowed=0
Tomas Cohen Arazi [Mon, 4 Feb 2019 14:18:29 +0000 (11:18 -0300)]
Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) POD fix
Tomas Cohen Arazi [Mon, 4 Feb 2019 14:06:09 +0000 (11:06 -0300)]
Bug 20912: (QA follow-up) POD fix

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Fix some test failures
Martin Renvoize [Thu, 31 Jan 2019 14:56:54 +0000 (14:56 +0000)]
Bug 20912: (QA follow-up) Fix some test failures

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Fix TestBuilder
Martin Renvoize [Thu, 31 Jan 2019 11:50:35 +0000 (11:50 +0000)]
Bug 20912: (QA follow-up) Fix TestBuilder

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (follow-up) Add hourly support
Martin Renvoize [Wed, 30 Jan 2019 20:34:13 +0000 (20:34 +0000)]
Bug 20912: (follow-up) Add hourly support

It seemed strange to only add support for Daily loans in the feature
when Koha also support loan periods in hours. This patch adds parallel
functionaliy for hourly loan periods.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (follow-up) Improve test coverage
Martin Renvoize [Wed, 30 Jan 2019 16:20:23 +0000 (16:20 +0000)]
Bug 20912: (follow-up) Improve test coverage

Increase test coverage for CanBookBeIssued and fix a introduced during
the refactoring to Koha::Fees.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Make DB Update idempotent
Martin Renvoize [Wed, 30 Jan 2019 11:42:57 +0000 (11:42 +0000)]
Bug 20912: (QA follow-up) Make DB Update idempotent

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Test for distinct accountlines
Martin Renvoize [Tue, 29 Jan 2019 11:51:29 +0000 (11:51 +0000)]
Bug 20912: (QA follow-up) Test for distinct accountlines

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Move Fees to Charges::
Martin Renvoize [Tue, 29 Jan 2019 11:28:28 +0000 (11:28 +0000)]
Bug 20912: (QA follow-up) Move Fees to Charges::

In preparation for the introduction of Koha::Charges::Fines I have moved
this ::Fees class into the Koha::Charges:: namespace

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up): Fix up unit tests
Kyle M Hall [Fri, 25 Jan 2019 17:49:07 +0000 (12:49 -0500)]
Bug 20912: (QA follow-up): Fix up unit tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up): Fix up Koha::Fees
Kyle M Hall [Fri, 25 Jan 2019 16:16:41 +0000 (11:16 -0500)]
Bug 20912: (QA follow-up): Fix up Koha::Fees

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: Move calculation to Koha::Fees
Kyle M Hall [Fri, 9 Nov 2018 18:34:05 +0000 (13:34 -0500)]
Bug 20912: Move calculation to Koha::Fees

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings
Kyle M Hall [Wed, 31 Oct 2018 19:29:55 +0000 (15:29 -0400)]
Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for...
Kyle M Hall [Wed, 31 Oct 2018 19:14:03 +0000 (15:14 -0400)]
Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: (QA follow-up) Fix number of tests and correct typos
Katrin Fischer [Sun, 28 Oct 2018 17:06:33 +0000 (17:06 +0000)]
Bug 20912: (QA follow-up) Fix number of tests and correct typos

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: Rental Fees based on Time Period
Kyle M Hall [Thu, 14 Jun 2018 13:36:51 +0000 (13:36 +0000)]
Bug 20912: Rental Fees based on Time Period

Some libraries would like to be able to charge a rental fee based on the
number of days an item will be checked out, as opposed to the flat fee
currently offered by Koha.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Edit an itemtype, add a daily rental fee of 1.00
4) Check an item of that itemtype out for 7 days
5) Verify the patron now has rental fee of 7.00

Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 20912: Update database
Kyle M Hall [Thu, 14 Jun 2018 11:13:19 +0000 (11:13 +0000)]
Bug 20912: Update database

Signed-off-by: Matha Fuerst <mfuerst@hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21721: Use Koha::Account->add_debit in AddRenewal
Martin Renvoize [Thu, 1 Nov 2018 13:28:25 +0000 (13:28 +0000)]
Bug 21721: Use Koha::Account->add_debit in AddRenewal

Known Side Effect: Prior to this patch renewal charges were not
recorded in the FinesLog. After this patch, if the FinesLog is
enabled then the 'action' will be recorded as `create_rent`.

Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (RM follow-up) Remove maxissueqty from issuingrule in SIP tests
Nick Clemens [Wed, 6 Mar 2019 14:29:18 +0000 (09:29 -0500)]
Bug 18925: (RM follow-up) Remove maxissueqty from issuingrule in SIP tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (RM follow-up) Remove schema files for deletedtables
Nick Clemens [Wed, 6 Mar 2019 14:28:08 +0000 (09:28 -0500)]
Bug 18925: (RM follow-up) Remove schema files for deletedtables

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (QA follow-up) Remove weird 'Null' values for integer column
Tomas Cohen Arazi [Wed, 6 Mar 2019 13:09:05 +0000 (10:09 -0300)]
Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: DBRev 18.12.00.020
Nick Clemens [Tue, 5 Mar 2019 20:59:07 +0000 (20:59 +0000)]
Bug 18925: DBRev 18.12.00.020

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (RM follow-up) Remove issuingrules columns for new installs
Nick Clemens [Tue, 5 Mar 2019 20:53:04 +0000 (20:53 +0000)]
Bug 18925: (RM follow-up) Remove issuingrules columns for new installs

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (QA follow-up) Fix Circulation.t
Josef Moravec [Tue, 5 Mar 2019 14:08:34 +0000 (14:08 +0000)]
Bug 18925: (QA follow-up) Fix Circulation.t

Test plan:
t/db_dependent/Circulation.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Fix 'Default checkout, hold policy by patron category' block
Jonathan Druart [Sat, 2 Mar 2019 17:14:11 +0000 (14:14 -0300)]
Bug 18925: Fix 'Default checkout, hold policy by patron category' block

We want ->Search to return undef if the rule does not exist.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Move existing rules
Jonathan Druart [Sat, 2 Mar 2019 16:45:14 +0000 (13:45 -0300)]
Bug 18925: Move existing rules

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (QA follow-up) Fix basic_workflow.t
Tomas Cohen Arazi [Sat, 2 Mar 2019 14:03:01 +0000 (11:03 -0300)]
Bug 18925: (QA follow-up) Fix basic_workflow.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt
Tomas Cohen Arazi [Sat, 2 Mar 2019 13:20:23 +0000 (10:20 -0300)]
Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (QA follow-up) Make DB update idempotent
Tomas Cohen Arazi [Sat, 2 Mar 2019 13:14:48 +0000 (10:14 -0300)]
Bug 18925: (QA follow-up) Make DB update idempotent

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Update new occurrences
Jonathan Druart [Thu, 21 Feb 2019 20:04:38 +0000 (17:04 -0300)]
Bug 18925: Update new occurrences

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Fix null/empty behavior, again
Jonathan Druart [Thu, 21 Feb 2019 20:04:36 +0000 (17:04 -0300)]
Bug 18925: Fix null/empty behavior, again

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule
Jonathan Druart [Sat, 15 Sep 2018 20:19:04 +0000 (13:19 -0700)]
Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (follow-up) Fix null/empty behavior
Jesse Weaver [Mon, 29 Jan 2018 22:30:29 +0000 (15:30 -0700)]
Bug 18925: (follow-up) Fix null/empty behavior

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: (follow-up) Change name of rule to fix ambiguity
Jesse Weaver [Sat, 16 Sep 2017 23:23:01 +0000 (17:23 -0600)]
Bug 18925: (follow-up) Change name of rule to fix ambiguity

There was previously an ambiguity between the branch/category/itemtype
specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty.
The latter has been renamed to patron_max{,onsite}issueqty.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules
Kyle M Hall [Mon, 10 Jul 2017 15:00:44 +0000 (11:00 -0400)]
Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules

This patch set moves maxissueqty and maxonsiteissueqty to the
circulation_rules table.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) prove t/db_dependent/Circulation.t
4) prove t/db_dependent/Circulation/Branch.t
5) prove t/db_dependent/Circulation/GetHardDueDate.t
6) prove t/db_dependent/Circulation/Returns.t
7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
8) prove t/db_dependent/Circulation/TooMany.t
9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
10) prove t/db_dependent/Reserves.t
11) Note no changes in circulation behavior related to check out limis
    both on and off site

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21728: (RM follow-up) Add 'Reserve Fee' for new installs
Nick Clemens [Mon, 4 Mar 2019 20:26:04 +0000 (20:26 +0000)]
Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21720: Update Tests
Martin Renvoize [Fri, 30 Nov 2018 13:30:24 +0000 (13:30 +0000)]
Bug 21720: Update Tests

AddIssuing charge is always called in void context, but the tests
checked that the return value was a Koha::Account::Offset and we now
return a Koha::Account::Line.

This patch changes the test to accept a Koha::Account::Line as returned,
adds a test to ensure a Koha::Account::Offset is also created and
corrects the logic that tests that only one accountline is added.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21720: Use Koha::Account->add_debit in AddIssuingCharge
Martin Renvoize [Thu, 1 Nov 2018 12:42:31 +0000 (12:42 +0000)]
Bug 21720: Use Koha::Account->add_debit in AddIssuingCharge

Known Side Effect: Prior to this patch issuing charges were not
recorded in the FinesLog. After this patch, if the FinesLog is
enabled then the 'action' will be recorded as `create_rent`.

Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21728: DBRev 18.12.00.019
Nick Clemens [Mon, 4 Mar 2019 19:10:56 +0000 (19:10 +0000)]
Bug 21728: DBRev 18.12.00.019

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21728: Add 'Reserve Fee' to the account_offset_types
Martin Renvoize [Fri, 30 Nov 2018 19:45:19 +0000 (19:45 +0000)]
Bug 21728: Add 'Reserve Fee' to the account_offset_types

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21728: Use Koha::Account->add_debit in ChargeReserveFee
Martin Renvoize [Thu, 1 Nov 2018 11:08:51 +0000 (11:08 +0000)]
Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21722: Use Koha::Account->add_debit in chargelostitem
Martin Renvoize [Thu, 1 Nov 2018 12:26:35 +0000 (12:26 +0000)]
Bug 21722: Use Koha::Account->add_debit in chargelostitem

This patch updates C4::Accounts::chargelostitem to use the newly
available add_debit method from Koha::Account.

Known Side Effects: If the FinesLog is enabled then the 'action'
recorded will change from the generic `create_fee` (for both the lost
charge and any associated processing charge) to the more descriptive
terms `create_processing` and `create_lost_item`.

Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21722: Tidy up tests and increase coverage
Martin Renvoize [Thu, 13 Dec 2018 19:23:07 +0000 (19:23 +0000)]
Bug 21722: Tidy up tests and increase coverage

This patch moves the chargelostitem 'branchcode' test to within the
'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also
adds tests for additional accountline fields that should be getting
set by this method and adds tests for ProcessingFeeNote before removing
t/db_dependent/Circulation/Chargelostitem.t which covered this
previously.

Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 18584: remove trailing space from C4/XSLT.pm
Hayley Mapley [Sun, 3 Mar 2019 22:26:54 +0000 (22:26 +0000)]
Bug 18584: remove trailing space from C4/XSLT.pm

Test plan:
1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is
gone.
2) Sign off.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22404: Fix parameter "for" of labels in subscription add form
Josef Moravec [Mon, 25 Feb 2019 08:46:11 +0000 (08:46 +0000)]
Bug 22404: Fix parameter "for" of labels in subscription add form

Attribute "for" of tag labelshould contain input id, not name.

Test plan:
1) Go to serials -> add subscription second step
2) Click on labels of these three fields:
    - First issue publication date
    - Subscription start date
    - Subscription end date

--> without patch, nothing happen
--> with path, the datepicker is shown

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22228: Update test for updated mappings
Nick Clemens [Mon, 4 Mar 2019 18:37:43 +0000 (18:37 +0000)]
Bug 22228: Update test for updated mappings

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22228: Escape lone colons and make sure term is balanced
Ere Maijala [Thu, 31 Jan 2019 11:43:00 +0000 (13:43 +0200)]
Bug 22228: Escape lone colons and make sure term is balanced

Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes.

Test plan:

1. Make sure the test case described in the bug works
2. Make sure tests pass:
  prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

Signed-off-by: Björn Nylén <bjorn.nylen(at)ub.lu.se>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: DBRev 18.12.00.018
Nick Clemens [Mon, 4 Mar 2019 18:30:55 +0000 (13:30 -0500)]
Bug 19575: DBRev 18.12.00.018

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: Don't lower case fields in db and use update script instead of raw SQL
David Gustafsson [Mon, 18 Feb 2019 13:56:17 +0000 (14:56 +0100)]
Bug 19575: Don't lower case fields in db and use update script instead of raw SQL

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: (RM follow-up) Fix mapping typo
Nick Clemens [Fri, 15 Feb 2019 14:49:33 +0000 (14:49 +0000)]
Bug 19575: (RM follow-up) Fix mapping typo

Found with QA tools, simple fix

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: Keep authority-number as alias and fix query
David Gustafsson [Thu, 14 Feb 2019 15:52:04 +0000 (16:52 +0100)]
Bug 19575: Keep authority-number as alias and fix query

Keep authority-number as alias and change field name
from alias to real field in hard coded Elasticsearch query

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: Fix an search field
Nick Clemens [Thu, 14 Feb 2019 12:44:13 +0000 (12:44 +0000)]
Bug 19575: Fix an search field

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: Rebase and fix tests
root [Tue, 12 Feb 2019 21:52:39 +0000 (21:52 +0000)]
Bug 19575: Rebase and fix tests

This patch lower cases the sort by fields to normalize checking them and adjusts
some existing tests to meet the new expectations.

The regex for splitting terms has been moved into a subroutine so that adjustment was made

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 19575: Use canonical field names and resolve aliased fields
David Gustafsson [Fri, 3 Nov 2017 12:21:22 +0000 (13:21 +0100)]
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates and
sorting of search results in UI. Also make field names in search strings
case insensitive to accept case variations in template links and user input.

Sponsored-by: Gothenburg University Library
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22360: (bug 21205 follow-up) Restore OPACAcquisitionDetails behavior
Jonathan Druart [Thu, 21 Feb 2019 18:28:10 +0000 (15:28 -0300)]
Bug 22360: (bug 21205 follow-up) Restore OPACAcquisitionDetails behavior

Caused by
  commit 7d10549ae8632e6640d3a99014268a2a1e46b3c4
  Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls

At this point $order is a Koha::Acquisition::Order object, not a hashref
anymore.

Test plan:
Create an order, receive items
Enable OPACAcquisitionDetails
At the detail page of the bibliographic record you should see
"X items are on order." at the bottom of the items list

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22370: Prevent OPAC users from seeing staff news from URL
Aleisha Amohia [Tue, 19 Feb 2019 21:00:31 +0000 (21:00 +0000)]
Bug 22370: Prevent OPAC users from seeing staff news from URL

To test:
1) Have some OPAC and staff only news items
2) On the OPAC view a single news item
3) Change the ID in the URL to the ID of a staff news item
4) Notice you can view the news item without any problems
5) Apply the patch and refresh the page
6) An error should show that the news item doesn't exist
7) Confirm you can still view OPAC news items individually

Sponsored-by: Catalyst IT
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21747: Insert fine_increase and fine_decrease for new installs
Jonathan Druart [Wed, 27 Feb 2019 19:05:20 +0000 (16:05 -0300)]
Bug 21747: Insert fine_increase and fine_decrease for new installs

This fixes Circulation.t
koha_1       | DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=1, 1='22', 2='fine_increase'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21747: DBRev 18.12.00.017
Nick Clemens [Wed, 27 Feb 2019 14:07:28 +0000 (09:07 -0500)]
Bug 21747: DBRev 18.12.00.017

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21747: (follow-up) Intelligent rename of offsets
Martin Renvoize [Mon, 4 Feb 2019 14:29:08 +0000 (14:29 +0000)]
Bug 21747: (follow-up) Intelligent rename of offsets

This patch intelligently renames the account_offset types for updateing
fines from `Fine Update` to `fine_increment` and `fine_decrement`
depending on the sign of the calculated difference of the adjustment.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21747: Use Koha::Account:: routines in UpdateFine
Martin Renvoize [Thu, 1 Nov 2018 14:55:15 +0000 (14:55 +0000)]
Bug 21747: Use Koha::Account:: routines in UpdateFine

Set to use Koha::Account->add_debit and Koha::Account::Line->adjust

Known Side Effect: The format of the FinesLog, if enabled, is changed
after this patch. Prior to this patch the $actionname was left undefined
and the $infos field contained the string:

`"due=".$due."  amount=".$amount." itemnumber=".$itemnum`

After this patch, the logs are more consistent with other FINES logs,
with an $actionname of 'CREATE' or 'UPDATE' and the $infos field
containing a Dumper of fine data.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22084: Plugin upgrade method and database plugin version storage will never be...
Kyle M Hall [Tue, 8 Jan 2019 18:10:53 +0000 (13:10 -0500)]
Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs

If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered.

In addition, if the plugin has no upgrade method, the installed version is never updated in the database!

Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

Test Plan:
1) Install an older version of the Kitchen sink plugin:
   * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from plugin_data for this plugin, to simulate having installed from an earlier version of Koha
3) Upgrade to the latest version of the Kitchen sink plugin:
   * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the plugin_data table
5) Apply this patch
6) Restart all the things
7) Browse to the Kitchen sink configuration page, this should trigger the upgrade method
8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in plugin_data for the Kitchen Sink plugin

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22084: Regression tests
Tomas Cohen Arazi [Wed, 9 Jan 2019 10:33:15 +0000 (07:33 -0300)]
Bug 22084: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume
Tomas Cohen Arazi [Mon, 11 Feb 2019 19:05:23 +0000 (16:05 -0300)]
Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume

This patch makes the mentioned method use the biult-in method for
resuming a suspended hold, instead of manually setting the specific
attributes using the accessors.

The side effect for this is that HoldsLog is now honoured.

This patchset also refactors the tests a bit so they rely on the exposed
methods and thus don't rely on specific implementation details (like
suspended hold means a date in suspended_until plus suspended=1).

To test:
- Apply the regression tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
=> FAIL: It fails loudly because things are done manually
- Apply this patch
- Run:
 k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
=> SUCCESS: Tests pass!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21765: Regression tests
Tomas Cohen Arazi [Mon, 11 Feb 2019 19:04:59 +0000 (16:04 -0300)]
Bug 21765: Regression tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 12318: Show shelving location on subscription tab in OPAC and staff
Katrin Fischer [Mon, 4 Feb 2019 06:09:32 +0000 (06:09 +0000)]
Bug 12318: Show shelving location on subscription tab in OPAC and staff

The shelving location can be helpful to locate an item in the library.
Especially, if the library has decided not to create items for a
subscription this information is currently not visible to the patron.

To test:
- Apply patch
- Create a subscription, set location
- View the subscription tab in detail and staff
- Verify that the location now shows above the callnumber
- Unset location in the subscription
- Verify that the page still looks ok

Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 21875: Handling subject line in Letters.pm
Marcel de Rooy [Fri, 23 Nov 2018 10:36:49 +0000 (11:36 +0100)]
Bug 21875: Handling subject line in Letters.pm

The variable name $utf8 is very misleading: it contains MIME-Header encoding.
$message->{subject} comes from the database and is in perl internal format;
it should NOT be decoded as a MIME-Header.
After encoding to MIME-Header, previously another (useless) encoding to
UTF-8 was done. Since the string is plain ASCII, this is useless and
theoretically wrong. We should stay in MIME-Header.

Test plan:
See Bugzilla comment5.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22016: Unit tests
Kyle M Hall [Tue, 19 Feb 2019 17:46:38 +0000 (12:46 -0500)]
Bug 22016: Unit tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22016: Always send CT field for SIP checkin, even if empty
Kyle M Hall [Mon, 17 Dec 2018 19:41:48 +0000 (14:41 -0500)]
Bug 22016: Always send CT field for SIP checkin, even if empty

Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a CT field to be sent, even if that field is empty. Koha should be able to support this behavior.

Test Plan:
1) Apply this patch
2) Enable the new option ct_always_send for a SIP2 account
3) Restart SIP
4) Check in an item successfully via SIP, which will not be transferred
5) Note the response contains a CT field with no value

Sponsored-by: Pueblo City-County Library District
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22014: Unit tests
Kyle M Hall [Tue, 19 Feb 2019 17:41:30 +0000 (12:41 -0500)]
Bug 22014: Unit tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22014: Add ability to send "00" in SIP CV field on checkin success
Kyle M Hall [Mon, 17 Dec 2018 17:34:14 +0000 (12:34 -0500)]
Bug 22014: Add ability to send "00" in SIP CV field on checkin success

Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior.

Test Plan:
1) Apply this patch
2) Enable the new option cv_send_00_on_success for a SIP2 account
3) Restart SIP
4) Check in an item successfully via SIP
5) Note the response contains a CV field with the value '00'

Sponsored-by: Pueblo City-County Library District
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
5 years agoBug 22337: Make it clearer that language preferences can be re-ordered
Owen Leonard [Wed, 13 Feb 2019 20:00:17 +0000 (20:00 +0000)]
Bug 22337: Make it clearer that language preferences can be re-ordered

This patch makes markup and CSS changes to the system preference
interface so that it is visually clearer that language preferences
(language and opaclanguages) can be re-ordered by the user to control
the sequence of their appearance in language-selection menus.

This patch makes some minor markup changes (including some whitespace
fixes -- diff accordingly) in order to make it easier to apply these CSS
changes.

To test you should have more than one translation installed. Apply the
patch and clear your browser cache if necessary.

 - Go to Administration -> System preferences -> I18N/L10N
 - The 'language' and 'opaclanguages' system preferences should show the
   new style.
   - Each language should show a "move" cursor when the mouse hovers
     over the "box."
   - Dragging and dropping the languages should work correctly, and
     changes should be reflected in language menus.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>