Ryan Higgins [Sun, 10 Aug 2008 21:07:11 +0000 (16:07 -0500)]
Update labels formatstring parse to pick the correct item tag from MARC data.
This patch allows use of "952a" e.g. in labels format string, getting the item-level
data from the correct MARC tag. Previously it just grabbed the data from the first item tag.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Sun, 10 Aug 2008 20:42:29 +0000 (15:42 -0500)]
Update longoverdue.pl cron job to manage setting lost values.
This patch deprecates the NoReturnSetLost system preference, which, as it
turns out, was not implemented anyway. New longoverdue script allows one to
specify on the commandline system-wide delays for changing items to different
lost statuses, and optionally charge for the item.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sun, 10 Aug 2008 20:52:49 +0000 (15:52 -0500)]
Adding some missing folks to the About page
Joshua Ferraro [Sun, 10 Aug 2008 20:38:42 +0000 (15:38 -0500)]
Adding three statistics files that NPL uses, they don't
work 100% with stock 3.0 yet but are good examples of
custom scripts that libraries might want to write and
schedule periodically
Joshua Ferraro [Sun, 10 Aug 2008 20:18:48 +0000 (15:18 -0500)]
Updates to the example crontab
Joshua Ferraro [Sun, 10 Aug 2008 19:49:56 +0000 (14:49 -0500)]
Remove biblio.* from sample notice templates and
replace with <<items.content>>
Joshua Ferraro [Sun, 10 Aug 2008 19:42:47 +0000 (14:42 -0500)]
Fix for 2492: Mail::Sendmail chokes on utf-8 [ process_message_queue.pl ]
Ryan Higgins [Sun, 10 Aug 2008 12:24:03 +0000 (07:24 -0500)]
Update fines cronjob: remove redundant scripts, remove some superfluous code in remaining fines.pl.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sun, 10 Aug 2008 14:48:22 +0000 (09:48 -0500)]
Minor update to README for RM
Joshua Ferraro [Sun, 10 Aug 2008 14:45:05 +0000 (09:45 -0500)]
Updates to the subtag registry for new translations
Updates to the RElease Manager's notes
Fix Danish langauge from dk to da
Joshua Ferraro [Sun, 10 Aug 2008 13:24:00 +0000 (08:24 -0500)]
Translation updates prior to 3.0-stable release
Joshua Ferraro [Sun, 10 Aug 2008 11:45:50 +0000 (06:45 -0500)]
Reverting an earlier change to overdue.pl (still broken) and
fixing a translation problem with borrowers_stats.ptmpl:
xgettext.pl: Warning: borrowers_stats.tmpl: line 28: SGML "closed start tag" notation: <p<!-- TMPL_IF NAME="debug"--> class="debug"<
Joshua Ferraro [Sun, 10 Aug 2008 11:44:43 +0000 (06:44 -0500)]
Release Notes for 3.0-stable
Ryan Higgins [Sun, 10 Aug 2008 10:25:55 +0000 (05:25 -0500)]
Final cleanup of labels for 3.0
This patch adds the callnum_split and text_justify options to the templates,
fixes bad javascript to switch between 'formatstring' and fixed-field means of specifying labels content,
fixes csv output when fixed-fields specifiers are used, and adds some help text for the formatstring case.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sun, 10 Aug 2008 00:47:34 +0000 (19:47 -0500)]
fix for 2382: Self Checkout Won't Work for Staff with Circ
Ryan Higgins [Sat, 9 Aug 2008 20:27:27 +0000 (15:27 -0500)]
Prevent borrower import from overwriting data that it shouldn't, and polish off a couple error conditions.
When an imported patron matches an existing one, keep data in the original record unless our import file
includes that column. Also, check for branch & categorycodes, and produce error if invalid. Finally,
auto-calculate expiry date if not given.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Sat, 9 Aug 2008 18:03:01 +0000 (13:03 -0500)]
kohabug 2475 [3/?] Adding splitting algorithm for fiction call numbers
This patch also looks for the call number type in items.cn_source and if
that is NULL, falls back to the DefaultClassificationSource syspref.
Splitting algorithms need to be written for other known/supported call
number systems (ie. sudocs, udc, generic, etc.)
Documentation Notes:
For now, if a call number falls through the regex checking for formal lccn or ddcn,
it is passed through the regex for a fiction call number; if it falls through that,
it is returned unsplit.
If a call number does not split, please update enhancement request 2500 with the
requested information.
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2500
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sat, 9 Aug 2008 17:56:04 +0000 (12:56 -0500)]
2433: Cannot apply manual credits with an item number
This patch changes the behavior so that you can enter in
a barcode instead of an itemnumber for the manual credit
and invoice screens. Also, the borrower's account page now
displays a link back to the item record if an item was
linked to the charge
Joshua Ferraro [Sat, 9 Aug 2008 17:06:04 +0000 (12:06 -0500)]
2487: Collection code select boxes in Adv search show both code and description
Galen Charlton [Sat, 9 Aug 2008 15:53:15 +0000 (10:53 -0500)]
commented out unconditional warns
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Sat, 9 Aug 2008 15:53:14 +0000 (10:53 -0500)]
Bug fix : use delete_field/insert_grouped_field rather than replace_with
replace_with maight have unexpected behaviour.
Has to test merge_authority.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Sat, 9 Aug 2008 15:53:13 +0000 (10:53 -0500)]
Bug Fixing merge_authority.pl
merge works on the fly now.
But for an obscure reason, merge_authority.pl fails to update database when lanched on command line.
Adding one table to LOCK for noZebra UPDATE in Biblio.pm
You should remove C4::Search from merg_authority.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sat, 9 Aug 2008 13:08:11 +0000 (08:08 -0500)]
2482: Default Letter on Notice Triggers Causes Error
Changing 'Default' to 'No notice' as per solution
suggested in bug report
Chris Nighswonger [Sat, 9 Aug 2008 12:36:27 +0000 (07:36 -0500)]
kohabug 2475 [2/2] Porting LCCN splitting code to Labels.pm
This patch corrects the csv field list processing alogrithm in two areas:
1. It adjusts the regexp to handle quoted fields with embedded spaces.
2. It adds descrimination for individual 952 subfields.
Documentation needs to be written for the label layout editor.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Sat, 9 Aug 2008 12:36:26 +0000 (07:36 -0500)]
kohabug 2463 & 2464 Removing unlinked fields from label-edit-layout.pl
This patch removes unlinked fields from the 'Choose Order Of Text Fields to Print'
option on label-edit-layout.pl
It also adds code to make the 'Itemtype' field respect the item-level_itypes syspref.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Sat, 9 Aug 2008 12:36:25 +0000 (07:36 -0500)]
kohabug 2475 [1/2] Porting LCCN splitting code to Labels.pm
This patch ports LCCN splitting code from Koha 2.2.9 to Koha 3.0
This algorithm has been ported just as it appears on some production
systems. LCCNs that do not split correctly should have a bug opened
and include an exact example so that the regexp's can be adjusted.
This patch also adds code to split DDCNs using the *loosest* possible
interpretation of DDCN rules. On the simple end, the DDCN split
algorithm will handle being passed just a Dewey call number.
However, there may be some unusually complex DDCNs that will not
split properly. These will need to have a bug submitted for them
including a specific example so that the regexp's can be adjusted.
The correct choice of splitting alogrithm is determimed by the
item level classification source (items.cn_source).
Documentation should be updated to reflect these changes. Please include
the bit about complex call numbers and the need of a bug report.
[LL Bug 26]
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Sat, 9 Aug 2008 13:01:14 +0000 (08:01 -0500)]
Bug 2410: Can't use string ("0") as an ARRAY ref while "strict refs" in use at detail.pl line 219
Thanks to HDL for your patch, I couldn't get it to apply so I did it manually
No change to documentation
Joshua Ferraro [Sat, 9 Aug 2008 12:45:35 +0000 (07:45 -0500)]
2425: Spelling Error - Permissions
Joshua Ferraro [Sat, 9 Aug 2008 12:03:37 +0000 (07:03 -0500)]
Updates to the installation instructions
In particular, removing references to the zebraqueue daemon
and replacing with mention of the -z option with rebuild_zebra.pl
Joshua Ferraro [Sat, 9 Aug 2008 11:49:21 +0000 (06:49 -0500)]
Temporary fix for bug 2483: t/Barcodes.t has database dependent tests in it
Moving Barcodes.t to db_dependent to avoid failure of make test
Joshua Ferraro [Fri, 8 Aug 2008 20:15:23 +0000 (15:15 -0500)]
Resolves problem where duplicate blank barcodes threw errors
form now only checks for duplication when the barcode is non-empty
Paul POULAIN [Thu, 31 Jul 2008 12:19:51 +0000 (14:19 +0200)]
fix for #2440 : acquisition recieve & item creation
It has to be reintroduced, as some (most in France) libraries don't create
items on recieve, but after "equipment" step.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Fri, 8 Aug 2008 19:22:59 +0000 (14:22 -0500)]
bug 2496: add 'edit' link to authority search results
When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record. This
allows a cataloger to do the following:
1. Start editing a bib record
2. Click on the '...' to select an authorized heading
for an authority-controlled field.
3. Look at the results in the pop-up window and
see that an authority record needs correction.
4. Click on the 'edit authority' link. This allows
the authority to be revised. Note that this
takes place in the popup window, not the originally
bib editing window.
5. Save the authority record, then close the popup
window and redo the heading search.
For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 7 Aug 2008 16:02:19 +0000 (11:02 -0500)]
Remove <br /> from syspref descriptions.
The template HTML-escapes the descriptions now (as it should).
So we can't make them prettier w/ HTML inserted.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 8 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Link correction (affected only non-js users).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Fri, 8 Aug 2008 17:28:48 +0000 (12:28 -0500)]
Add help text indicating that one should not use stopwords with Zebra.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 8 Aug 2008 19:09:52 +0000 (14:09 -0500)]
Partial fix for 2446: single word queries that were stopwords
weren't being striped out of the query
Joe Atzberger [Fri, 8 Aug 2008 17:15:10 +0000 (12:15 -0500)]
Fix to prevent crash on null dateexpiry.
Error was:
Usage: Date::Calc::Date_to_Days(year, month, day)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 8 Aug 2008 16:06:47 +0000 (11:06 -0500)]
Adding "New Item" menu option. Jumps to anchor for Add Item form.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 8 Aug 2008 14:43:44 +0000 (09:43 -0500)]
Changing tabindex="-1" to tabindex="0". Fixes 2493.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 8 Aug 2008 14:43:34 +0000 (09:43 -0500)]
Minor markup correction.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Fri, 8 Aug 2008 13:22:49 +0000 (08:22 -0500)]
kohabug 2458 Disallowing non-SELECT SQL in reports module
This patch enforces SELECT-only SQL in the reports module.
It introduces code to check SQL in two places. The first is
when a save is attempted on a user constructed SQL statement.
If a non-SELECT SQL statement is entered, the user will be
presented with an error message and a button giving the
option of editing the SQL. The second is when any SQL is
executed. If execution of a non-SELECT SQL statement is
attempted, the user is presented with an error message and
instructed to delete that report as the SQL is invalid.
The second check is intended as a safety net as no non-SELECT
SQL should ever be saved.
It may be well to document the proper usage of the direct SQL
entry type report.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 8 Aug 2008 15:51:45 +0000 (10:51 -0500)]
Revert "Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity."
This reverts commit
67f229cba7395485a22fc0effa67ca4f592408f4.
Southeastern University [Fri, 8 Aug 2008 01:38:06 +0000 (21:38 -0400)]
Add missing to and from email addresses to user and admin EnqueueLetter calls, respectively. Add extra level to verbosity.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 7 Aug 2008 22:18:25 +0000 (17:18 -0500)]
addbiblio - HTML validation fix, add type to link
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 7 Aug 2008 22:06:41 +0000 (17:06 -0500)]
auth_finder - HTML validation fixes
Missing </tr> and extra </select>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Thu, 7 Aug 2008 21:05:41 +0000 (16:05 -0500)]
kohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber
The INSERT was missing the copynumber parameter. moredetail.pl was also not setting
the copyvol template variable. This patch corrects these issues so that the copynumber
is both inserted when a new item is created (including during a bulkmarcimport.pl run)
and displayed properly on moredetail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Wed, 6 Aug 2008 20:43:51 +0000 (15:43 -0500)]
kohabug 2448 Correcting Alignment of Column Headers
This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 6 Aug 2008 20:17:51 +0000 (15:17 -0500)]
Add missing </td> to opac-user.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 6 Aug 2008 19:49:30 +0000 (14:49 -0500)]
Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 6 Aug 2008 16:14:26 +0000 (11:14 -0500)]
Bug 2084 [2/2]: Database version 3.00.00.107: adding warnings to three system preferences
This patch adds warnings to the OPACShelfBrowser, CataloguingLog, and NoZebra system preferences. Using
them on busy koha installations has proven to be rather resource intensive.
This is considered a stopgap solution. Making these features less resource using to run
would be preferred.
Note to documentation writers: screenshots of these system preferences could be updated, but
no functionality has changed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 6 Aug 2008 16:14:25 +0000 (11:14 -0500)]
Bug 2084 [1/2]: adding warning to overdues report
This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.
This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.
Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 16:32:15 +0000 (11:32 -0500)]
bug 2479: allow MARC21 bib 440 to link to authorities
Fixed overly-strict interpretation of OCLC practice
that prevented 440 series statement/added entries
from linking to the appropriate series authority
record.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:29 +0000 (18:53 +0200)]
partial fix for #2471, (overdue notice sent twice)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 6 Aug 2008 15:35:05 +0000 (10:35 -0500)]
Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 14:54:42 +0000 (09:54 -0500)]
bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.
Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 6 Aug 2008 08:44:46 +0000 (03:44 -0500)]
Patron import reform - bug 2287 - expanded error catching and feedback
This incorporates and extends the patch from MJ Ray attached to bug 2287.
Added feedback of up to 25 lines, including for errors at the Text::CSV
parsing level. This allows feedback for problems than involve encoding.
Added link to download "starter" CSV file (with all the columns).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Tue, 5 Aug 2008 14:27:14 +0000 (16:27 +0200)]
Bug fixing : 2470 Serials forgetting library
Using default values for PrepareItemrecordDisplay
It changes Biblio.pm
Adding a hash with default values to PrepareItemrecordDisplay
Usunf that API in Serials.pm and serials-edit.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Wed, 6 Aug 2008 12:59:58 +0000 (14:59 +0200)]
Bug fix : 2361 Location was lost on subscription update
Location is now defaulted to the location of the librarian
When updating subscription, subscription branchcode is taken into account.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:30 +0000 (18:53 +0200)]
bugfix for #2472
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:28 +0000 (18:53 +0200)]
Adding Email::Date dependancy, requested by MIME::Lite
(no bugzilla entry)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Wed, 6 Aug 2008 09:23:36 +0000 (11:23 +0200)]
use alphabetical order to popup the cities
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 02:16:09 +0000 (21:16 -0500)]
bug 2317: avoid crash when auto-creating authority
If BiblioAddsAuthorities is ON, saving a MARC bib record
in the cataloging editor can create new authority records.
When using MARC21, if one of those authority records
has diacritics in its heading, the save crashes with the
following error:
Wide character in null operation at
/usr/local/share/perl/5.8.8/MARC/Charset/Table.pm line 96
To prevent this, new MARC21 authorities created by
BiblioAddsAuthorities have the Leader/09 set to 'a'. Note
that this is not currently required for UNIMARC authorities,
as MARC::File::XML->as_xml_record() does not attempt
to transcode UNIMARC records from MARC-8 to UTF-8.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Tue, 5 Aug 2008 20:01:42 +0000 (15:01 -0500)]
bug 2473: correct display of items.content
Correct bug in output of overdue notices that has
items.content displaying only the number of columns
in each items.content structure (currently, 4).
Patch inspired by patch submitted by Paul Poulain.
[LL bug 31]
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 13:10:01 +0000 (15:10 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.
This manage multiple errors on barcode and displays them.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Tue, 5 Aug 2008 13:12:49 +0000 (08:12 -0500)]
Revert "bugfix for 2451 : serial recieve & barcode does exist complaint"
This reverts commit
23b8da277b0a1aa67f0686aa65a9e0d527a3b26b.
Galen Charlton [Mon, 4 Aug 2008 23:50:37 +0000 (18:50 -0500)]
bug 2411: fix adding new tag to authority framework
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Tue, 5 Aug 2008 03:50:01 +0000 (22:50 -0500)]
Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously was reporting nothing since the js was broken).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 4 Aug 2008 14:09:41 +0000 (09:09 -0500)]
Rename crontab.example
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 4 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Correcting markup for validity.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 4 Aug 2008 15:15:23 +0000 (10:15 -0500)]
bug 2459: fix module depedency error blocking SIP2
Ror a poorly understood (by me) reason, use of 'use
UNIVERSAL' and 'use C4::Auth' in the SIP2 code is resulting
in a compilation error, thus blocking SIP2 from working.
The error (prior to this patch) could be reproduced as follows:
cd C4/SIP
perl -I. -wc Sip/MsgType.pm
"get_session" is not exported by the C4::Auth module
Can't continue after import errors at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51.
Compilation failed in require at /home/gmc/koha/dev/C4/Auth.pm line 34.
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/Auth.pm line 34.
Compilation failed in require at Sip/MsgType.pm line 21.
BEGIN failed--compilation aborted at Sip/MsgType.pm line 21.
or more minimally
perl -ce 'use UNIVERSAL; use C4::Auth;'
This patch works around the problem by making C4::Auth
and C4::VirtualShelves not import any symbols
from each other.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:22 +0000 (10:15 -0500)]
kohabug 2457 Minor patch to correct GD
version number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:21 +0000 (10:15 -0500)]
kohabug 2456 Moving certain C4::VirtualShelves.pm subs from EXPORT
to EXPORT_OK and correcting associated syntax
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:20 +0000 (10:15 -0500)]
kohabug 2437 Corrects LIMIT offset algorithm
Because of a miscalculation in the offset algorithm, the LIMIT offset creeps
backwards by a magnitude for every page beyond page two. This patch corrects
the algorithm to behave as expected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:19 +0000 (10:15 -0500)]
kohabug 2417 Removing hardcoded query limit from reports
This patch removes a hardcoded 'LIMIT 20' which was added to all report queries
thus limiting all reports to only the first twenty rows of applicable data. In
its place this patch introduces code to paginate through all applicable data,
regardless of how many rows are available. The code will also honor any user
defined 'LIMIT' in reports based on SQL entered directly by the user.
This patch also adds column labels to 'tab' and 'csv' files generated by reports.
NOTE: Only user defined 'LIMIT's apply to 'tab,' 'csv,' and 'text' files.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:18 +0000 (10:15 -0500)]
kohabug 1679 & 1680 Fixes date formatting in guided reports wizard
This patch corrects date formatting when defining dictionary definitions in the
guided reports wizard so that dates display according to syspref.
Date formating is also corrected in the report creation section of the guided
reports wizard.
It also corrects a javascript bug which caused some of the calander widgets not
to function properly.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Mon, 4 Aug 2008 13:31:07 +0000 (15:31 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Nicole Engard [Mon, 4 Aug 2008 13:34:45 +0000 (09:34 -0400)]
Help file updates
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Mon, 4 Aug 2008 13:32:55 +0000 (08:32 -0500)]
Putting the db revision from 105 into 106 as it wasn't
applied in 105
Paul POULAIN [Sat, 2 Aug 2008 17:22:03 +0000 (19:22 +0200)]
very small french translation fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 17:22:02 +0000 (19:22 +0200)]
bump to 106, bug 2452, subscriptionhistory.enddate can be 0000-00-00
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 17:22:01 +0000 (19:22 +0200)]
dealing with L' and D' in french
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 14:53:14 +0000 (16:53 +0200)]
unimarc plugin fix, suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:37:51 +0000 (20:37 -0500)]
Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction. This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time). Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:10:15 +0000 (20:10 -0500)]
Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )
Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:05:55 +0000 (20:05 -0500)]
Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible. A 'show advanced pattern' button will display/hide the
base prediction table at any time. A 'reset pattern' button is added. The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 20:24:35 +0000 (15:24 -0500)]
Fixing markup error in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Danny Bouman [Fri, 1 Aug 2008 20:08:51 +0000 (16:08 -0400)]
bug 2450: expanded size of cardnumber input field
Expanded the size of the cardnumber input field to 20 instead of 10. This allows the full 14-digit barcode to be viewed at a glance without having to
scroll.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Tue, 29 Jul 2008 09:05:37 +0000 (11:05 +0200)]
Bugfix #2414
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 30 Jul 2008 15:03:05 +0000 (17:03 +0200)]
BUGFIX fix on 2380 fix, dump to 102
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 16:33:11 +0000 (11:33 -0500)]
Correcting structure and markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 14:00:00 +0000 (09:00 -0500)]
Complete sweep of help files in order to correct invalid markup and fix Bug 2444(break up long lines in templates).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 31 Jul 2008 11:21:31 +0000 (13:21 +0200)]
small typo/html fixes as suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 30 Jul 2008 16:18:02 +0000 (11:18 -0500)]
bug 2335: adding SMSSendDriver system preference - DB update to version 3.00.00.105
Previously, the SMSSendDriver system preference was set as a local use system
preference. This patch makes it an official system preference under the "Patron" tab.
This system preference determines which SMS::Send driver is used to send SMS messages.
I have attempted to take care to not overwrite this system preference if it has already
been set.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 17:03:52 +0000 (12:03 -0500)]
Cleaning up tags display a little bit, adding tablesorter to user tags table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 17:03:43 +0000 (12:03 -0500)]
Minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Thu, 31 Jul 2008 13:58:43 +0000 (08:58 -0500)]
Bug 1953: updating bad unit test for C4::Items::GetItemsForInventory
The tests I wrote for C4::Items::GetItemsForInventory confused the differences
between biblionumber and itemnumber. That wasn't uncovered on my limited test
database, but I uncovered it later.
This fixes that problem by populating a $self->{'items'} list with details of any items
added by KohaTest::add_biblios. Then, tests can probe there for the details of items
they should expect to find when searching.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:52:53 +0000 (08:52 -0500)]
Need to pass dateformat pref to the template so tablesorter js knows how to handle sorting date column.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:52:44 +0000 (08:52 -0500)]
Display publicationdate if available, else copyrightdate.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:43:11 +0000 (08:43 -0500)]
Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>