Katrin Fischer [Sat, 14 May 2011 10:36:25 +0000 (12:36 +0200)]
Bug 6340: Pagination bar on guided reports result page broken
The pagination on the guided reports page was not showing up.
TT problem.
To test:
Add a sql report with more than 20 results.
Example: select * from borrowers
Without the patch, only the first 20 results will show and no pagination bar.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Liz Rea [Fri, 20 May 2011 19:41:20 +0000 (14:41 -0500)]
Bug 6258 - Guided reports wizard 'Build new' brings up empty page
Patch fixes a TT error that caused Build New to be empty.
To test:
Click More -> Reports, you should see the welcome page and be able to step through creating the report.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 17 May 2011 15:07:03 +0000 (11:07 -0400)]
Fix for Bug 3140 - It is possible to email someone else's private list
Adding check for ShelfPossibleAction("view") to make sure the logged
in user has permission to view the selected list when downloading
or emailing a list.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 24 May 2011 19:15:18 +0000 (15:15 -0400)]
Fix for Bug 6395, Cannot create routing list
Some old TMPL tags got left behind.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Fri, 20 May 2011 19:14:56 +0000 (21:14 +0200)]
Bug 6343: TT issues in label creator
- Manage Batch had no branch set
- New Batch had no branch set
- Add link on item result list was broken, missing the batchid
To test:
Create a new batch and add items one by one. Look at 'Manage batches'.
Check that the branch in the top right corner is always correctly shown and set.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Fridolyn SOMERS [Mon, 23 May 2011 13:07:28 +0000 (09:07 -0400)]
Bug 5658 can't delete subfields in frameworks
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
ruth@bywatersolutions.com [Tue, 24 May 2011 19:57:08 +0000 (15:57 -0400)]
Bug 6401 fix to the history file
This patch adds Ian Walls' name to the history file, so he can be found.
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédérick Capovilla [Thu, 24 Feb 2011 17:30:09 +0000 (12:30 -0500)]
Bug 3580 Sort the facets categories so they don't move every search.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 17 May 2011 03:36:01 +0000 (15:36 +1200)]
Bug 6350 : Updating history docs
http://bugs.koha-community.org/show_bug.cgi?id=6350
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 18 May 2011 18:05:47 +0000 (14:05 -0400)]
Fix for bug 6367 - 'Preview MARC' hover button does not show correct MARC record
Misplaced line of JavaScript meant that the menu always grabbed
the ID of the last item in the search results.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Wed, 18 May 2011 05:23:21 +0000 (07:23 +0200)]
Improve error message when translation installation fails
For Translator Manager (myself...). A translation installation may fail because
translator hasn't enter properly string parameters (%s). With this patch, the
message ID is displayed not only the parameter.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Alex Arnaud [Fri, 13 May 2011 14:19:09 +0000 (16:19 +0200)]
Bug #6131 - change index "Author-name-personal" for "Personal-name"
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Tomas Cohen Arazi [Fri, 6 May 2011 17:11:17 +0000 (14:11 -0300)]
Bug 6320 - Provide language filter selection in adv an id inside a div
Basically, put the language filter selection fieldset inside a <div> with its
own id so it can be hidden through OPACUserCSS variable.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Fri, 6 May 2011 11:50:39 +0000 (12:50 +0100)]
Bug 6315: Fix depreciated constructions in C4::Serials
Perl 5.14 will issue warnings in cases where it is assumed that
() will magically appear around qw() as the interpreter
will stop fooling itself that they are there
Added the missing () in the couple of cases they were required
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 15 May 2011 08:38:00 +0000 (20:38 +1200)]
Merge remote-tracking branch 'kc/new/bug_6312' into kcmaster
Nicole C. Engard [Thu, 5 May 2011 16:25:29 +0000 (12:25 -0400)]
Bug 6312: Remove references to login being OPAC only
This patch changes the 'opac login' label to read 'username'
since it can be used in the staff client and the opac
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
conan (aka Fernando Canizo) [Wed, 20 Apr 2011 20:04:37 +0000 (17:04 -0300)]
Bug 6218: patron gets dot added if no first name
Trivial fix, now it choose surname if firstname is empty and behaves
like before (firstname.surname) if both are provided.
Signed-off-by: Frederic Demians <frederic@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Sat, 9 Apr 2011 15:29:07 +0000 (11:29 -0400)]
Bug 6152: Document DOM authority index config
Add a note so developers know not to edit authority-zebra-indexdefs.xsl directly
but to instead edit authority-koha-indexdefs.xml and use the
koha-indexdefs-to-zebra.xsl stylesheet to generate the former from the latter.
Signed-off-by: Frederic Demians <frederic@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Matthias Meusburger [Fri, 5 Feb 2010 11:00:15 +0000 (12:00 +0100)]
Bug 5995 : MT2892: Fix security issue in CAS intranet login
Users could log in intranet using their cardnumber, with superlibrarian
rights.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole C. Engard [Wed, 11 May 2011 19:46:29 +0000 (15:46 -0400)]
Bug 6330 - Change hold language from 'until' to 'since'
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Sat, 30 Apr 2011 02:01:49 +0000 (22:01 -0400)]
Fix for Bug 6284, Reports Filters Need Prettying
1. Moved the form to the left under the menu
2. Added a calendar next to date (and a date format tip)
3. Styled the form like other filter forms for consistency's sake
4. Formatted on-screen message to match standard style
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Tue, 10 May 2011 17:25:05 +0000 (13:25 -0400)]
Bug 6320 Generate Next button doesn't generate next issue
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Tue, 10 May 2011 17:09:38 +0000 (13:09 -0400)]
Fix for Bug 6295 - misaligned columns in opac suggestions list
Template variable scope error.
NOTE: this bug only applies when OPACViewOthersSuggestions is turned on; otherwise there is nothing to fix.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Magnus Enger [Tue, 10 May 2011 16:48:09 +0000 (12:48 -0400)]
Bug 6308 - Show number of comments - new patch
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 8 May 2011 20:25:36 +0000 (08:25 +1200)]
Merge remote-tracking branch 'kc/new/bug_5449' into kcmaster
Ian Walls [Tue, 3 May 2011 15:37:46 +0000 (11:37 -0400)]
Bug 6294: {BIBLIONUMBER} parsing for SearchForTitleIn
Adds support for parsing of the biblionumber into the SearchForTitleIn system preference, allowing
external sites with APIs (like Facebook or Twitter) to do link-backs to the details page for the
title.
Sample code for implementing Facebook "like" links and Twitter "tweet this" are included on the bug report
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 2 May 2011 00:39:35 +0000 (12:39 +1200)]
Bug 6031 : Fix for syntax (bashism crept into a pure sh script)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 28 Apr 2011 15:47:07 +0000 (16:47 +0100)]
Bug 6282: HomeOrHoldingBranchReturn missing from pref file
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 28 Apr 2011 23:39:18 +0000 (11:39 +1200)]
Fixing a template error
Chris Cormack [Thu, 28 Apr 2011 23:33:19 +0000 (11:33 +1200)]
Rewriting the valid templates test to test template toolkit
Chris Cormack [Thu, 28 Apr 2011 21:34:58 +0000 (09:34 +1200)]
Merge remote branch 'kc/new/enh/bug_6033' into kcmaster
Chris Cormack [Thu, 28 Apr 2011 21:33:35 +0000 (09:33 +1200)]
Bug 6033 : Follow up fix for bug that crept in with conversion to template toolkit
Katrin Fischer [Mon, 25 Apr 2011 19:55:40 +0000 (21:55 +0200)]
Bug 6265: Authority search in OPAC not exact
The search for linked records from the full heading page was not exact.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Matthias Meusburger [Thu, 1 Apr 2010 14:07:25 +0000 (16:07 +0200)]
Bug 6001 : batchRebuildBiblioTables.pl doesn't crash anymore when GetMarcBiblio fails. Unprocessed biblionumbers are displayed at the end of the execution instead.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 28 Apr 2011 20:55:19 +0000 (08:55 +1200)]
Merge remote branch 'kc/new/enh/bug_6143' into kcmaster
Nicole C. Engard [Thu, 28 Apr 2011 16:31:06 +0000 (12:31 -0400)]
Follow Up for Bug 6143: New numSearchRSSResults preferences
This patch updates the language in the pref file to match the format
used in other areas of the preferences by making the preference value
part of a sentence.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Robin Sheat [Thu, 16 Dec 2010 05:05:43 +0000 (18:05 +1300)]
Bug 5509 - use an XML parser to get values from config
Using sed and regex was causing issues when LDAP connection details were
added.
See
http://stackoverflow.com/questions/
1732348/regex-match-open-tags-except-xhtml-self-contained-tags/
1732454#
1732454
for more information.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 27 Apr 2011 23:26:42 +0000 (11:26 +1200)]
Bug 6033 : Template changes
Srdjan Jankovic [Wed, 6 Apr 2011 02:56:45 +0000 (14:56 +1200)]
Bug 6033 : wr77488 : report selection filter
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Wed, 13 Apr 2011 14:03:03 +0000 (10:03 -0400)]
Bug 3543: split NLM call numbers in label creator
Split NLM call numbers using the same rules as those used for Library of
Congress call numbers.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Ian Walls [Mon, 25 Apr 2011 22:30:22 +0000 (18:30 -0400)]
Bug 6259: AllowHoldPolicyOverride causes every hold to need override
Adds a check to make sure that the item is actually unavailable before requiring the override
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Mon, 25 Apr 2011 22:27:34 +0000 (18:27 -0400)]
Bug 5445: Nicer breadcrumbs when ordering from different sources
Replaces previous patch. Also fixes ordering from existing records.
While it was possible to go back to vendor and basket page when ordering
from a new suggestion the other odering options missed those 'crumbs'.
This patch makes the breadcrumbs for all orderings options consistent and
makes it possible to navigate back to the vendor or basket from all
pages.
- from existing record
- from staged record
- from external source
- from empty record
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Tue, 26 Apr 2011 10:28:09 +0000 (22:28 +1200)]
Bug 6143 : Fixing missing sysprefs
Chris Cormack [Tue, 26 Apr 2011 08:51:37 +0000 (20:51 +1200)]
Bumping the database number
Stéphane Delaune [Mon, 11 Apr 2011 12:04:36 +0000 (14:04 +0200)]
Bug #6143 - New feature: capability to limit the RSS results
Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Ian Walls [Thu, 21 Apr 2011 04:46:34 +0000 (00:46 -0400)]
Bug 3202: creating new 'child' categorytype patrons doesn't set branch properly
If a guarantor search is not being performed, the creation of any Child category_type patron will
not default to the currently logged in branch, but rather the first branch alphabetically.
Adding a test for the existence of any guarantor branch data before assigning it clears up this problem
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Sun, 10 Apr 2011 21:32:26 +0000 (17:32 -0400)]
Bug 6153: Display imprint subfields in order
Prior to this patch, the imprint (field 260) was displayed out-of-order on the
MARC21 XSLT record detail page. For example, the following data:
=260 \\$aNew York :$bHarper,$c2003$g(2005 printing)
Displayed as:
Harper, New York : 2003 (2005 printing)
Instead of:
New York : Harper, 2003 (2005 printing)
Even more problematically, the following data:
=260 \\$a[S.l. :$bs.n.],$c1860.
Displayed as:
s.n.], [S.l. : 1860
Instead of:
[S.l. : s.n.], 1860.
This patch changes the MARC21 OPAC Details display to display the imprint
subfields in the proper order (as the Results display already does).
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Mon, 18 Apr 2011 03:35:21 +0000 (23:35 -0400)]
Bug 6194 Suppress punctuation when no location
Template was showing empty parentheses when no location
data was present. Punctuation should be dependent on
the variable being set
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Sun, 24 Apr 2011 15:58:45 +0000 (17:58 +0200)]
Bug 6257: Fix broken MARC documentation links
Another TT issue.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Mon, 25 Apr 2011 16:35:28 +0000 (12:35 -0400)]
Bug 6263: shelf browser broken in 3.4
Another problem with TT.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Magnus Enger [Mon, 25 Apr 2011 09:34:04 +0000 (11:34 +0200)]
Move nb-NO-i-staff-prog-v-
3002000.po -> nb-NO-i-staff-t-prog-v-
3002000.po
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Mon, 25 Apr 2011 09:25:13 +0000 (11:25 +0200)]
Bug 6228: Show active currency in system preferences
Some system preferences like maxoutstanding should show the
active currency behind the value. The code for this was not
translated to Template Toolkit.
Will change strings, so probably for 3.4.1
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Fri, 22 Apr 2011 20:57:38 +0000 (16:57 -0400)]
Fix for Bug 2941 Transfers cannot be canceled once initiated
This patch includes the changes by Catalyst found at
http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bug_2941
and adds a "cancel transfer" link to the transferstoreceive
script, including a redirect check to send the user back to
that report.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Fri, 22 Apr 2011 14:23:05 +0000 (10:23 -0400)]
history.txt updates for April 2011 releases
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nicole C. Engard [Fri, 22 Apr 2011 14:20:08 +0000 (10:20 -0400)]
Add missing library to release notes
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Frédéric Demians [Fri, 22 Apr 2011 08:37:54 +0000 (10:37 +0200)]
Update ALL Koha translation files
Galen Charlton [Fri, 22 Apr 2011 02:42:42 +0000 (22:42 -0400)]
textual improvements to release notes
* typo and usage improvements
* alphabetize sponsoring libraries
Thanks to Brendan Gallagher for suggestions.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Fri, 22 Apr 2011 01:27:37 +0000 (13:27 +1200)]
Bumping version number for release
Chris Cormack [Thu, 21 Apr 2011 23:31:44 +0000 (11:31 +1200)]
Fixing typo in the release notes
Katrin Fischer [Thu, 21 Apr 2011 22:48:19 +0000 (00:48 +0200)]
Bug 6251: Acq: receiving orders
- numbered pagination links are broken, previous and next work
- link to order line missing supplier id
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 22:06:08 +0000 (00:06 +0200)]
Bug 6250: Link to order in uncertain prices list broken
Missing URL parameter.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 21:55:56 +0000 (23:55 +0200)]
Bug 6249: Can't order accepted suggestions
Order link was missing URL parameters.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 21:10:26 +0000 (23:10 +0200)]
Bug 6248: Acq: order from staged marc file broken
Corrects missing parameters in urls for
- single order from staged marc file
- bulk order from staged marc file
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 20:44:16 +0000 (22:44 +0200)]
Bug 6247: Acq: order already existing record broken
Another URL missing parameters.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 20:26:22 +0000 (22:26 +0200)]
Bug 6246: Modify/Delete links were missing from basket lines
Another TT problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 20:08:39 +0000 (22:08 +0200)]
Bug 6245: Can't order from z39.50 search in acq
Fixing missing url parameters in z39.50 search in acquisitions.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Thu, 21 Apr 2011 19:11:48 +0000 (15:11 -0400)]
Fix for Bug 6244, Javascript error on circulation home page
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 21 Apr 2011 19:32:34 +0000 (20:32 +0100)]
Bug 6240 : pass a hash to template not a scalar
As subscription info was passed as a scalar hashref
template could not access any of the data contained therein
esp Bib and Vendor ids
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 17:12:13 +0000 (13:12 -0400)]
Follow-up fix for Bug 6168, Can't delete holds from circulation page
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Wed, 20 Apr 2011 16:45:38 +0000 (12:45 -0400)]
Bug 6236 : When checking for expiry don't try to process 0 dates
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 21 Apr 2011 15:13:47 +0000 (16:13 +0100)]
Bug 6237: remove compile time warning
Remove a 'variable in void context' warning from
C4::Auth which shows up as a compile warning in all users of
the module and generates log noise
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 21 Apr 2011 15:13:46 +0000 (16:13 +0100)]
Bug 6237: Remove redeclarations of global vars in same scope
Scripts should be able to compile without warnings as a minimal test
a couple of variables are redeclared in the same scope generating
warnings. Remove the redeclations
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Wed, 20 Apr 2011 02:35:55 +0000 (04:35 +0200)]
Bug 6232: Impossible to link authorities to bibliographic records
Another fix for TT.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 14:31:02 +0000 (10:31 -0400)]
Bug 6231: some system preferences in XSLT broken
URL was accidently changed to url, breaking the case sensitive system preference
variables in XSLT.
- URLLinkText
- OPACurlOpenInNewWindow
- OPACBaseURL
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 17:41:34 +0000 (13:41 -0400)]
Fix for Bug 6238 - Checkboxes in staff's list view are missing
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Thu, 21 Apr 2011 18:36:11 +0000 (14:36 -0400)]
Bug 6234: Fixing missing biblionumber for links using biblio-default-view.inc
Fixes various pages where the biblionumber was missing in links to the detail page of a record.
Should also fix 6241.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I made the changes Owen suggested
- added the class="ratiolimit" back
- fixed additional link in waitingreserve.tt
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 19:11:40 +0000 (15:11 -0400)]
Fix for Bug 6239, Merging records broken
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 19:23:02 +0000 (15:23 -0400)]
Fix for bug 6243 - Link to fast cataloging missing from circulation home page
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Wed, 20 Apr 2011 00:18:09 +0000 (02:18 +0200)]
Bug 6230: Search to hold links on titles in result list were missing
Another TT fix.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Tue, 19 Apr 2011 23:48:39 +0000 (01:48 +0200)]
Bug 6229: Message preferences on patron details tab broken
TT scoping problems fixed.
Table now greyed out on the details tab and last column 'Don't notify'
shows correctly.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 21 Apr 2011 02:45:37 +0000 (14:45 +1200)]
Bug 6224 : Revert "3.0.x:
ce353e7 bug #3674 allow users creation with disabled password"
This reverts commit
87b792b2b61c8232c2facecf6feb2ce5f3fa2b9e.
Galen Charlton [Wed, 20 Apr 2011 22:37:08 +0000 (18:37 -0400)]
bug 6227: tweak release notes
NoZebra is deprecated
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 20 Apr 2011 22:37:07 +0000 (18:37 -0400)]
bug 6227: adjust description of NoZebra syspref
NoZebra mode is deprecated.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 20 Apr 2011 22:37:06 +0000 (18:37 -0400)]
bug 6227: remove search engine question from installer
NoZebra mode is deprecated.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Thu, 21 Apr 2011 01:36:58 +0000 (13:36 +1200)]
Updating updatedatabase.pl to try to stop duplicate upgrades being run
for people coming from 3.2.x
Chris Cormack [Thu, 21 Apr 2011 00:53:00 +0000 (12:53 +1200)]
Updating upgrade instructions
Chris Cormack [Wed, 20 Apr 2011 23:48:11 +0000 (11:48 +1200)]
Merge branch 'new/enh/bug_5579' into kcmaster
Conflicts:
C4/Biblio.pm
Chris Cormack [Wed, 20 Apr 2011 23:37:44 +0000 (11:37 +1200)]
Bug 6215 : Fixing a bug with virtuallists
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 20 Apr 2011 21:34:47 +0000 (17:34 -0400)]
bug 5579: tweaks to bulkmarcimport.pl
Fixes bug where a bib record imported by bulkmarcimport.pl
could become unindexable by ensuring that ModBiblioMarc()
is always called by bulkmarcimport.pl to finalize saving the
bib record (as it was initially created by AddBiblio with the
defer_marc_save option).
Also introduces a utility routine, C4::Biblio::_strip_item_fields.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 20 Apr 2011 21:34:46 +0000 (17:34 -0400)]
bug 5579: remove a now-unecessary vestigal variable
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Galen Charlton [Wed, 20 Apr 2011 21:34:45 +0000 (17:34 -0400)]
bug 5579: add line removed during patch review
Had effect of breaking item record changes when the
CatalogingLog system preference is on.
(Note to people reviewing patches - please do not modify the content
of patches that you are signing off on unless you are *sure* you
know *exactly* what you doing. The process of patch review should
not be introducing yet more bugs.)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 20 Apr 2011 21:39:38 +0000 (09:39 +1200)]
Bug 6212 : Fix for tags label showing with no tags
Owen Leonard [Wed, 20 Apr 2011 13:01:45 +0000 (09:01 -0400)]
Fix for Bug 6213, Koha News template error
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 14:09:59 +0000 (10:09 -0400)]
Fix for Bug 6216, Search results pagination links broken
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Owen Leonard [Wed, 20 Apr 2011 06:59:11 +0000 (02:59 -0400)]
Fix for Bug 6221, Modifying patron doesn't show "Patron Account Flags" group
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Wed, 20 Apr 2011 02:16:13 +0000 (22:16 -0400)]
Bug 6211: Set default correctly for SubscriptionHistory syspref
Was being set to an invalid value ';'
resulting in weird behaviour where it looked set but was not
in practice
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 20 Apr 2011 08:44:36 +0000 (20:44 +1200)]
Merge remote branch 'kc/new/enh/bug_5917' into kcmaster
Chris Cormack [Wed, 20 Apr 2011 08:42:05 +0000 (20:42 +1200)]
Bug 5917 : Testing fixing utf8 for preferences po file
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 20 Apr 2011 04:44:04 +0000 (16:44 +1200)]
Fixing bug in the french sys pref file, duplicate sys prefs plus l'OPAC not l\'OPAC
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Wed, 20 Apr 2011 04:19:44 +0000 (16:19 +1200)]
Merge remote branch 'kc/new/enh/bug_5897' into kcmaster