]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 7331 - Circulation.pl generates errors in the log
Duncan Tyler [Thu, 8 Dec 2011 01:11:43 +0000 (14:11 +1300)]
Bug 7331 - Circulation.pl generates errors in the log

Fixed error in C4::Dates causing unneeded warnings

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7330 - System preferences editor generates errors in the log with each search
Owen Leonard [Wed, 7 Dec 2011 15:50:06 +0000 (10:50 -0500)]
Bug 7330 - System preferences editor generates errors in the log with each search

Adding a check for an empty value in a couple of places
which seem to always get one.

As far as I can tell these places in the script are looping
over ALL the data in the pref files, and sometimes an empty
value comes through. I wonder if this is because of a minor
syntax error in the pref file?

My correction is a stab in the dark since I haven't determined
where the empty value is actually coming from. This change
quiets the errors in the log and doesn't seem to affect
preference search results.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
No more messages in the logs. Yay!

Ran unit tests on this (t, xt/author, xt, t/db_dependent)- nothing out of the ordinary in any.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7326: longoverdue.pl hardcoded to 366 days maximum
Ian Walls [Wed, 7 Dec 2011 00:12:04 +0000 (19:12 -0500)]
Bug 7326: longoverdue.pl hardcoded to 366 days maximum

Adds --maxdays command line flag to longoverdue.pl to allow the user to specify
their own $endrange value.  Because sometimes 366 isn't enough!

Also adds help documentation for both --quiet and --maxdays params

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Simple change, works well

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7325 - Editing a list generates errors in the log
Owen Leonard [Tue, 6 Dec 2011 21:03:31 +0000 (16:03 -0500)]
Bug 7325 - Editing a list generates errors in the log

Checking for variables before trying to use them in
building the pagination menu

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7323 - Javascript error when editing list
Owen Leonard [Tue, 6 Dec 2011 16:43:10 +0000 (11:43 -0500)]
Bug 7323 - Javascript error when editing list

Correcting check for empty shelf name to prevent
javascript error.

Also correcting unescaped ampersand.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7321: Silence some warns in Koha.pm
Katrin Fischer [Mon, 5 Dec 2011 20:52:44 +0000 (21:52 +0100)]
Bug 7321: Silence some warns in Koha.pm

While testing bug 7013 I noticed a lot of warns in the koha error log.
This patch is silencing them.

To test:
Add or edit an authorised value and check your log files before and after
applying the patch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7313: Untranslatable strings in 'Search to hold' feature
Katrin Fischer [Sat, 3 Dec 2011 08:55:44 +0000 (09:55 +0100)]
Bug 7313: Untranslatable strings in 'Search to hold' feature

Changed the javascript to include markup for translation _(...) in result
list and detail page tool bars.

Also changed the text shown for each result to match the text in the toolbar
to make things more consistent.

To test:
- Apply patch
- Run "perl translate update <your language code>"
- Open .po file for staff and check for "Place hold on" and "Forget"
- Translate those
- Run "perl translate install <your language code>"
- Activate "Search for hold" feature in patron account
- Do a search and check tool bar on top of result list
- Check link text shown in result list
- Check detail page

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Thu, 15 Dec 2011 15:17:44 +0000 (16:17 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agoRevert "Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm"
Paul Poulain [Thu, 15 Dec 2011 15:14:35 +0000 (16:14 +0100)]
Revert "Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm"

This reverts commit 06c822c37ce91e5936542990d7e3299e14271bd3.

12 years agoRevert "Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token"
Paul Poulain [Thu, 15 Dec 2011 15:13:43 +0000 (16:13 +0100)]
Revert "Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token"

This reverts commit 18bb9c22100ba810944a1341a891bc5b2e765255.

12 years agoRevert "Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token"
Paul Poulain [Thu, 15 Dec 2011 15:11:47 +0000 (16:11 +0100)]
Revert "Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token"

This reverts commit 18bb9c22100ba810944a1341a891bc5b2e765255.

12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Thu, 15 Dec 2011 12:53:39 +0000 (13:53 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agoBug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm
Duncan Tyler [Wed, 14 Dec 2011 03:42:30 +0000 (16:42 +1300)]
Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test requires a database installed using the sample data.
All tests pass.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdded missing reference case to Boolean.t and corrected count
Chris Hall [Wed, 7 Dec 2011 20:34:36 +0000 (09:34 +1300)]
Added missing reference case to Boolean.t and corrected count

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/master' into new/bug_5327
Paul Poulain [Thu, 15 Dec 2011 12:49:47 +0000 (13:49 +0100)]
Merge remote-tracking branch 'origin/master' into new/bug_5327

12 years agowelcome to Duncan Tyler, developer 166 !
Paul Poulain [Thu, 15 Dec 2011 12:45:21 +0000 (13:45 +0100)]
welcome to Duncan Tyler, developer 166 !

12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Thu, 15 Dec 2011 12:43:58 +0000 (13:43 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agoAdded missing reference case to Boolean.t and corrected count
Chris Hall [Wed, 7 Dec 2011 20:34:36 +0000 (09:34 +1300)]
Added missing reference case to Boolean.t and corrected count

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5327: Patch removes unneeded self=shift from TTParser::unshift_token
Chris Hall [Thu, 8 Dec 2011 22:04:19 +0000 (11:04 +1300)]
Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token

Removed  unneeded self=shift from unshift_token
(as peek and next do not take a self, makes interface more consistent)

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdded unit tests for Scrubber
Duncan Tyler [Thu, 8 Dec 2011 21:19:14 +0000 (10:19 +1300)]
Added unit tests for Scrubber

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdded unit test for AuthoritiesMarc/UNIMARC.pm
Duncan Tyler [Thu, 8 Dec 2011 19:52:34 +0000 (08:52 +1300)]
Added unit test for AuthoritiesMarc/UNIMARC.pm

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdded unit tests for Sip Checksum.pm
Duncan Tyler [Thu, 8 Dec 2011 01:38:28 +0000 (14:38 +1300)]
Added unit tests for Sip Checksum.pm

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago7185 Fixing typo in release notes
Marcel de Rooy [Thu, 17 Nov 2011 12:07:59 +0000 (13:07 +0100)]
7185 Fixing typo in release notes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial typo fix in text file.

12 years agoBug 7309 - Add NORMARCslim2intranetDetail.xsl for detail view in intranet
Magnus Enger [Fri, 2 Dec 2011 16:08:44 +0000 (16:08 +0000)]
Bug 7309 - Add NORMARCslim2intranetDetail.xsl for detail view in intranet

Adds two files, to enable XSLT for the detail view in the intranet:
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl

To test:
- Set sysprefs: marcflavour = NORMARC and XSLTDetailsDisplay = "using XSLT stylesheet"
- Make sure OPACBaseURL is set correctly
- Check that detail display looks ok
- Check that automatic links for author, subjects etc work
- Check that the "Open in new window" link works as expected
- Empty the OPACBaseURL syspref and check that "Open in new window" does not display

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Great test plan, could reproduce problem and can confirm patch fixes it.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7287 : Fix overdue notification if a branch given as parameter does not have...
Sophie Meynieux [Fri, 2 Dec 2011 09:04:25 +0000 (10:04 +0100)]
Bug 7287 : Fix overdue notification if a branch given as parameter does not have rules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7275 - Pagination lost when click in the option "Show more" of facets column
Juan Romay Sieira [Tue, 29 Nov 2011 09:17:26 +0000 (10:17 +0100)]
Bug 7275 - Pagination lost when click in the option "Show more" of facets column

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7270: Removing double itemtype on shelve contents page when no icon is shown
Marcel de Rooy [Wed, 30 Nov 2011 15:42:19 +0000 (16:42 +0100)]
Bug 7270: Removing double itemtype on shelve contents page when no icon is shown

Just adding a check on imageurl in the template.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7262 - No calendar present in holidays module when there are quotes in title...
Juan Romay Sieira [Thu, 24 Nov 2011 17:01:05 +0000 (18:01 +0100)]
Bug 7262 - No calendar present in holidays module when there are quotes in title or description

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Nice patch, making use of the Template::Toolkit filters

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7239 fix to avoid error being thrown even though a record is created
Chris Hall [Tue, 6 Dec 2011 03:03:59 +0000 (16:03 +1300)]
bug 7239 fix to avoid error being thrown even though a record is created

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
When creating an item in acquisitions while ordering and not filling out
any fields, there is no longer shown a perl error message.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7227, "Delete all items" action should redirect to the detail view
Owen Leonard [Tue, 15 Nov 2011 16:50:40 +0000 (11:50 -0500)]
Fix for Bug 7227, "Delete all items" action should redirect to the detail view

Using the delete all items function should now redirect back to the
biblio view specified in the BiblioDefaultView system preference.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7135'
Paul Poulain [Wed, 14 Dec 2011 14:54:34 +0000 (15:54 +0100)]
Merge remote-tracking branch 'origin/new/bug_7135'

12 years agoBug 7135 - in addbiblio, make save button floating to have it on always on screen
Owen Leonard [Tue, 13 Dec 2011 19:37:32 +0000 (14:37 -0500)]
Bug 7135 - in addbiblio, make save button floating to have it on always on screen

Follow-up fix corrects z-index of toolbar so that "More" menu
is not hidden behind it.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7202 - z39.50 search on bib edit not working
Owen Leonard [Fri, 2 Dec 2011 20:14:58 +0000 (15:14 -0500)]
Bug 7202 - z39.50 search on bib edit not working

The pop-up menu's "Import" link did not correctly pick
up the existing record's biblionumber, if present.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
1) Searched for a record in your catalog
2) Edit > Edit record
3) Start Z39.50 search
4) Pick a new record with different title for import
- using the import link at the end of the table line
- using the pop up menu's import link
5) Save and check if a duplicate was created

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7197 - add a Spanish readme file to the packages
Robin Sheat [Wed, 23 Nov 2011 05:39:25 +0000 (18:39 +1300)]
Bug 7197 - add a Spanish readme file to the packages

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
I don't speak spanish, so my signoff is just a technical view of the patch

12 years agoMerge branch 'master' into new/bug_7164
Paul Poulain [Wed, 14 Dec 2011 14:35:39 +0000 (15:35 +0100)]
Merge branch 'master' into new/bug_7164

12 years agoBug 7164 follow-up history.txt and perlcritic compliance
Paul Poulain [Wed, 14 Dec 2011 14:10:28 +0000 (15:10 +0100)]
Bug 7164 follow-up history.txt and perlcritic compliance

* in history.txt, added a tab for Stephane Delaune, for display consistency
* fixed a small mistake in about.pl that was resulted in a perlcritic failure

12 years agoBug 7164 minor follow-up
Paul Poulain [Wed, 14 Dec 2011 13:49:22 +0000 (14:49 +0100)]
Bug 7164 minor follow-up

tab for Stephane Delaune, for display consistency

12 years agoBug 7164 - add Koha history timeline tab to 'About' page
Mason James [Sat, 5 Nov 2011 10:28:48 +0000 (23:28 +1300)]
Bug 7164 - add Koha history timeline tab to 'About' page

Includes follow up by Chris Cormack fixing formatting in docs/history.txt

[MINOR EDIT] Added html filter to output for validity's sake

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 7160: paying fines throws error
Ian Walls [Sat, 5 Nov 2011 03:28:31 +0000 (23:28 -0400)]
Bug 7160: paying fines throws error

The call to ReturnLostItem in C4/Accounts was not properly namespaced to
come from C4::Circulation.  That prefix is added to the call.

To test:

Pay a fine, and confirm the error disappears (and the fines is still paid)

Signed-off-by: Brendan <brendan@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7143: Follow up patch for Updating about.tt
Brendan [Wed, 2 Nov 2011 10:04:58 +0000 (03:04 -0700)]
Bug 7143: Follow up patch for Updating about.tt

I had a typo where I put Ian Walls as Release Manager - I have fixed to QA.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I put in another missing space for Colin Campbell.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7143: Updating About.tt for Ian Walls, Chris Nighswonger and Paul Poulain
Brendan [Wed, 2 Nov 2011 09:59:41 +0000 (02:59 -0700)]
Bug 7143: Updating About.tt for Ian Walls, Chris Nighswonger and Paul Poulain

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 7139 : Log addition and deletion of circulation messages
Chris Cormack [Wed, 2 Nov 2011 01:43:45 +0000 (14:43 +1300)]
Bug 7139 : Log addition and deletion of circulation messages

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Changed the two action names into caps no-spaces.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7135: Save button options
Owen Leonard [Thu, 3 Nov 2011 18:54:39 +0000 (14:54 -0400)]
Fix for Bug 7135: Save button options

This patch adds a jQuery plugin which will cause
an element to remain "fixed" at the top of the
screen if it would otherwise scroll up out of
view.

The license of this plugin is "This plugin is as free as fresh
air. Feel free to use it anywhere.".

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
I tested this on Chrome OSX
saving works
changing framework works
scrolling works, obviously.
tabbing through the records works
z39 button works as expected

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
updated patch comment about licensing of the plugin

12 years agoFix for Bug 7123 - barcode should be one word
Owen Leonard [Tue, 1 Nov 2011 13:21:51 +0000 (09:21 -0400)]
Fix for Bug 7123 - barcode should be one word

Other fixes thrown in for good measure:

- Adding data to the results table to match output of returns
- Better checking of error codes in the script to control
  output of error messages (don't show error box when there
  are no errors).
- Move some errors/messages from the right column onto the
  top of the page to match Koha's established pattern.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7121 - remove comma on items info
Owen Leonard [Fri, 11 Nov 2011 16:43:27 +0000 (11:43 -0500)]
Fix for Bug 7121 - remove comma on items info

Because I can't just take out one comma, I reworked
the way moredetail.pl fetches and outputs biblio
data based on the way it does in detail.pl. This
allows for simpler output in the template.  In the
process I've added subtitle information to the
template.

Revision adds line break for readability

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7093: placeholds for suggestion table not working in notices
Ian Walls [Wed, 7 Dec 2011 16:43:20 +0000 (11:43 -0500)]
Bug 7093: placeholds for suggestion table not working in notices

In parseletter_sth, the suggestions table was defined twice.  The first time (which
is the only definition to get called, as it matches first then exists), defined the
primary search keys as borrowernumber and biblionumber.  This is incorrect; the only
usage of the suggestions table tokens is with suggestionid as the key.  This is defined
further down the if/then chain.

This patch removes the erroneous sth query definition.

To test:

1.  Place a suggestion with a patron account with a configured email you can access
2.  Approve or reject it
3.  Verify the message you receive contains suggestion tokens (like title, author and reason)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Suggestion mails for accepted, rejected and ordered look good now.
I couldn't test the suggestion mail AVAILABLE (bug 7096), but
assuming this would work too.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6935: Correct XISBNDailyLimit for new installations
Katrin Fischer [Wed, 30 Nov 2011 07:04:27 +0000 (08:04 +0100)]
Bug 6935: Correct XISBNDailyLimit for new installations

This corrects the value of XISBNDailyLimit in the system preferences
installation file to 999 instead of 499.

The file was missed in an earlier update, so new installations
have different values than older installations that were updated.

Another patch with a database update is needed. Sending this patch first,
until it's clear how database updates will work for 3.8.

To test:
1) Recreate your database from scratch
2) Check your system preference XISBNDailyLimit shows 999 instead of 499,
matching the description of the system preference.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6865'
Paul Poulain [Tue, 13 Dec 2011 15:23:38 +0000 (16:23 +0100)]
Merge remote-tracking branch 'origin/new/bug_6865'

12 years agobug 6917 Dates filters doesn't work when they are not selected on row or column
Alex Arnaud [Mon, 26 Sep 2011 10:21:58 +0000 (12:21 +0200)]
bug 6917 Dates filters doesn't work when they are not selected on row or column

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6865 - Replace image-based gradient backgrounds with CSS3 gradients
Owen Leonard [Tue, 13 Sep 2011 12:16:13 +0000 (08:16 -0400)]
Bug 6865 - Replace image-based gradient backgrounds with CSS3 gradients

Replaces image-based gradients in:

OPAC search bar
OPAC submit buttons
OPAC lists menu background
OPAC alert and message boxes
OPAC user menu tabs
Staff client alert and message boxes
Staff client side menu tabs

Removes obsoleted background image files.

Cross-browser background-gradients created using:
http://www.colorzilla.com/gradient-editor/

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6803: Replacing remote XSL include
Marcel de Rooy [Wed, 12 Oct 2011 12:00:54 +0000 (14:00 +0200)]
Bug 6803: Replacing remote XSL include

Replacing remote include by local one.
This resolves possible connectivity issues (see Bugzilla comments).
Should theoretically be safer and faster too.

December 7, 2011: Rebased and included nbsp entity definition (bug 7141).

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6716 Update biblio & deletedbiblio tables
Nicole C. Engard [Thu, 20 Oct 2011 10:47:54 +0000 (06:47 -0400)]
Bug 6716 Update biblio & deletedbiblio tables

The comments on the biblio and deletedbiblio table
didn't mention the MARC21 subfields. This patch adds
that documentation in.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 6716 : Categories table
Nicole C. Engard [Mon, 10 Oct 2011 10:50:23 +0000 (06:50 -0400)]
Bug 6716 : Categories table

This patch documents the patron categories table in Koha.
There are a couple fields marked unused and a couple that aren't
documented because I wasn't sure:

* dateofbirthrequired
* bulk

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 6716: Document biblioitems and deletedbiblioitems
Nicole C. Engard [Sun, 2 Oct 2011 14:04:37 +0000 (10:04 -0400)]
Bug 6716: Document biblioitems and deletedbiblioitems

This patch documents the biblioitems and the deletedbiblioitems
tables.  There are many fields left undocumented because I didn't see
information in them, but this is enough of a start to be helpful to
those writing reports.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 6716 Document deleteditems table
Nicole C. Engard [Sun, 2 Oct 2011 06:16:44 +0000 (02:16 -0400)]
Bug 6716 Document deleteditems table

This patch documents the deleted items table. Some fields were left
undocumented because I was unsure of what data was stored there:

stack - might be linked to shelving number, but need confirmation
paidfor - pretty sure this is unused, but don't want to document it that way

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 6716 - Document Items Table
Nicole C. Engard [Sun, 2 Oct 2011 06:11:06 +0000 (02:11 -0400)]
Bug 6716 - Document Items Table

This patch documents the items table. Some fields were left
undocumented because I was unsure of what data was stored there:

stack - might be linked to shelving number, but need confirmation
paidfor - pretty sure this is unused, but don't want to document it that way

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agobug6716: documenting reserves and old_reserves tables
Nicole C. Engard [Wed, 28 Sep 2011 10:19:33 +0000 (06:19 -0400)]
bug6716: documenting reserves and old_reserves tables

This patch documents the reserves and the old_reserves table.
Note that a few fields are marked unused: notificationdate and
reminderdate. Also two fields are left undocumented: lowestPriority
which never seems to be anything other than 0 and constrainttype which
is either 'a' or 0, but there doesn't appear to be any explanation
as to what each stands for.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 6663: Features for holidays.pl with datepicker
Christophe Croullebois [Fri, 2 Dec 2011 15:03:19 +0000 (16:03 +0100)]
Bug 6663: Features for holidays.pl with datepicker

Allow to select a range between 2 dates and in one "submit" creates holidays only on these days.
I have added also Holidays repeated yearly on a range.
On suggestions I have added a datepicker for "To Date".

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agowelcome Fabio, you're 165th !
Paul Poulain [Tue, 13 Dec 2011 13:43:41 +0000 (14:43 +0100)]
welcome Fabio, you're 165th !

12 years agoBug 7245 Tables population with mandatory data for italian installation
Frédéric Demians [Sun, 20 Nov 2011 12:13:28 +0000 (13:13 +0100)]
Bug 7245 Tables population with mandatory data for italian installation

Formatted patch from Fabio Tiana <fabio.tian@gmail.com>

While installing italian and UNIMARC version of Koha via web installer, two
errors occur: ERROR 1136 (21S01) and ERROR 1064 (42000). Some tables can't be
populated with mandatory data.

Errors are related to files sample_itemtypes.sql and unimarc_framework.sql
(/usr/share/koha/intranet/cgi-bin/installer/data/mysql/it-IT/ and
subdirectories).

Signed-off-by: koha <koha@kohabase.l.i>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7215'
Paul Poulain [Tue, 13 Dec 2011 13:29:04 +0000 (14:29 +0100)]
Merge remote-tracking branch 'origin/new/bug_7215'

12 years agoBug 7215 : The Module changed, but the tests weren't updated to reflect that
Chris Cormack [Tue, 13 Dec 2011 08:18:37 +0000 (21:18 +1300)]
Bug 7215 : The Module changed, but the tests weren't updated to reflect that

Updating the test

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7082: Template improvements for better translatability
Katrin Fischer [Mon, 24 Oct 2011 14:09:35 +0000 (16:09 +0200)]
Bug 7082: Template improvements for better translatability

Problem:
/cgi-bin/koha/admin/aqbudgets.pl
<label for="show_mine">Show my<br /> funds only</label>

This gets broken into 2 strings for translation which makes it very hard for
translators to make sense of it.
Patch removes the line break.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
This patch removes the linebreak and has no ill effects that I can see, even
on a small screen. I'll attach before and after screenshots in Bugzilla.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7336 - memberentry.pl generates an error in the log
Owen Leonard [Thu, 8 Dec 2011 16:10:20 +0000 (11:10 -0500)]
Bug 7336 - memberentry.pl generates an error in the log

Adding check for the existence of a variable in
order to quiet errors in the log.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7215 - changed callnumber PRESET field to itemcallnumber
Brendan [Fri, 11 Nov 2011 17:25:15 +0000 (09:25 -0800)]
Bug 7215 - changed callnumber PRESET field to itemcallnumber

Fixes problem with creating new labels - before it populated with callnumber and not itemcallnumber

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7198: show patron name in overdue list even if name column is null
Galen Charlton [Wed, 9 Nov 2011 01:44:25 +0000 (20:44 -0500)]
bug 7198: show patron name in overdue list even if name column is null

If the surname or firstname of a patron is NULL, the MySQL concat()
function (properly) returns NULL, leading to the patron name not
displaying in the overdue report.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7159 - Add branchcode to circulation.pl search (take two, revising with Owen...
Liz Rea [Fri, 4 Nov 2011 19:37:11 +0000 (14:37 -0500)]
Bug 7159 - Add branchcode to circulation.pl search (take two, revising with Owen's suggestion)

I know there's talk of getting rid of this patron search method, but I had a
request for this and so here it is.

To test:
verify that branchcode is displayed on patron search results from
circulation.pl.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7124 - back to search wrapping in lower resolutions
Owen Leonard [Fri, 11 Nov 2011 14:00:27 +0000 (09:00 -0500)]
Fix for Bug 7124 - back to search wrapping in lower resolutions

Maybe not a complete fix, but hopefully an improvement. I couldn't
prevent it from wrapping at smaller browser widths, but I was
able to change the style so that when it does wrap it's a little
more readable.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7316 - Missing escaping in search results
Frère Sébastien Marie [Sun, 4 Dec 2011 17:14:09 +0000 (18:14 +0100)]
Bug 7316 - Missing escaping in search results

Two parameters are now escaped in title (html element):
 - query_desc
 - limit_desc

This is a security correction against XSS.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6679'
Paul Poulain [Fri, 9 Dec 2011 08:51:40 +0000 (09:51 +0100)]
Merge remote-tracking branch 'origin/new/bug_6679'

12 years agoBug 6679: fix missing use strict
Paul Poulain [Thu, 8 Dec 2011 16:13:38 +0000 (17:13 +0100)]
Bug 6679: fix missing use strict

The 3 files had use strict missing. The patch add the use strict and modify what's needed to work with it
4XX.pl also has some perlcritic fixes:
Variable declared in conditional statement at line XXX, column 9.  Declare variables outside of the condition.  (Severity: 5)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoupdatedatabase: Adding missing \n at the end of 2 print
Paul Poulain [Fri, 9 Dec 2011 08:39:38 +0000 (09:39 +0100)]
updatedatabase: Adding missing \n at the end of 2 print

They were missing on bug 6530 and 6328

12 years agoBug 7028 - updated the koha-conf.xml template
Robin Sheat [Mon, 17 Oct 2011 04:51:39 +0000 (17:51 +1300)]
Bug 7028 - updated the koha-conf.xml template

Now it more closely matches the one that's distributed in /etc

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(not tested. I confirm the code is clean, and tests are not broken)

12 years agoFix for Bug 6818 - acquisitions basket groups could use some design work
Owen Leonard [Wed, 26 Oct 2011 14:50:11 +0000 (10:50 -0400)]
Fix for Bug 6818 - acquisitions basket groups could use some design work

I've made changes to the basket grouping interface to bring it
in line with other interfaces in Koha. I think it's better to
keep things following a consistent pattern.

On the page which lists basket groups:

- Basket groups listed in a table instead of as custom-styled lists
- Buttons use standard style
- Tabs are generated by jQuery

On the page for managing baskets in a group:

- Markup has been revised to be more consistent with established
  patterns.
- Corrections have been made for validity

On the basket view page:

- Display of data has been streamlined a little bit
- An option has been added to the "Basket group" dropdown
  for adding a new group
- Markup has been corrected for validity and consistency

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Basket group page
The blue is gone and the new buttons  are much better
readable than before.

2) Basket grouping page
Works.

3) Basket view page
I like the new option to create a new group from here.
Nice improvement to the workflow!
I removed a spare 'td' from line 264.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7259 - Show a count of items pending approval on staff client home and tools...
Owen Leonard [Wed, 7 Dec 2011 15:02:56 +0000 (10:02 -0500)]
Bug 7259 - Show a count of items pending approval on staff client home and tools pages

- Correcting permissions checks on the home page
- Adding default parameter (1)  to numberofreviews subroutine

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7259 - Show a count of items pending approval on staff client home and tools...
Owen Leonard [Wed, 23 Nov 2011 19:25:20 +0000 (14:25 -0500)]
Bug 7259 - Show a count of items pending approval on staff client home and tools pages

This patch adds count indicators on the staff client home page and
the tools page for the number of items pending approval. On the
home page this includes suggestions, comments, and tags. On the tools
page a count of pending comments and tags is shown.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Counts appear for all types of actionable items listed, all are clickable through to the proper place.

Nice work!

12 years agoBug 7116: White space on item form for bulk ordering from staged file
Katrin Fischer [Sun, 30 Oct 2011 23:21:27 +0000 (00:21 +0100)]
Bug 7116: White space on item form for bulk ordering from staged file

Same fix that was done for normal order page and receive page.
Moving the style element for hiding the subfield into the li tag.

AcqCreateItem = on order

To recreate:
1) stage a marc file with 1 - many records
2) make sure you have an acq framework with hidden fields in 952
3) create new basket
4) order from your marc file
5) check item form below the record list for white space

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Followed the steps outlined by Katrin above. Before the patch there are gaping
holes left by the hidden fields. After the patch the holes are gone.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoWelcome to jon Aker (#164) + missing tabs & "releases"
Paul Poulain [Thu, 8 Dec 2011 10:26:02 +0000 (11:26 +0100)]
Welcome to jon Aker (#164) + missing tabs & "releases"

12 years agoBug 7020 Items with no checkouts report does not output call number, barcode or item...
Jon Aker [Tue, 6 Dec 2011 23:06:41 +0000 (12:06 +1300)]
Bug 7020 Items with no checkouts report does not output call number, barcode or item details

When running the Items with no checkouts report and outputting to
screen, the results do not include any identifying information for
the items. The only information listed is the item count and the
branch location.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6987 Make return from Overdues::GetFine consistent
Colin Campbell [Fri, 7 Oct 2011 12:19:06 +0000 (13:19 +0100)]
Bug 6987 Make return from Overdues::GetFine consistent

If there is not a fine amount return zero not
undefined or other undefined behaviour

Use more meaningful var names for readability

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7141'
Paul Poulain [Thu, 8 Dec 2011 10:05:35 +0000 (11:05 +0100)]
Merge remote-tracking branch 'origin/new/bug_7141'

12 years agoBug 7141 : Changing test to match new formatting of xsl style sheet
Chris Cormack [Wed, 7 Dec 2011 20:28:12 +0000 (09:28 +1300)]
Bug 7141 : Changing test to match new formatting of xsl style sheet

http://bugs.koha-community.org/show_bug.cgi?id=7141
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
verified tests pass

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 : Allowing eval require
Chris Cormack [Thu, 8 Dec 2011 08:09:48 +0000 (21:09 +1300)]
Bug 6679 : Allowing eval require

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 : Adding license statement and stopping declaring variables in a conditional
Chris Cormack [Wed, 2 Nov 2011 02:55:00 +0000 (15:55 +1300)]
Bug 6679 : Adding license statement and stopping declaring variables in a conditional

12 years agoBug 6679 : cataloguing/ now passing critic tests
Chris Cormack [Mon, 31 Oct 2011 08:16:29 +0000 (21:16 +1300)]
Bug 6679 : cataloguing/ now passing critic tests

Declare variables outside of conditionals
Don't use prototypes http://www.modernperlbooks.com/mt/2009/08/the-problem-with-prototypes.html
Use ":encoding(UTF-8)" to get strict validation.

12 years agoMerge remote-tracking branch 'origin/master' into new/bug_6679
Paul Poulain [Thu, 8 Dec 2011 09:08:44 +0000 (10:08 +0100)]
Merge remote-tracking branch 'origin/master' into new/bug_6679

Conflicts:
catalogue/showmarc.pl

12 years agoBug 6679: catalogue/ now passing perl critic tests
Chris Cormack [Mon, 31 Oct 2011 08:02:13 +0000 (21:02 +1300)]
Bug 6679: catalogue/ now passing perl critic tests

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5604'
Paul Poulain [Wed, 7 Dec 2011 17:07:40 +0000 (18:07 +0100)]
Merge remote-tracking branch 'origin/new/bug_5604'

12 years agoBug 5604 : Follow up for missing image
Chris Cormack [Tue, 6 Dec 2011 21:17:12 +0000 (10:17 +1300)]
Bug 5604 : Follow up for missing image

When doing icons, there is a test for them please run

perl xt/author/icondirectories.t

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
see jenkins complaining: http://jenkins.koha-community.org/job/Koha_master/lastUnstableBuild/#showFailuresLink

12 years agoJenkins complaining = fixing number of tests
Paul Poulain [Wed, 7 Dec 2011 17:04:10 +0000 (18:04 +0100)]
Jenkins complaining = fixing number of tests

(see jenkins build http://jenkins.koha-community.org/job/Koha_master/557/#showFailuresLink)

12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Wed, 7 Dec 2011 15:38:39 +0000 (16:38 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agot/UploadedFile, updated comment
Paul Poulain [Wed, 7 Dec 2011 15:37:31 +0000 (16:37 +0100)]
t/UploadedFile, updated comment

12 years agoBug 5327: Fixing the Members.t test
Chris Cormack [Tue, 6 Dec 2011 21:09:43 +0000 (10:09 +1300)]
Bug 5327: Fixing the Members.t test

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Confirm Members.t tests complete

12 years agoBug 5327 : Fixing unit test for SQLHelper.pm
Chris Cormack [Tue, 6 Dec 2011 20:17:35 +0000 (09:17 +1300)]
Bug 5327 : Fixing unit test for SQLHelper.pm

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Confirm that all SQLHelper tests pass.

12 years agoBug 5327 : Complete coverage for BackgroundJob.pm
Chris Cormack [Sun, 4 Dec 2011 07:02:45 +0000 (20:02 +1300)]
Bug 5327 : Complete coverage for BackgroundJob.pm

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tests run without problems.

12 years agoBug 5327 : Adding more unit tests
Chris Cormack [Sun, 6 Nov 2011 06:59:34 +0000 (19:59 +1300)]
Bug 5327 : Adding more unit tests

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
New tests run without problems.

12 years agoBug 5327: Unit tests for C4/Exteral/BakerTaylor.pm
Chris Hall [Mon, 21 Nov 2011 23:19:55 +0000 (12:19 +1300)]
Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agofix test xml records
Maxime Pelletier [Tue, 20 Sep 2011 22:01:23 +0000 (18:01 -0400)]
fix test xml records

http://bugs.koha-community.org/show_bug.cgi?id=5327

12 years agoMerge remote-tracking branch 'origin/new/bug_6291'
Paul Poulain [Wed, 7 Dec 2011 15:03:16 +0000 (16:03 +0100)]
Merge remote-tracking branch 'origin/new/bug_6291'

12 years agoBug 6291 - Cart printing truncated in Firefox
Owen Leonard [Tue, 6 Dec 2011 17:50:57 +0000 (12:50 -0500)]
Bug 6291 - Cart printing truncated in Firefox

Alternate fix suggested by http://www.sidesofmarch.com/index.php/archive/2007/04/25/firefox-truncates-long-tables-when-printing/

Seems absurd that changing the top heading from an <h1> to an <h2>
would fix the problem, but it does in my tests in Firefox 3.6 and 8
on Windows 7