Alex Arnaud [Tue, 30 Mar 2010 08:01:56 +0000 (10:01 +0200)]
(BUG #4348) parcel.pl: list with duplicates orders after a clearfilter
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Mon, 29 Mar 2010 09:26:23 +0000 (11:26 +0200)]
(BUG #4345) Redirect after closing a basket and creation of a group
after closing a basket and creation of a group we should landed on the "Closed" tab.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Mon, 29 Mar 2010 08:15:31 +0000 (10:15 +0200)]
(BUG #4344) Basket.pl - remove the line "contract number"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Fri, 26 Mar 2010 15:51:07 +0000 (16:51 +0100)]
(BUG #4342) should not be able to close an empty basket
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Tue, 23 Mar 2010 10:38:34 +0000 (11:38 +0100)]
(BUG #4332) Changed the display of ordered search results
Changing the display of the basket column: changing "basketNumber" to "my
basket (basketNumber)".
Adding the Basket group column with fallowing display: "my group (group
Number)"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 25 Apr 2010 19:44:34 +0000 (07:44 +1200)]
New Developer to history
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Srdjan Jankovic [Sun, 25 Apr 2010 19:44:32 +0000 (07:44 +1200)]
catalyst-wr68480: better handling of holds re IndependantBranches
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Srdjan Jankovic [Thu, 25 Feb 2010 21:02:28 +0000 (10:02 +1300)]
catalyst-wr68479: Limit holds to the user branch, provide a link to
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 24 Apr 2010 02:25:10 +0000 (22:25 -0400)]
Bug 4307: Sorts library locations in inventory drop-down list.
Replacement patch for previous patch submitted.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 27 Apr 2010 18:13:04 +0000 (14:13 -0400)]
Fix to enable Amazon cover images in the staff client.
Since this fix enables the previously-missing variable
'AmazonEnabled' in Auth.pm, this will also enable other
Amazon content in the staff client like Product
Descriptions and Amazon Similar Items (See Bug 3863)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 28 Apr 2010 08:15:47 +0000 (04:15 -0400)]
fix minor typo in preference description
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 28 Apr 2010 08:15:12 +0000 (04:15 -0400)]
bug 4410 - change member to patron to be consistent
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 28 Apr 2010 08:14:32 +0000 (04:14 -0400)]
bug 4412 move staff xslt prefs to staff client tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 28 Apr 2010 08:10:50 +0000 (04:10 -0400)]
bug 4425: reorder search options on staff advanced search
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 29 Apr 2010 15:45:19 +0000 (11:45 -0400)]
Fix for Bug 4424, MARC Framework deletion incorrectly reports usage count
Thanks to Thomas Dukleth for the fix.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Wolfgang Heymans [Thu, 4 Mar 2010 14:07:51 +0000 (15:07 +0100)]
highlighting bug (causes rtl text to move when clicking 'Unhighlight')
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 23 Apr 2010 11:13:24 +0000 (07:13 -0400)]
Merge branch 'bug2505_patches' of git://git.catalyst.net.nz/koha into to-push
* 'bug2505_patches' of git://git.catalyst.net.nz/koha: (24 commits)
Bug 2505 - use strict and warnings in sax_parser_test
Bug 2505 - enable warnings for link_bibs_to_authorities
Bug 2505 - add strict and warnings to perlmodule_ls
Bug 2505 - add strict and warnings to check_sysprefs
Bug 2505 - Add commented use warnings where missing in *.t
Bug 2505 - Add commented use warnings where missing in *.pm
Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory
Bug 2505 - Add commented use warnings where missing in the misc/ directory
Bug 2505 - Add commented use warnings where missing in the tools/ directory
Bug 2505 - Add commented use warnings where missing in the installer/ directory
Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory
Bug 2505 - Add commented use warnings where missing in the C4/ directory
Bug 2505 - Add commented use warnings where missing in the serials/ directory
Bug 2505 - Add commented use warnings where missing in the catalogue/ directory
Bug 2505 - Add commented use warnings where missing in the sms/ directory
Bug 2505 - Add commented use warnings where missing in the opac/ directory
Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory
Bug 2505 - Add commented use warnings where missing in the suggestion/ directory
Bug 2505 - Add commented use warnings where missing in the admin/ directory
Bug 2505 - Add commented use warnings where missing in the circ/ directory
...
Conflicts:
C4/Auth_with_cas.pm
acqui/supplier.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 13 Apr 2010 19:48:32 +0000 (15:48 -0400)]
Fix for Bug 4302, shouldn't have to scroll left to right on z search results
Adds inline pop-up menu for each row of Z39.50 search results, similar to the
one recently added to the additem screen. This allows the user to click
anywhere in the row to display the menu and access the preview/import links.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 26 Mar 2010 10:25:36 +0000 (11:25 +0100)]
removing warn logs
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Tue, 16 Mar 2010 08:11:54 +0000 (09:11 +0100)]
Followup : d31ac1 reintroducing submit buttons
this reintroduces translation of submit values
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 26 Mar 2010 10:25:32 +0000 (11:25 +0100)]
unconditional warning changed to if $DEBUG
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 26 Mar 2010 10:25:34 +0000 (11:25 +0100)]
follow-up : remove perl error if the librarian choose no budget
the librarian can enter the suggestion without selecting any budget.
Searching the budget name in this case resulted in a Perl error
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 26 Mar 2010 10:25:31 +0000 (11:25 +0100)]
MT3168 : Suggestion budget management
budget were not saved and not correctly displayed
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Fri, 26 Mar 2010 10:25:35 +0000 (11:25 +0100)]
(MT3174) acqui/neworderempty.pl: incrementing the quantity when adding an item
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Paul Poulain [Fri, 26 Mar 2010 10:25:37 +0000 (11:25 +0100)]
budget limit not working
on a new order, the branch limits for the budgets where not managed properly
if a budget had a limit on branch, it was not respected : the list displayed all budgets, including other branches than mine
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 7 Apr 2010 13:01:19 +0000 (15:01 +0200)]
MT3186: Remove warnings from Auth_with_cas
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 22 Apr 2010 19:22:53 +0000 (15:22 -0400)]
A fix for Bug 4208, Many submit buttons are not translatable in 3.2
Not a fix for a submit button problem, but for a problem with
TMPL_IFs nested inside tags, a practice which will break the
translation script.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Wed, 14 Apr 2010 11:32:34 +0000 (13:32 +0200)]
(BUG #4388) aqbudgets.pl: add a column in the table for display the total spent of level and sublevels
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 1 Apr 2010 11:53:55 +0000 (13:53 +0200)]
(BUG #4360) aqbudgets.pl: Adding the hierarchy of budgets in the tooltip
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 22 Apr 2010 21:30:34 +0000 (23:30 +0200)]
Bug 4399 Untranslated link 'Export selected items data' in claims.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 22 Apr 2010 07:53:44 +0000 (03:53 -0400)]
bug 4391 fix a series of minor text styles and
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 18 Apr 2010 19:30:30 +0000 (07:30 +1200)]
Adding new committer to the history
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sun, 18 Apr 2010 09:53:33 +0000 (11:53 +0200)]
Fix a warning in log
Using a hash as a reference is deprecated
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Robin Sheat [Mon, 19 Apr 2010 22:17:32 +0000 (10:17 +1200)]
wr69607 - fixed conditions for display of tax details
Previously, if the tax rate for a particular seller was '0.000' it
couldn't be edited. Now, the tax information always is shown if there
is a default system one, or one for that seller.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Wed, 21 Apr 2010 23:36:36 +0000 (11:36 +1200)]
wr69959 Pagination on neworderbiblio was missing baskteno, caused a server error when trying to add an order on any page other than page one
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Cindy Murdock Ames [Mon, 19 Apr 2010 18:44:42 +0000 (14:44 -0400)]
Fix ampersand problem in non-XSLT Intranet search results
Quick fix for ampersand display issue in non-xslt intranet search results,
related to bug 3326.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Mon, 19 Apr 2010 20:29:12 +0000 (16:29 -0400)]
update news links to point to official koha site
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Mon, 19 Apr 2010 22:51:25 +0000 (10:51 +1200)]
When purging, remove /var/log/koha.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Mon, 19 Apr 2010 04:58:44 +0000 (16:58 +1200)]
Remove generated /etc/koha/koha-conf.xml when package is purged.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Mon, 19 Apr 2010 04:58:42 +0000 (16:58 +1200)]
Remove now-unnecessary debian-specific patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Mon, 19 Apr 2010 12:29:56 +0000 (08:29 -0400)]
bug 4391 - fix minor typos
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Donovan Jones [Mon, 19 Apr 2010 04:17:10 +0000 (16:17 +1200)]
Bug 2505 - use strict and warnings in sax_parser_test
Donovan Jones [Mon, 19 Apr 2010 03:21:35 +0000 (15:21 +1200)]
Bug 2505 - enable warnings for link_bibs_to_authorities
Donovan Jones [Mon, 19 Apr 2010 03:17:27 +0000 (15:17 +1200)]
Bug 2505 - add strict and warnings to perlmodule_ls
Donovan Jones [Mon, 19 Apr 2010 03:13:10 +0000 (15:13 +1200)]
Bug 2505 - add strict and warnings to check_sysprefs
Donovan Jones [Mon, 19 Apr 2010 00:02:46 +0000 (12:02 +1200)]
Bug 2505 - Add commented use warnings where missing in *.t
Donovan Jones [Sun, 18 Apr 2010 23:52:29 +0000 (11:52 +1200)]
Bug 2505 - Add commented use warnings where missing in *.pm
Donovan Jones [Sun, 18 Apr 2010 23:00:19 +0000 (11:00 +1200)]
Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory
Donovan Jones [Fri, 16 Apr 2010 04:18:23 +0000 (16:18 +1200)]
Bug 2505 - Add commented use warnings where missing in the misc/ directory
Donovan Jones [Fri, 16 Apr 2010 03:54:32 +0000 (15:54 +1200)]
Bug 2505 - Add commented use warnings where missing in the tools/ directory
Donovan Jones [Fri, 16 Apr 2010 03:47:30 +0000 (15:47 +1200)]
Bug 2505 - Add commented use warnings where missing in the installer/ directory
Donovan Jones [Fri, 16 Apr 2010 03:44:39 +0000 (15:44 +1200)]
Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory
Donovan Jones [Fri, 16 Apr 2010 03:42:23 +0000 (15:42 +1200)]
Bug 2505 - Add commented use warnings where missing in the C4/ directory
Donovan Jones [Fri, 16 Apr 2010 03:40:32 +0000 (15:40 +1200)]
Bug 2505 - Add commented use warnings where missing in the serials/ directory
Donovan Jones [Fri, 16 Apr 2010 03:39:44 +0000 (15:39 +1200)]
Bug 2505 - Add commented use warnings where missing in the catalogue/ directory
Donovan Jones [Fri, 16 Apr 2010 03:27:11 +0000 (15:27 +1200)]
Bug 2505 - Add commented use warnings where missing in the sms/ directory
Donovan Jones [Fri, 16 Apr 2010 03:25:50 +0000 (15:25 +1200)]
Bug 2505 - Add commented use warnings where missing in the opac/ directory
Donovan Jones [Fri, 16 Apr 2010 03:14:43 +0000 (15:14 +1200)]
Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory
Donovan Jones [Fri, 16 Apr 2010 03:13:29 +0000 (15:13 +1200)]
Bug 2505 - Add commented use warnings where missing in the suggestion/ directory
Donovan Jones [Fri, 16 Apr 2010 03:00:19 +0000 (15:00 +1200)]
Bug 2505 - Add commented use warnings where missing in the admin/ directory
Donovan Jones [Fri, 16 Apr 2010 02:52:03 +0000 (14:52 +1200)]
Bug 2505 - Add commented use warnings where missing in the circ/ directory
Donovan Jones [Fri, 16 Apr 2010 02:47:08 +0000 (14:47 +1200)]
Bug 2505 - Add commented use warnings where missing in the reports/ directory
Donovan Jones [Fri, 16 Apr 2010 02:40:27 +0000 (14:40 +1200)]
Bug 2505 - Add commented use warnings where missing in the members/ directory
Donovan Jones [Fri, 16 Apr 2010 02:32:36 +0000 (14:32 +1200)]
Bug 2505 - Add commented use warnings where missing in the acqui/ directory
Donovan Jones [Fri, 16 Apr 2010 01:51:41 +0000 (13:51 +1200)]
Bug 2505 - Add commented use warnings where missing in the errors/ directory
Kyle M Hall [Thu, 1 Apr 2010 15:45:25 +0000 (15:45 +0000)]
Replace branch codes in on returns screen with branch names.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Fri, 26 Mar 2010 19:58:48 +0000 (08:58 +1300)]
Bug 3293, changes to the xslt files to fix the wrong type/icon showing for music scores. Courtesy of Bernardo Gonzalez Kriegel
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Tue, 16 Mar 2010 15:13:40 +0000 (16:13 +0100)]
(bug #4318) remove the confirmation step in validating a form
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Wed, 24 Mar 2010 11:04:39 +0000 (12:04 +0100)]
(bug #4339) fix catalog stats
This fix the catalog stats to count items that have no barcode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
amit gupta [Fri, 16 Apr 2010 07:48:31 +0000 (13:18 +0530)]
Allow zebra search for Accelerated Reading Point in field 526$d
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
amit gupta [Fri, 16 Apr 2010 07:53:01 +0000 (13:23 +0530)]
Allow zebra search for Accelerated Reading Level in field 526$c
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Fri, 9 Apr 2010 16:47:26 +0000 (18:47 +0200)]
Allow UNIMARC item callnumber splitting
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Fri, 9 Apr 2010 16:14:04 +0000 (18:14 +0200)]
Bug 4382 Export batch label to CSV
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Wed, 7 Apr 2010 20:52:22 +0000 (08:52 +1200)]
History updated - 4 New developers !
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 13 Apr 2010 05:46:29 +0000 (17:46 +1200)]
Change #! line for cronjob to refer to sh using canonical path.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Wed, 7 Apr 2010 13:01:18 +0000 (15:01 +0200)]
MT3160 : Fix plugin callback when subfields are cloned
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Fri, 16 Apr 2010 03:35:50 +0000 (15:35 +1200)]
Replace old, non-functional Debian packaging with a new one.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Fri, 16 Apr 2010 03:34:11 +0000 (15:34 +1200)]
Fix file permissions: if it is not a script, it should not be executable.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sat, 3 Apr 2010 10:48:54 +0000 (12:48 +0200)]
Bug 4368 - Avoid reseting UNIMARC 100 tag when importing biblio records
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Mon, 29 Mar 2010 18:27:22 +0000 (14:27 -0400)]
bug 4233 HidePatronName values swapped
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 8 Apr 2010 11:02:22 +0000 (12:02 +0100)]
bug 4378 Missing option prompt for IntranetBiblioDefaultView syspref
labeled_marc ioption was omitted (spelling police?)
options available now match those in code
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 16 Apr 2010 04:16:16 +0000 (00:16 -0400)]
Merge branch 'serials_mods' of git://github.com/colinsc/koha into to-push
Description by Colin Campbell:
A number of commits, subsequent to enabling warnings in C4::Serials and
eradicating errors and removing dead code.
These are extracted from an install branch running at UN FAO in Rome.
Commits have been rebased on current 3.2 HEAD.
These are not major new functionality, but a series of fixes to
eradicate some randomness caused by undefined values. Includes a commit
to fix Licenses in the serials directory.
* 'serials_mods' of git://github.com/colinsc/koha:
Check value is defined before splitting it
Fix FSF Address in directory serials/
Bug 4380 Use syspref to resolve which bib display is used
Remove bottleneck making claims page unuseable
Clean up Pod Documentation
add warnings to Serials.pm
Add Text to claim date column's header
Basic refactoring of serials-edit.pm
Remove unused or unnecessary variables in claims processing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 22 Feb 2010 18:28:40 +0000 (13:28 -0500)]
Fix for Bug 4235, Date picker broken if placing multiple holds
Also includes minor style change.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 2 Mar 2010 19:22:43 +0000 (14:22 -0500)]
Fix for Bug 4262, changing matching rule add big message box
Fix includes a change to the format of the page to consolidate
matching rule settings with matching rule controls. This
reduces potential confusion from the placement of the message
box. Assuming that matching rule settings and controls were
displayed separately for clarity and control, I've added
JavaScript which allows the user to change their mind after
changing a selection (but before submitting). It's a new
interaction which I hope is useful.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 5 Feb 2010 15:45:10 +0000 (10:45 -0500)]
Fix for Bug 4121, Cataloging record modification should obey IntranetBiblioDefaultView pref
- Re-used redirect logic found in search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 24 Feb 2010 15:03:35 +0000 (10:03 -0500)]
Fix for Bug 4251, click on show more in facet drops limit=branch in query
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 24 Feb 2010 15:16:31 +0000 (10:16 -0500)]
Fix for Bug 4251 in the staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 24 Feb 2010 16:38:36 +0000 (11:38 -0500)]
Fix for Bug 4250, cart missing print button
- Print button was hidden by CSS for some reason (git blame me)
- Print formatting was off because of column mismatch
- Table style modified in print view for clarity
- Redirect from print view corrected by adding missing bib_list
and verbose parameters
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 24 Feb 2010 17:13:45 +0000 (12:13 -0500)]
Fix for Bug 4214, "Your Cart is Currently Empty" popup displays underneath News header
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Mon, 12 Apr 2010 08:06:09 +0000 (20:06 +1200)]
Adding Calyx to the about page and the history
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 8 Apr 2010 21:36:16 +0000 (22:36 +0100)]
Check value is defined before splitting it
splitting an undef generates a warning
Colin Campbell [Thu, 8 Apr 2010 19:37:12 +0000 (20:37 +0100)]
Fix FSF Address in directory serials/
Add License statement to those files lacking it
Colin Campbell [Thu, 8 Apr 2010 19:04:24 +0000 (20:04 +0100)]
Bug 4380 Use syspref to resolve which bib display is used
Be consistent with elsewhere in cataloguing
When switching there from serials
TODO Duplicates Code Should be in a common routine
Colin Campbell [Thu, 8 Apr 2010 16:58:20 +0000 (17:58 +0100)]
Remove bottleneck making claims page unuseable
While the idea of showing the number of late serials against the
vendor name was nice it does not scale and on large sites selecting claims
was just timing out. Improved the speed of the initial query but have removed
the big query for each user just to get a count.
Check for 0000-00-00 dates so that C4::Dates does not log error
Removed a variable that was never set and the bit of template used
if the impossible happened
Colin Campbell [Thu, 8 Apr 2010 13:44:39 +0000 (14:44 +0100)]
Clean up Pod Documentation
Ensured returns were documented
Fixed some language issues
Removed the host of podchecker warnings about missing lists
added a couple of explicit returns when subroutines
'fell off the end' to remove any ambiguity
Colin Campbell [Thu, 8 Apr 2010 12:28:40 +0000 (13:28 +0100)]
add warnings to Serials.pm
Change obvious warning generators:
( use of string comparisons in numeric comparison)
( declaration of variable in comnditional )
also some errors caused by undefined values:
abouttoexpire was not checking for undef values
Pass a valid planneddate in generation of next expected
(undef here causes odd results)
Add a basic test script
test is minimal but I fell over a bug this would have caught
Colin Campbell [Thu, 21 Jan 2010 15:27:02 +0000 (15:27 +0000)]
Add Text to claim date column's header
Colin Campbell [Thu, 8 Apr 2010 12:16:31 +0000 (13:16 +0100)]
Basic refactoring of serials-edit.pm
Removed some useless counts from serials-edit / Serials interfaces
Removed old commented out code. Unrequired variables
Reformatted some code so that improving logic can be done
more easily
Colin Campbell [Thu, 8 Apr 2010 11:46:06 +0000 (12:46 +0100)]
Remove unused or unnecessary variables in claims processing
Also cleaned the interface to the claims related functions
in C4::Serials so they do not return an extra count variable
moved generation of dropdown to template instead of inline code
Donovan Jones [Wed, 24 Feb 2010 00:33:02 +0000 (13:33 +1300)]
Bug 2505 - remove unnecessary -w and replace with use warnings;
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>