Joe Atzberger [Sat, 18 Apr 2009 17:43:06 +0000 (12:43 -0500)]
Bug 3133 - correct typos
This corrects 3 typographical errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 18 Apr 2009 17:12:06 +0000 (12:12 -0500)]
followup to 3004 - fix typo
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 18 Apr 2009 16:21:43 +0000 (11:21 -0500)]
Removing duplicate email form field. Fixes Bug 3010.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 18 Apr 2009 15:39:41 +0000 (10:39 -0500)]
remove last reference to deprecated syspref noOPACUserLogin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 9 Apr 2009 14:55:41 +0000 (09:55 -0500)]
bug 2958: fix search results navigation for CCL, CQL, and PQF queries
The shortcut to build $query_cgi in C4::Search::buildQuery()
for CCL, CQL, and PQF queries is incorrect, as (for now)
the "q=" prefix is required.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 18 Apr 2009 14:34:27 +0000 (02:34 +1200)]
History docs
Squashed commit of the following:
commit
143a24041dd1988e025458ccb285a64809640f45
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 19 01:48:35 2009 +1200
Updating indian news
commit
21e518389b99acd038a5f0f5a3819e66bfc32062
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Fri Apr 17 04:43:41 2009 +1200
Adding more dehli public library news
commit
a610f13cabf07d4de44e6b841be57e391301d0f3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 16 02:41:48 2009 +1200
More history work from the devel list
commit
8d7f33c548600177a2b55f46a53f9828238c6e05
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 12 22:24:40 2009 +1200
Added translation information
commit
c1d20eb095275904a01090f278356ee6c1b77f71
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 12 21:07:46 2009 +1200
Up to March 2006 on the devel list
commit
45b9ea49220dc350d684e5fe175062dfc95d146c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 21:39:14 2009 +1200
Up to August 2005 on the devel list
commit
2788b21f1efb9ace2e23cabfbd82bfc27868ab33
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 20:21:01 2009 +1200
Adding tags
commit
f3b26c2eccc86a0616c5e98cedeee68ce5662abb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 20:05:03 2009 +1200
Last little fix
commit
f5e778278e9483c9ee4be24fa95692079a5ccbb4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:55:17 2009 +1200
More formatting
commit
83ea369a4e0c5cb6141cf0b2dc104e0e9d0b1761
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:32:08 2009 +1200
Formatting tweaks
commit
f5c6709268f216b52826a45f427258717e011777
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 19:20:40 2009 +1200
Tab separated text
commit
6a80241a9a77b79b4d3ab8881f0b91217d8238a5
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 17:30:07 2009 +1200
Up to May 2005 on the devel list
commit
6ea5ec539e023d3652ed097467c65f81257a2146
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 16:07:30 2009 +1200
Up to october 2003 on th devel list
commit
8e0d72b86c2da276d1fc5731e69974b135c047f2
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 10:49:59 2009 +1200
Now up to February 2003 on the devel list
commit
aedcfd1c66fe2bd61c5bc5cb0aa3ae9e446d356c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 09:34:32 2009 +1200
Adding history about paul
commit
cb728d09ee3024abb3d98cca90f68514e9a6e14e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sat Apr 11 08:41:51 2009 +1200
Typo fix
commit
9f515f9df0450a9a797bb0abb68233eddb2d15ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Fri Apr 10 21:43:35 2009 +1200
Done up to October 2002 on the devel list
commit
87382c7d2c2fb05b23eedb0840a94b729f211d16
Author: Chris Cormack <chris@deb-lap.(none)>
Date: Fri Apr 10 20:31:22 2009 +1200
Up to june 2002 on the developer list
commit
75d24ed5f05c45ea7c25e2c8623bec114c35ce81
Author: Chris Cormack <chris@deb-lap.(none)>
Date: Fri Apr 10 18:47:21 2009 +1200
Adding information from the devel list
commit
4ab492672feab94cabc2337f1c8ef01e588c90f6
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Wed Apr 8 08:47:31 2009 +1200
Adding date for biblibre
commit
4a0153d1dbd5abdf289f9e842c8e60908286c66a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 22:39:23 2009 +1200
Finished the main mailing list and the announce list, working on the translate list now
commit
4c99f3809ce2539d8c2312ad76bc533ebe2a0fdf
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 21:03:07 2009 +1200
Fixing typo
commit
ad5f8685529503da0a4a214fc900a9b2fd9a880a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 20:47:00 2009 +1200
Adding biblibre, fixing rfp history
commit
0be5d854db10eb2d1710a940c141c1689e3e226a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 19:47:59 2009 +1200
More history work
commit
2b423736e5e343fbf5abe84e6e1055541bb2a7c3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Apr 7 07:04:30 2009 +1200
Fixing dates for OLC
commit
5065f400dc369531725bfe4469b115a168110f52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 22:07:07 2009 +1200
More work on the history
commit
d5dd62629bddded528edf5b99e1b316554ff3138
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 20:18:03 2009 +1200
Finished committers history
commit
d707b19d04f094239d0300b6a0a296b7ac93c799
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Apr 6 19:57:07 2009 +1200
Finishing off committer history
commit
b15d07d0c8f299d719365dd087e98066beee19a9
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 21:38:39 2009 +1200
VCS history for 2007
commit
47e69aa34409389d8c203e35b70a1480351705ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 21:30:21 2009 +1200
VCS and main mailing list history for 2006
commit
3e45921c5fee7a122e745d025524970a11ef9b09
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 20:07:26 2009 +1200
Continuing on with the History
commit
f8719ebb2bde3871c45de9b043f0260b5bd810d7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 19:14:08 2009 +1200
Adding links to computerworld articles
commit
500370aa98b869edb0b0b36ca7af5a8b094f515b
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 18:59:30 2009 +1200
2005 vcs and main mailing list history
commit
f6fad5cfba85aa4213038ce301cc84436f76df2f
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Apr 5 07:59:18 2009 +1200
Up to June 2005
commit
43d40046e0fb9baf75b58c769632bc99346295cb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 2 22:05:33 2009 +1300
Working on 2005
commit
f15da9231fffecbe2b6d35c53e9e1adf370222c1
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Thu Apr 2 09:33:09 2009 +1300
More history work
commit
93174bbd9bde579c91a3bc49976faf118a83da52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 22:04:56 2009 +1300
More history
commit
f2fd3c6d74ef4489100401bbbf936df1efa16d19
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 18:55:08 2009 +1300
More 2004
commit
a17646986b0abf99b121309e22fce299449a3cc4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 18:27:29 2009 +1300
Working on 2004
commit
5886fae2d293f801ed436a3efa8660966a31ba3e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 13:52:07 2009 +1300
Continuing on with the history updates
commit
1f64c51abf414d8432280023e72d5f191961a8a0
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Tue Mar 31 09:02:25 2009 +1300
More history
commit
c20b84d7d42b7774d8c5ab7f20a54f6314e4f30c
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date: Tue Mar 31 13:48:49 2009 +1300
formatting fix
commit
7698ba607429e502126ccf2df1e9e9a4755fa448
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 22:02:12 2009 +1300
And even more history
commit
cac079f7541e9276710dc778527ea9c84e8d185a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 21:45:36 2009 +1300
COntinuing on
commit
ce7402c7dbcf01483f9905b4eb75f1d89568e0d8
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 21:05:27 2009 +1300
Continuing on
commit
3dcd055d4640160a54e88d8c6519785a390a93a7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 20:44:41 2009 +1300
Continuing on the history
commit
cf07159fd8d400750d1878213fab7b01b45c5197
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Mon Mar 30 20:33:28 2009 +1300
More history updates
commit
a3c31379e115e9aeab44c752126f6f4878c3bf15
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 23:16:52 2009 +1300
More history
commit
831a385489a90f750cc760e18b598339c02aa620
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 22:53:25 2009 +1300
Continuing on
commit
26e38756019023dfd928538553fdf95311eee4ed
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 22:15:11 2009 +1300
More doc
commit
bb13ea869d83f4493dc53041a0894880a5fefd66
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 21:54:50 2009 +1300
Continuing work on the history doc
commit
69aff74445eac3c260c081cb63e403c1025b7950
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date: Sun Mar 29 21:37:37 2009 +1300
History documentation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 9 Apr 2009 15:31:45 +0000 (10:31 -0500)]
bug 3100: increase width of alternate postal code
The alternative postal code input on the patron
editing form was only permitted 5 characters of
input. Increase this to 10 to match the
primary zipcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha
This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode. This should help open the door for reliable
input of diacriticals via acquisitions.
MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.
Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 7 Apr 2009 22:37:56 +0000 (17:37 -0500)]
Tweak perldoc (--help) for leader_fix.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 3 Apr 2009 20:42:20 +0000 (15:42 -0500)]
Script to repair MARC21 leader/09.
Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09. It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8). This script diagnoses
and repairs the value in the leader, depending on runtime options.
The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal. While we work on
fixing the input, this script will fix the existing data.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Mon, 13 Apr 2009 21:53:42 +0000 (15:53 -0600)]
bug: unescaped single-quote in french sys. prefs. sql file
The description for autoBarcode had an unescaped single-quote.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 13 Apr 2009 22:05:49 +0000 (17:05 -0500)]
Re-insert useldapserver into koha-conf.xml
This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap. This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Tue, 14 Apr 2009 13:51:08 +0000 (08:51 -0500)]
remove last reference to deprecated syspref NoReturnSetLost
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
John Beppu [Tue, 14 Apr 2009 19:45:15 +0000 (14:45 -0500)]
bug 3110 - Move Serial Preferences to Serials Tab
- Moved the following system preferences to the Serials tab:
OPACDisplayExtendedSubInfo
OPACSubscriptionDisplay
RenewSerialAddsSuggestion
SubscriptionHistory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Ryan Higgins [Wed, 15 Apr 2009 17:23:21 +0000 (10:23 -0700)]
But 3117 : fix typo in C4::Matcher causing compilation failure.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 8 Apr 2009 20:13:12 +0000 (15:13 -0500)]
qualify warn; sort_by is not a required search parameter
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
(displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
(attemping to calculate average Amazon rating if no Amazon info
is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
(attempting to calculate length of $isbn if it happens to be undef)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
(displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
(attemping to calculate average Amazon rating if no Amazon info
is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
(attempting to calculate length of $isbn if it happens to be undef)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 8 Apr 2009 19:46:01 +0000 (14:46 -0500)]
bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.
The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date. This patch
fixes the bug in two ways:
[1] AddRenewal() now updates items.onloan with the
correct due date.
[2] Two templates were updated to display the
due date from (indirectly) issues.date_due
instead of items.onloan, thus making it less
likely that the wrong value will be displayed.
This patch does *not* update items.onloan to reflect
the correct due date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.
Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery. Performance improved.
Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 21 Jan 2009 01:18:21 +0000 (19:18 -0600)]
Begin cleanup on additem.
REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see. Remove the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations. There is no
longer any /cgi-bin in the actual directory file path.
This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Wed, 8 Apr 2009 18:39:37 +0000 (13:39 -0500)]
Minor markup corrections for validity.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Fri, 3 Apr 2009 10:28:24 +0000 (12:28 +0200)]
auto truncation was not used
Auto truncation now works on LTR languages
For RTL languages(Arab, Hebrew), development should be really improved.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 27 Mar 2009 15:34:34 +0000 (10:34 -0500)]
Introduce sth caching to Letters.pm
The re-creation of statement handles for the same queries, repeatedly,
seriously degrades the performance of notices. This introduces new
class-level caching to avoid that problem.
Note: initial provisions
to do the same with caching of COLUMNS information about tables is
also included, but this would probably be most usefully implemented
in C4::Context (or a separate more central module). The benefits of
caching that info would probably be even greater. Note that this
proposed implementation might be obsoleted by ORM integration, where
DB structure info would already be cached.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Mon, 6 Apr 2009 13:50:51 +0000 (08:50 -0500)]
Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 7 Apr 2009 22:37:50 +0000 (17:37 -0500)]
perltidy finishreceive.pl and two comments added
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 7 Apr 2009 22:37:55 +0000 (17:37 -0500)]
Bug 3090 - Add perldoc details
This is half of the fix for 3090.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 7 Apr 2009 22:37:52 +0000 (17:37 -0500)]
parcel.pl cleanup
It looks like a lot of change, but it isn't much:
perltidy, removed unused "toggle" code, and corrected comments.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup
Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 7 Apr 2009 19:21:18 +0000 (14:21 -0500)]
Fix for Bug 3095, Add to lists page doesn't redirect with no javascript
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 6 Apr 2009 14:45:56 +0000 (09:45 -0500)]
remove incomplete bib bulk editing code
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Mon, 16 Mar 2009 21:05:21 +0000 (22:05 +0100)]
3040 : seriestitle mistaken as collection title
If series title was previously taken as collectiontitle
then you should launch
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/batchRebuildBiblioTables.pl
[RM note: applies only to UNIMARC users - MARC21
users should not run the batch jobs.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 4 Apr 2009 15:19:33 +0000 (10:19 -0500)]
Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 5 Apr 2009 16:29:32 +0000 (11:29 -0500)]
restored tab-delimited report download
Previous patch broke this, always providing the
guided report download in CSV format regardless of
whether CSV or tab-delimited was requested.
Also, default name of downloaded file is reportresults.csv
for CSV output and reportresults.tab for tab-delimited.
Also removed a couple subroutine prototypes that
were leading to unnecessary compile-time warnings
under use warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 31 Mar 2009 20:08:10 +0000 (15:08 -0500)]
Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap. Arguments reduced, client scripts
adapted to new API and performance improved. Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.
Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
~ security fixed
~ documentation improved
~ TODO: finish sendmail option.
Bug 3077 also fixed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 26 Mar 2009 15:59:17 +0000 (10:59 -0500)]
Condense inarticulate construction of TMPL structures.
Use map to replace multiple temporary hash constructions.
Also a minor POD fix.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 27 Mar 2009 15:34:33 +0000 (10:34 -0500)]
runreport.pl and prep work on Guided.pm
The old location of runreport.pl was under tools, leaving it exposed
to web requests. This is a security flaw since it does NOT check any
Auth and allows the user to request any Saved Report be run. This is
not a problem under misc/crontab/ and it suggests the more appropriate use.
Guided.pm is not fixed here (see bug 3066), but it is prepared to be fixed
and made compatible with runreport as detailed in the perldoc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Mon, 9 Mar 2009 02:13:06 +0000 (15:13 +1300)]
patch for bug-3017
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Wed, 1 Apr 2009 19:36:28 +0000 (21:36 +0200)]
Internationalize Amazon support
With this patch:
* On Amazon book cover, 'search inside' text is not displayed
anymore because it's not translatable.
* Link the image to local Amazon web site 'search inside' service.
Based on AmazonLocale syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
David Bavousett [Thu, 18 Sep 2008 16:43:46 +0000 (11:43 -0500)]
Updated INSTALL.debian
Modified INSTALL.debian to update install and web
configuration instructions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Fri, 26 Dec 2008 22:12:06 +0000 (16:12 -0600)]
Changes to installed indexing.
These changes tidy up ISBN and ISSN indexing, per Michele Maenpaa. It's being
set up manually on many new installations, and probably ought to become part of the default
Koha installation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Fri, 26 Dec 2008 21:56:55 +0000 (15:56 -0600)]
Changes to bulkmarcimport.pl
Adds three new switches:
-idmap <filename> - optional output file of
map of source record ID numbers
to Koha biblionumber
-x - if idmap is supplied, MARC tag
to get source record ID from
-y - if idmap is supplied, MARC subfield
to get source record ID from
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Fri, 26 Dec 2008 21:38:00 +0000 (15:38 -0600)]
Modifications to C4/Matcher for colon and ending punctuation
Recommended by Michele Maenpaa, this adds handling colon and end-punctuation stripping
in subroutine _normalize, and fixes length testing in subroutine _get_match_keys
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Fri, 30 Jan 2009 16:05:46 +0000 (10:05 -0600)]
Added ISBN to RSS results.
Added ISBN tag to RSS results, right after the title.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Wed, 1 Apr 2009 18:17:54 +0000 (13:17 -0500)]
Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 2 Apr 2009 13:34:30 +0000 (15:34 +0200)]
(bug #3084) in baskets, change the isbn of column
this patch add a new column and put the isbn in it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Thu, 2 Apr 2009 19:06:33 +0000 (14:06 -0500)]
Adding details to OPAC search results RSS, described in Bug 2973.
This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 3 Apr 2009 23:15:08 +0000 (18:15 -0500)]
bug 3088: fix crash in opac-ISBDdetail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 1 Apr 2009 16:49:43 +0000 (11:49 -0500)]
added dependencies for new OAI-PMH server
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Thu, 26 Mar 2009 20:54:25 +0000 (21:54 +0100)]
Add a UNIMARC to Dublin Core XSL
This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frederic Demians [Thu, 26 Mar 2009 20:54:24 +0000 (21:54 +0100)]
Add another OAI server
This OAI server has those characteristics:
* It doesn't use C4::OAI anymore.
* It uses HTTP::OAI library which is easily expandable.
* XML result is not build anymore directly but using
XML::SAX::Writer. It should solve encoding and XML related issues.
* It returns two formats: oai_dc and marcxml.
* DC is generated from biblioitems.marcxml by applying XSLT
(MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
* It uses the same tokens as previous OAI server (thanks Philippe
Jaillon).
* There is no more sets (it wasn't operational in previous version).
Add two new dependencies:
* HTTP::OAI
* XML::SAX::Writer
available as a Debian package: libxml-sax-writer-perl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Sun, 29 Mar 2009 08:55:34 +0000 (10:55 +0200)]
Bug #3071 - Z39.50 search result highlights are mixed
This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Mon, 30 Mar 2009 06:42:22 +0000 (08:42 +0200)]
Fix Amazon cover for UNIMARC
In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-'
are valid. This patch modify ISBN normalization in order to
automaticaly suppress '-' before sending ISBN to Amazon
to get book cover.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Sun, 29 Mar 2009 23:54:15 +0000 (12:54 +1300)]
BUG-1503: fixes broken matching for 'hidden' values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Wed, 1 Apr 2009 04:11:13 +0000 (17:11 +1300)]
fix to ignore 600$2 'Source of heading' fields for MARC21 subject display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Mon, 30 Mar 2009 16:15:04 +0000 (11:15 -0500)]
Adding patron address to select patron form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 23 Mar 2009 21:25:21 +0000 (16:25 -0500)]
Improve performance and fault tolerance for sync_items...
Pulled the GetMarcFromKohaField outside the loop, since we only need to
check it once. Same for $item_sth. Added safety checks for success of
delete_field and GetMarcItem, with warnings on failure.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 13 Mar 2009 19:22:43 +0000 (14:22 -0500)]
cleanup some of value_builder MARC21 plugins
Tons of unnecessary dependencies removed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 13 Mar 2009 19:22:42 +0000 (14:22 -0500)]
perltidy some ugly value_builder plugins
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 18 Mar 2009 22:21:48 +0000 (17:21 -0500)]
whitespace cleanup and remove editor comments
No functionality affected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 26 Mar 2009 12:59:37 +0000 (13:59 +0100)]
(bug #3063) fix unimarc 4xx plugin with cloned field
this patch fix the unimarc plugin 4xx to work with cloned fields, the id of the div wasn't replaced when the field was cloned.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frederic Demians [Fri, 13 Mar 2009 07:14:58 +0000 (08:14 +0100)]
Instructions and packages required for Debian Lenny Installation
INSTALL.debian-lenny
Instructions for installing Koha on Debian Lenny.
Based on INSTALL.debian. Almost all Perl modules are now available
via Debian packages. MySQL installation is simplified.
debian-lenny.packages
List of all Lenny packages required by Koha.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frederic Demians [Fri, 13 Mar 2009 19:47:25 +0000 (20:47 +0100)]
Bug #3036 Avoid command-line installer blocking on opensolaris plateform
Koha installation/upgrade on OpenSolaris 'seems' to work.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Sun, 15 Mar 2009 05:52:35 +0000 (18:52 +1300)]
fixes error below...
bookcount.pl: Illegal Date 'Item has no branch transfers record' does not match 'iso' format: yyyy-mm-dd at /home/mason/git/kap-k3-2/circ/bookcount.pl line 88
tested on 3.0.x
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Mon, 16 Mar 2009 11:49:01 +0000 (00:49 +1300)]
fixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branches.pl line 242.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Mon, 16 Mar 2009 20:34:39 +0000 (21:34 +0100)]
Minor bug fix Documentation update : 3039
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 17 Mar 2009 20:02:43 +0000 (15:02 -0500)]
Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Wed, 18 Mar 2009 03:19:34 +0000 (16:19 +1300)]
quietens a noisy debug pop-up, when debugging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 19 Mar 2009 19:06:26 +0000 (14:06 -0500)]
Bug 2958 - notforloan (8008) is a numeric field.
Update index to allow searching for "On Order" items, -1 value.
Example:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-search.pl?q=ccl=notforloan:-1
Without this patch, search for "-1" is normalized to "1".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 18 Mar 2009 22:21:49 +0000 (17:21 -0500)]
Invalid field 'expiry' referenced.
This caused a warning from C4::Dates on every execution, since the value
passed to format_date was undefined. Now we reference the correct field
and check for a populated value before trying to reformat it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joshua Ferraro [Mon, 16 Feb 2009 16:42:36 +0000 (10:42 -0600)]
Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joshua Ferraro [Thu, 12 Feb 2009 18:59:22 +0000 (12:59 -0600)]
Fix for LL bug 367 Titles without ISBNs display "no cover image available"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Tue, 24 Mar 2009 13:42:22 +0000 (14:42 +0100)]
Bug Fix : weight field was broken in UNIMARC
Title-cover was not defined in record.abs
So the relevance ranking was broken.
This patch corrects that
For UNIMARC people, please reindex
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 11 Mar 2009 15:28:44 +0000 (10:28 -0500)]
fix error introduced in a previous commit
Change to GetReservesFromBiblionumber() had effect
of causing all requests of constrainttype other
than 'o' to not be included in result.
while ($foo) {
$bar or next;
# do stuff
# do other stuff
}
is not equivalent to
while ($foo) {
if ($bar) {
# do stuff
}
# do other stuff
}
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 11 Mar 2009 14:09:30 +0000 (09:09 -0500)]
bug 3028: remove reservefix.pl cronjob
Removed cronjob, which was written to work around
a bug in 2.2 that no longer applies and is specific
to a single library in any event.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 7 Mar 2009 16:34:42 +0000 (10:34 -0600)]
Correcting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014, Can't delete restricted patron from circulation screen.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 7 Mar 2009 17:41:50 +0000 (11:41 -0600)]
Fix for Bug 3015: Check-in screen displays branch name inconsistently
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Mon, 9 Mar 2009 13:38:06 +0000 (08:38 -0500)]
Changes to tabindex values to improve keyboard access.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 9 Mar 2009 18:51:58 +0000 (13:51 -0500)]
Sort collection codes by description for dropdown.
Collection code descriptions were otherwise displaying in an
unsorted order. The result was not readable for any sufficiently
large number of ccodes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 9 Mar 2009 18:51:57 +0000 (13:51 -0500)]
Correct perldoc
Indentations misformatted for code blocks. Also updated reference to
GetBranchesLoop.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 10 Mar 2009 21:41:00 +0000 (16:41 -0500)]
Bug 2617: Add strict (and warnings), partial fix.
These are some of the simpler scripts to add strict to.
Corrected perldoc for Bookfund.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 10 Mar 2009 21:40:59 +0000 (16:40 -0500)]
InstallAuth doesn't have setlanguagecookie to export.
Only installer/install uses InstallAuth, and it gets setlanguagecookie
from C4::Export.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 10 Mar 2009 21:40:58 +0000 (16:40 -0500)]
Trivial correction to comment.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 9 Mar 2009 18:58:28 +0000 (13:58 -0500)]
Add larger values to numerical limit.
Client requested additional values in dropdown for numerical limit.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 10 Mar 2009 21:41:01 +0000 (16:41 -0500)]
Fixing catalogue_out errors.
This script ran against biblioitems.itemtype instead of items.itype.
With that corrected, biblioitems is not used by the query.
Report also failed to check whether the item was currently checked out
(i.e., in the issues table) before declaring it an inactive,
uncirculating item!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 6 Mar 2009 20:19:56 +0000 (14:19 -0600)]
Remove outmoded (and possibly dangerous) cronjob.
This script is superceded by rebuild_zebra and the sync_items scripts.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 12 Dec 2008 16:47:25 +0000 (17:47 +0100)]
(bug #2863) add the borrowers branchcodes in suggestion list
Not a big patch, just add the borrower branchcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 6 Mar 2009 19:17:04 +0000 (13:17 -0600)]
fix permissions error
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel Angelinetti [Thu, 4 Dec 2008 15:45:30 +0000 (16:45 +0100)]
fix the sql request to work in all mysqls
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 30 Dec 2008 19:50:15 +0000 (13:50 -0600)]
Libraries (branches) should be sorted by branchname.
The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes. Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 30 Dec 2008 19:42:10 +0000 (13:42 -0600)]
Allow all argument forms to GetBranchesLoops.
Allow arguments to be specified in the negative (i.e. 0).
Allow function to be called with no arguments.
This supercedes the patch titled:
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 18 Dec 2008 03:35:21 +0000 (21:35 -0600)]
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 30 Oct 2008 05:07:40 +0000 (00:07 -0500)]
Add GetBranchLoop since so many pages use exactly the same code.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 18 Dec 2008 03:36:05 +0000 (21:36 -0600)]
catalogue_out report cleanup.
Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected. Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.
NOTE: CSV output is not fixed by this patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 7 Jan 2009 13:33:23 +0000 (14:33 +0100)]
(bug #2811)[3.2] fix opac-renew.pl part
This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 13 Jan 2009 23:11:06 +0000 (17:11 -0600)]
AddReserve had bogus prepare statement.
This patch was not fully tested because the actual behavior intended
by constraints 'o' and 'e' was apparently never implemented here.
But it had no chance of success as with:
my $sth = $dbh->prepare("");
This uses the inteneded query, removes unneeded $sth->finish calls and
fixes *some* redeclaration of my $variables in the same scope, as
would be needed to run under warnings pragma.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 6 Mar 2009 18:17:39 +0000 (12:17 -0600)]
bug 2904: fix display of URLs in UNIMARC
This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951. The original
patch description is:
in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Thu, 12 Feb 2009 23:15:57 +0000 (12:15 +1300)]
corrected patch for bug 2951
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>