]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 8224 - Make authorized values appear in planning list
Alex Arnaud [Mon, 11 Jun 2012 08:58:24 +0000 (10:58 +0200)]
Bug 8224 - Make authorized values appear in planning list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I can confirm the bugs on current master and this patch fixes both problems.

- Pull down list for "Planning" on the budget page was not showing
  categories of authorized values
- Planning page showed the categories, but budget_period_id was
  missing from the URL

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8282: Bug in modules list in about.pl
Matthias Meusburger [Thu, 21 Jun 2012 13:41:54 +0000 (15:41 +0200)]
Bug 8282: Bug in modules list in about.pl

  Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron <veron@veron.ch>
Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8289 Upgrading from 2.2 does not work anymore
Paul Poulain [Fri, 22 Jun 2012 09:10:18 +0000 (11:10 +0200)]
Bug 8289 Upgrading from 2.2 does not work anymore

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818 Add UNIMARC biblio records zebra DOM def files
Frédéric Demians [Fri, 6 Apr 2012 17:39:03 +0000 (19:39 +0200)]
Bug 7818 Add UNIMARC biblio records zebra DOM def files

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I tested two UNIMARC Koha installations using the sample UNIMARC
data from the BibLibre sandbox, comparing the results with DOM
and with GRS-1 indexing. The results are very similar, though there
are some differences. Most noticeable:
* relevance and facets seem to be more accurate with DOM enabled
* the GRS-1 configuration returns approximately 10% more results with
  random single keywords like "petit," but the DOM results contain
  the most relevant items, and any lacks in the configuration can
  easily be corrected as UNIMARC users identify fields that should be
  indexed but aren't
* authority-controlled searches match exactly
* author and topic facets do not work with the out-of-the-box GRS-1
  indexing configuration (?!?)
(adding second sign-off line below because all that probably looks like
a commit message and not a sign off)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: add warning about not editing record.abs when using DOM filter
Galen Charlton [Fri, 6 Apr 2012 15:26:12 +0000 (11:26 -0400)]
Bug 7818: add warning about not editing record.abs when using DOM filter

This commit also updates the authority and biblio DOM indexing definition
XSL to include updated header comments.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: update comment to clarify availability of DOM index mode
Galen Charlton [Fri, 6 Apr 2012 15:18:55 +0000 (11:18 -0400)]
Bug 7818: update comment to clarify availability of DOM index mode

DOM indexing is now available for both bibs and authorities.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: use Title-cover for title phrase weighting
Galen Charlton [Fri, 6 Apr 2012 04:48:04 +0000 (00:48 -0400)]
Bug 7818: use Title-cover for title phrase weighting

This is offerred as a compromise alternative to creating
a new Title-rel index to avoid having the statement of
responsiblity unduly affect field weight when using the DOM
filter and MARC21 -- the problem with creating a Title-rel index
is that it would *force* reindexing upon upgrade.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: -x option of rebuild_zebra.pl now works with DOM filter
Galen Charlton [Fri, 6 Apr 2012 04:05:46 +0000 (00:05 -0400)]
Bug 7818: -x option of rebuild_zebra.pl now works with DOM filter

One consequence is that the -x and -a options are no longer
mutually exclusive.

Also, because of the way that the GRS-1 SGML filter works, if you're
indexing multiple documents, you can't just wrap them in a document
element, but the DOM filter *requires* it.  Consequently, two
new config settings in koha-conf.xml are added to indicate the
Zebra filter in use so that the -x option of rebuild_zebra.pl
knows whether to wrap the exported records or not:

- bib_index_mode (defaults to 'grs1' if not specified)
- auth_index_mode (defaults to 'dom')

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: Zebra DOM filter index definitions for MARC21 bibs
Galen Charlton [Mon, 26 Mar 2012 05:16:11 +0000 (01:16 -0400)]
Bug 7818: Zebra DOM filter index definitions for MARC21 bibs

The file biblio-zebra-indexdefs.xsl, which is the stylesheet that
is used by the Zebra DOM filter to convert an incoming MARC21 bib
to its indexed form, was generated by the following two steps:

misc/maintenance/make_zebra_dom_cfg_from_record_abs \
  --input  etc/zebradb/marc_defs/marc21/biblios/record.abs \
  --output etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml

xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \
  etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \
  > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl

Records indexed using this XSLTshould behave similarly to records
indexed using the GRS-1 filter and the old record.abs definition, with
the following big exception (and improvemwent): indexed phrases now
span subfield boundaries if a specific subfield wasn't specified in the
index definition.  For example, the GRS-1 filter index definition

melm 245 Title

would allow 245 $a Cats on boxes : $b cardboard fantasies

to be searched as the phrases "cats on boxes" or "cardboard fantasies",
but a title phrase seach of "cats on boxes cardboard fantasises"
wouldn't work.  The DOM filter equivalent,

<index_data_field xmlns="http://www.koha-community.org/schemas/index-defs" tag="245">
  <target_index>Title:w</target_index>
  <target_index>Title:p</target_index>
</index_data_field>

*does* allow phrase searches to span subfield boundaries.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: add index_data_field option to DOM indexing repertoire
Galen Charlton [Mon, 26 Mar 2012 05:10:09 +0000 (01:10 -0400)]
Bug 7818: add index_data_field option to DOM indexing repertoire

Adds a new kohaidx:index_data_field index definition type which
indexes all of the subfields of a MARC data field as a single
phrase, separating the contents of each with a space.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: move koha-indexdefs-to-zebra.xsl
Galen Charlton [Mon, 26 Mar 2012 05:08:58 +0000 (01:08 -0400)]
Bug 7818: move koha-indexdefs-to-zebra.xsl

Since the koha-indexdefs-to-zebra.xsl  stylesheet will be used
by both bib and authority indexing, put in a central location.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: utility to generate DOM indexing configs
Galen Charlton [Mon, 26 Mar 2012 05:05:58 +0000 (01:05 -0400)]
Bug 7818: utility to generate DOM indexing configs

misc/maintenance/make_zebra_dom_cfg_from_record_abs:
  generate a DOM filter Zebra index config from a GRS-1 config

Given a Zebra record.abs file containing a set of index definitions for
Zebra's GRS-1 filter, write an equivalent DOM filter configuration.

To generate the XSLT that is to be used by Zebra, run something like
the following on the output of this utility:

xsltproc ZEBRA_CFG_DIR/xsl/koha-indexdefs-to-zebra.xsl \
  biblio-koha-indexdefs.xml \
  > ZEBRA_CFG_DIR/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl

The above example assumes that the output of the program was named
biblio-koha-indexdefs.xsl.

This commit also introduces Koha::Indexer::Utils, a new package for
misceallenous routines that support Koha's indexing definitions.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: update miscellaneous installer scripts
Galen Charlton [Fri, 23 Mar 2012 23:08:58 +0000 (19:08 -0400)]
Bug 7818: update miscellaneous installer scripts

Teach a couple of the quick-install scripts about
DOM mode for bibs.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7818: update installer for biblio DOM indexing
Galen Charlton [Fri, 23 Mar 2012 22:52:27 +0000 (18:52 -0400)]
Bug 7818: update installer for biblio DOM indexing

Adds the necessary bits to enable DOM indexing for bib
records as an option during installation from source.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8272 - OPAC : date expiration format
Owen Leonard [Tue, 19 Jun 2012 17:08:28 +0000 (13:08 -0400)]
Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8043 - today's checkouts are in Previous checkouts in circulation.pl
Kyle M Hall [Thu, 14 Jun 2012 10:33:51 +0000 (06:33 -0400)]
Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8154: The export today's checked in barcodes generated file is always empty
Jonathan Druart [Mon, 18 Jun 2012 08:19:12 +0000 (10:19 +0200)]
Bug 8154: The export today's checked in barcodes generated file is always empty

Comparation of date and datetime is always false

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Exported file contains the list of checked in items.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8267 - Overdue notices not working
Kyle M Hall [Mon, 18 Jun 2012 14:08:23 +0000 (10:08 -0400)]
Bug 8267 - Overdue notices not working

The variable $i was being re-used and overwriting the necessary value that was being passed to a subroutine. Renaming $i to $j fixed it. I also added an extra safety check within parse_letter that would also have prevented this bug.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6634 : 3 more cases of manager_id not populated
Maxime Pelletier [Wed, 28 Mar 2012 21:26:01 +0000 (17:26 -0400)]
Bug 6634 : 3 more cases of manager_id not populated

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoFixing whitespace issues. Note to Paul, docs/history.txt is a tab
Chris Cormack [Sat, 23 Jun 2012 07:24:58 +0000 (19:24 +1200)]
Fixing whitespace issues. Note to Paul, docs/history.txt is a tab
separated text file.

12 years agoAdding Claire Hernandez as contributor + adding missing contributors in about.tt
Paul Poulain [Wed, 20 Jun 2012 19:49:40 +0000 (21:49 +0200)]
Adding Claire Hernandez as contributor + adding missing contributors in about.tt

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7642 - remove the cloud weight from the tags
Robin Sheat [Sun, 10 Jun 2012 13:32:56 +0000 (14:32 +0100)]
Bug 7642 - remove the cloud weight from the tags

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7994: Fix pref yaml errors
Claire Hernandez [Mon, 11 Jun 2012 13:52:10 +0000 (15:52 +0200)]
Bug 7994: Fix pref yaml errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7994: scripts to check yaml files
Claire Hernandez [Mon, 23 Apr 2012 13:11:46 +0000 (15:11 +0200)]
Bug 7994: scripts to check yaml files

$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8006 - Loading offline circulation does not anonymize
Kyle M Hall [Wed, 25 Apr 2012 12:44:50 +0000 (08:44 -0400)]
Bug 8006 - Loading offline circulation does not anonymize

Simple, one line fix. Added the privacy parameter to the list
of parameters passed to C4::Circulation::MarkIssueReturned.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8152: Clicking cancel link on edit suggestion redirect to the suggestions list
Jonathan Druart [Fri, 25 May 2012 09:29:23 +0000 (11:29 +0200)]
Bug 8152: Clicking cancel link on edit suggestion redirect to the suggestions list

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8216: Allow SIP modules to pass critic tests
Colin Campbell [Sat, 9 Jun 2012 09:40:19 +0000 (10:40 +0100)]
Bug 8216: Allow SIP modules to pass critic tests

Add C4/SIP to perlcritic tests. Fix those issues that were
generating perlcritic errors

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6720: show authority type in auth details
Jared Camins-Esakov [Fri, 15 Jun 2012 14:40:59 +0000 (10:40 -0400)]
Bug 6720: show authority type in auth details

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Authority type on detail page in staff now shows correctly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller
Kyle M Hall [Mon, 11 Jun 2012 08:45:57 +0000 (04:45 -0400)]
Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8229: Tabs in marc subfield structure is not shown correctly
Matthias Meusburger [Mon, 11 Jun 2012 13:24:00 +0000 (14:24 +0100)]
Bug 8229: Tabs in marc subfield structure is not shown correctly

  - Fixed URLs in marc_subfields_structure.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8232: Comments in OPAC contain untranslatable javascript messages
Katrin Fischer [Mon, 11 Jun 2012 14:09:00 +0000 (15:09 +0100)]
Bug 8232: Comments in OPAC contain untranslatable javascript messages

To test:
- add a new comment to a record in the OPAC
- Your comment (preview, pending approval) is not translatable
- update po files by running 'perl translate update <language>'
- Open po file and check if strings are there, translate
- install language again by running 'perl translate install <language>'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7367 Followup for opac-suggestions template
Marcel de Rooy [Thu, 14 Jun 2012 06:31:46 +0000 (08:31 +0200)]
Bug 7367 Followup for opac-suggestions template

This small typo was found by Albert Oller.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial fix.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'tamil/3.8.2-translate' into 3.8.x v3.08.02
Chris Cormack [Thu, 21 Jun 2012 21:06:03 +0000 (09:06 +1200)]
Merge remote-tracking branch 'tamil/3.8.2-translate' into 3.8.x

12 years agoRelease notes for 3.8.2
Chris Cormack [Thu, 21 Jun 2012 20:59:09 +0000 (08:59 +1200)]
Release notes for 3.8.2

12 years agoKoha 3.8.2 Translation Update
Frédéric Demians [Thu, 21 Jun 2012 17:27:11 +0000 (19:27 +0200)]
Koha 3.8.2 Translation Update

12 years agoBug 7368 Followup for history.txt Only correcting whitespace for correct placement...
Marcel de Rooy [Mon, 11 Jun 2012 12:18:02 +0000 (14:18 +0200)]
Bug 7368 Followup for history.txt Only correcting whitespace for correct placement in about form

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Conflicts:

docs/history.txt

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8222 - make the zipcode no longer mandatory
Robin Sheat [Sun, 10 Jun 2012 14:56:21 +0000 (15:56 +0100)]
Bug 8222 - make the zipcode no longer mandatory

Having the zipcode field mandatory by default is a bit annoying for
places where no one cares about it. This patch stops it being the case
on new installs.

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agopatch for Bug 8226 - 'OpacFooter' markup/css improvements
Mason James [Mon, 11 Jun 2012 04:40:04 +0000 (16:40 +1200)]
patch for Bug 8226 - 'OpacFooter' markup/css improvements

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'kc/3.8.x' into 3.8.x
Chris Cormack [Wed, 20 Jun 2012 09:24:35 +0000 (21:24 +1200)]
Merge remote-tracking branch 'kc/3.8.x' into 3.8.x

12 years agoBug 7961 - Local cover images should support CSV link files
Dobrica Pavlinusic [Sat, 14 Apr 2012 09:39:20 +0000 (11:39 +0200)]
Bug 7961 - Local cover images should support CSV link files

Corrent code doesn't have support for filenames which contain spaces
or commans which breaks CSV files saved from spreadsheet similar to:

  12345, "conver image, with spaces.jpg"

This patch tweaks file parsing a bit. We are always splitting line to
only two values (to support commas as part of filename) and removing
spaces only on beginning and end of filename (to cover space after
comma in CSV example above while preserving spaces in filename).

With this change only invalid character in picture filename left
are quotes (") which are commonly used to quote strings with spaces.

Covers added will be logged in action_log, using CATALOGUING / MODIFY
action (which is shown as "Catalog" in tools > Log viewer)

Test scenario:

1. collect pictures with spaces and commas in name
2. dump file list into CSV file and add biblio number as first column
   (name of file is idlink.txt or datalink.txt)
3. create zip with CSV file and pictures
4. verify that all pictures got uploaded and linked to biblio records
5. verify that modification log includes cover image name

Signed-off-by: Olugbenga Adara <gbengaadara@yahoo.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl
christophe croullebois [Tue, 22 May 2012 11:59:33 +0000 (13:59 +0200)]
Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl

In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35.
If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing.
The standart lenght is 36.
I have just changed 35 to 36.

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl
christophe croullebois [Tue, 22 May 2012 11:59:33 +0000 (13:59 +0200)]
Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl

In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35.
If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing.
The standart lenght is 36.
I have just changed 35 to 36.

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch...
Sophie Meynieux [Sun, 10 Jun 2012 15:01:26 +0000 (17:01 +0200)]
Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch...
Sophie Meynieux [Sun, 10 Jun 2012 10:23:20 +0000 (12:23 +0200)]
Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7329: Items onloan are deleted when undoing import into catalog
Christophe Croullebois [Wed, 7 Dec 2011 10:54:29 +0000 (11:54 +0100)]
Bug 7329: Items onloan are deleted when undoing import into catalog

this patch checks the "on loan" and "reserved" status before deleting item, and
do noting in this case, so the record can't be deleted due to existing item.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8247 - adding basket doesn't save basket name, internal or vendor note
Dobrica Pavlinusic [Thu, 14 Jun 2012 15:17:52 +0000 (17:17 +0200)]
Bug 8247 - adding basket doesn't save basket name, internal or vendor note

URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form

I'm also getting mysql referential integrity error:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416.

Test scenario:

1. Find vendor and select "New basket"
2. fill in basket name, internal and vendor note
3. press save
4. verify that created basket doesn't have name nor internal or vendor notes

Signed-off-by: Marc Veron <veron@veron.ch>
First tested without patch applied, new basket's name and internal / vendor notes were empty-
Applied patch, new basket's name and notes behave OK.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoUpdating release template
Chris Cormack [Tue, 19 Jun 2012 02:14:04 +0000 (14:14 +1200)]
Updating release template

12 years agoFirst cut of the 3.8.2 release notes
Chris Cormack [Sun, 17 Jun 2012 09:09:41 +0000 (21:09 +1200)]
First cut of the 3.8.2 release notes

12 years agoBug 6141 - html glitches causing problems to translator - 3.8.x
Kyle M Hall [Sat, 9 Jun 2012 11:04:48 +0000 (07:04 -0400)]
Bug 6141 - html glitches causing problems to translator - 3.8.x

* opac-topissue.pl = untranslatable string removed
* authorities.pl missing _() in javascript

Rewrite of patch authored by Julian Maurice.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoRevert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"
Chris Cormack [Sun, 17 Jun 2012 08:01:37 +0000 (20:01 +1200)]
Revert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"

This reverts commit 958b65d0045949b406b16a370ad06a239184828d.

12 years agoBug 7952 - followup to fix t/Creators.t
Dobrica Pavlinusic [Thu, 14 Jun 2012 12:00:16 +0000 (14:00 +0200)]
Bug 7952 - followup to fix t/Creators.t

Since we are now using temporary file, we are creating test.pdf
at end of test and checking if it exists and have non-zero size.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser
Dobrica Pavlinusic [Thu, 12 Apr 2012 22:20:00 +0000 (00:20 +0200)]
Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser

Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.

This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or CGI) to pick up.

Test secenario:

1. Home › Tools › Patron Card Creator › Manage Card Batches
2. select batch checkbox and click Export
3. select template and click Export
4. click on pdf file to download it

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7810 - C4/Auth.pm - on plack restart session is undefined
Dobrica Pavlinusic [Fri, 23 Mar 2012 08:54:25 +0000 (09:54 +0100)]
Bug 7810 - C4/Auth.pm - on plack restart session is undefined

So we shouldn't try to delete it. This produces application error
instead of redirection to login page.

I had similar problems with CGI, especially when session in browser
is still active, and one on filesystem or database is already expired.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Solved the problem when my Plack installation started acting up due to
stale cookies.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7444: Update circ/circulation.pl to use KohaDates TT Plugin
Ian Walls [Fri, 9 Mar 2012 18:55:38 +0000 (13:55 -0500)]
Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin

Removes all date formatting done in circ/circulation, and sets any/all date
outputs to iso format.  The formatting of dates is now handled in the template
using the KohaDates plugin.

This allows use to remove a dependency on C4/Dates.pm from the script.

This patch also removes the usage of C4/Overdues/CheckBorrowerDebarred.  Since
borrowers.debarred is returned by GetMemberDetails, it doesn't make sense to
include another module to run another MySQL query just to fetch the date again.

To Test:

1. View the checkout page for a patron with materials checked out today and in days past, as
well as items on reserve.
2. View a patron who is nearing their expiry date
3. Renew a patron
4. Renew a material from the checkout page using the renewal date selector
5. Attempt to checkout a book to a patron that is on hold for someone else
6. Attempt to checkout a book that is currently checked out
7. View a debarred patron

In all cases, any dates displayed should be in syspref format

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7941 : Module versions bumped pre release
Chris Cormack [Thu, 14 Jun 2012 07:19:50 +0000 (19:19 +1200)]
Bug 7941 : Module versions bumped pre release

12 years agoBug 7941 : Fix version numbers in modules
Chris Cormack [Tue, 10 Apr 2012 23:02:48 +0000 (11:02 +1200)]
Bug 7941 : Fix version numbers in modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Conflicts:

C4/Members.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html
Owen Leonard [Mon, 4 Jun 2012 19:23:30 +0000 (15:23 -0400)]
Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html

Implementing fix as suggested by Chris Cormack:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8201: Receive date not passed through correctly
Katrin Fischer [Sun, 10 Jun 2012 09:54:59 +0000 (10:54 +0100)]
Bug 8201: Receive date not passed through correctly

All orders were received with today's date instead of the receive date
given with the invoice number.

To test:
1) Add an order with a few order lines
2) Create a new invoice, receive date != today's date
3) Start receiving orders, check date on receive screens is correct

Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 4838 Fix repeated authorities selection
Frédéric Demians [Tue, 5 Jun 2012 10:06:23 +0000 (12:06 +0200)]
Bug 4838 Fix repeated authorities selection

How to test:

Create an authority, with more than one heading, for example a
UNIMARC multilingual author:

  200 $7 da
      $a 原
      $b 純輔
  200 $7 ba
      $a Hara
      $b Junsuke

In data entry form, on 700 field, you click on ... Search for the above author.
In auhtority search result page, you just have a 'Choose' link, and so you just
can select the first heading (in Chinesse writing).

Apply the patch. Repeat. Now you have, on result page, you have two links, and
can select one heading or the other.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8166 - Adding new currencies & exchange rates
Amit Gupta [Wed, 30 May 2012 07:07:33 +0000 (12:37 +0530)]
Bug 8166 - Adding new currencies & exchange rates

if not fill any field it save blank record

To Test:
1) Go to Currencies & Exchange rates.
2) Create New currency
3) If you not fill any field for ex: (Currency, rate, symbol)
   it will not save the record.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoFixing tabs in docs/history.txt
Chris Cormack [Thu, 14 Jun 2012 06:39:53 +0000 (18:39 +1200)]
Fixing tabs in docs/history.txt

NOTE: This is a tab separated file, please do not switch tabs for
spaces

12 years agoAdding Shari Perkins as contributor
Paul Poulain [Sun, 10 Jun 2012 11:56:26 +0000 (13:56 +0200)]
Adding Shari Perkins as contributor

(she submitted some patches for online help)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7815 : Order pickup libraries list by name rather than by code
Sophie Meynieux [Fri, 23 Mar 2012 14:02:22 +0000 (15:02 +0100)]
Bug 7815 : Order pickup libraries list by name rather than by code

Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8178 - circ/circulation.pl under plack duplicates checkout rows
Dobrica Pavlinusic [Fri, 1 Jun 2012 13:22:30 +0000 (15:22 +0200)]
Bug 8178 - circ/circulation.pl under plack duplicates checkout rows

Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)

This also fixes %renew_failed initialization on each request.

Test scenario:
1. start intranet under plack
2. open /cgi-bin/koha/circ/circulation.pl and reload page few time
   confirming that rows gets duplicated
3. apply patch and reload page to verify that it works

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoUpdating template for release notes
Chris Cormack [Tue, 12 Jun 2012 07:53:12 +0000 (19:53 +1200)]
Updating template for release notes

12 years agoBug 8217:[SIGNED-OFF] Focus on search box in staff detail page
Adrien Saurat [Sat, 9 Jun 2012 10:43:56 +0000 (11:43 +0100)]
Bug 8217:[SIGNED-OFF] Focus on search box in staff detail page

Signed-off-by: Marc Veron <veron@veron.ch>
Works exactly as expected.
Adds onload="document.getElementById('search-form').focus() to HTMP body.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8009: Followup Item descriptive data not populated on pay.pl
Jonathan Druart [Tue, 15 May 2012 14:29:46 +0000 (16:29 +0200)]
Bug 8009: Followup Item descriptive data not populated on pay.pl

Separation of title from the description.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8009: Item descriptive data not populated on pay.pl
D Ruth Bavousett [Wed, 25 Apr 2012 13:06:31 +0000 (06:06 -0700)]
Bug 8009: Item descriptive data not populated on pay.pl

GetBorNotifyAcctRecord was not populating the {title} element of the
hash, which pay.tt will use.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8139 - add margin to recent comments CSS to fix stuff with menus
Robin Sheat [Wed, 23 May 2012 05:24:21 +0000 (17:24 +1200)]
Bug 8139 - add margin to recent comments CSS to fix stuff with menus

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Simple CSS change, fixes the problem with left navigation
overlapping list of recent comments on small screens in OPAC.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8005 - Lost item is not anonymized when checked in
Kyle M Hall [Wed, 25 Apr 2012 12:33:21 +0000 (08:33 -0400)]
Bug 8005 - Lost item is not anonymized when checked in

This bug is caused by the subroutine C4::Circulation::LostItem
not passing the privacy parameter when calling
C4::Circulation::MarkIssueReturned.

This issue is actually anonymized when the item is marked as lost,
not when the item is checked in.

Note, even if the issue is anonymized, the fine charged for lost
items still contains a description of the lost item, which is
required for the ability to forgive fees for lost items that
are later found.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8184 - Duplicate budget page lacks heading and breadcrumbs
Owen Leonard [Tue, 5 Jun 2012 16:54:52 +0000 (12:54 -0400)]
Bug 8184 - Duplicate budget page lacks heading and breadcrumbs

Adding title, heading, and breadcrumbs for "duplicate a budget"
operation. Also:
  - adding cancel link for duplicate and edit
  - correcting the CSS so that the "edit" menu button
    is styled like an edit button.
operations.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8197 : Software error when you have cleaned cookies and try to past the url to...
christophe croullebois [Wed, 6 Jun 2012 13:14:15 +0000 (15:14 +0200)]
Bug 8197 : Software error when you have cleaned cookies and try to past the url to opac-topissues.pl

Try to delete cookies and paste the url to opac-topissues.pl.
Without the patch we have a Software error.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBUG5312 XHTML correction in authority summary
Fridolyn SOMERS [Mon, 22 Aug 2011 13:14:24 +0000 (15:14 +0200)]
BUG5312 XHTML correction in authority summary

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7872 - C4::Items::GetItemsInfo should use C4::Koha instead of SQL queries directly
Dobrica Pavlinusic [Thu, 5 Apr 2012 13:41:29 +0000 (15:41 +0200)]
Bug 7872 - C4::Items::GetItemsInfo should use C4::Koha instead of SQL queries directly

This simplifies code, and has nice side-effect that memoize of
C4::Koha functions will be more effective.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7586 - Search: Language restriction does NOT show expected results (no items...
Marc Veron [Fri, 8 Jun 2012 11:40:31 +0000 (13:40 +0200)]
Bug 7586 - Search: Language restriction does NOT show expected results (no items shown)

modified:   etc/zebradb/marc_defs/marc21/biblios/record.abs

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'origin/new/bug_7936'
Paul Poulain [Sun, 10 Jun 2012 08:41:34 +0000 (10:41 +0200)]
Merge remote-tracking branch 'origin/new/bug_7936'

12 years agoBug 8062 [SIGNED-OFF] Perl module dependency Template::Plugin::HtmlToText
Frédéric Demians [Mon, 4 Jun 2012 08:06:22 +0000 (10:06 +0200)]
Bug 8062 [SIGNED-OFF] Perl module dependency Template::Plugin::HtmlToText

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8062 [SIGNED-OFF] Cart email broken for non english templates
Frédéric Demians [Mon, 14 May 2012 07:57:50 +0000 (09:57 +0200)]
Bug 8062 [SIGNED-OFF] Cart email broken for non english templates

Fix basket email sent from OPAC. The email body is now generated HTML
(to be translatable), and converted into TEXT before beeing sent by
email.

To test that it works in other language than English, you have to update
your language .po file:

  perl translate update de-DE

Then, translated strings coming from opac-sendbasket.tt, and install the
translation:

  perl translate install de-DE

New dependency: Template::Plugin::HtmlToText

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBumping database version
Chris Cormack [Sun, 10 Jun 2012 10:01:05 +0000 (22:01 +1200)]
Bumping database version

12 years agoBug 7951 - Suspending holds needs a system preference
Kyle M Hall [Fri, 13 Apr 2012 15:12:29 +0000 (11:12 -0400)]
Bug 7951 - Suspending holds needs a system preference

Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Conflicts:

installer/data/mysql/sysprefs.sql

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6267: [SIGNED-OFF]Fix a typo
Frédéric Demians [Fri, 25 May 2012 06:10:19 +0000 (08:10 +0200)]
Bug 6267: [SIGNED-OFF]Fix a typo

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8119 - Followup Show hint when disabling active currency checkbox
Jonathan Druart [Tue, 22 May 2012 09:31:32 +0000 (11:31 +0200)]
Bug 8119 - Followup Show hint when disabling active currency checkbox

Display the message on editing

Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8119 - Show hint when disabling active currency checkbox
Owen Leonard [Fri, 18 May 2012 13:19:34 +0000 (09:19 -0400)]
Bug 8119 - Show hint when disabling active currency checkbox

Display a hint when the exchange rate != 1.0: "The active currency
must have a rate of 1.0"

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Shari Perkins <dear.shari+koha@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8195: Selected link must be bold (in admin and tools)
Jonathan Druart [Wed, 6 Jun 2012 08:18:01 +0000 (10:18 +0200)]
Bug 8195: Selected link must be bold (in admin and tools)

For several links, the selected entry is not bold, try with these pages:

admin/smart-rules.pl
admin/biblio_framework.pl
tools/export.pl

This patch fixes this behaviour

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agobug_8138: added 773$t field to search results
Srdjan [Mon, 28 May 2012 00:12:34 +0000 (12:12 +1200)]
bug_8138: added 773$t field to search results

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Colin Campbell [Fri, 1 Jun 2012 07:10:21 +0000 (08:10 +0100)]
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere

warnings in log because of undefined value in
string concatenation
variable should be initialized to empty string rather
than left undefined

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Removes a warning in logs

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8161 - Cataloging home page should be accessible to users with permission to...
Owen Leonard [Fri, 18 May 2012 14:46:01 +0000 (10:46 -0400)]
Bug 8161 - Cataloging home page should be accessible to users with permission to edit catalog or edit items

This patch modifies the permissions required to access the cataloging
home page (addbooks.pl) so that the user requires edit_catalogue,
edit_items, or fast_cataloging permission.

Users with only edit_catalogue permission will only see biblio edit
links. Users with edit_items permission will only see item edit
links. Users with fast_cataloging permission will only be able to
view information about contents of the catalog--useless for them
but I'm not sure how better to handle it.

To test, log in as a user with each of the above permissions
enabled separately and in combination and test access.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 3638 : Captured Holds may need to generate a transfer
Colin Campbell [Thu, 18 Aug 2011 15:48:44 +0000 (16:48 +0100)]
Bug 3638 : Captured Holds may need to generate a transfer

If a discharged item is captured for a hold at another branch
the selfcheck should generate a branchtransfer for it.
This was complicated as the checkin routine was setting its own
location from a field not set in many scm machines (e.g. 3M)
also in ILS::Transaction the test for location was incorrect
assuming that an empty string or undefined was a valid location

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 3638 Self Check Should Capture Hold Items
Colin Campbell [Mon, 4 Jul 2011 15:44:16 +0000 (16:44 +0100)]
Bug 3638 Self Check Should Capture Hold Items

Shelf Check was receiving messages saying item was wanted
for a hold but the item was discharged to the shelf
not associated with the hold or transited to
the pickup location. The message was also being sent
on discharge of items when a suitable item had already
been captured.
Checkin now associates the item with the hold and sets
the appropriate data for a correct checkin response

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5327 : Fix for XISBN test, thingisbn is now handing back different results
Chris Cormack [Fri, 1 Jun 2012 22:29:52 +0000 (10:29 +1200)]
Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results

12 years agoBug 8182 follow-up, fixing BLO typo mistake
Paul Poulain [Tue, 5 Jun 2012 14:22:30 +0000 (16:22 +0200)]
Bug 8182 follow-up, fixing BLO typo mistake

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8182 - Problem with overdue fine calculations after upgrade
Kyle M Hall [Fri, 1 Jun 2012 18:30:05 +0000 (14:30 -0400)]
Bug 8182 - Problem with overdue fine calculations after upgrade

Items that were overdue and still out as of 5/26 (date of Upgrade) were charged
overdue fines as of 5/26.  When the items DO come back, the overdue fines are
calculated again from the due date to the date of checkin.  Therefore the
patron is being charged double overdue fines from the original date up to 5/26.

This is caused by issues.date_due being changed to a datetime, with the
hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead.

This is an unusual patch as it modifies a previous database update. This
make sense because if a install has already been updated past the db rev
update, this fix will be too late. It will only help those that have not
updated past that db revision.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8160 - Link to cataloging appears for users without cataloging permission
Owen Leonard [Tue, 29 May 2012 15:30:28 +0000 (11:30 -0400)]
Bug 8160 - Link to cataloging appears for users without cataloging permission

This patch wraps cataloging links on the staff client home
page and in the header menu with checks for edit_catalogue
OR edit_items permission.

To test, access the staff client as a user with various
permissions. The "cataloging" link on the main page and
in the header menu should only appear to a user with
edit_catalogue permission, edit_items permission, or both.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8082: Fixing circulation.pref to match reality for IssuingInProcess
Chris Cormack [Mon, 14 May 2012 01:48:53 +0000 (13:48 +1200)]
Bug 8082: Fixing circulation.pref to match reality for IssuingInProcess

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, changes are as advertised.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoWelcome to Piotr Kowalski, that is 183th
Paul Poulain [Tue, 5 Jun 2012 13:54:50 +0000 (15:54 +0200)]
Welcome to Piotr Kowalski, that is 183th

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8116 : Fixing warn in error log
Piotr Kowalski [Mon, 28 May 2012 09:50:49 +0000 (21:50 +1200)]
Bug 8116 : Fixing warn in error log

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8111 - Language chooser display problem in self-checkout
Owen Leonard [Wed, 16 May 2012 16:44:56 +0000 (12:44 -0400)]
Bug 8111 - Language chooser display problem in self-checkout

- Adds required JavaScript and JavaScript linked files
- Updates CSS with changes relevant to this feature which had
  been made to the main CSS file.
- Removes an image file which has been made obsolete now that
  sco.css uses the main image sprite like opac.css does.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7847: OPAC search dies with Plack
Jared Camins-Esakov [Mon, 28 May 2012 23:27:45 +0000 (19:27 -0400)]
Bug 7847: OPAC search dies with Plack

Due to a dependency cycle between C4::Search and C4::Items, searches
in the OPAC die spectacularly under Plack. This counter-patch extends
dpavlin's solution and replaces use with require for C4::Search in
C4::Items and for C4::Items in C4::Search.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings
Owen Leonard [Tue, 22 May 2012 18:42:42 +0000 (14:42 -0400)]
Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings

To simplify the sentence structure for better translation flexibility
the message now reads:

"Item in your cart: " + number

Fixed in both OPAC and staff client, although I'm not sure
the message is actually triggered in the staff client.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Strings become translatable

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8129 - Quickslips not printing
Liz Rea [Tue, 29 May 2012 21:06:22 +0000 (16:06 -0500)]
Bug 8129 - Quickslips not printing

Implemented from the suggestions attached to the bug.

To test:
Check out a book to a patron
Click print -> quick slip

Slip should show only today's checkouts.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>