]> git.koha-community.org Git - koha.git/log
koha.git
15 years agobug 3222: fix Safari display of patron category preferences
Galen Charlton [Wed, 20 May 2009 16:35:57 +0000 (11:35 -0500)]
bug 3222: fix Safari display of patron category preferences

[LL bug 454]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: tweak sending of hold filled notification
Galen Charlton [Wed, 20 May 2009 16:35:56 +0000 (11:35 -0500)]
bug 3222: tweak sending of hold filled notification

Send a hold filled notification only when the item
is (assumed) to enter the hold shelf, i.e., when
the request status (reserves.found) is set to 'W'.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: moved messaging preference editing
Galen Charlton [Wed, 20 May 2009 16:35:55 +0000 (11:35 -0500)]
bug 3222: moved messaging preference editing

The display and editing of messaging preferences
for a patron have been moved as follows:

* the prefs for a patron are now displayed on the
  patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
  record, not on the messaging tab.

The messaging tab now contains only the list of
messages that have been or will be sent to the patron.

When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron.  If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.

Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.

Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: set messaging preferences during patron import
Galen Charlton [Wed, 20 May 2009 16:35:54 +0000 (11:35 -0500)]
bug 3222: set messaging preferences during patron import

If the EnhancedMessagingPreferences option is ON, when
creating a new patron record via the patron import, set
the default messaging preferences to the applicable values
the default preferences for the patron category.

Messaging preferences are currently changed only when
*adding* a patron record via the import; if the import
updates an existing record, the patron's existing
preferences are not changed.

API changes:

SetMessagingPreferencesFromDefaults() is a new function
in C4::Members::Messaging to unconditionally replace
the current messaging preferences of a patron with the
default preferences from a specified patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: messaging preferences for patron categories
Galen Charlton [Wed, 20 May 2009 16:35:53 +0000 (11:35 -0500)]
bug 3222: messaging preferences for patron categories

Add the ability to set the default circulation messages preferences
for a patron category.  When the EnhancedMessagingPreferences
syspref is ON, the administrator will be able to define
default patron messaging preferences for a patron category.  When
a new patron record is created (either manually or via a patron
import), the new patron's preferences will be copied from the default
for that patron's category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: new module to handle messaging preferences form
Galen Charlton [Wed, 20 May 2009 16:35:52 +0000 (11:35 -0500)]
bug 3222: new module to handle messaging preferences form

Define and use a new module, C4::Form::MessagingPreferences,
to handle displaying and processing the messaging preferences
form.  This change reduces code duplication between OPAC
and staff.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: changes to messaging preferences form
Galen Charlton [Wed, 20 May 2009 16:35:51 +0000 (11:35 -0500)]
bug 3222: changes to messaging preferences form

Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: C4::Members::Messaging changes
Galen Charlton [Wed, 20 May 2009 16:35:50 +0000 (11:35 -0500)]
bug 3222: C4::Members::Messaging changes

Updated GetMessagingPreferences() and SetMessagingPreferences()
in this module to allow a categorycode to be passed
instead of a borrowernumber, permitting default preferences
for a patron category to be stored.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3222: database changes for messaging preferences (DB rev 033)
Galen Charlton [Wed, 20 May 2009 16:35:49 +0000 (11:35 -0500)]
bug 3222: database changes for messaging preferences (DB rev 033)

This patch modifies the database for the messaging
preferences enhancement <http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_defaultmessagingsettings>
as follows:

* adds a categorycode column to borrower_message_preferences

This allows a set of messaging preferences to be linked
to a patron category

* allow the borrowernumber column to be null

This allows a messaging preference set to be linked
*only* to a patron category.  If MySQL had check
constraints, I would add one so that exactly
one of borrowernumber and categorycode in a row in
borrower_message_preferences could be NULL.

* add a FK constraint from borrower_message_preferences.categorycode
to categories; if you delete a patron category, any default preferences
associated with it will be automatically deleted.

The messaging preference enhancement was sponsored by the Northeast
Kansas Library System (NEKLS).

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3243: fix adding patron after resorting in patron label search
Galen Charlton [Fri, 22 May 2009 14:18:37 +0000 (09:18 -0500)]
bug 3243: fix adding patron after resorting in patron label search

Also needed to keep track of the batch type.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3243: pcard-members-search fails to add patrons to batch after using some links
MJ Ray [Thu, 21 May 2009 14:27:19 +0000 (15:27 +0100)]
bug 3243: pcard-members-search fails to add patrons to batch after using some links

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd patron card member searching by category code
MJ Ray [Fri, 22 May 2009 13:53:13 +0000 (14:53 +0100)]
Add patron card member searching by category code

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3239 - Content-Script-Type and Content-Style-Type
Joe Atzberger [Fri, 22 May 2009 01:37:46 +0000 (20:37 -0500)]
Bug 3239 - Content-Script-Type and Content-Style-Type

This adds headers to define the default script and style languages.
Please note that this output isn't 100% canonical from CGI yet, but
that is due to a bug in CGI:
  http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3243

So either CGI will perfect it's output, or we can switch to using
HTTP::Headers.  The latter may be desirable anyway, since then we
would not need a CGI $query argument at all.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to previous patch - don't use TMPL_IF EXPR
Galen Charlton [Fri, 22 May 2009 12:41:22 +0000 (07:41 -0500)]
followup to previous patch - don't use TMPL_IF EXPR

Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:

non-initialized variable new_subfield

For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago =?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure
Andrei V. Toutoukine [Fri, 22 May 2009 11:53:29 +0000 (15:53 +0400)]
 =?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2001, 2432: improve unAPI implementation
Galen Charlton [Fri, 22 May 2009 00:10:50 +0000 (19:10 -0500)]
bug 2001, 2432: improve unAPI implementation

Improves Koha's unAPI support as follows:

* The implementation no longer depends on there being
  an accessible Zebra or SRW server.  Instead, responses
  are created by running the bib MARCXML through local
  stylesheets.
* unAPI now works for all bibs, not just ones that have
  an ISBN.  The ID format is changed from koha:isbn:ISBN
  to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
  http://validator.unapi.info/ .
* MODS3 support now works correctly.  As a consequence, this
  patch fixes bug 2432 (Zotero support when using the XSLT
  OPAC stylesheets).

TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circ/billing.pl
Joe Atzberger [Fri, 22 May 2009 01:37:49 +0000 (20:37 -0500)]
Cleanup circ/billing.pl

Remove ton of unused variables.
Remove wrong use of BiblioDefaultView on INTRANET side.
Consolidate failover values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup circ/stats.pl
Joe Atzberger [Fri, 22 May 2009 01:37:47 +0000 (20:37 -0500)]
Cleanup circ/stats.pl

Use elsif and else.  FIXME's added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup C4/Stats.pm
Joe Atzberger [Fri, 22 May 2009 01:37:48 +0000 (20:37 -0500)]
Cleanup C4/Stats.pm

Use C4::Debug.  Remove $sth->finish and an unconditional warn.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a new committer to the history docs
Chris Cormack [Fri, 22 May 2009 00:11:10 +0000 (12:11 +1200)]
Adding a new committer to the history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3245: advancedMARCeditor syspref not returning to cataloguing tab
Garry Collum [Thu, 21 May 2009 21:03:18 +0000 (17:03 -0400)]
Bug 3245: advancedMARCeditor syspref not returning to cataloguing tab

The advancedMARCeditor system preference was not returning to the cataloguing tab after you changed its value in system preferences.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated create_koc_db.pl to output SQlite2 files compatible with the Offline Circulat...
koha [Wed, 20 May 2009 15:36:00 +0000 (15:36 +0000)]
Updated create_koc_db.pl to output SQlite2 files compatible with the Offline Circulation system, rather than the SQlite3 files that required post-processing.

[RM Note: patch by Kyle Hall <kyle.m.hall@gmail.com>]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agooffline_circ must use SQLite v2 - because Kyles PHP does
Michael Hafen [Tue, 5 May 2009 22:56:30 +0000 (16:56 -0600)]
offline_circ must use SQLite v2 - because Kyles PHP does

The Offline Circ tool by Kyle Hall uses PHP's SQLite, which is SQLite
v2.  Gnope, which Kyle links, ships with libSQLite v2.

Let's not count on libsqlite3 not being installed for perl.  If it is
installed DBD::SQLite will use it, where DBD::SQLite2 will not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to patch by Galen - add javascript to prevent premature submission of forms...
Michael Hafen [Thu, 13 Nov 2008 23:19:05 +0000 (16:19 -0700)]
followup to patch by Galen - add javascript to prevent premature submission of forms in Fines pages

Adds javascript to the manual invoice and manual credit pages to prevent
the premature submission of these forms when using a barcode scanner.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2897: fix English sample notices
Galen Charlton [Thu, 21 May 2009 20:03:57 +0000 (15:03 -0500)]
bug 2897: fix English sample notices

Same as Joe's prior 2897 patch, but applied to the English
sample_notices.sql - due to a Git merge and rename detection
oddity, his original submitted patch was applied to the French
sample_notices.sql.  Since the two files are
currently identical, no problem in the end.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2897 - sample notices include bogus values
Joe Atzberger [Thu, 12 Feb 2009 20:49:33 +0000 (14:49 -0600)]
Bug 2897 - sample notices include bogus values

items.content is invalid for anything but overdue notices.  It is
not processed by advance_notices.pl for DUE and PREDUE.  Also, the
odd greeting "Dear firstname title" is standardized to match the
other messages' "Dear firstname surname".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2726: updated doc to explain auth_by_bind option
Galen Charlton [Thu, 21 May 2009 19:26:02 +0000 (14:26 -0500)]
bug 2726: updated doc to explain auth_by_bind option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoin Auth_with_ldap.pm try binding with user password or compare
Michael Hafen [Wed, 29 Oct 2008 19:48:04 +0000 (13:48 -0600)]
in Auth_with_ldap.pm try binding with user password or compare

This changes the checkpw code in Auth_with_ldap.  Along with comparing
the user entered password against the directory attibute userPassword
you can try to bind with the users dn and password.

This is controlled by the option auth_by_bind, which, if set, causes
this code to try binding instead of comparing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoShow "no title", when a notice doesn't have a title
Nahuel ANGELINETTI [Thu, 11 Dec 2008 12:54:05 +0000 (13:54 +0100)]
Show "no title", when a notice doesn't have a title

This patch just check if there is a title, else show "No Title".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2287: use defaults when needed even if CSV has correct number of columns
MJ Ray [Thu, 21 May 2009 14:27:20 +0000 (15:27 +0100)]
bug 2287: use defaults when needed even if CSV has correct number of columns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoclean up redundant test
Galen Charlton [Thu, 21 May 2009 14:00:09 +0000 (09:00 -0500)]
clean up redundant test

Credit to Joe Atzberger for cathing this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3235) improve searchorder
Nahuel ANGELINETTI [Tue, 19 May 2009 11:54:50 +0000 (13:54 +0200)]
(bug #3235) improve searchorder

If an supplierid is provided with a ordernumber, the search should be able to return everytime a record. This patch do the job.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3149) fix searchorder
Nahuel ANGELINETTI [Tue, 19 May 2009 09:53:50 +0000 (11:53 +0200)]
(bug #3149) fix searchorder

this patch fix the searchorder function, and add to the SQL query a "AND biblionumber" statement if a biblionumber is speficied.
Sometimes C4::Acquisitions::searchorder() find more than one result, so the user is looping to the same page to choose the great record, adding a contraint to biblionumber allows to be more strict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore cleanup on returns.pl
Joe Atzberger [Wed, 20 May 2009 16:56:26 +0000 (11:56 -0500)]
More cleanup on returns.pl

Removed unused variable.  Corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup and enhance bookcount.pl and .tmpl
Joe Atzberger [Wed, 20 May 2009 21:55:09 +0000 (16:55 -0500)]
Cleanup and enhance bookcount.pl and .tmpl

Eliminated bug with date handling outputting an English string.
Row striping added.  Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3120: tweak DDCN call number splitting for labels
Galen Charlton [Wed, 20 May 2009 16:20:20 +0000 (11:20 -0500)]
bug 3120: tweak DDCN call number splitting for labels

Allow a call number of the form MP3-CD F PARKER to be split as

MP3-CD
F
PARKER

instead of

MP
3
-CD
F
PARKER

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd onlymine helper function.
Joe Atzberger [Wed, 20 May 2009 19:39:03 +0000 (14:39 -0500)]
Add onlymine helper function.

This should allow scripts to use GetBranchesLoop without having to reproduce
the check for:
(1) IndependantBranches,
(2) User logged in,
(3) User Not superlibrarian, and
(4) User branch set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomore permissions fixes on uk-UA installer SQL files
Galen Charlton [Thu, 21 May 2009 12:46:34 +0000 (07:46 -0500)]
more permissions fixes on uk-UA installer SQL files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixed permissions on ru-RU and uk-UA installer SQL files
Galen Charlton [Thu, 21 May 2009 11:52:59 +0000 (06:52 -0500)]
fixed permissions on ru-RU and uk-UA installer SQL files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug: Importing sample data removes marcflavour variable (ru-RU)
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:24 +0000 (12:42 +0400)]
Bug: Importing sample data removes marcflavour variable (ru-RU)

modified:   installer/data/mysql/ru-RU/mandatory/system_preferences_optimal.sql

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoimport of the authorized values fails on the step 3 of the web-installation (ru-RU)
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:23 +0000 (12:42 +0400)]
import of the authorized values fails on the step 3 of the web-installation (ru-RU)

ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1

modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[DAMAGED].csv.sql
modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[LOST].csv.sql
modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[NOT_LOAN].csv.sql
modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[RESTRICTED].csv.sql
modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[STACK].csv.sql
modified:   installer/data/mysql/ru-RU/authorised_values/authorised_values_[WITHDRAWN].csv.sql

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3107. Creation of `permissions` table fails during the web-installation (ru-RU)
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:22 +0000 (12:42 +0400)]
Bug 3107. Creation of `permissions` table fails during the web-installation (ru-RU)

ERROR 1452 (23000) at line 3: Cannot add or update a child row: a foreign key constraint fails (`koha/permissions`,
CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON
UPDATE CASCADE)

renamed:    installer/data/mysql/ru-RU/mandatory/permissions.sql -> installer/data/mysql/ru-RU/mandatory/userpermissions.sql
renamed:    installer/data/mysql/ru-RU/mandatory/permissions.txt -> installer/data/mysql/ru-RU/mandatory/userpermissions.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRussian and Ukranian SQL files
Chris Cormack [Wed, 11 Feb 2009 08:24:19 +0000 (21:24 +1300)]
Russian and Ukranian SQL files
(cherry picked from commit af505046afd9fa20d299e002645bd6517e31a971)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup returns, consolidate some repeated logic.
Joe Atzberger [Tue, 19 May 2009 18:23:49 +0000 (13:23 -0500)]
Cleanup returns, consolidate some repeated logic.

Use one $userenv_branch instead of many calls to C4::Context->userenv->{'branch'}
for comparisons.  Script is not warnings safe yet, but getting closer.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBUG 2736 - added link for MARC country codes.
Nicole Engard [Mon, 18 May 2009 22:43:30 +0000 (17:43 -0500)]
BUG 2736 - added link for MARC country codes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3236: remove disused scripts and a function
Galen Charlton [Tue, 19 May 2009 12:22:42 +0000 (07:22 -0500)]
bug 3236: remove disused scripts and a function

Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files.  According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.

Also removed C4::Search::findseealso(), which was used
only by the two scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBUG #2736 Fix. Updated link to go to list of language codes.
Nicole Engard [Mon, 18 May 2009 21:42:33 +0000 (16:42 -0500)]
BUG #2736 Fix. Updated link to go to list of language codes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1768: Calendar now retains the month on which the user was entering data.
Garry Collum [Sun, 17 May 2009 22:20:05 +0000 (18:20 -0400)]
Bug 1768: Calendar now retains the month on which the user was entering data.

If a user adds or edits a holiday, the calendar will now return to the month in which the user was working.  Also after an add or an edit, if the user selects another location, the calendar remains in the same month for which the add or edit took place.  The user sees a 'calendardate' parameter in the URL in the format that is chosen as the system preference.  If an invalid date is entered in the url, the current date is used.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2736 fix. Updated link to go to LOC instead of itsmarc.com
Nicole Engard [Mon, 18 May 2009 20:32:15 +0000 (15:32 -0500)]
Bug 2736 fix. Updated link to go to LOC instead of itsmarc.com

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3102 Fix Part 2: Fixed terminology on Transfers to Receive.
Nicole Engard [Mon, 18 May 2009 20:49:02 +0000 (15:49 -0500)]
Bug 3102 Fix Part 2: Fixed terminology on Transfers to Receive.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix permissions on new icons
Galen Charlton [Sat, 16 May 2009 01:20:28 +0000 (20:20 -0500)]
fix permissions on new icons

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding 4 additional icons to the bridge set: Software, Audio, Journal, and Realia.
Owen Leonard [Sat, 16 May 2009 00:57:16 +0000 (19:57 -0500)]
Adding 4 additional icons to the bridge set: Software, Audio, Journal, and Realia.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1448: improve subject classification browser
Galen Charlton [Fri, 15 May 2009 14:40:00 +0000 (09:40 -0500)]
bug 1448: improve subject classification browser

* turn on warnings
* fix problem where the top level of the classification
  hiearchy wasn't displayed, instead pointing to
  the link to the Wiki page with instructions on
  how to set up the feature.
* fix XHTML validation errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoquell warning if format parameter isn't passed to opac-search.pl
Galen Charlton [Fri, 15 May 2009 15:53:42 +0000 (10:53 -0500)]
quell warning if format parameter isn't passed to opac-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix undefined variable warnings when using Syndetics
Galen Charlton [Fri, 15 May 2009 16:02:10 +0000 (11:02 -0500)]
fix undefined variable warnings when using Syndetics

Also consolidate duplicate code to a new routine,
_fetch_syndetics_content()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevisions to auto-generated authorities patch
Brian Harrington [Wed, 29 Apr 2009 17:37:06 +0000 (13:37 -0400)]
Revisions to auto-generated authorities patch

It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag
and move it and the leader set to earlier in the process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix XHTML errors in z3950_search.tmpl
Galen Charlton [Fri, 15 May 2009 14:59:49 +0000 (09:59 -0500)]
fix XHTML errors in z3950_search.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoImprove XSLT.pm performances
Frédéric Demians [Fri, 15 May 2009 08:26:33 +0000 (10:26 +0200)]
Improve XSLT.pm performances

This patch is done in the process of understanding what's
going wrong with bug #3226. It improves some processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1440: Show a list of holidays. Fix for the date formats.
Garry Collum [Fri, 15 May 2009 11:37:50 +0000 (07:37 -0400)]
Bug 1440: Show a list of holidays. Fix for the date formats.

This patch fixes the date formats in the holiday display tables.  They are now based on the syspref for date formats.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBUG #1277 Enhance: Z39.50 More search criteria
Darrell Ulm [Fri, 15 May 2009 14:27:17 +0000 (10:27 -0400)]
BUG #1277 Enhance: Z39.50 More search criteria

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBUG 1277 Enhance: Z39.50 More search criteria
Darrell Ulm [Fri, 15 May 2009 14:27:16 +0000 (10:27 -0400)]
BUG 1277 Enhance: Z39.50 More search criteria

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded barcode query back to circ/ysearch.pl for patron proxies.
Daniel Sweeney [Wed, 25 Mar 2009 21:37:17 +0000 (16:37 -0500)]
Added barcode query back to circ/ysearch.pl for patron proxies.

This is to allow patron proxy relationships to be built using the patron barcode.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago@renew_failed can cause enormous performance-killing array.
Joe Atzberger [Thu, 14 May 2009 20:28:40 +0000 (15:28 -0500)]
@renew_failed can cause enormous performance-killing array.

The array was populated and values flagged with an accessor, like:
    for (@failedrenews) { $renew_failed[$_] = 1; }
But this means that an array of possibly hundreds of thousands of elements
would have to be auto-populated for high itemnumbers.  A hash is the correct
structure.  We also haven't checked the user input for validity, so we do not know
for sure that @failedrenews really does contain just itemnumbers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoupdated JSON and JSON::XS package reqs for Debian lenny
Galen Charlton [Thu, 14 May 2009 12:53:33 +0000 (07:53 -0500)]
updated JSON and JSON::XS package reqs for Debian lenny

By default, the JSON module will automatically use
JSON::XS if available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix small POD error
Galen Charlton [Thu, 14 May 2009 12:33:36 +0000 (07:33 -0500)]
fix small POD error

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew framework for AJAX services
Pianohacker [Sun, 5 Apr 2009 22:40:13 +0000 (17:40 -0500)]
New framework for AJAX services

This adds two new C4 modules, C4::Service and ::Output::JSONStream, and
makes important modifications to C4::Output. The first two are a basic
framework for JSON-based AJAX services and a simple JSON output wrapper,
respectively. C4::Output has been slightly refactored, with a new
function, output_with_http_headers, that supports different
content-types. output_html_with_http_headers still exists, and the three
pages affected by this change have been refactored to support it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)
Galen Charlton [Thu, 14 May 2009 00:37:17 +0000 (19:37 -0500)]
bug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)

Note: to completely apply this change, ensure that the working
copy of record.abs is updated and rebuild the bib indexes
using rebuild_zebra.pl -b -x -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1542, fixing filter by area in reports dictionary
Chris Cormack [Thu, 14 May 2009 06:46:56 +0000 (18:46 +1200)]
Bug 1542, fixing filter by area in reports dictionary

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3224 : inventory tool fails on DOS newlines
Ryan Higgins [Thu, 14 May 2009 07:46:45 +0000 (00:46 -0700)]
Bug 3224 : inventory tool fails on DOS newlines

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1440: Show a list of holidays. Second patch.
Garry Collum [Tue, 12 May 2009 20:53:15 +0000 (16:53 -0400)]
Bug 1440: Show a list of holidays. Second patch.

Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3169 - Comply with new Google Book branding guidelines
Frédéric Demians [Tue, 12 May 2009 12:28:27 +0000 (14:28 +0200)]
Bug 3169 - Comply with new Google Book branding guidelines

It adds pretty huge image 'Google Preview' on google
book jacket.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2505 adding use warnings and fixing warnings in opac-basket.pl
Chris Cormack [Tue, 12 May 2009 10:28:19 +0000 (22:28 +1200)]
Bug 2505 adding use warnings and fixing warnings in opac-basket.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWhoops extra } crept in when fixing a merge conflict, removing it
Chris Cormack [Tue, 12 May 2009 10:13:10 +0000 (22:13 +1200)]
Whoops extra } crept in when fixing a merge conflict, removing it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3079) show summary in opac results
Nahuel ANGELINETTI [Tue, 12 May 2009 09:09:49 +0000 (11:09 +0200)]
(bug #3079) show summary in opac results

This add the summary in opac search results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing more warnings
Chris Cormack [Tue, 12 May 2009 07:30:56 +0000 (19:30 +1200)]
Fixing more warnings

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1440: Show a list of holidays
Garry Collum [Tue, 12 May 2009 02:51:07 +0000 (22:51 -0400)]
Bug 1440: Show a list of holidays

This patch adds displays for holidays. A table for each type of holiday.  It could be improved by adding a link for a holiday listed in one of the tables to the edit panel.  The date formats could also be changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1907 partial fix: prevent warnings on undefined params.
Chris Catalfo [Tue, 12 May 2009 00:35:13 +0000 (00:35 +0000)]
Bug 1907 partial fix: prevent warnings on undefined params.

This patch adds default blank values for a couple of params the script might receive which were producing warns in the error log. Also wraps GetMarcBiblio in an eval.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoScript to check for corruption of marcxml, and optionally to attempt fix.
Joe Atzberger [Mon, 11 May 2009 21:44:29 +0000 (16:44 -0500)]
Script to check for corruption of marcxml, and optionally to attempt fix.

When marcxml cannot be parsed into a MARC::Record object, the biblio is
undisplayable and it obviously breaks many features in Koha.  This script
can test to parse every marcxml, and alert on failures.  Optionally, the
marcxml can be replaced from the marc field.

See extensive perldoc for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #1578) change the shelf COinS support
Nahuel ANGELINETTI [Fri, 9 Jan 2009 10:36:47 +0000 (11:36 +0100)]
(bug #1578) change the shelf COinS support

this change the old COinS support, and now use C4::Biblio::GetCOinSBiblio().

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd subtitle to COinS for MARC21
Galen Charlton [Tue, 12 May 2009 00:03:50 +0000 (19:03 -0500)]
add subtitle to COinS for MARC21

Preserves change added in the LTFL integration
while also switching to Nahuel's COinS implementation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #1578) fix a little error in code
Nahuel ANGELINETTI [Mon, 9 Mar 2009 13:34:27 +0000 (14:34 +0100)]
(bug #1578) fix a little error in code

This one, fix the use of "or" instead of "||", else a warning is raised.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #1578) Add the (quasi)full COinS(Zotero) support
Nahuel ANGELINETTI [Thu, 8 Jan 2009 10:41:57 +0000 (11:41 +0100)]
(bug #1578) Add the (quasi)full COinS(Zotero) support

this patch do a lot of things :
 * Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
   This will be usefull for OpenURL support.

 * Replace the span in opac-detail, and put the var get from GetCOinSBiblio
 * Fix an <img> tag that wasn't autoclosed
 * Add the COinS in search result
 * Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPrevent fines failure on NULL borrowernumber.
Joe Atzberger [Fri, 23 Jan 2009 22:22:40 +0000 (16:22 -0600)]
Prevent fines failure on NULL borrowernumber.

The problem is that we do not ensure that the issues table has valid
borrowernumber in each line.  This is exacerbated by Getoverdues()
returning data sorted BY borrowernumber.  So one NULL borrowernumber
in issues prevented ALL fines from being assessed.  The actual error
from fines.pl cron log is:
  No branchcode argument to new.  Should be C4::Calendar->new(branchcode => $branchcode)
  at /home/user/kohaclone/misc/cronjobs/fines.pl line 98

This patch deals only with getting fines to avoid crashing.  It does
not fix the underlying data integrity problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoexcised hard-coded reference to HLT
Galen Charlton [Mon, 11 May 2009 21:22:04 +0000 (16:22 -0500)]
excised hard-coded reference to HLT

Note to Chris Cormack: I suspect the current ability
to override most circulation conditions is sufficient,
but if HLT still needs to establish a patron category
that can ignore issuingimpossible limitations, needs
to be done in a more flexible way.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix references to $session in circ/circulation.pl
Galen Charlton [Mon, 11 May 2009 21:19:20 +0000 (16:19 -0500)]
fix references to $session in circ/circulation.pl

Now that sticky due date processing uses the session,
script will always need it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMake stickyduedate remember for session a little more permanent
Michael Hafen [Mon, 11 May 2009 20:52:35 +0000 (14:52 -0600)]
Make stickyduedate remember for session a little more permanent

Store the stickyduedate in the session.  So "Remember for Session" means
for session rather than "while on this page".

Includes some updates since initial submission of patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix to CanBookBeIssued()
Galen Charlton [Mon, 11 May 2009 21:10:37 +0000 (16:10 -0500)]
fix to CanBookBeIssued()

Bail out if item does not exist - otherwise
subsequent checks can fail for lack of an
item branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2770: add RenewalPeriodBase syspref for 3.2 (DB rev 032)
Galen Charlton [Mon, 11 May 2009 20:25:14 +0000 (15:25 -0500)]
bug 2770: add RenewalPeriodBase syspref for 3.2 (DB rev 032)

Reconciliation patch to add the RenewalPeriodBase system
preference, which per code by Nahuel Angelinetti changes
the process of calculating the due date after a renewal:

If RenewalPeriodBase is set to 'now', the due date is
set to the current date + the loan period.  This is the
current behavior.

If RenewalPeriodBase is set to 'date_due', the due date
is set to the due date before the renewal + the loan period.

Unless like the corresonding database update in the 3.0.x branch
(3.00.01.007), the default value of RenewalPeriodBase is set to
'now' so as not to unexpectedly change the calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix the previous patch to add a syspref that permit to choose the renewal period...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:04 +0000 (11:38 +0100)]
fix the previous patch to add a syspref that permit to choose the renewal period(day or date_due).

This patch just check the syspref and use it as base date of renew.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agochange the date calc, to set the date_due to date_due+loanlength.
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:03 +0000 (11:38 +0100)]
change the date calc, to set the date_due to date_due+loanlength.

At the moment when you renew a document the date_due calculated is now+loanlength, but it's a bad thing, It should be
date_due+loanlength.
This patch do change Circulation.pm to use the date_due as renew base and add the loanlength to get the new date_due after
renewal.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug # 3048 changed Descriptions label to Title Notes
brendan [Tue, 31 Mar 2009 23:20:52 +0000 (23:20 +0000)]
Bug # 3048 changed Descriptions label to Title Notes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 988 followup - tweak wording
Galen Charlton [Mon, 11 May 2009 19:26:23 +0000 (14:26 -0500)]
bug 988 followup - tweak wording

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #988
Paul Poulain [Sat, 18 Apr 2009 20:51:41 +0000 (22:51 +0200)]
fix for #988

When a borrower can't issue any book (issuingrules=0), the message should be
"this user can't issue book" and not "too many books already issued"wrong message

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd a date field in news edition, and permit to set the "timestamp" field, that is...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:00 +0000 (11:38 +0100)]
Add a date field in news edition, and permit to set the "timestamp" field, that is the publication date and modify the GetNewsToDisplay to return only news that timestamp is < to current date that permit to publish news later without any action.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2872: fix width of columns in branch_transfer_limits (DB rev 031)
Galen Charlton [Mon, 11 May 2009 17:22:46 +0000 (12:22 -0500)]
bug 2872: fix width of columns in branch_transfer_limits (DB rev 031)

change itemtype, tobranch, and frombranch from varchar(4)
to varchar(10)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agotweak removal of whitespace from barcodes
Galen Charlton [Mon, 11 May 2009 16:39:19 +0000 (11:39 -0500)]
tweak removal of whitespace from barcodes

Per suggestion from Joe Atzberger, match on \s
instead of [ \t] for stripping leading and
trailing whitespace from barcode lookups.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix to remove leading/trailing whitespace from entered barcode.
Mason James [Thu, 19 Mar 2009 22:52:26 +0000 (11:52 +1300)]
fix to remove leading/trailing whitespace from entered barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix stickyduedate more sticky - couple more forms in circulation.tmpl
Michael Hafen [Wed, 6 May 2009 22:15:08 +0000 (16:15 -0600)]
bugfix stickyduedate more sticky - couple more forms in circulation.tmpl

There are a couple more forms in circulation.tmpl that need the
stickyduedate and duedatespec hidden inputs.  The 'Don't Check Out' form
of the needsconfirmation block, and the findborrower form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix stickyduedate more sticky - also patron search in quick search block
Michael Hafen [Wed, 6 May 2009 22:34:47 +0000 (16:34 -0600)]
bugfix stickyduedate more sticky - also patron search in quick search block

Forgot about the patron search for check out form in the quick search
block

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd windows quote to ignored chars
Nahuel ANGELINETTI [Mon, 11 May 2009 14:51:46 +0000 (16:51 +0200)]
add windows quote to ignored chars

This patch add the CP1252 "quote" (’) in ignored chars in zebra configuration.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>