Galen Charlton [Fri, 15 May 2009 15:53:42 +0000 (10:53 -0500)]
quell warning if format parameter isn't passed to opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Daniel Sweeney [Wed, 25 Mar 2009 21:37:17 +0000 (16:37 -0500)]
Added barcode query back to circ/ysearch.pl for patron proxies.
This is to allow patron proxy relationships to be built using the patron barcode.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 14 May 2009 20:28:40 +0000 (15:28 -0500)]
@renew_failed can cause enormous performance-killing array.
The array was populated and values flagged with an accessor, like:
for (@failedrenews) { $renew_failed[$_] = 1; }
But this means that an array of possibly hundreds of thousands of elements
would have to be auto-populated for high itemnumbers. A hash is the correct
structure. We also haven't checked the user input for validity, so we do not know
for sure that @failedrenews really does contain just itemnumbers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 May 2009 12:53:33 +0000 (07:53 -0500)]
updated JSON and JSON::XS package reqs for Debian lenny
By default, the JSON module will automatically use
JSON::XS if available.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Tue, 12 May 2009 12:28:27 +0000 (14:28 +0200)]
Bug 3169 - Comply with new Google Book branding guidelines
It adds pretty huge image 'Google Preview' on google
book jacket.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Tue, 12 May 2009 10:13:10 +0000 (22:13 +1200)]
Whoops extra } crept in when fixing a merge conflict, removing it
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Catalfo [Tue, 12 May 2009 00:35:13 +0000 (00:35 +0000)]
Bug 1907 partial fix: prevent warnings on undefined params.
This patch adds default blank values for a couple of params the script might receive which were producing warns in the error log. Also wraps GetMarcBiblio in an eval.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 11 May 2009 21:44:29 +0000 (16:44 -0500)]
Script to check for corruption of marcxml, and optionally to attempt fix.
When marcxml cannot be parsed into a MARC::Record object, the biblio is
undisplayable and it obviously breaks many features in Koha. This script
can test to parse every marcxml, and alert on failures. Optionally, the
marcxml can be replaced from the marc field.
See extensive perldoc for details.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 8 May 2009 20:10:14 +0000 (15:10 -0500)]
bug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.
This patch also fixes the descriptions of the Leader/09
and Leader/17.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 8 May 2009 20:10:13 +0000 (15:10 -0500)]
bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Also made the following updates to the MARC21 leader plugin
[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 8 May 2009 22:31:14 +0000 (17:31 -0500)]
bug 3120: tweak splitting of Dewey call number
If a call number prefix contains a hyphen, try not to
split on the hyphen. For example, rather than
splitting the call number 'CD-ROM 787.87 EAS'
like this:
CD
-ROM
787.87
EAS
it should be
CD-ROM
787.87
EAS
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 11 May 2009 11:41:49 +0000 (13:41 +0200)]
Bug 3213 - UNIMARC/MARC21 selection
Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.
DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 5 May 2009 21:01:09 +0000 (15:01 -0600)]
Tweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL
Add the ofline_circ directory to Makefile.PL as needing to be installed.
Add calls to barcodedecode() on issueing and returning.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 1 May 2009 22:59:04 +0000 (17:59 -0500)]
fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sat, 5 Sep 2009 20:03:29 +0000 (08:03 +1200)]
Fix for opac-detail being broken after merging
Henri-Damien LAURENT [Sat, 5 Sep 2009 15:36:57 +0000 (17:36 +0200)]
Revert "followup previous patch - remove disused $opacstylesheet"
This reverts commit
59b8fd2383053698996ffd2f6d936d8fcb20ca76.
c4/Output would not compile
Nahuel ANGELINETTI [Wed, 5 Aug 2009 07:48:56 +0000 (09:48 +0200)]
(bug #3497) show publication year, or copyrightdate
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 31 Jul 2009 15:05:27 +0000 (17:05 +0200)]
(bug #3459) fix opac-topissue to take care of ccode
This bugfix, add a conditionnal sql request, that get the "ccode" document type if AdvancedSearchTypes is positionned to ccode.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 31 Jul 2009 13:58:53 +0000 (15:58 +0200)]
(bug #3458) fix die and unimarc 700-4 plugin
This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 21 Jul 2009 07:28:19 +0000 (09:28 +0200)]
(bug #3432) fix return of lost items
This patch delete some useless code, and fix the problem that if a lost item is returned, the lost flag is not deleted.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 10 Jul 2009 12:30:03 +0000 (14:30 +0200)]
(bug #3409) fix return rules for transfert
This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.
This add a little improvment that does not re-request each time the circcontrol syspref.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Matthias Meusburger [Thu, 3 Sep 2009 15:37:31 +0000 (17:37 +0200)]
Removing unused files from the serials module
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 2 Sep 2009 15:09:21 +0000 (17:09 +0200)]
(bug #3573) use delimiter syspref generating overdues csv
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Wed, 2 Sep 2009 13:30:12 +0000 (15:30 +0200)]
Adding autotruncation
Allow autotruncation to be set on its own
This simply reprocess operands in order to add * at lefthandside
It is a problem with non LTR scripts. But works fine with all the latin scripts
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 20 Aug 2009 14:36:41 +0000 (16:36 +0200)]
(bug #3541) show reserved items as not available
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 28 Aug 2009 13:19:26 +0000 (15:19 +0200)]
[3.0.x](bug #3242) send email when hold is placed
This add a new letter in database, and each time a new hold is placed, a new mail is enqueued.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Thu, 27 Aug 2009 11:16:01 +0000 (13:16 +0200)]
[3.0.x](bug #3560) This add a filter to search by itemtype
The value builder for 4XX should be able to filter results by itemtype.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Wed, 26 Aug 2009 13:26:56 +0000 (15:26 +0200)]
[3.0.x](bug #3555) This sets the default branch to the logged user branch when IndependantBranches is active
In the advanced search form, when IndependantBranches is activated, the default
branch should be set to the logged user branch.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Wed, 26 Aug 2009 08:31:51 +0000 (10:31 +0200)]
[3.0.x](bug #3552) This mark mandatory fields with a red asterisk
Many librarian ask for a way to know if a field is mandatory before validation.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 26 Aug 2009 14:52:27 +0000 (16:52 +0200)]
(bug #3557) fix bor_issues_top
Just add the condition where column is "None".
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 26 Aug 2009 11:18:50 +0000 (13:18 +0200)]
(bug #3553) do not allow users to create code-less frameworks
This patch, disallow the users to create frameworks without frameworkcode.
It adds some javascripts checks, and some perls checks(for non-javascript users).
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Tue, 25 Aug 2009 08:12:21 +0000 (10:12 +0200)]
[3.0.x](bug #3549) Sorted framework options in the dropdown menu
In addbook.pl, the framwork options are sorted in random order. They should be
sorted in alphabetical order of value or code.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 24 Aug 2009 11:56:15 +0000 (13:56 +0200)]
(bug #3546) fix issues_stats
This fix the order of columns.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 6 Aug 2009 08:03:25 +0000 (10:03 +0200)]
(bug #3512) fix acquisition reports and group by
This fix, just change a grep value that make different way to calculate the table depending on the choosen column and line.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 6 Aug 2009 13:06:08 +0000 (15:06 +0200)]
[followup](bug #3505) order collections by alphabetical order
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 5 Aug 2009 13:11:29 +0000 (15:11 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Fri, 14 Aug 2009 13:41:23 +0000 (15:41 +0200)]
Auto incremental inventory number plugin
Renamed it stocknumber.pl to avoid confusion with the already existing inventory.pl
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Thu, 6 Aug 2009 08:17:10 +0000 (10:17 +0200)]
This is a calatoguing plugin based on auth_finder but specific to one of our customers.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 29 Jul 2009 08:31:58 +0000 (10:31 +0200)]
(bug #3453) fix authority search in opac
this just set default values in opac search.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 24 Jul 2009 14:01:48 +0000 (16:01 +0200)]
(bug #2812) fix holds cancel in OPAC
This fix the user ability to cancel holds in OPAC.
At the moment, a user can cancel all his holds, but in fact, only items that are not in transfert or waiting to be checked out can be cancelled by the user.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 15 Jul 2009 09:58:05 +0000 (11:58 +0200)]
(bug #3421) fix the xhtml in serial biblio search
This fix differents errors, and escape in bib search.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 10 Jul 2009 14:49:59 +0000 (16:49 +0200)]
(bug #3412) fix double encoded guided report
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 7 Jul 2009 15:16:13 +0000 (17:16 +0200)]
(bug #3403) fix circulation.pl reservation list
This delete useless code that introduce the leak of reserved items informations.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 10 Jul 2009 10:16:18 +0000 (12:16 +0200)]
(bug #3411) escape authorities values
The values are not escaped in javascript, so if there is double quotes, the authority cannot be imported because of javascript error. This patch fix this.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jean-André Santoni [Thu, 23 Jul 2009 13:19:23 +0000 (15:19 +0200)]
This little hack makes BuildUnimarcHierarchy able to work with any 2.. field.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 6 Jul 2009 12:58:24 +0000 (14:58 +0200)]
(bug #3395) fix unimarc plugin 225$a
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 2 Jul 2009 10:30:05 +0000 (12:30 +0200)]
[followup](bug #3080) refix the sql request
This fix the sql request that have some problems of synthax and a table repeated in "FROM".
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sat, 22 Aug 2009 14:30:36 +0000 (10:30 -0400)]
BUG 3371: ISBN no longer shows twice when more options on
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sat, 22 Aug 2009 14:05:49 +0000 (10:05 -0400)]
BUG #3533: Fix documentation link in news for new installs
This patch only fixes the link for new installs, not for
updates.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Wed, 19 Aug 2009 01:31:03 +0000 (21:31 -0400)]
Cleaned up display on reports page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Tue, 18 Aug 2009 14:47:08 +0000 (09:47 -0500)]
Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Thu, 20 Aug 2009 10:12:57 +0000 (11:12 +0100)]
Avoid numeric comparisons with leading zeroes
Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Thu, 20 Aug 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3420: Revised follow-up patch for 'patrons with no checkouts'
Comments out all warnings that were used for debugging.
Enables warnigns and fixes the resulting warnings.
This patch replaces the previous follow-up patch for bug 3420.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Thu, 20 Aug 2009 22:07:08 +0000 (18:07 -0400)]
Bug 2889: Adds table highlighting to the Authority search results.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 20 Aug 2009 22:27:42 +0000 (10:27 +1200)]
Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Thu, 20 Aug 2009 23:32:18 +0000 (19:32 -0400)]
Bug 2505: Enables warnings in reserveratios.pl
Also fixes resulting warnings.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Mon, 17 Aug 2009 18:35:27 +0000 (20:35 +0200)]
Remove utility script replaced by a test case
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Mon, 17 Aug 2009 18:35:26 +0000 (20:35 +0200)]
Test case identifying incoherences between 'en' sysprefs and translated ones
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Mon, 17 Aug 2009 10:52:04 +0000 (22:52 +1200)]
Follow up patch for the about patch, changing management team to release team
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 15 Aug 2009 22:18:16 +0000 (10:18 +1200)]
Updating about page, some are bound to be missed, please send additional patches
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sat, 15 Aug 2009 13:50:24 +0000 (09:50 -0400)]
Bug 3420: Fixes 'Patrons with no checkouts' report.
Fixed typo in SQL statement. Commented out some unused SQL statements.
Removed limit for itemtype (column not available in results) and added limit for branchcode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 15 Aug 2009 13:45:38 +0000 (09:45 -0400)]
fixed glitch in display of current time filter in OPAC top issues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Mon, 31 Aug 2009 09:54:51 +0000 (11:54 +0200)]
Findgroupreserve update : Factorizing code
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Sun, 30 Aug 2009 20:28:29 +0000 (22:28 +0200)]
Fixing kohastructure.sql : some fields were duplicated
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sat, 15 Aug 2009 01:00:33 +0000 (20:00 -0500)]
Updated Help Files - Part 4
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Tue, 11 Aug 2009 16:43:02 +0000 (17:43 +0100)]
Bug 3522 Refactor Create Update Delete letter for consistency and readability
Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Tue, 11 Aug 2009 14:46:20 +0000 (10:46 -0400)]
bug 3520: fix crash when adding or editing items
Fix the following crash when adding or editing an
item record in the staff interface:
Can't call method "append_fields" on an undefined value at
/usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92.
at /usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92
This crash appears only if a version of MARC::File::XML
greater than 0.88 is installed, and was triggered by
C4::Biblio::TransformHtmlToXml() failing to create a valid
MARCXML blob, which must include a <record> element.
This patch also fixes the indicator values generated by
TransformHtmlToXml(), setting them to " " instead of
"" when no indicator value is supplied.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 10 Aug 2009 04:18:08 +0000 (00:18 -0400)]
bug 2157: add ability to 'clean' staged record batches
batches, it is now possible to 'clean' a batch by
removing all bib and item records staged in the batch. This
has the effect of helping to reduce database space used
by old import batches as well as removing staged records
from the cataloging reservoir search. Note that 'cleaning'
a batch affects only the copies of the records that were staged;
if the batch was committed, cleaning the batch does not
affect any bibs and items that were committed into the catalog.
Also note that once you clean a committed batch of records, it is
impossible to undo the previous commit operation.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 10 Aug 2009 04:18:07 +0000 (00:18 -0400)]
bug 2505: enable warnings in tools/manage-marc-import.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Mon, 10 Aug 2009 17:24:05 +0000 (11:24 -0600)]
bugfix opac-user stomps mylibraryfirst value in quick search label
the system preference mylibraryfirst is exported by Auth containing the logged
in users branchcode. It is also exported as the value of the syspref by
opac-user.pl. The effect is that when mylibraryfirst is on and the user
logged in the text label for the OPAC quick search instead of displaying
'Search (in [branchcode] only)' shows 'Search (in 1 only)'. Other user pages
are uneffected.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 9 Aug 2009 20:28:08 +0000 (16:28 -0400)]
Bug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.
Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl. Also enables zebra striping in opac-serial-issues.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 9 Aug 2009 21:37:36 +0000 (17:37 -0400)]
Bug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl
Enabled warnings and fixed unintialized variables in opac-alert-subscribe.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Thu, 23 Jul 2009 16:47:41 +0000 (18:47 +0200)]
_remove_stopwords in C4::Search had some issues
For some reason, it would not really do an exact match on stopwords but would also prune some other part of words
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 6 Aug 2009 15:11:24 +0000 (17:11 +0200)]
(bug #3513) fix xhtml in marc detail
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 9 Aug 2009 17:47:14 +0000 (13:47 -0400)]
Bug 2505: Enabled warnings in opac-serial-issues.pl and opac-showmarc.pl
Enabled warnings and also fixed resulting 'unintialized value' warning in opac-showmarc.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sat, 8 Aug 2009 16:01:10 +0000 (12:01 -0400)]
Bug 3450: RSS feed link for a tag search incorrect.
Adds the tag parameter to the RSS feed link if the results of a query are retrieved from a tag in opac.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sat, 8 Aug 2009 18:37:26 +0000 (14:37 -0400)]
Bug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_subject.pl.
Enabling warnings in these files did not generate any warnings in the logs when tested.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 5 Aug 2009 13:14:13 +0000 (15:14 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 4 Aug 2009 14:30:43 +0000 (16:30 +0200)]
(bugs #3502) search on available items in unimarc
this add a "w" index, that allow to search on available items only
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 1 Aug 2009 16:17:18 +0000 (12:17 -0400)]
bug 3465: enhance DB update reporting by web installer
This enhances the web installer so that messages from updatedatabase.pl will
be displayed to the user running a database update. Messages printed to STDOUT
will be displayed as the update report, while messages printed to STDERR will
be displayed as update errors.
This patch introduces a new module dependency, IPC::Cmd.
IPC::Cmd lets one run an external program such as updatedatabase.pl and easily
capture STDERR and STDOUT for further munging. IPC::Cmd is core in Perl 5.10
and stable in Perl 5.8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Sat, 1 Aug 2009 23:38:44 +0000 (19:38 -0400)]
Created database-tidying cron script
This little script establishes a framework for database cleanup on some regular
schedule. Initial implementation provides for brute truncation of the sessions
table, and selective-by-age cleanup of the zebraqueue.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Thu, 23 Jul 2009 03:53:00 +0000 (23:53 -0400)]
Bug 2889: Removed toggle variable from Serials vendor search.
Removed toggle variable from acqui-search-result.pl. Added highlighting using __odd__ to acqui-search-result.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Wed, 22 Jul 2009 17:07:30 +0000 (18:07 +0100)]
Stop generation of unnecessary warning messages to log over undef values
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Thu, 23 Jul 2009 11:20:07 +0000 (13:20 +0200)]
Installer break utf8 for DBD::mysql
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 29 Jul 2009 21:09:17 +0000 (17:09 -0400)]
Bug 1607: Fixes the delete checkboxes in purchase suggestions.
If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed
Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 8 Jul 2009 20:27:45 +0000 (15:27 -0500)]
Search.pm minor cleanup
Trying to move towards enabling warnings.
Add warn for unknown $query_type.
Use common $dbh.
push @array, ({key1=>value1...}); is the same as
push @array, {key1=>value1...};
if ( scalar(@$arrayref) > 0 ) is the same as
if (scalar @$arrayref)
Lines like:
my @operators = @$operators if $operators;
are bad because we need @operators to be declared and in scope later,
even if it is undef. Without $operators, the variable is not in scope.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 29 Jul 2009 00:49:58 +0000 (20:49 -0400)]
Bug 3452: Displays borrower category and adds links to Suggestions Management
A couple of enhancments to Suggestions Management.
Adds a display of the borrower category of the suggesting patron for each item.
Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 28 Jul 2009 14:08:41 +0000 (09:08 -0500)]
Change to layout of tag review interface (enhancement bug 3447)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Mon, 27 Jul 2009 13:28:21 +0000 (08:28 -0500)]
BUG 1255 Barred users will not see renew or renew all anymore
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
J. David Bavousett [Mon, 27 Jul 2009 12:15:37 +0000 (08:15 -0400)]
(Bug 3402) Serials issue name not escaped when passed forward to routing slip
The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation. It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Fri, 24 Jul 2009 01:25:43 +0000 (21:25 -0400)]
Bug 2935: Patch to fix location in routing slip.
routing-preview.pl and routing.pl were pointing to a non-existent column in the borrowers table. This patch replaces streetaddress with branchcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Wed, 22 Jul 2009 15:10:08 +0000 (16:10 +0100)]
Show claimed issues as 'Claimed' not just blank space
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 22 Jul 2009 15:23:15 +0000 (10:23 -0500)]
Fix POD for GetReservesFromBiblionumber
Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.
Fix POD for GetReservesFromBiblionumber
Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 22 Jul 2009 15:23:16 +0000 (10:23 -0500)]
Cleanup _Findgroupreserve.
Mostly formatting SELECT statement for readability. Also updated POD
and added a comment. This command:
git diff -w C4/Reserves.pm
shows only the POD and comment chnages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 17 Jun 2009 22:37:58 +0000 (17:37 -0500)]
Correct GetItemIssue to actually return undef if item not checked out.
Updated POD for correctness.
Replaced strftime + regexp w/ C4::Dates->today.
Also removed some sth->finish statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Sat, 20 Jun 2009 00:32:46 +0000 (19:32 -0500)]
Give Overdues a few whacks with perltidy
This was, an in part still is, some of the worst-formatted code in Koha.
Also made a few minor changes:
~ removing sth->finish
~ adding comment
~ removed whitespace error trailing spaces
~ use trinary op, like: return ( $debarredstatus eq '1' ? 1 : 0 );
Note that the logic is the same, even where I condsider it faulty.
(In the exampe case, because $debarredstatus may be undef.)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Tue, 21 Jul 2009 10:59:09 +0000 (11:59 +0100)]
Explicitly set _find_value's return to a string if not defined
Avoids generating a slew of warnings in the log when the undefined
value was concatenated or used in regexps
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 22 Jul 2009 00:36:15 +0000 (20:36 -0400)]
Bug 2553: Alphabetization of branches in the catalogue stats report.
Improvement on previous patch by using GetBranchesLoop.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 22 Jul 2009 00:46:10 +0000 (20:46 -0400)]
Bug 2553: Alphabetization of branches in Checkout Statistics form.
Improvement of previous patch through the use of GetBranchLoop.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 15 Jul 2009 02:16:27 +0000 (22:16 -0400)]
Bug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.
Copies the logic of catalogue/search.pl to fix the expanded search option in opac. When expanded search is the default, it was impossible to go to the "fewer" options.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>