]> git.koha-community.org Git - koha.git/log
koha.git
11 years agoBug 9052 - followup: fix the YUI CSS locations for SCO
Robin Sheat [Tue, 18 Dec 2012 04:48:46 +0000 (17:48 +1300)]
Bug 9052 - followup: fix the YUI CSS locations for SCO

This is followup to the previous YUI-fixing patch, and simply causes the
self-checkout page to load the YUI files via the sco CSS file,
and that gets re-written at package build time to work.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested on a package installation using packages built by
Mirko Tietgen and a git dev installation.

To test:
1) Enable WebBasedSelfCheck system preference
2) Enter login date for staff user in AutoSelfCheckAllowed... prefernces
3) Go to the self checkout page:
   .../cgi-bin/koha/sco/sco-main.pl
4) Verify all pages have the usual look, CSS, Javascript and images
   look normal
5) Verify the same is true for translated templates

Manual: http://manual.koha-community.org/3.10/en/selfcheckout.html
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9052 - rewrite the YUI links to use the system library
Robin Sheat [Fri, 14 Dec 2012 02:45:40 +0000 (15:45 +1300)]
Bug 9052 - rewrite the YUI links to use the system library

This uses libjs-yui to provide the skin.css and reset-fonts-grids.css
files from YUI. It patches the CSS files to point to the right location
for the files.

To test:
* Build a package with this patch included
* Install it
* Look at the OPAC and note that things no longer look terrible, and
  that there are no 404's coming from bad CSS URLs.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
I created a package of 3.10+9052, installed and tested.
I confirm that the OPAC does not look broken anymore
and I could not find 404 errors with Firebug.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I also created a package of 3.10+9052 and removed libchi-* from the
debian/control file. The OPAC shows no problems using those packages,
layout, pictures and colors seem to all be in place.
Also the OPAC on master with patch applied still works as expected.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9056' into 3.12-master
Jared Camins-Esakov [Fri, 14 Dec 2012 13:23:25 +0000 (08:23 -0500)]
Merge branch 'bug_9056' into 3.12-master

11 years agoBug 9056 follow-up: add missing \n to updatedatabase.pl
Jared Camins-Esakov [Fri, 14 Dec 2012 13:23:03 +0000 (08:23 -0500)]
Bug 9056 follow-up: add missing \n to updatedatabase.pl

11 years agoBug 7067: Increment version number
Jared Camins-Esakov [Fri, 14 Dec 2012 13:14:16 +0000 (08:14 -0500)]
Bug 7067: Increment version number

Database update for bug 7067 has been given version 3.11.00.008

11 years agoBug 7067 follow-up: fix updatedatabase.pl formatting
Jared Camins-Esakov [Fri, 14 Dec 2012 13:12:14 +0000 (08:12 -0500)]
Bug 7067 follow-up: fix updatedatabase.pl formatting

11 years agoBug 7067 - QA Followup - Fix error when confirming via email
Kyle M Hall [Fri, 14 Dec 2012 12:58:29 +0000 (07:58 -0500)]
Bug 7067 - QA Followup - Fix error when confirming via email

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - Fix bad url in breadcrumbs
Kyle M Hall [Thu, 13 Dec 2012 18:13:21 +0000 (13:13 -0500)]
Bug 7067 - Fix bad url in breadcrumbs

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - QA Followup - Fix failing tests
Kyle M Hall [Thu, 13 Dec 2012 18:10:52 +0000 (13:10 -0500)]
Bug 7067 - QA Followup - Fix failing tests

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 QA Followup - Add descriptions to tests
Kyle M Hall [Thu, 13 Dec 2012 17:28:02 +0000 (12:28 -0500)]
Bug 7067 QA Followup - Add descriptions to tests

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 QA Followup
Kyle M Hall [Mon, 10 Dec 2012 20:45:28 +0000 (15:45 -0500)]
Bug 7067 QA Followup

Adjusts calling conventions to use hashrefs and eliminate redundant
procedural/OO mixed code.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 Followup: FIX merge updatedatabase
Jonathan Druart [Thu, 29 Nov 2012 09:09:55 +0000 (10:09 +0100)]
Bug 7067 Followup: FIX merge updatedatabase

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067: Followup FIX QA fails
Jonathan Druart [Thu, 25 Oct 2012 14:42:31 +0000 (16:42 +0200)]
Bug 7067: Followup FIX QA fails

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Fixed minor conflict in C4/Installer/PerlDependencies.pm
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 [Follow-up: templates] allow patron self registration via the opac
Owen Leonard [Fri, 14 Sep 2012 12:26:35 +0000 (08:26 -0400)]
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - OPAC Borrower Self Registration
Kyle M Hall [Tue, 31 Jul 2012 14:07:04 +0000 (10:07 -0400)]
Bug 7067 - OPAC Borrower Self Registration

This development will add the ability for a new patron to register
himself or herself. The self-registration will attempt to match this
newly inputted data to any existing patrons and if any possible matches
are found, ask if the patron is sure he or she doesn't already have an
account at the library. A system preference may be set to prevent patron
self-registration if the system detects the possibility that the person
may already have an account.

Once the patron has registered, passing a captcha (or similar
bot-stopper), the patron will then be optionally verified a second time
via email. At this point, the patron will be able to print a temporary
library card (optional by system preference), and will be provided any
details necessary to access electronic resources (this body of text
would be a template in the slips and notices system). At the library's
choice, this new patron would either be set to a temporary patron status
(patron type set via system preference), or a fully-fledged patron
(allow patron type to be determined by age and/or other attributes).
Assuming the library uses temporary patron types for OPAC registrations,
this patron will next enter a queue and would need to physically enter
the library to verify himself and become a fully-fledged patron (most
likely by bringing in physical proof of address, etc.). The librarian
would look up the patron record and modify the patron type. If a
temporary patron has not been verified within a certain time frame
(defined by a system preference), the patron record will be deleted
from the system via a cron job.

For registered patrons, the system will allow each person to also
update his or her personal data via the OPAC. When a patron updates his
or her information, the changes will be entered into a queue to be
verified by a librarian (preventing a patron from inputting obviously
bogus data). The staff client home page will display the number of
patron records with changes awaiting approval. A librarian would then be
able to click through a list of modification requests, and approve or
deny each (with approval and denial alerts being sent to the patron via
the standard messaging system).

NEW SYSTEM PREFERENCES
* PatronSelfRegistration
* PatronSelfRegistrationDetectDuplicates
* PatronSelfRegistrationVerifyByEmail
* PatronSelfRegistrationPrintTemporaryCard
* PatronSelfRegistrationUseTemporaryStatus
* PatronSelfRegistrationExpireTemporaryAccountsDelay

NEW NOTICE
* Verify by email notice

NEW SLIP
* Temporary card slip

NEW CRON JOB
* delete_expired_opac_registrations.pl
  - Deletes patrons that have not been upgraded from the temporary
    status within the specified delay
* delete_unverified_opac_registrations.pl
  - Deletes the unverified patrons based on the length of time specified
    in the PatronSelfRegistrationExpireTemporaryAccountsDelay

The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are.

Test Plan:
1) Enable PatronSelfRegistration
2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number
   of days
3) Create a self-registered borrower category
4) Set PatronSelfRegistrationUseTemporaryStatus
5) Set PatronSelfRegistrationVerifyByEmail to "Don't require"
6) Go to OPAC, log out if logged in.
7) You should see the "Register here" link below the login box
8) Attempt to register yourself
9) Verify you can log in with your temporary password.
10) Set PatronSelfRegistrationVerifyByEmail to "Require"
11) Attempt another self-registration
12) Check the messages table, you should see a new message with a
    verification link.
13) Copy and paste the link into a web browser to verify the registration
14) Log in with the given credentials to verify the account was created.

Test Plan - Part 2 - Borrower Modifications

1) Log in to OPAC, go to "my personal details" tab.
2) Make some modifications to your details.
3) Repeat steps 1 and 2 for two more borrowers.
4) Log in to Koha intranet with a user that can modify borrowers.
5) At the bottom of mainpage.pl, you should see:
  Patrons requesting modifications: 3
6) Click the link
7) Approve one change, deny a different one, and ignore the third, then
   submit.
8) Check the records, you should see the changes take affect on the
   approved one, and no changes to the other two. You should also see
   "Patrons requesting modifications: 1" at the bottom of mainpage.pl
   now.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033: Change javascipt behavior to degrade nicely
Jared Camins-Esakov [Thu, 13 Dec 2012 17:48:16 +0000 (12:48 -0500)]
Bug 8033: Change javascipt behavior to degrade nicely

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033 follow-up removing tabs in indentation
Paul Poulain [Wed, 12 Dec 2012 07:47:41 +0000 (08:47 +0100)]
Bug 8033 follow-up removing tabs in indentation

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033: This patch adds print slips to self checkout.
Elliott Davis [Thu, 5 Jul 2012 14:46:54 +0000 (09:46 -0500)]
Bug 8033: This patch adds print slips to self checkout.

To Test:

Sign in to self checkout.
Enter a barcode and click submit.
Click the finish button
You should be prompted with a message asking if you would like a receipt.
If you click OK you should be taken to the page with the receipt.
If you click Cancel you should not see the reciept and you should be logged out.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Added copyright to print slip for SCO

Modified POD and copyright.  Also perltidied

updated print slip option to show on the click of the finish button instead of the submit button

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8039 follow-up: replace tabs by 4 spaces (QA process)
Paul Poulain [Mon, 10 Dec 2012 20:21:03 +0000 (21:21 +0100)]
Bug 8039 follow-up: replace tabs by 4 spaces (QA process)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8039: Try userid if cardnumber borrower search fails in SIP
Srdjan [Wed, 30 May 2012 01:38:35 +0000 (13:38 +1200)]
Bug 8039: Try userid if cardnumber borrower search fails in SIP

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 5709: Add the ability to translate HTML5 placeholder text in an input field
koha-preprod [Mon, 7 Feb 2011 20:59:18 +0000 (15:59 -0500)]
Bug 5709: Add the ability to translate HTML5 placeholder text in an input field

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9275 follow-up: Add Romina Racca to history
Jared Camins-Esakov [Wed, 12 Dec 2012 23:39:08 +0000 (18:39 -0500)]
Bug 9275 follow-up: Add Romina Racca to history

Welcome, Romina! You are the 195th committer to Koha.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9275 Missing '<' closing pharagraph tag
Romina Racca [Wed, 12 Dec 2012 16:16:16 +0000 (13:16 -0300)]
Bug 9275 Missing '<' closing pharagraph tag

On file koha-tmpl/intranet-tmpl/prog/en/modules/help/authorities/authorities.tt,
line 5,
there is a missing '<'. (...'New Authority' button.,/p>)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Small change, fixes obvious problem.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9246: Koha installer crash with mysql error
Marc Veron [Tue, 11 Dec 2012 09:43:18 +0000 (10:43 +0100)]
Bug 9246: Koha installer crash with mysql error

The Koha installer reports "Error 1166 at line 1871: Incorrect column
name 'closed'." Reason: line 1923 in kohastructure.sql had whitespace
between back tick on Column name "closed".

Patch removes white space on given line.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9101: Add REPORT_GROUP to sample data
Katrin Fischer [Sat, 17 Nov 2012 19:45:13 +0000 (20:45 +0100)]
Bug 9101: Add REPORT_GROUP to sample data

To test:
Option 1) Run the English and German web installer and check authorised values
have been added correctly.

Option 2) Run SQL code from auth_val.sql for German and English against your
database and check the authorised values have been added correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9033: Wide character error in runreport.pl
Julian Maurice [Thu, 22 Nov 2012 16:19:41 +0000 (17:19 +0100)]
Bug 9033: Wide character error in runreport.pl

This patch fix a typo that prevented report to be run

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9033 - Wide character error in runreport.pl
Kyle M Hall [Thu, 8 Nov 2012 15:39:32 +0000 (10:39 -0500)]
Bug 9033 - Wide character error in runreport.pl

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9019: Return item fields in ILS-DI GetRecords
Julian Maurice [Wed, 7 Nov 2012 09:51:49 +0000 (10:51 +0100)]
Bug 9019: Return item fields in ILS-DI GetRecords

Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Activate ILS-DI in system preferencs
2) Access http://.../cgi-bin/koha/ilsdi.pl to see documentation
3) Try http://.../cgi-bin/koha/ilsdi.pl?service=GetRecords&id=12+14
   with various valid biblionumbers for your system
4) Verify 952 is included in the <marcxml> and all other data displays
   correctly

All tests pass.

http://bugs.koha-community.org/show_bug.cgi?id=9010
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9191 follow-up: remove example updatedatabase stanzas
Jared Camins-Esakov [Tue, 11 Dec 2012 13:29:11 +0000 (08:29 -0500)]
Bug 9191 follow-up: remove example updatedatabase stanzas

The patch for bug 9191 included example updatedatabase stanzas that
require removal before pushing. This patch also updates the
00-checkdatabase-version.t test so that it will not give
false-positives.

11 years agoBug 9191: updatedatabase.pl should only run updates up to the current version
Jared Camins-Esakov [Mon, 3 Dec 2012 21:28:51 +0000 (16:28 -0500)]
Bug 9191: updatedatabase.pl should only run updates up to the current version

Check whether a given update should be run when passed the proposed
version number. The update will always be run if the proposed version
is greater than the current database version and less than or equal to
the version returned by C4::Context->final_linear_version (initially set
to be equal to the version in kohaversion.pl). The update is also run if
the version contains XXX, though this behavior will be changed following
the adoption of non-linear updates as implemented in bug 7167.

To test:
1) Make sure that the first example database update added by this patch
   in installer/data/mysql/updatedatabase.pl has a version number one
   greater than the version of Koha you have installed.
2) Set the Version syspref back one version behind your current version.
3) Navigate to the main page of the staff client, and log in to the
   installer.
4) Confirm that the update page claims to have rerun the previous update
   and has displayed the log message:
   "Upgrade to 3.11.00.XXX done (Bug 9191: You should see this)"
   but not the log message:
   "Upgrade to [version number] done (Bug 9191: You shouldn't see this)"

Note: the sample database revisions will be removed by the RM before
this patch is pushed to master.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
works great

Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
Works as expected.  Test plan is great. Code looks to be adherent to standards.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9056: Increment version number
Jared Camins-Esakov [Tue, 11 Dec 2012 13:13:07 +0000 (08:13 -0500)]
Bug 9056: Increment version number

Database update for bug 9056 has been given version 3.11.00.007

11 years agoBug 9056 - Add more translations to table language_descriptions
Marc Veron [Sun, 11 Nov 2012 21:00:19 +0000 (22:00 +0100)]
Bug 9056 - Add more translations to table language_descriptions

In table language_descriptions a lot of translations are missing (with the exception of French)

Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading).

This Bug could be used as 'omnibus' for follow ups for other languages.

This patch adds German (and some missing French) translations.

Tested updatedatabase.pl
Would appreciate if somebody could test subtag_registry.sql.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested both, the updatedatabase and the sql file. Works well.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9049: Don't use shadow with rebuild_zebra -r
Jared Camins-Esakov [Sat, 10 Nov 2012 12:51:22 +0000 (07:51 -0500)]
Bug 9049: Don't use shadow with rebuild_zebra -r

Due to a limitation of Zebra, the register must be cleared *before*
doing shadow indexing if you want to reset the indexes. In light of
that, it does not make sense to do shadow indexing at all when
rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset)
imply -n (no shadow).

To test:
1) Run `rebuild_zebra.pl -b -r -v -v -v`
2) Note that the script never runs the merge phase

Without the patch I see log lines refering to the shadow cache (enabling shadow spec=/home/koha/koha-dev/var/lib/zebradb/biblios/shadow:20G)
With the patch I don't see anything in the logs about shadow.  I do however see lines about merging.  I think it could just be a misunderstanding of the logs

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8519' into 3.12-master
Jared Camins-Esakov [Sat, 8 Dec 2012 14:45:44 +0000 (09:45 -0500)]
Merge branch 'bug_8519' into 3.12-master

11 years agoMerge branch 'bug_7919' into 3.12-master
Jared Camins-Esakov [Fri, 7 Dec 2012 23:30:36 +0000 (18:30 -0500)]
Merge branch 'bug_7919' into 3.12-master

11 years agoBug 7919: Fix unit test (Members_AttributeTypes.t)
Jonathan Druart [Thu, 6 Dec 2012 09:08:23 +0000 (10:08 +0100)]
Bug 7919: Fix unit test (Members_AttributeTypes.t)

- Reintroduce the class column in a select statement (was present before
  this development)
- FIX UT: If there are no arg passed in parameter, the routine calls
  C4::Context->userenv which call an execute statement. It consumes the
  mocked resultset

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
All tests successful.
Files=1, Tests=9,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.16 cusr  0.06 csys =  0.25 CPU)
Result: PASS

11 years agoBug 8519 - Make koha-index-daemon run on startup
Tomas Cohen Arazi [Wed, 31 Oct 2012 18:53:02 +0000 (14:53 -0400)]
Bug 8519 - Make koha-index-daemon run on startup

[This patch was split out from tcohen's excellent patches for bug 8519
--jcamins 2012/10/31]

Added a new koha-index-daemon-ctl.sh script that uses the
'koha-index-daemon' provided by Koha::Contrib::Tamil (install via CPAN)
to process the indexing queue ('zebraqueue' for now, 'indexqueue' in the
future I guess :-P).

This script could be easily modified in the future for using another
index queue processing script (a more abstract indexing script for both Solr
and Zebra, etc). I removed all zebra-ish stuff from it.

Documentation patches will be provided as followups, once Mark Tompsett's
docs are pushed to avoid continous rebasing.

Tested to work on an up-to-date Ubuntu 12.04.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9167' into 3.12-master
Jared Camins-Esakov [Fri, 7 Dec 2012 13:46:35 +0000 (08:46 -0500)]
Merge branch 'bug_9167' into 3.12-master

11 years agoBug 9167: Increment version number
Jared Camins-Esakov [Thu, 6 Dec 2012 13:33:43 +0000 (08:33 -0500)]
Bug 9167: Increment version number

Database update for bug 9167 has been given version 3.11.00.006

11 years agoBug 8240: Remove dead code from orderreceive
Jonathan Druart [Mon, 15 Oct 2012 14:24:33 +0000 (16:24 +0200)]
Bug 8240: Remove dead code from orderreceive

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch removes a lot of code from acquisitions. I tested 2 complete
acquisition workflows from ordering the item to receiving it, with
AcqCreateItem set to 'on order' and to 'on receive'. Both worked
without any visible changes after applying the patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9167: Standardize the sort field copyrightdate for lists
Jonathan Druart [Thu, 29 Nov 2012 15:27:27 +0000 (16:27 +0100)]
Bug 9167: Standardize the sort field copyrightdate for lists

How to reproduce the issue:
Create a list at the OPAC and select the sort field 'year'. Go to the
list management page at the intranet: the sort field "copyrightdate" is
not selected by default.

How to test this patch:
Check the issue is not still present with this patch.
Create several lists at the OPAC with different sort field.
Check results are consistent on both interfaces.
Check the selected sort field is selected on the edit page.
Check there is no regression.

What this patch does:
- change the way to send the selected sort field to the templates
- remove the select tests on the new list page (useless)
- the copyrightdate sortfield is named "copyrightdate" everywhere
- update your database : set virtualshelves.sortfield = 'copyrightdate'
  if virtualshelves.sortfield = 'year'

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Works as advertised. Improves code.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7919: Increment version number
Jared Camins-Esakov [Wed, 5 Dec 2012 15:11:35 +0000 (10:11 -0500)]
Bug 7919: Increment version number

Database update for bug 7919 has been given version 3.11.00.005

11 years agoBug 7919: Followup: Fix plural and GetAuthvalueDropbox
Jonathan Druart [Tue, 4 Dec 2012 09:13:49 +0000 (10:13 +0100)]
Bug 7919: Followup: Fix plural and GetAuthvalueDropbox

Remove plural if there is just one branch limitation
(authorised_values.tt, categorie.tt and patron-attr-types.tt)

FIX a bug in GetAuthvalueDropbox (called by acqui/fetch_sort_dropbox.pl)

Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7919 : Display of values depending on the connexion library
Jonathan Druart [Wed, 28 Nov 2012 15:36:03 +0000 (16:36 +0100)]
Bug 7919 : Display of values depending on the connexion library

In a librairies network, we would like to declare specific values just
for one (or more) library.
Here we implement the ability to associate categories, patron attributes
types and/or authorised_values with librairies (branches).

This patch adds 3 new association tables:
- categories_branches ( association table between categories and branches )
- authorised_values_branches ( association table between
  authorised_values and branches )
- borrower_attribute_types_branches (association table between
  borrower_attribute_types and branches )

Plan test:
  - Create (or modify) categories, patron attributes and
    authorised_values and link it with one (or more) library.
  - Set one of these librairies
  - Go to one of the multiple pages where this specific value must be displayed
    and check that it does appear.
  - Set a library not concerned.
  - Check on the same pages this value is doest not appear.

A page list:
cataloguing/addbiblio.pl
cataloguing/additems.pl
members/members-home.pl
members/memberentry.pl
acqui/neworderempty.pl
tools/modborrowers.pl
and others :)

Please say me if filters don't work on some pages.

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9130 follow up: add statesave cookie and "all" option for parcel drop-down menu
David Cook [Tue, 4 Dec 2012 00:10:27 +0000 (11:10 +1100)]
Bug 9130 follow up: add statesave cookie and "all" option for parcel drop-down menu

This patch sets the bStateSave parameter for the "Pending orders" and
"Already received" Datatables in Acquisitions, which uses a cookie to
save the "pagination information, display length, filtering and sorting".

It also sets the iCookieDuration parameter to 1000 days (the default
value is 2 hours otherwise).

It also adds an "all" option to the dro-down menu using the aLengthMenu
parameter.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9130 - Remove old javascript from Parcel
David Cook [Wed, 21 Nov 2012 21:09:11 +0000 (08:09 +1100)]
Bug 9130 - Remove old javascript from Parcel

When receiving orders, the old javascript would show the following above
the tables for pending orders and received orders:

"Only the first 5 items are displayed. Click here to show all 'X'
items."

With the implementation of the Jquery Datatables plugin, this text and
the 4 JS functions associated with it are now pointless (since users
should be using the datatable toolbar) and problematic.

The problem is that the Jquery toolbar says "Showing 1 to 10 of X",
while in fact it is actually only showing 5 items, because that other JS
takes place after the Jquery.

While not a crippling bug, it's certainly irritating and misleading.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8945' into 3.12-master
Jared Camins-Esakov [Tue, 4 Dec 2012 13:29:26 +0000 (08:29 -0500)]
Merge branch 'bug_8945' into 3.12-master

11 years agoBug 8945: Did you mean help file
Nicole C. Engard [Wed, 21 Nov 2012 00:08:32 +0000 (19:08 -0500)]
Bug 8945: Did you mean help file

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marc Veron <veron@veron.ch>
Help file displays as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Add a new help file

11 years agoBug 9012 - --framework option for bulkmarcimport
Robin Sheat [Tue, 6 Nov 2012 04:48:23 +0000 (17:48 +1300)]
Bug 9012 - --framework option for bulkmarcimport

This allows the --framework option to be specified when running
bulkmarkimport. This option allows a framework code to be specified for
the records being imported.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass, perlcritic fails before and after.

Tested
- imported records with -framework FA, FA framework is used
- imported records without -framework, default framework is used
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8893 [Follow-up] show more information on printout
Owen Leonard [Fri, 30 Nov 2012 20:38:09 +0000 (15:38 -0500)]
Bug 8893 [Follow-up] show more information on printout

This follow-up removes the old link to detailprint.pl and
replaces it with an empty container as a hook for the YUI
button function.

The appearance and functionality should not be any
different.

Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch removes a ref to detailprint.pl.
With JS a "Print" button is displayed (else it is not).
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8893 - show more information on printout
Owen Leonard [Thu, 25 Oct 2012 15:43:18 +0000 (11:43 -0400)]
Bug 8893 - show more information on printout

My proposed solution eliminates the special print view
page altogether and has the Print button trigger the
browser's print function. I've tweaked the print stylesheet
to improve the output.

Normally I don't think print buttons in the interface
are necessary, since a user could be expected to be able
to print the page using browser controls. But I think it's
best not to remove the button when people are used to seeing
it.

The behavior people will find now is different when clicking
the button from different catalogue pages. A user on the MARC
detail page, instead of getting the generic print view will
get a print of the page they're on. Overall I think this
is more in line with what a user would expect.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9135: updatedatabase.pl fails when DEBUG is set
Jared Camins-Esakov [Fri, 23 Nov 2012 17:30:26 +0000 (12:30 -0500)]
Bug 9135: updatedatabase.pl fails when DEBUG is set

When the DEBUG environment variable is set to a true value, all DBI
errors are treated as fatal. Unfortunately, duplicate keys are
incredibly common in updatedatabase.pl, since sysprefs are often added
in testing, then re-added once the patches have been pushed to master
(or added when on a maintenance branch, and then re-added when the
system is upgraded to either a newer maintenance branch or master).
This patch disables fatal errors for the updatedatabase.pl script.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.
To test, run from command line:
export DEBUG=1
installer/data/mysql/updatedatabase.pl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
If a query causes an error, the script continues as expected.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8641' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 21:36:16 +0000 (16:36 -0500)]
Merge branch 'bug_8641' into 3.12-master

11 years agoBug 8641 [Follow up]-Reword warning about log-in as root user to About-System information
Melia Meggs [Wed, 28 Nov 2012 17:05:07 +0000 (12:05 -0500)]
Bug 8641 [Follow up]-Reword warning about log-in as root user to About-System information

The wording of this message sounds strange to a native speaker. Reword it.

Signed-off-by: Marc Veron <veron@veron.ch>
New wording appears as expected on about page.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass, new wording shows up.

To test:
1) Login with your normal user - no warning is shown on about page
2) Login with the root/database user - warning is shown on about page

11 years agoBug 8641 [Follow-up] Add warning about log-in as root user to About page
Owen Leonard [Mon, 26 Nov 2012 17:57:15 +0000 (12:57 -0500)]
Bug 8641 [Follow-up] Add warning about log-in as root user to About page

Correction for incorrect term: Koha uses the word "library"
instead of "branch."

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass and wording changed.

11 years agoBug 9123: Authorities search ordered by authid does not work
Fridolyn SOMERS [Wed, 21 Nov 2012 10:05:05 +0000 (11:05 +0100)]
Bug 9123: Authorities search ordered by authid does not work

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with Zebra, marc21, grs1.
Discovered that paging through auth search results does no longer work, but that is not related to these changes.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with Zebra, marc21, dom.
All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7896' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:40:48 +0000 (09:40 -0500)]
Merge branch 'bug_7896' into 3.12-master

11 years agoBug 7896: follow-up: Allow translation of strings
Julian Maurice [Tue, 24 Jul 2012 11:30:23 +0000 (13:30 +0200)]
Bug 7896: follow-up: Allow translation of strings

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7896: Acq statistics wizard: add filters and cell values
Julian Maurice [Tue, 3 Apr 2012 15:30:36 +0000 (17:30 +0200)]
Bug 7896: Acq statistics wizard: add filters and cell values

- Possibility to select for line and column: items.homebranch and
  items.ccode
- Possibility to filter on these fields
- Possibility to count unique biblios (count(distinct biblionumber)),
  ordered amount and spent amount (based on aqorders.datereceived)

Filtering on item homebranch and ccode works only on items that were
created at ordering or receiving (ie items are linked to an order)

Some refactoring is done, mainly replacing switch-like if statements by
given/when

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8781' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:27:26 +0000 (09:27 -0500)]
Merge branch 'bug_8781' into 3.12-master

11 years agoBug 8781: hiding of transfer page when it's useless
Adrien Saurat [Tue, 18 Sep 2012 08:27:39 +0000 (10:27 +0200)]
Bug 8781: hiding of transfer page when it's useless

The transfer page is only useful when the system
preference "IndependantBranches" is Off of when the user
is a superlibrarian. Otherwise it can be hidden.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.

TEST PLAN :
It's about testing the display of the "Transfer" link on "circulation-home.pl".
The link needs to appear if IndependantBranches is off or if the user is a superlibrarian.

1) IndependantBranches = Off, user is superlibrarian : link appears
2) IndependantBranches = Off, user is not superlibrarian : link appears
3) IndependantBranches = On, user is superlibrarian : link appears
4) IndependantBranches = On, user is not superlibrarian : link does not appear
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8117' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:21:50 +0000 (09:21 -0500)]
Merge branch 'bug_8117' into 3.12-master

11 years agoBug 8117 [Follow-up] Divide budget periods into two tabs
Owen Leonard [Tue, 27 Nov 2012 20:57:55 +0000 (15:57 -0500)]
Bug 8117 [Follow-up] Divide budget periods into two tabs

This patch corrects some capitalization errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String changes, all tests pass.

11 years agoMerge branch 'bug_9134' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:17:06 +0000 (09:17 -0500)]
Merge branch 'bug_9134' into 3.12-master

11 years agoBug 9134: There is no previous link on the second page of the search results page
Jonathan Druart [Fri, 23 Nov 2012 13:38:03 +0000 (14:38 +0100)]
Bug 9134: There is no previous link on the second page of the search results page

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass.
Checked paging forwards, backwards, using 'Previous', 'Next'
and page numbers works correctly in staff and OPAC.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9154' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:16:50 +0000 (09:16 -0500)]
Merge branch 'bug_9154' into 3.12-master

11 years agoBug 9154 - On item edit page, highlight row of item being edited
Owen Leonard [Tue, 27 Nov 2012 19:34:27 +0000 (14:34 -0500)]
Bug 9154 - On item edit page, highlight row of item being edited

This patch changes the item edit page to add a highlighting
background color to the row in the table of all items corresponding
to the item being edited. Changes to JavaScript have been made
to allow row color changes on hover.

Other minor edits: Capitalization corrections.

Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String changes, changes to JavaScript.
All tests pass.

Test plan:
1) 'Edit items' on a record with some items.
2) Check edited item is highlighted correctly in table above.
3) Add, edit, delete an item, should all work the same as before.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9168' into 3.12-master
Jared Camins-Esakov [Sun, 2 Dec 2012 14:06:22 +0000 (09:06 -0500)]
Merge branch 'bug_9168' into 3.12-master

11 years agoBug 9168: Software error when filtering in receipt summary (followup)
Fridolyn SOMERS [Thu, 29 Nov 2012 15:40:44 +0000 (16:40 +0100)]
Bug 9168: Software error when filtering in receipt summary (followup)

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.

To test:
- Use filters on the 'order receive' page
  (don't confuse with invoices - filters are similar)
- Verify that without patch filters are not functional
- Verify that with patch applied filters work correctly
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9168: Software error when filtering in receipt summary
Fridolyn SOMERS [Thu, 29 Nov 2012 15:40:12 +0000 (16:40 +0100)]
Bug 9168: Software error when filtering in receipt summary

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8429: Remove unnecessary use of Exporter from SIP/ILS
Colin Campbell [Fri, 6 Jul 2012 15:19:33 +0000 (16:19 +0100)]
Bug 8429: Remove unnecessary use of Exporter from SIP/ILS

All the modules in the SIP/ILS tree are objects
The addition of calls to Exporter or hand manipulation of
@ISA added unnecessary bloat
Removed the "self = shift or return" idiom  as it is nonsensical
if the method can only be called via an object.
standardized inheritance via use parent
added a $self = shift in a couple of places where it
was not strictly necessary as its absence seemed to have
misled readers in the past

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8782: Increment version number
Jared Camins-Esakov [Fri, 30 Nov 2012 13:14:27 +0000 (08:14 -0500)]
Bug 8782: Increment version number

Database update for bug 8782 has been given version 3.11.00.004

11 years agoBug 8782: Close a subscription
Jonathan Druart [Tue, 18 Sep 2012 12:03:06 +0000 (14:03 +0200)]
Bug 8782: Close a subscription

If a subscription is no longer enough published (or we are not waiting
for a new periodical) we are allowed to close it.
If a subscription is closed, we are not able to receive or generate a
new serial.

On the serial module, we can now
- close a subscriptionn
- reopen a closed subscription

On serial search 2 tabs is displayed (opened and closed subscriptions).

This patch adds:
- a new field subscription.closed in DB
- a new status for serials (8 = stopped)

Test plan:
- search subscriptions
- close a subscription and check that you cannot receive or generate a
  new serial
- launch another search and check that the closed serial is into the "closed"
  tab.
- You are allowed to reopen a subscription on the subscription detail
  page and on the subscription result page. A javascript alert ask you
  if are certain to do this operation.
- Check the serial status "stopped" everywhere the status is
  displayed (catalogue/detail.pl, serials/claims.pl,
  serials/serial-issues-full.pl, serials/serials-collection.pl,
  serials/serials-edit.pl, serials/serials-recieve.pl,
  serials/subscription-detail.pl and opac-full-serial-issues.pl)
- The report statistics does not include the closed subscriptions if you
  don't check the "Include expired subscriptions" checkbox.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Bug 8782: Followup: add some minor modifications

- Show 'closed' information in biblio detail page
- Add a column in serials report table
- Search subscriptions on title words instead of string
- Prevent serials editing when subscription is closed
- Don't change status of "disabled" serials

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7189' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 13:02:14 +0000 (08:02 -0500)]
Merge branch 'bug_7189' into 3.12-master

11 years agoBug 7189: Increment version number
Jared Camins-Esakov [Fri, 30 Nov 2012 13:02:00 +0000 (08:02 -0500)]
Bug 7189: Increment version number

Database update for bug 7189 has been given version 3.11.00.003

11 years agoBug 7189 - preference to control if returning lost items gives refund
Kyle M Hall [Tue, 24 Apr 2012 13:05:36 +0000 (09:05 -0400)]
Bug 7189 - preference to control if returning lost items gives refund

Right now when you return an item that was lost the patron's card is
credited with the lost fee, but not all libraries refund lost fees
and sometimes the fee is refunded after the patron has paid for it,
causing all kinds of financial issues.

Adds the syspref RefundLostItemFeeOnReturn to control whether
returning a lost item refunds the fee charged for losing that
item. Enabled by default to maintain Koha's current functionality.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_6945' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 12:38:55 +0000 (07:38 -0500)]
Merge branch 'bug_6945' into 3.12-master

11 years agoBug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the normal view
Owen Leonard [Wed, 22 Aug 2012 20:01:03 +0000 (16:01 -0400)]
Bug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the normal view

Adding the same MARC preview link to the section of the template
which is displayed when XSLT is on.

This revision also adds a unique id to the surrounding element in the
normal and XSLT versions.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 6945: Add a link to show a MARC preview in the normal view of the detail
Maxime Pelletier [Thu, 29 Sep 2011 20:40:47 +0000 (16:40 -0400)]
Bug 6945: Add a link to show a MARC preview in the normal view of the detail

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8032' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 12:29:15 +0000 (07:29 -0500)]
Merge branch 'bug_8032' into 3.12-master

11 years agoBug 8032: Sort lists by call number
Marcel de Rooy [Mon, 5 Nov 2012 13:22:55 +0000 (14:22 +0100)]
Bug 8032: Sort lists by call number

Precaution: Joining the items table makes that the table is sorted on
the item call number of the first item (in case there are more items).

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8715' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 12:14:29 +0000 (07:14 -0500)]
Merge branch 'bug_8715' into 3.12-master

11 years agoBug 8715: Receive all serials for a year.
Jonathan Druart [Mon, 3 Sep 2012 09:44:21 +0000 (11:44 +0200)]
Bug 8715: Receive all serials for a year.

This patch adds
- 2 links in the table header (select all and clear all).
- Datatable on these tables

Test plan:
Try to select all serials for a year and receive them.
Test there is no regression (ergonomic) on this page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Bug 8715 [Follow-up] Receiving all serials for a year

Follow-up: For consistency, I would prefer to have the
column of checkboxes at the beginning of the table and the
select/clear links above.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Bug 8715: Force the default sort order to desc

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8946' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 12:09:47 +0000 (07:09 -0500)]
Merge branch 'bug_8946' into 3.12-master

11 years agoBug 8946: corrections in inc files for UNIMARC coded fields advanced search
Mathieu Saby [Thu, 18 Oct 2012 21:21:25 +0000 (23:21 +0200)]
Bug 8946: corrections in inc files for UNIMARC coded fields advanced search

In subtypes_unimarc.inc files for opac and staff interface, this patch
- fix 1 wrong code (Frequency-code:i = Other should be z)
- fix the label "Feschrift Ind." to "Literary genre"
- add some values for Material-type index (s, t), Literature-Code (i), ctype (v, w), Type-Of-Serial (e,f,g)
- fix a few typos
- change the order of some values (u values)

To test, check if the new values are visible in the opac and staff interface.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 6602 - Reports dictionary doesn't properly recognize text columns
Owen Leonard [Tue, 20 Nov 2012 18:53:43 +0000 (13:53 -0500)]
Bug 6602 - Reports dictionary doesn't properly recognize text columns

Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To
test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding
a new dictionary definition. Before the patch, in Step 4 you would not see
any kind of form field for entering a comparison. After patching Step 4 will
offer you a field labeled "Search string matches."

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.

Test plan:
1) Reports > Reports dictionary > New definition
2) Step 1: Some name
3) Step 2: Patrons
4) Step 3: First name (mediumtext)
5) Step 4: Verify 'Search string matches' is offered.

For both, surname (mediumtext) and first name (text) the program should offer you
"Search string matches" on step 4.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7687' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 03:18:06 +0000 (22:18 -0500)]
Merge branch 'bug_7687' into 3.12-master

11 years agoBug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer
Owen Leonard [Tue, 30 Oct 2012 18:10:53 +0000 (14:10 -0400)]
Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer

Removing and revising some CSS which causes problems in
Internet Explorer:

- User sidebar menu tabs in the OPAC
- Sidebar menu tabs in the staff client (circ, catalog, etc)
- List edit/delete buttons in the OPAC (when viewing the
  list of lists and viewing a list itself).

Also fixed is the sprite positioning for the "new list"
link which showed the wrong icon.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I tested this in Firefox, and Chromium and it didn't break anything,
I trust it works for IE too.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8981' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 03:07:49 +0000 (22:07 -0500)]
Merge branch 'bug_8981' into 3.12-master

11 years agoBug 8981 follow-up: case
Paul Poulain [Thu, 29 Nov 2012 16:38:09 +0000 (17:38 +0100)]
Bug 8981 follow-up: case

While QAing your patch, I saw you were writting "MarcFlavour", it should have been "marcflavour"

Will work with the UC, but let's be consistent.

This patch fixes another MarcFlavour just a few lines before I spotted by chance

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8981 - Remove Nonpublic General Note from OPAC authorities display
David Cook [Mon, 29 Oct 2012 22:06:45 +0000 (09:06 +1100)]
Bug 8981 - Remove Nonpublic General Note from OPAC authorities display

Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page.

Since it is a nonpublic note, it makes sense to remove it from this view.

This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Does what it says, with no side effects

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_5801' into 3.12-master
Jared Camins-Esakov [Fri, 30 Nov 2012 03:03:55 +0000 (22:03 -0500)]
Merge branch 'bug_5801' into 3.12-master

11 years agoBug 5801 - C4::Circulation::_GetCircControlBranch wrongly used in opac-reserve.pl
Kyle M Hall [Mon, 1 Oct 2012 19:16:29 +0000 (15:16 -0400)]
Bug 5801 - C4::Circulation::_GetCircControlBranch wrongly used in opac-reserve.pl

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.

Tests done:
holds policy vs. circulation rules seemed to make the difference for me,
I am not totally sure why that is, but see no reason to fail this patch as
results are ok.

System preferences
- CircControlBranch = the library the item is from
- ReservesControlBranch = patron's home library

Circulation rules
- Library A - Holds policy: Books can not be put on hold.
- Library B - Holds policy: Books can be put on hold. (no special setting needed)

Catalog data
- A record with an item for library B, itemtype Books.

Test without patch:

1) Patron A (home library A) places a hold in OPAC on an item from library B.

Should be: hold is NOT allowed.
Before patch: hold IS allowed.
After patch: hold is NOT allowed.
OK

2) ReserveControlbranch = item's home library
Patron A (home library A) places a hold in OPAC on an item from library B.

Should be: hold is allowed.
Before patch: hold is allowed.
After patch: hold is allowed.
OK

3) ReservesControlBranch = patron's home library
Circulation rules: Remove hold policy for library B.
Library A: no holds allowed for books using 'Holds allowed (count)' = 0
Library B: 5 holds allowed for books using 'Holds allowed (count)' = 5
Patron A (home library A) places a hold in OPAC on an item from library B.

Should be: hold is NOT allowed
Before patch: hold is NOT allowed
After patch:  hold is NOT allowed
OK

4) ReserveControlbranch = item's home library

Should be: hold is allowed
Before patch: hold is allowed
After patch:  hold is allowed
OK
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7731' into 3.12-master
Jared Camins-Esakov [Thu, 29 Nov 2012 00:10:45 +0000 (19:10 -0500)]
Merge branch 'bug_7731' into 3.12-master

11 years agoBug 7731 [Follow-up] Library should be used instead of branch and site
Owen Leonard [Mon, 26 Nov 2012 19:34:38 +0000 (14:34 -0500)]
Bug 7731 [Follow-up] Library should be used instead of branch and site

This patch corrects new and old instances of the use of the
term "branch" and replaces them with "library."

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass, changes look good.
Also inlcudes some bookseller > vendor changes.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8164' into 3.12-master
Jared Camins-Esakov [Thu, 29 Nov 2012 00:08:39 +0000 (19:08 -0500)]
Merge branch 'bug_8164' into 3.12-master

11 years agoBug 8164: Replace IFNULL with COALESCE
Jonathan Druart [Thu, 23 Aug 2012 14:36:24 +0000 (16:36 +0200)]
Bug 8164: Replace IFNULL with COALESCE

mysql> SELECT IFNULL(0, 123);
+----------------+
| IFNULL(0, 123) |
+----------------+
|              0 |
+----------------+
1 row in set (0.00 sec)

mysql> SELECT IFNULL(1, 123);
+----------------+
| IFNULL(1, 123) |
+----------------+
|              1 |
+----------------+
1 row in set (0.00 sec)

mysql> SELECT IFNULL(NULL, 123);
+-------------------+
| IFNULL(NULL, 123) |
+-------------------+
|               123 |
+-------------------+
1 row in set (0.00 sec)

mysql> SELECT COALESCE(0, 123);
+------------------+
| COALESCE(0, 123) |
+------------------+
|                0 |
+------------------+
1 row in set (0.00 sec)

mysql> SELECT COALESCE(1, 123);
+------------------+
| COALESCE(1, 123) |
+------------------+
|                1 |
+------------------+
1 row in set (0.00 sec)

mysql> SELECT COALESCE(NULL, 123);
+---------------------+
| COALESCE(NULL, 123) |
+---------------------+
|                 123 |
+---------------------+
1 row in set (0.00 sec)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8710 - Don't show the images tab in the OPAC if the record has no local images
Owen Leonard [Fri, 26 Oct 2012 13:14:15 +0000 (09:14 -0400)]
Bug 8710 - Don't show the images tab in the OPAC if the record has no local images

For unknown reasons, having ListImagesForBiblio return undef
when there are no images still results in a variable being passed
to the template which evaluates as true, with a size of 1.

This patch alters ListImagesForBiblio to remove the "return undef"
condition, allowing the template to evaluate images as false
and show no tab.

To test, turn on local cover images and view records in the OPAC
which do and do not have cover images attached. Images should
display as expected when present, and no images tab should appear
on records which have none.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9030' into 3.12-master
Jared Camins-Esakov [Wed, 28 Nov 2012 23:46:18 +0000 (18:46 -0500)]
Merge branch 'bug_9030' into 3.12-master

11 years agoBug 9030: Increment version number
Jared Camins-Esakov [Wed, 28 Nov 2012 23:44:13 +0000 (18:44 -0500)]
Bug 9030: Increment version number

Database update for bug 9030 has been given version 3.11.00.002