]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoBasic cleanup of fixup_cardnumber
Joe Atzberger [Wed, 21 Jan 2009 01:18:23 +0000 (19:18 -0600)]
Basic cleanup of fixup_cardnumber

Avoid warning on syspref "checkdigit" undefined.
Functionality essentially unchanged.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2904: fix display of URLs in UNIMARC
Galen Charlton [Fri, 6 Mar 2009 18:17:39 +0000 (12:17 -0600)]
bug 2904: fix display of URLs in UNIMARC

This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951.  The original
patch description is:

in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agocorrected patch for bug 2951
Mason James [Thu, 12 Feb 2009 23:15:57 +0000 (12:15 +1300)]
corrected patch for bug 2951

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to library transfer limits: DB rev => 014
Galen Charlton [Wed, 4 Mar 2009 22:15:33 +0000 (16:15 -0600)]
followup to library transfer limits: DB rev => 014

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup: assign BranchTransferLimitsType to Circulation
Galen Charlton [Wed, 4 Mar 2009 22:15:34 +0000 (16:15 -0600)]
followup: assign BranchTransferLimitsType to Circulation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoThis patch allows the Branch Transfer Limits feature to limit transfers either by...
koha [Wed, 4 Mar 2009 22:15:32 +0000 (16:15 -0600)]
This patch allows the Branch Transfer Limits feature to limit transfers either by itemtype ( like the original commit ) or collection code ( new feature ).

[Note inserted by RM: this patch is by Kyle Hall]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2703: Changed spent.pl select statment to include joins between tables.
James Winter [Wed, 4 Mar 2009 20:57:01 +0000 (15:57 -0500)]
bug 2703: Changed spent.pl select statment to include joins between tables.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2991: Request hold on multiple items at one time.
Stephen Edwards [Thu, 5 Mar 2009 00:10:03 +0000 (19:10 -0500)]
bug 2991: Request hold on multiple items at one time.

Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.

Updated the request CGI scripts to handle multiple biblio items.

Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.

Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMarkup and style corrections.
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.

Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2772: bad image location
Nahuel Angelinetti [Mon, 10 Nov 2008 16:16:16 +0000 (17:16 +0100)]
bug 2772: bad image location

This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2978) fix differents bugs in marc editor
Nahuel ANGELINETTI [Mon, 23 Feb 2009 11:12:49 +0000 (12:12 +0100)]
(bug #2978) fix differents bugs in marc editor

This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110c94935e1b3fe6ba3a3c9ea35a473a4)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2933) change popup names containing space chars
Nahuel ANGELINETTI [Thu, 29 Jan 2009 14:29:19 +0000 (15:29 +0100)]
(bug #2933) change popup names containing space chars

This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUsing openAuth function for authorities Searching
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:11 +0000 (14:58 +0100)]
Using openAuth function for authorities Searching

Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3011) csv export doesn't fill all the fields
Nahuel ANGELINETTI [Fri, 6 Mar 2009 11:25:05 +0000 (12:25 +0100)]
(bug #3011) csv export doesn't fill all the fields

This patch just fix the script which export to csv the overdue, and field the missing fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2840: Delete a hidden tag that is not needed and create an error
Nahuel Angelinetti [Wed, 3 Dec 2008 11:41:11 +0000 (12:41 +0100)]
bug 2840: Delete a hidden tag that is not needed and create an error

The bug exists because for each table line, an hidden field was set, with subscriptionid, but it's not used by the script and
create a bug "Request-URI Too Large".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2883 - longoverdue cronjob fails to implement required functionality.
Joe Atzberger [Mon, 29 Dec 2008 16:51:45 +0000 (10:51 -0600)]
Bug 2883 - longoverdue cronjob fails to implement required functionality.

This does not fix all problems recorded in 2883 (see all the FIXME's), but
it does improve the script's basic feedback to an intelligible level.
It also adjusts the documentation and examples to correct bogus usage
instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow LDAP test to bail if LDAP disabled.
Joe Atzberger [Fri, 23 Jan 2009 17:57:57 +0000 (11:57 -0600)]
Allow LDAP test to bail if LDAP disabled.

Also added more feedback and the ability to override KOHA_CONF
"useldapserver" value with ENV variable KOHA_USELDAPSERVER.

This patch should be considered for inclusion to 3.0 stable branch
because it prevents unnecessary failure of test battery.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2996) update unimarc 105 plugin to the actual norm
Nahuel ANGELINETTI [Thu, 5 Mar 2009 11:12:49 +0000 (12:12 +0100)]
(bug #2996) update unimarc 105 plugin to the actual norm

This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832c7aba6d8ef642bd420504eee2cc23b)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2996) fix and improve 100 and 105 unimarc plugins
Nahuel ANGELINETTI [Tue, 3 Mar 2009 12:57:19 +0000 (13:57 +0100)]
(bug #2996) fix and improve 100 and 105 unimarc plugins

This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03503c2ed5940fff93f43f730f96488f)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTranslating UNIMARC plugins in English
Henri-Damien LAURENT [Mon, 24 Nov 2008 21:31:24 +0000 (22:31 +0100)]
Translating UNIMARC plugins in English

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 839c87a48cfc1aa3e37705fd7cc8d902d0b6bfb9)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded a require C4::Heading to resolve a circular dependency.
Daniel Sweeney [Wed, 4 Mar 2009 22:53:06 +0000 (16:53 -0600)]
Added a require C4::Heading to resolve a circular dependency.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago- perltidy corrects broken indentation on 'if' block.
Mason James [Mon, 26 Jan 2009 00:05:30 +0000 (13:05 +1300)]
- perltidy corrects broken indentation on 'if' block.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.
Mason James [Thu, 22 Jan 2009 23:13:42 +0000 (12:13 +1300)]
bug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug-2923, corrects renew status in SCO
Mason James [Thu, 22 Jan 2009 22:04:50 +0000 (11:04 +1300)]
fix for bug-2923, corrects renew status in SCO

 - removes unneeded  HTML::Template::Pro
 - some indent/newline tidies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTrivial comment typos corrected.
Joe Atzberger [Wed, 21 Jan 2009 01:18:24 +0000 (19:18 -0600)]
Trivial comment typos corrected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAutoselect marcflavour in marc import
Nahuel ANGELINETTI [Tue, 20 Jan 2009 14:59:23 +0000 (15:59 +0100)]
Autoselect marcflavour in marc import

This patch is writted by Paul Poulain.
It auto-select the marcflavour from syspref in the stage marc import.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPrevent warning if intranetuserjs is already NULL/undefined.
Joe Atzberger [Sat, 17 Jan 2009 00:31:54 +0000 (18:31 -0600)]
Prevent warning if intranetuserjs is already NULL/undefined.

Warning would look like:
updatedatabase.pl: Use of uninitialized value in string eq
at /home/user/koha/installer/data/mysql/updatedatabase.pl line 2141.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrect capitalization on CGI::Session::Serialize::yaml
Joe Atzberger [Sat, 17 Jan 2009 00:31:55 +0000 (18:31 -0600)]
Correct capitalization on CGI::Session::Serialize::yaml

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2917) editing authority marc field structure doesn't workl
Nahuel ANGELINETTI [Tue, 20 Jan 2009 12:46:58 +0000 (13:46 +0100)]
(bug #2917) editing authority marc field structure doesn't workl

This patch add a field in the ->execute() statement which was missing.
The sql request have 8 args, and only 7 was passed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixes command-line 'number' arg in bulkauthimport.pl.
Mason James [Fri, 16 Jan 2009 10:07:12 +0000 (23:07 +1300)]
Fixes command-line 'number' arg in bulkauthimport.pl.

for HEAD and 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2961) be xhtml valid
Nahuel ANGELINETTI [Wed, 4 Mar 2009 16:14:50 +0000 (17:14 +0100)]
(bug #2961) be xhtml valid

This little patch just fix the previous patch to be xhtml valid(onclick instead of onClick)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2961) add a button to add manually the next issue
Nahuel ANGELINETTI [Fri, 13 Feb 2009 16:15:31 +0000 (17:15 +0100)]
(bug #2961) add a button to add manually the next issue

This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2962) escape searchbox, and change the search from tag clouds
Nahuel ANGELINETTI [Mon, 16 Feb 2009 10:03:42 +0000 (11:03 +0100)]
(bug #2962) escape searchbox, and change the search from tag clouds

This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoKohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix
Chris Nighswonger [Thu, 26 Feb 2009 20:43:35 +0000 (15:43 -0500)]
Kohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix

The current regexp used to split fiction call numbers does not handle the '.' char well. This patch corrects the regexp so that it behaves as expected.

This patch should be ported to the 3.0.x branch.

[fbcbug 5]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding Copy Number column to table of item information on holds pages.
Owen Leonard [Thu, 26 Feb 2009 19:39:54 +0000 (13:39 -0600)]
Adding Copy Number column to table of item information on holds pages.

Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2924 fixed rebuild_zebra.pl to work when export is skipped
Brian Harrington [Mon, 2 Mar 2009 21:08:13 +0000 (16:08 -0500)]
bug 2924 fixed rebuild_zebra.pl to work when export is skipped

reindexing now occurs if there are $num_records_exported or if
$skip_export is set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2986: tweak authtype index for MARC21 (GRS-1)
Galen Charlton [Wed, 4 Mar 2009 14:19:02 +0000 (08:19 -0600)]
bug 2986: tweak authtype index for MARC21 (GRS-1)

Following a similar patch for UNIMARC, tweak the
authtype index for MARC21 authorities if the GRS-1
Zebra filter is in use.

Note that it is recommended that *DOM* mode indexing
be used for MARC21 authorities; if you're using DOM mode,
it is not necessary to rebuild the index.  However, if
you're using the GRS-1 definitions (record.abs), it will
be necessary to reindex the authority records using

misc/migration_tools/rebuild_zebra.pl -a -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix bug #2986 - Authority search
Frederic Demians [Thu, 26 Feb 2009 09:57:43 +0000 (10:57 +0100)]
Fix bug #2986 - Authority search

On authorities-home.pl page, when you do search, you don't have any
result. Looking in log file, you see a Zebra error:

  Unsupported Use attribute (114) authtype Bib-1

This patch modify record.abs UNIMARC definition.
The same may have to be done for MARC21 record.abs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixes missing 'STDERR', causing 500 error below..
Mason James [Mon, 2 Mar 2009 03:29:54 +0000 (16:29 +1300)]
fixes missing 'STDERR', causing 500 error below..

 malformed header from script. Bad header=## checkpw - checking LDAP: mainpage.pl,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2992: don't display MARC codes in search results
Galen Charlton [Fri, 27 Feb 2009 21:39:43 +0000 (15:39 -0600)]
bug 2992: don't display MARC codes in search results

Two fields (type of continuing resource and literary
form for sound recordings) in the MARC21 XSLT search
results stylesheet display the code from the 008
position (/21 and /31, respectively) in addition to a
descriptive label.  As a MARC code is meaningless to
patrons, this patch removes the code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2998) fix search sorting containing "="
Nahuel ANGELINETTI [Tue, 3 Mar 2009 16:48:15 +0000 (17:48 +0100)]
(bug #2998) fix search sorting containing "="

just modify the way to parse the actual args

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdate autobarcode syspref for french framework
Nahuel ANGELINETTI [Tue, 3 Mar 2009 13:16:17 +0000 (14:16 +0100)]
Update autobarcode syspref for french framework

This patch just update the syspref to use incremental|annual|hbyymmincr|OFF instead of "YesNo".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2995) Set a default encoding for e-mails
Nahuel ANGELINETTI [Tue, 3 Mar 2009 10:16:24 +0000 (11:16 +0100)]
(bug #2995) Set a default encoding for e-mails

Just set a default encoding as utf8 if none is provided.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agochanges to OPAC results and detail XSLT
Galen Charlton [Wed, 11 Feb 2009 23:01:01 +0000 (17:01 -0600)]
changes to OPAC results and detail XSLT

Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agodisplay library name instead of code in limit description
Galen Charlton [Wed, 25 Feb 2009 19:29:41 +0000 (13:29 -0600)]
display library name instead of code in limit description

The OPAC and staff search results page will now display
the library name instead of the library code in the limit
part of the search description, e.g.,

"kw,wrdl: cat branch:Centerville" instead of
"kw,wrdl: cat branch:CPL"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoResubmitting: Change to how email link is displayed for on-hold items
Owen Leonard [Thu, 26 Feb 2009 20:50:40 +0000 (14:50 -0600)]
Resubmitting: Change to how email link is displayed for on-hold items

Email link should only display when the on-hold item is being checked in at its destination branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agominor corrections to check-url.pl
Galen Charlton [Thu, 26 Feb 2009 21:15:53 +0000 (15:15 -0600)]
minor corrections to check-url.pl

* removed ersataz YAML::XS dependency
* use 'return' instead of 'return undef'
* minor language changes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoURLs checker enhancement (bug #2959)
Frederic Demians [Tue, 17 Feb 2009 09:23:13 +0000 (10:23 +0100)]
URLs checker enhancement (bug #2959)

Improve URLs checker script in the way (half way) pointed out by Galen:

- A C4::URL::Checker class handle URL checking. This class is not yet
  in a separate file in C4 directory. This class would be easily
  extended to accomodate authorities URLs checking.
- Script output can now be formatted in CSV or HTML. HTML version
  link directly to MARC biblio record editor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2968 - SIP ACS_STATUS message (98) misreported config.
Joe Atzberger [Thu, 19 Feb 2009 16:20:07 +0000 (10:20 -0600)]
Bug 2968 - SIP ACS_STATUS message (98) misreported config.

The *_ok methods in ILS.pm were targeting the wrong depth.
This also resolves a longstanding FIXME on to_bool() warning like:
    Argument "\x{66}\x{61}..." isn't numeric in numeric ne (!=) at /ILS.pm line 94.

The example_institution_dump.sh essentially provides the proof test case for this patch.
Run it before/after on SIPconfig.xml where "MAIN" has checkout="true" and checkin="true".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding additional information and consolidating display of information in holds queue...
Owen Leonard [Fri, 20 Feb 2009 16:59:28 +0000 (10:59 -0600)]
Adding additional information and consolidating display of information in holds queue report

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoConsistency check between Makefile.pl and about.pl We weren't picking up JSOM so...
Andrew Elwell [Sun, 22 Feb 2009 13:53:08 +0000 (14:53 +0100)]
Consistency check between Makefile.pl and about.pl We weren't picking up JSOM so admin/item_circulation_alerts.pl gave a 500 internal server error if JOSM not installed.

 Also sorted packages.debian alphabetically so that we can maintain
 easier.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomore Minor documentation fixes
Andrew Elwell [Fri, 20 Feb 2009 14:34:51 +0000 (15:34 +0100)]
more Minor documentation fixes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor documentation typos
Andrew Elwell [Thu, 19 Feb 2009 11:01:55 +0000 (12:01 +0100)]
Minor documentation typos

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpgrade jquery dimensions plugin. Correction to Cart js to match.
Owen Leonard [Thu, 26 Feb 2009 20:14:36 +0000 (14:14 -0600)]
Upgrade jquery dimensions plugin. Correction to Cart js to match.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding information that patron is restricted/address in doubt to hold notification...
Owen Leonard [Thu, 26 Feb 2009 18:58:31 +0000 (12:58 -0600)]
Adding information that patron is restricted/address in doubt to hold notification screen

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrection: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only...
Owen Leonard [Thu, 26 Feb 2009 19:17:52 +0000 (13:17 -0600)]
Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2988: apply correct hold policy
Galen Charlton [Thu, 26 Feb 2009 16:42:53 +0000 (10:42 -0600)]
bug 2988: apply correct hold policy

Item type was not retrieved in a query, leading to a case
where an item could be selected by build_holds_queue.pl
to fill a hold request even where forbidden by the
library and item type-level policy.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUsing "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when...
Owen Leonard [Wed, 25 Feb 2009 14:38:37 +0000 (08:38 -0600)]
Using "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when SQL includes double-quotes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1546 - REPLACE statements
John Beppu [Thu, 26 Feb 2009 19:19:28 +0000 (13:19 -0600)]
bug 1546 - REPLACE statements

A REPLACE statement in tools/letter.pl was indirectly corrupting data
in the message_transports table.  It has been replaced with code that
does an UPDATE or INSERT depending on whether the row existed or not.

Also, to protect data in the message_transports table further, letters
which have entries in the message_transports table are no longer
deletable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnabling listing of category codes when "new patron" button is displayed.
Owen Leonard [Tue, 24 Feb 2009 16:10:03 +0000 (10:10 -0600)]
Enabling listing of category codes when "new patron" button is displayed.

circulation.pl lacked the code to check whether category codes existed, meaning it would only display category types.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd option to inventory tool to ignore copies on loan
Michael Hafen [Tue, 24 Feb 2009 19:05:50 +0000 (12:05 -0700)]
Add option to inventory tool to ignore copies on loan

This adds an option to the inventory tool causing it to ignore copies
currently on loan.  This is good if you want to do inventory, but don't
want to update the date-last-seen on items currently on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoving check for non-existent OPACDisplayItypes sytem pref which prevented itemtype...
Owen Leonard [Wed, 25 Feb 2009 17:02:06 +0000 (11:02 -0600)]
Removing check for non-existent OPACDisplayItypes sytem pref which prevented itemtype icons from appearing on opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2984, Error when generating CSV output from "Generate labels for Batch...
Owen Leonard [Wed, 25 Feb 2009 21:17:15 +0000 (15:17 -0600)]
Fix for Bug 2984, Error when generating CSV output from "Generate labels for Batch" button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2939) delete a warning
Nahuel ANGELINETTI [Tue, 3 Feb 2009 08:47:45 +0000 (09:47 +0100)]
(bug #2939) delete a warning

just add a default value to $sep

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2952 followup
Galen Charlton [Thu, 12 Feb 2009 23:04:20 +0000 (17:04 -0600)]
bug 2952 followup

The feature in question is described in bug 2952; to
summarize the enhancement, which the earlier patch
description did not do, the list of bibs in an
import record batch now includes a column linking
each import record to the bib that was actually created
or updated when the import batch was committed.

The improvements in this patch are:

* If bib in import batch has not been committed, it
  has not been linked to a matching new or updated bib.
  In that case, do not create a link to a guaranteed
  404 (/cgi-bin/koha/catalogue/detail.pl?biblionumber=)

* When reverting an import batch, set matched_biblionumber
  to NULL for affected records - otherwise, the Bib
  column will include links to bibs that may no longer
  exist.

* Fixed a minor HTML validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2952: 1 char typo
Mason James [Tue, 10 Feb 2009 02:38:15 +0000 (15:38 +1300)]
bug 2952: 1 char typo

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agopatch for feature 2952 - v3
Mason James [Tue, 10 Feb 2009 01:48:26 +0000 (14:48 +1300)]
patch for feature 2952 - v3

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges to improve keyboard access to global search box tabs.
Owen Leonard [Tue, 10 Feb 2009 20:45:36 +0000 (14:45 -0600)]
Changes to improve keyboard access to global search box tabs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2955: fix remaining calls to GetMarcFromKohaField
Galen Charlton [Thu, 12 Feb 2009 22:28:41 +0000 (16:28 -0600)]
bug 2955: fix remaining calls to GetMarcFromKohaField

This includes part of a patch from Henri-Damien Laurent
that could not be applied because Chris and Joe patches
happened to win the race.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoA new script to check URLs in 856$u field
Frederic Demians [Tue, 10 Feb 2009 06:13:30 +0000 (07:13 +0100)]
A new script to check URLs in 856$u field

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMoved several etch packages from cpan install to the packages.debian.
Andrew Elwell [Mon, 9 Feb 2009 21:30:53 +0000 (22:30 +0100)]
Moved several etch packages from cpan install to the packages.debian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2956) fix another results calculation
Nahuel ANGELINETTI [Thu, 12 Feb 2009 14:58:35 +0000 (15:58 +0100)]
(bug #2956) fix another results calculation

this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2955 (2/2) GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 17:15:00 +0000 (12:15 -0500)]
kohabug 2955 (2/2) GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by dateaccessioned.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMake sax_parser_print provide more obvious feedback.
Joe Atzberger [Tue, 10 Feb 2009 20:16:31 +0000 (14:16 -0600)]
Make sax_parser_print provide more obvious feedback.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrecting title of link to admin/itemtypes.pl from "Item types and circulationcodes...
Owen Leonard [Tue, 10 Feb 2009 20:45:47 +0000 (14:45 -0600)]
Correcting title of link to admin/itemtypes.pl from "Item types and circulationcodes" to just "Item types." Ccodes are authorized values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd some search indexes to opac advanced search that are on quick search
Michael Hafen [Mon, 2 Feb 2009 23:24:53 +0000 (16:24 -0700)]
add some search indexes to opac advanced search that are on quick search

This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2955 GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 16:44:12 +0000 (11:44 -0500)]
kohabug 2955 GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by barcode.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

fbcbug 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2956) fix 4xx plugin pagination
Nahuel ANGELINETTI [Thu, 12 Feb 2009 14:38:52 +0000 (15:38 +0100)]
(bug #2956) fix 4xx plugin pagination

this patch rework the calculation of the pagination and of results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2957) import Date_to_Days
Nahuel ANGELINETTI [Thu, 12 Feb 2009 15:04:52 +0000 (16:04 +0100)]
(bug #2957) import Date_to_Days

This patch import Date_to_Days from Data::Calc, else CalcFine can crash.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoreduce bib fetches during search and OPAC display
Galen Charlton [Tue, 10 Feb 2009 22:38:11 +0000 (16:38 -0600)]
reduce bib fetches during search and OPAC display

Speed up bib search and OPAC bib display, especially
when the XSLT OPAC results and details display sysprefs are
ON, by passing an existing MARC::Record object to three
functions:

C4::Biblio::get_biblio_authorised_values()
C4::XSLT::XSLTParse4Display()
C4::XSLT::transformMARCXML4XSLT (internal)

These functions previously fetched the bib from the
database, incurring the cost of DB retrieval and MARCXML
parsing even though client code already had a
MARC::Record object available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2126: reduce round-off errors in fine balance
Galen Charlton [Thu, 12 Feb 2009 20:20:43 +0000 (14:20 -0600)]
bug 2126: reduce round-off errors in fine balance

If a patron has a number of fine transactions, the
total could be wrong.  This is particularly noticeable
when a patron has a zero balance, as summing a group
of floating point values derived from decimal(6,2) columns
can result a scalar value that is not zero.

Koha really should be using integral arithmetic
or appropriate accounting modules to do fine and
acquisitions calculations.  Using floating point scalars
for monetary amounts is always a mistake.

This patch also prevents an account maintenance
fee from being applied when renewing a patron if the
amount would be 0.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded empty item call number test to copies for reserve; added ending punctuation...
Daniel Sweeney [Wed, 4 Feb 2009 16:46:25 +0000 (10:46 -0600)]
Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixes to two issues with status display on OPAC:
Joshua Ferraro [Wed, 4 Feb 2009 16:46:24 +0000 (10:46 -0600)]
Fixes to two issues with status display on OPAC:

1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDisplays the itemcallnumber in brackets next to location in XSL Results
Joshua Ferraro [Wed, 4 Feb 2009 16:46:21 +0000 (10:46 -0600)]
Displays the itemcallnumber in brackets next to location in XSL Results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDistinguish between items marked 'not for loan' and 'Available'
Joshua Ferraro [Wed, 4 Feb 2009 16:46:23 +0000 (10:46 -0600)]
Distinguish between items marked 'not for loan' and 'Available'

This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding warnings to request/ files
Joshua Ferraro [Wed, 4 Feb 2009 16:46:22 +0000 (10:46 -0600)]
Adding warnings to request/ files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoholds policies fixes
Galen Charlton [Fri, 30 Jan 2009 21:21:29 +0000 (15:21 -0600)]
holds policies fixes

* use item branch instead of patron's branch to
look up the applicable hold policies - this makes
requesting in the OPAC consistent with the intranet.
* when generating pick list using build_holds_queue.pl, only match items
to patrons if request is allowed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2940 - private shelf (list) display error on 2nd and subsequent pages.
Joe Atzberger [Mon, 2 Feb 2009 20:36:19 +0000 (14:36 -0600)]
Bug 2940 - private shelf (list) display error on 2nd and subsequent pages.

The before/after URL for the 2nd page of list elements:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?display=privateshelves?viewshelf=120&itemoff=2
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?viewshelf=120&display=privateshelves&itemoff=2

The change in query string arguments is incidental, the prevention of multiple "?" is essential.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoGetMarcFromKohaField needs 2 args, or there's no point.
Joe Atzberger [Wed, 4 Feb 2009 21:55:49 +0000 (15:55 -0600)]
GetMarcFromKohaField needs 2 args, or there's no point.

GetMarcFromKohaField returns (0,0) without the $frameworkcode argument.
Note the argument can be "", but it must not be undefined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAvoid XSLT stylesheet building for each biblio record to transform
Frederic Demians [Thu, 5 Feb 2009 07:26:13 +0000 (08:26 +0100)]
Avoid XSLT stylesheet building for each biblio record to transform

In XSLT.pm, put XSLT stylesheet object in a session variable in order
to avoid to build it for each biblio to parse: useful on search
result page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated INSTALL.debian and debian.packages for new dependencies
J. David Bavousett [Thu, 5 Feb 2009 21:27:30 +0000 (15:27 -0600)]
Updated INSTALL.debian and debian.packages for new dependencies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agotweak Inventory tool and sub in C4/Items so call number min and max are not required
Michael Hafen [Tue, 3 Feb 2009 23:46:25 +0000 (16:46 -0700)]
tweak Inventory tool and sub in C4/Items so call number min and max are not required

This changes the setting if default values in the inventory tool where
the min and max call number are concerned.  Also changes how the query
is formed in C4/Items so that these two are not required.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 356: removed redundant interface
John Beppu [Thu, 5 Feb 2009 22:36:22 +0000 (16:36 -0600)]
bug 356: removed redundant interface

The messaging tab already provided a way to configure these
notifications, so this isn't needed.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2911: popup calendar not available in IE
Owen Leonard [Sat, 7 Feb 2009 20:39:18 +0000 (14:39 -0600)]
Fix for Bug 2911: popup calendar not available in IE

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove editor settings
Galen Charlton [Wed, 4 Feb 2009 20:47:10 +0000 (14:47 -0600)]
remove editor settings

Me, I use ed(1) for everything...

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoreconciled DB revs: now at 013
Galen Charlton [Wed, 4 Feb 2009 20:19:51 +0000 (14:19 -0600)]
reconciled DB revs: now at 013

15 years agobug 341: Use the Right Branch
John Beppu [Tue, 3 Feb 2009 22:02:14 +0000 (16:02 -0600)]
bug 341: Use the Right Branch

When sending circulation alerts, use the branch that the
event happened on instead of $item->{homebranch}.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 324: Setting to_address
John Beppu [Tue, 3 Feb 2009 22:02:13 +0000 (16:02 -0600)]
bug 324: Setting to_address

- Enqueue the messages with a to_address.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 323: Item Circulation Alerts UI Fixes
John Beppu [Tue, 3 Feb 2009 22:02:12 +0000 (16:02 -0600)]
bug 323: Item Circulation Alerts UI Fixes

- fixed cross browser issues.  (IE and Safari don't let you say
  someobject.class, presumably because "class" is a keyword that's reserved
  for future versions of JS.  Firefox and Opera allow it.)

- added text to the grid for added clarity.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago[Checkout Slips Part 3 14/16] SQL
John Beppu [Tue, 3 Feb 2009 22:02:11 +0000 (16:02 -0600)]
[Checkout Slips Part 3 14/16] SQL

- fixed syntax errors (thanks Dan)
- made sample_notices.sql mandatory

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>