Joe Atzberger [Fri, 19 Sep 2008 00:02:49 +0000 (19:02 -0500)]
Revising the stub for ILS/Transaction/FeePayment.pm
Obviously more implementation is needed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 19 Sep 2008 00:09:02 +0000 (19:09 -0500)]
bug 2625: finish fix by converting another array to hash
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Clay Fouts [Thu, 18 Sep 2008 19:40:05 +0000 (14:40 -0500)]
bug 2625
Using the barcode as an index for assigning values to an array creates problems if
the numeric value of the barcode is sufficiently large to consume enough memory to
starve other processes. This patch changes return_failed from an indexed array into
an associative one, using the barcode as the key.
Signed-off-by: Ryan Higgins <rch@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 12 Nov 2008 11:08:41 +0000 (12:08 +0100)]
Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tmpl
Joe Atzberger [Fri, 12 Sep 2008 16:25:01 +0000 (11:25 -0500)]
DHTMLcalendar should not be imported.
Changing these scripts as precursor to removing it from C4::Dates @EXPORT_OK
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 12 Nov 2008 10:30:46 +0000 (11:30 +0100)]
Bug 2600 : escaping information in returns.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:21:14 +0000 (19:21 +0100)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
and keep ability to hyperlink URL fields in MARC detail display
Henri-Damien LAURENT [Thu, 4 Sep 2008 14:34:41 +0000 (16:34 +0200)]
Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Using $item->{$hbranch} rather than $item->{homebranch}
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image
I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template. I don't understand why, but this fixes it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 4 Sep 2008 17:23:46 +0000 (12:23 -0500)]
bug 2582 [1/2]: don't set issuedate during renewal
Changed so that issues.issuedate is never modified
during a renewal, since that column records the original
date of the loan. Changed the name and interpretation
of the $issuedate parameter of AddRenewal() to
$lastreneweddate, allowing (e.g.) offline circulation
to set the date of the renewal without changing the
issue date.
As a result of the original bug, issues.issuedate can be
set to NULL for loans that were renewed via the OPAC,
self checkout, or the staff interface when explicitly
renewing a loan. Loans that were renewed by checking
the item out to the same patron will have the issue date
changed to the date of the last renewal.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:11:38 +0000 (19:11 +0100)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.
Forgot the returns.pl. Will do that in the next patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:08:23 +0000 (19:08 +0100)]
Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.
Links to moredetail.pl with itemnumber and #item in the url.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:04:07 +0000 (19:04 +0100)]
Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:01:52 +0000 (19:01 +0100)]
If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.
This patch makes moredetail.pl show only the item specified by
itemnumber.
Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.
Thanks to Galen Charlton and Joe Atzberger
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 27 Aug 2008 14:44:28 +0000 (09:44 -0500)]
Minor SIP cleanup, conditionalize warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 17:51:45 +0000 (18:51 +0100)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Fri, 22 Aug 2008 15:54:31 +0000 (10:54 -0500)]
Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 20 Aug 2008 20:40:44 +0000 (15:40 -0500)]
issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
B&T Rental--Fiction
The Tidy error associated would be:
line 574 column 29 - Error: general entity "T" not defined and no default entity
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 17:44:35 +0000 (18:44 +0100)]
fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:
C4/Koha.pm
catalogue/search.pl
opac/opac-search.pl
Vincent Danjean [Fri, 15 Aug 2008 19:19:01 +0000 (21:19 +0200)]
Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:48 +0000 (11:21 -0500)]
bug 2503: tests for C4::Circulation
I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.
C4::Circ::Addissue to tests issuedate
these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:46 +0000 (11:21 -0500)]
bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today
When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them
added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Tue, 19 Aug 2008 18:51:09 +0000 (13:51 -0500)]
bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 15 Aug 2008 16:19:06 +0000 (11:19 -0500)]
bug 2526: removing DEBUG flag from C4::Search
The DEBUG flag was left turned on.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 4 Nov 2008 16:38:16 +0000 (17:38 +0100)]
Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 01:59:52 +0000 (20:59 -0500)]
bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title
As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.
This patch includes the final component of the fix
for bug 2331.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 28 Oct 2008 22:29:37 +0000 (23:29 +0100)]
Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 16:48:41 +0000 (11:48 -0500)]
bug 2341: OPAC title-level holds permitted when items are on-order
Changed so that the presence of an on-order item (items.notforloan =- -1)
permits a title-level hold request to be made. Prior to this patch,
if all of the items linked to the bib were on-order, no title-level
request was permitted.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:08 +0000 (10:43 -0500)]
bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.
As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.
Documentation note: new screenshot of list of requests for
a bib in the staff interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:09 +0000 (10:43 -0500)]
bug 2521: distinguish types of hold requests
Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:06 +0000 (10:43 -0500)]
bug 2518: remove useless patron and branch lookups
AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue. This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:07 +0000 (10:43 -0500)]
bug 2519: clear waitingdate if request is moved off waiting status
* Changed C4::Reserves::ModReserve so that if using it to take an
item off the hold shelf, reserves.waitingdate is cleared.
* Improved POD.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 15 Sep 2008 16:33:32 +0000 (11:33 -0500)]
Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 18:04:16 +0000 (12:04 -0600)]
Reduce logging from rebuild_zebra.pl with a command line option
This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 24 Sep 2008 16:26:33 +0000 (11:26 -0500)]
Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
paul [Mon, 22 Sep 2008 16:31:54 +0000 (18:31 +0200)]
BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Pianohacker [Fri, 26 Sep 2008 19:57:25 +0000 (14:57 -0500)]
fix date formatting in overdue_notices.pl
This makes overdue_notices.pl format dates in fields that both start and end with 'date'.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Fri, 26 Sep 2008 17:25:58 +0000 (19:25 +0200)]
Bugfix #2630 2nd attempt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 30 Sep 2008 00:00:29 +0000 (19:00 -0500)]
Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Tue, 23 Sep 2008 15:47:11 +0000 (17:47 +0200)]
Bugfix #2633
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 17 Sep 2008 12:07:51 +0000 (07:07 -0500)]
bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.
No user-visible or documentation changes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 16 Sep 2008 02:00:42 +0000 (22:00 -0400)]
bug 2609: display correct requested title
In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Tue, 16 Sep 2008 11:05:33 +0000 (06:05 -0500)]
Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Sun, 14 Sep 2008 03:59:10 +0000 (22:59 -0500)]
fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Sat, 13 Sep 2008 15:50:19 +0000 (10:50 -0500)]
Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Sat, 13 Sep 2008 15:50:11 +0000 (10:50 -0500)]
Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 12 Sep 2008 16:25:02 +0000 (11:25 -0500)]
moredetail.pl is not an Exporter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Thu, 11 Sep 2008 19:31:05 +0000 (14:31 -0500)]
Remove acquisitions permission requirement on catalogue/showmarc.pl
This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here. A user without acquisitions permissions
would get a login instead of the record display without this change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Thu, 11 Sep 2008 18:17:24 +0000 (13:17 -0500)]
Sort libraries by name in holds queue's select input.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 11 Sep 2008 14:55:52 +0000 (09:55 -0500)]
Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 11 Sep 2008 14:54:04 +0000 (09:54 -0500)]
Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 11 Sep 2008 14:53:48 +0000 (09:53 -0500)]
Refining keyboard shortcuts javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 10 Sep 2008 19:02:20 +0000 (14:02 -0500)]
Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 17 Sep 2008 02:58:13 +0000 (21:58 -0500)]
bug 2596: remove URL escaping added by previous patch
If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 10 Sep 2008 13:11:07 +0000 (08:11 -0500)]
Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 20:21:07 +0000 (15:21 -0500)]
Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Danny Bouman [Tue, 9 Sep 2008 20:05:35 +0000 (16:05 -0400)]
bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 19:54:04 +0000 (14:54 -0500)]
Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 19:53:49 +0000 (14:53 -0500)]
Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 9 Sep 2008 16:16:59 +0000 (11:16 -0500)]
fix extra <td> introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 9 Sep 2008 16:08:07 +0000 (11:08 -0500)]
commenting out debug warns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 15:54:23 +0000 (10:54 -0500)]
Correction to previous commit, removing debugging.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 15:26:48 +0000 (10:26 -0500)]
Formatting itemtype icon section with tabs to match authorized value interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 8 Sep 2008 17:49:40 +0000 (12:49 -0500)]
Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 8 Sep 2008 17:49:39 +0000 (12:49 -0500)]
Minor cleanup, updated POD.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 9 Sep 2008 15:26:40 +0000 (10:26 -0500)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 5 Sep 2008 15:52:20 +0000 (10:52 -0500)]
bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:
When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work. When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Fri, 5 Sep 2008 22:50:15 +0000 (17:50 -0500)]
Correct application of noissues flag in SIP.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Danny Bouman [Thu, 4 Sep 2008 15:50:58 +0000 (11:50 -0400)]
bug2580: category name and home library will now correctly display on all patron tabs
This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image
I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template. I don't understand why, but this fixes it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Mon, 8 Sep 2008 15:45:07 +0000 (17:45 +0200)]
bug fix 2590 :
seems that when itemtypeimagelocation returns undef, the hash is messed up.
put it at the end of the hash and everything is fine.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Tue, 2 Sep 2008 22:53:27 +0000 (17:53 -0500)]
fix for bug 2577: Cannot delete patron in IE
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 2 Sep 2008 23:48:15 +0000 (18:48 -0500)]
Remove unnecessary EXPR.
There are two problems with this EXPR:
(1) It's unnecessary, and
(2) It's an EXPR.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 3 Sep 2008 01:20:28 +0000 (20:20 -0500)]
HTML fixes for matching-rules.tmpl
* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 3 Sep 2008 20:49:54 +0000 (15:49 -0500)]
HTML validation adjustments to about.pl
Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 21:52:06 +0000 (16:52 -0500)]
remove debug warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 2 Sep 2008 22:39:12 +0000 (17:39 -0500)]
Validation fix, include required "type" in link tag.
This removes validation warnings like:
Warning: <link> inserting "type" attribute
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 2 Sep 2008 23:08:34 +0000 (18:08 -0500)]
Documentation update (test-single not single-test)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Fri, 29 Aug 2008 16:15:20 +0000 (18:15 +0200)]
Bug fixing : 2516
There was a problem with names ordering in circ/circulation.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 29 Aug 2008 14:06:03 +0000 (09:06 -0500)]
Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 29 Aug 2008 14:06:11 +0000 (09:06 -0500)]
More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 29 Aug 2008 14:05:52 +0000 (09:05 -0500)]
Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Danny Bouman [Thu, 28 Aug 2008 19:22:39 +0000 (15:22 -0400)]
bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission
Michael Hafen [Fri, 22 Aug 2008 23:26:17 +0000 (17:26 -0600)]
change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 22 Aug 2008 23:24:43 +0000 (17:24 -0600)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.
Forgot the returns.pl. Will do that in the next patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 22 Aug 2008 23:24:44 +0000 (17:24 -0600)]
Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.
Links to moredetail.pl with itemnumber and #item in the url.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Thu, 28 Aug 2008 15:48:13 +0000 (17:48 +0200)]
modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 28 Aug 2008 13:46:04 +0000 (08:46 -0500)]
bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.
Documentation changes: none per se. However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 16:14:36 +0000 (11:14 -0500)]
Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 18:38:56 +0000 (13:38 -0500)]
Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 29 Aug 2008 19:36:51 +0000 (13:36 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.
This patch makes moredetail.pl show only the item specified by
itemnumber.
Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.
Thanks to Galen Charlton and Joe Atzberger
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 20:36:02 +0000 (15:36 -0500)]
Revert "If itemnumber is sent to catalogue/moredetail.pl use it"
Applied wrong version of patch. Oops.
This reverts commit
9eb1465b2874a8a65195065bed083d26614ca287.
Joe Atzberger [Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)]
Fines fixes: apparent problems with fines prevent processing.
CalcFine returned values that mismatched expectations in fines.pl.
fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.
Calendar exported "new" erroneously. I also cleaned up the queries to
avoid needlessly compiling additional statement handles.
Please test and consider application to 3.0 maintenance.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 21 Aug 2008 21:55:27 +0000 (15:55 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.
This patch makes moredetail.pl show only the item specified by itemnumber.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 26 Aug 2008 15:32:59 +0000 (10:32 -0500)]
bug 2466: regression test
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 26 Aug 2008 15:33:00 +0000 (10:33 -0500)]
bug 2466: fix clearing item field
When editing an item in the cataloging and serials
item editors, clearing a field now works.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>