]> git.koha-community.org Git - koha.git/log
koha.git
9 years agoBug 13785: (QA followup) koha-disable should stop the indexer daemon
Tomas Cohen Arazi [Sat, 7 Mar 2015 21:22:53 +0000 (22:22 +0100)]
Bug 13785: (QA followup) koha-disable should stop the indexer daemon

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fdca44709e105451908d0e38be44ae3da8f7e496)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13785: koha-disable should also stop SIP and zebra for instance
Larry Baerveldt [Tue, 3 Mar 2015 15:33:21 +0000 (07:33 -0800)]
Bug 13785: koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 1fd9cdcdb03ae77d47a8a19fc92413ef6ba2c999)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13657 - Don't show extra comma after guarantor name on patron details
Marc Véron [Tue, 10 Feb 2015 15:37:41 +0000 (16:37 +0100)]
Bug 13657 - Don't show extra comma after guarantor name on patron details

This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations.

To test:
Apply this patch (without the first patch).
Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page.

Signed-off-by: Jesse Maseto <Jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e0863d9711f6e63f627a6cca1450fde481e935e7)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 11364: Label layout types and text justification types are not translatable
Pasi Kallinen [Tue, 6 May 2014 08:20:59 +0000 (11:20 +0300)]
Bug 11364: Label layout types and text justification types are not translatable

To test:

1) cd misc/translator
2) perl translate update xx-YY
3) check that there's no msgids that contain the layout types or
   text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the
   msgid for the frequencies. (search for "BLOCK translate_label_types"
   and "BLOCK translate_justification_types")

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 901fdce2c658bb4f19396d23a492e2dc6ce28375)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13804 - Returns via the checkouts tables uses the phrase "Returned" rather than...
Kyle M Hall [Fri, 6 Mar 2015 10:08:41 +0000 (11:08 +0100)]
Bug 13804 - Returns via the checkouts tables uses the phrase "Returned" rather than "Checked in"

Test plan:
1) Apply this patch
2) Return an item via the checkouts table
3) Note the left most column now reads "Checked in" rather than "Returned"

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d50163786156b4b4eda37addaeeab957961329d7)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13350: Untranslatable strings in aqbudgetperiods.tt
Bernardo Gonzalez Kriegel [Thu, 5 Mar 2015 18:48:45 +0000 (15:48 -0300)]
Bug 13350: Untranslatable strings in aqbudgetperiods.tt

Counter patch, same test plan as original

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 379e9cbe1eac5aca880e193691a3dedf22900c5d)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13351 - Untranslatable javascript in members.tt
Marc Véron [Tue, 3 Mar 2015 10:49:29 +0000 (11:49 +0100)]
Bug 13351 - Untranslatable javascript in members.tt

This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable).

To test:
- Apply patch
- Select Englsh language
- Apply filter wit several values or click on a letter for "Browse by last name"
- Verify that the title makes sense
- Translate to your language and select this language
- Verify that the text appears properly in your language

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

http://bugs.koha-community.org/show_bug.cgi?id=13352
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 6004b2492bc945739fd95bb55955ca1fe3f0483b)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12631: Inventory: fix "wrong place" and "item not scanned"
Matthias Meusburger [Mon, 23 Jun 2014 14:51:00 +0000 (16:51 +0200)]
Bug 12631: Inventory: fix "wrong place" and "item not scanned"

 "item not scanned": when calling GetItemsForInventory, datelastseen should
 be used when "compare barcodes list to result" is checked.

 Otherwise, when loading multiple barcodes files for the same inventory, many
 items will be marked as "item not scanned" when loading the last barcode file
 ("compare barcodes list to result" checked) even though they were scanned.

 "wrong place": when searching for wrongly placed items, we should only check
 for the location (callnumbers, location and branch). To fix this, A new call
 to  GetItemsForInventory has been made with location filters only.

 Otherwise, any item with a different itemtype for instance will be marked as
 wrong place even if the location is correct.

 Test plan:

"item not scanned" status:

1) Split a barcode file in two.
2) Load the first barcode file without checking "compare barcodes list to result".
3) Load the second barcode file with "compare barcodes list to result" checked.
4) Check in the csv report that you have a lot of scanned items with the "item
not scanned" status.

Then apply the patch, do the same, and check that the false "item not scanned"
statuses are gone.

"wrong place" status:

1) Load a barcode file with barcode matching an item that has a correct
location, but a different itemtype than what you're looking for.
2) Check in the results that this item will be marked as "change item status"
and "wrong place".

Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit bafceab9bd3fdc140b729b8adb67540a1a62effc)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13750: Fix capitalization All vs ALL
Jonathan Druart [Wed, 25 Feb 2015 11:24:20 +0000 (12:24 +0100)]
Bug 13750: Fix capitalization All vs ALL

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d3405211be867483fdda50c6982af5dc411858f1)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13750: Holds queue - Show branch name instead of branch code
Katrin Fischer [Sun, 22 Feb 2015 10:50:21 +0000 (11:50 +0100)]
Bug 13750: Holds queue - Show branch name instead of branch code

When the holds queue report is limited to one library, it shows
<cound> items found for <branchcode>

With the patch applied, the branch name is shown instead of the code.

To test:
- Go to circulation > Holds queue
- Limit to one branch with holds waiting to be processed
- Confirm the string has changed to show the branch name

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 1bd8f5e6f783c8dfec2c53c2cc277506202ca2f7)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13784: (QA followup) allow running Zebra for disabled instances on packages
Tomas Cohen Arazi [Sat, 7 Mar 2015 20:35:36 +0000 (21:35 +0100)]
Bug 13784: (QA followup) allow running Zebra for disabled instances on packages

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ee3c31076b93eb2a724bd3a62e6f9f5c750cff72)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13784: koha-stop-zebra should also work for disabled instances
Larry Baerveldt [Tue, 3 Mar 2015 13:49:57 +0000 (05:49 -0800)]
Bug 13784: koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 77809ccd32de48c0946b1451392021d9a67180e6)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13787 - Clean up noisy opac-advsearch warnings
Mark Tompsett [Wed, 4 Mar 2015 00:28:44 +0000 (19:28 -0500)]
Bug 13787 - Clean up noisy opac-advsearch warnings

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 384.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 161.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 161.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 177.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 177.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 202.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 202.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 240.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 240.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 256.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 256.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 356.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 356.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 369.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
- Applied the patch from bug 10937
- Ran "koha-qa.pl -c 1" and observed the warnings described in the
  commit message
- Applied the patch from this bug
- Ran "koha-qa.pl -c 1" again and saw no warnings
- Ran "koha-qa.pl -c 2" and saw no warnings

I have not tested the functionality of 10937 with this patch, just verified
that the changes look sensible.

This patch feels more like a followup for 10937, than a separate patch,
especially since 10937 is just "signed off" at this time. But as long as it
works...

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit f71f1ba6e23b7b3777ba2ea5d531bc2cf25da140)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13744: Fix datatables paging on 'Holds to pull' report
Katrin Fischer [Sat, 21 Feb 2015 19:40:31 +0000 (20:40 +0100)]
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.
Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit dad48bcf0a7e495fe68eab37198e2c40cdbe52bf)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13744: Fix datatables paging on 'checkout history' page
Katrin Fischer [Sun, 22 Feb 2015 10:10:59 +0000 (11:10 +0100)]
Bug 13744: Fix datatables paging on 'checkout history' page

The paging in the datatable on the 'circulation history' page
is broken without this patch.

/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=...

To test:
- Search for a record with items that have been checked out
  in the past
- From the detail page, open the 'checkout history' tab
- Check paging displays correctly with this patch and is
  broken without

Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 92656844d89c37447947cdeaec1361a9ddadbdce)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13744: Fix datatables paging on 'order from subscription' page
Katrin Fischer [Sat, 21 Feb 2015 19:30:07 +0000 (20:30 +0100)]
Bug 13744: Fix datatables paging on 'order from subscription' page

The paging of the datatable on the 'order from subscription' page
is broken without this patch.

To test:
- Make sure you have a subscription, note the vendor
- Create a new basket for this vendor
- Add a new order line 'from a subscription'
- Check paging on the result table displays correctly

Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d9d0ea3904d4aa3b7498a3c0f4516bd497b59f8b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13771: Update manage staged marc help for 3.18
Nicole [Thu, 5 Mar 2015 10:03:43 +0000 (02:03 -0800)]
Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ad898e811c6b0c04f7e0993da1b3722bc1fee00b)

9 years agoBug 13771: Add missing item search help file
Nicole [Wed, 4 Mar 2015 15:47:54 +0000 (07:47 -0800)]
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fd4f8f136029e6ccda501c2dfc3e82b1f43b6217)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13771: Add admin help files for 3.18
Nicole [Tue, 3 Mar 2015 10:01:56 +0000 (02:01 -0800)]
Bug 13771: Add admin help files for 3.18

This patch adds a new help file for column settings and updates the
files for budgets, funds, libraries, patron categories, and circ rules.

To test:

* Visit the above listed admin pages
* Review help files

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 15dd5e99432450597b3b29f975b1ad8c5c6ffdc1)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13771: Update Circ Help File
Nicole [Mon, 2 Mar 2015 15:48:12 +0000 (07:48 -0800)]
Bug 13771: Update Circ Help File

This updates the main circulation help file with new features in 3.18.

To test:

* visit circulation page
* click help
* review text

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 008d0b3438c74659f0115d63f29432b1e82853ad)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13771: Main Page Help fro 3.18
Nicole C. Engard [Mon, 2 Mar 2015 09:49:30 +0000 (04:49 -0500)]
Bug 13771: Main Page Help fro 3.18

This updates the main page help file for 3.18.

To test:
* Log in to staff cleint
* Click help on the mian page
* Review help file

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 9702bf1211bfc2fb20781b2d7bc16f62116158c5)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBUG 13771: Update Tools Help Files for 3.18
Nicole C. Engard [Mon, 2 Mar 2015 10:28:42 +0000 (05:28 -0500)]
BUG 13771: Update Tools Help Files for 3.18

This patch creates a helpf ile for the batch record delete tool
and updates the help files for notices and marc export.

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit cee9f08bcb34a077c8a57d05e69629087e4b5e36)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoRevert "Bug 13789 - facets with accented utf-8 characters generate double encoded...
Chris Cormack [Thu, 12 Mar 2015 08:01:52 +0000 (21:01 +1300)]
Revert "Bug 13789 - facets with accented utf-8 characters generate double encoded links"

This reverts commit 0029619eb3838eb372eca87b8eb3e6ca1a3a4629.

9 years agoBug 13789 - facets with accented utf-8 characters generate double encoded links
Dobrica Pavlinusic [Wed, 4 Mar 2015 10:38:42 +0000 (11:38 +0100)]
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
   /cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 1ca9adaa56ff809a76ff903bb231175d0195163c)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc

9 years agoBug 13635: Unimarc - On editing a notice, the title should be displayed
Jonathan Druart [Wed, 28 Jan 2015 12:03:31 +0000 (13:03 +0100)]
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

Signed-off-by: joel aloi <aloi54@live.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 07e6ddc44af5ba6cdcccbcdac44bba223d891610)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13605 - _AUTHOR_ not replaced in relatives checkouts
Fridolin Somers [Wed, 21 Jan 2015 09:22:19 +0000 (10:22 +0100)]
Bug 13605 - _AUTHOR_ not replaced in relatives checkouts

In members/moremember.pl, in relatives checkouts tab, "by _AUTHOR_" appears before author.
This code sould be replaced in JS.

Test plan :
- Go to a borrower with relative's checkouts
=> without patch : you see "by _AUTHOR_" string before author name
=> with patch : you see "by" string before author name

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, fixes the problem.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ce2ea3e8091e699f6fc78e4d0f6569a707df299b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin)
Adrien Saurat [Tue, 19 Mar 2013 16:00:40 +0000 (17:00 +0100)]
Bug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin)

Adds a checkin operation at the beginning of the test.
Otherwise, a former test leaves the test item checked out
and this generates an error.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit dff7d28275c09193094557c907cc6c10f9bee0e1)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13731: Suggestions reason does not save on updating the status
Jonathan Druart [Mon, 23 Feb 2015 11:32:33 +0000 (12:32 +0100)]
Bug 13731: Suggestions reason does not save on updating the status

On the suggestion list view, if you set a status, it won't be saved.

Test plan:
1/ Create a suggestion
2/ Go on the suggestion list view (suggestion/suggestion.pl)
3/ Select a suggestion and marked it as "rejected" (or the status you
want) and choose a reason
4/ Save
5/ Browse you suggestions DB table (using your favorite MySQL CLI) and
verify that the "reason" field is correctly filled.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as expected, thx!

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 45e5afb77b8185eda9151cde7943577201671d17)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13745: Fix serial collection page to always show branch name
Katrin Fischer [Sat, 21 Feb 2015 21:24:03 +0000 (22:24 +0100)]
Bug 13745: Fix serial collection page to always show branch name

The serial collection page shows 2 tables, one for the subscriptions
and a second for the issues. Both show the branch, but the first
showed the code while the second showed the name.
With this patch both tables show the name.

To test:
- Search for a subscription or create one
- Navigate to the serial collection page (navigation on left side)
- Check both tables on the page show the branch name with
  the patch applied

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 90ac9ec545b9883de63943daef0ffe0692c1b799)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13741: "No fund found" is not translatable
Katrin Fischer [Sat, 21 Feb 2015 19:52:02 +0000 (20:52 +0100)]
Bug 13741: "No fund found" is not translatable

The string "No fund found" on the funds overview page is
not translatable.

To test:
- Create a new budget
- Check for the string on the funds page of the new budget
- Run an update on one of the po file sets
    cd misc/translator
    perl translate update <langcode>
- Verify that the string now appars in the po file for staff
- Verify the page still looks the same as before the patch

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a78b95821369a9a2c2eef50d9d3191612bd342c2)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13676 - OpacSuppression description says 'items' but means 'records'
Marc Véron [Tue, 10 Feb 2015 17:32:08 +0000 (18:32 +0100)]
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must have the <code>Suppress</code> index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ...

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e08f4e75db215b4daab7290761714632dac0dfed)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13753: koha-indexer contains invalid statement
Tomas Cohen Arazi [Tue, 24 Feb 2015 13:54:57 +0000 (10:54 -0300)]
Bug 13753: koha-indexer contains invalid statement

An incorrect conditional makes the indexer daemon fail to load.

To test:
- Enable the indexer daemon on packages [1]
- Restart koha-common:
  $ service koha-common restart
- Run
  $ ps waux | grep koha-indexer
=> FAIL: there's no reference to the rebuild_zebra.pl script
  (line should look like *rebuild_zebra.pl -daemon*)
   Run ps -ef | grep rebuild_zebra.pl too to make sure.
- Apply the patch, repeat the steps
=> SUCCESS: the rebuild_zebra.pl script is ran
- Sign off :-D

Thanks

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit b1ef4123bf80522fbab97e4ac7e4648a4122d6e9)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13473 - Plugins fail
Kyle M Hall [Tue, 17 Feb 2015 11:23:35 +0000 (06:23 -0500)]
Bug 13473 - Plugins fail

When trying to execute or configure the plugin on 3.18 I got:

Template process failed: file error - doc-head-open.inc: not found at
/usr/share/koha/lib/C4/Templates.pm line 129.

Test Plan:
1) Install the Kitchen Sink plugin
2) Go to the configuration page of the plugin
3) Note the template processing error
4) Apply this patch
5) Refresh the page
6) Note the page now loads

Signed-off-by: Nick <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 003993d547a98a3b1e085058b96aecd318ece036)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13523: DBIC updates
Tomas Cohen Arazi [Tue, 24 Feb 2015 17:20:31 +0000 (14:20 -0300)]
Bug 13523: DBIC updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 7272426d0d6985e1e7f35d4a55d5fb6444b1ffba)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoFixing db version
Chris Cormack [Tue, 10 Mar 2015 19:11:34 +0000 (08:11 +1300)]
Fixing db version

9 years agoBug 13523: DBRev 3.19.00.012
Tomas Cohen Arazi [Tue, 24 Feb 2015 14:27:03 +0000 (11:27 -0300)]
Bug 13523: DBRev 3.19.00.012

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 06608a24408c74d0975665b24c1e80fec5669385)

Conflicts:
kohaversion.pl

9 years agoBug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES
Benjamin Rokseth [Thu, 22 Jan 2015 11:21:47 +0000 (12:21 +0100)]
Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES

This patch removes the NOT NULL restriction on biblioitems.marcxml and
deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in
Mysql 5.6.22 and onwards.

Test:

1. check mysql global settings:
   mysql > SELECT @@GLOBAL.sql_mode;
   verify that STRICT_TRANS_TABLES is not set
2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21)
   mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES';
3. try to add biblio in Cataloguing module
   verify that it fails with a "software error"
4. apply patch
5. repeat 3 and verify that there is no "software error" any more

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled.
On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in
_koha_add_biblioitem but marxcml is not generated yet. It's in
ModBiblioMarc, few lines later.
The NOT NULL condition is not valid here.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4b59bc4e2b591b32ff28eccda0baf8d131544736)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13729 - Give news in Opac a unique anchor
Viktor Sarge [Wed, 18 Feb 2015 21:02:09 +0000 (21:02 +0000)]
Bug 13729 - Give news in Opac a unique anchor

This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac.

The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream.

Test plan:
* Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window.
* Install the patch.
* Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4
* Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised. Nice enhancement!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 13a16343fa21e87b9c4723fdf4d02ae6eb46d495)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13645: dependencies for libdbix-connector-perl
Robin Sheat [Tue, 24 Feb 2015 05:32:30 +0000 (18:32 +1300)]
Bug 13645: dependencies for libdbix-connector-perl

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 0a91c48edbd4eb8d4080fbca6fb2bc3af9ca9f92)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies
Kyle M Hall [Fri, 20 Feb 2015 14:54:35 +0000 (09:54 -0500)]
Bug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Nice catch Kyle, I changed it to require Ubuntu 12.04's

(cherry picked from commit 00f27cb0b9fb200a06da461371e04be1501ca107)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13645: Use DBIx::Connector
Jonathan Druart [Tue, 10 Feb 2015 09:47:05 +0000 (10:47 +0100)]
Bug 13645: Use DBIx::Connector

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 4883835816ebce164ec336f9adcd4c925f9244b4)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
C4/Context.pm

9 years agoBug 13645: Cache the DBIx connection
Jonathan Druart [Fri, 30 Jan 2015 16:10:54 +0000 (17:10 +0100)]
Bug 13645: Cache the DBIx connection

We don't want to recreate a new connection to the DB every time we want
a new schema.

This patch creates a $database package level variable on the same way
it's done in C4::Context for $dbh.

Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 354ee6d427e3ec8fc926d7fb793141a127733258)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13593: (follow-up) 'stock number' should be 'inventory number'
Jonathan Druart [Thu, 19 Feb 2015 14:50:37 +0000 (15:50 +0100)]
Bug 13593: (follow-up) 'stock number' should be 'inventory number'

Add one more.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 8770d37de70ea935702139ca955b4dd9d4ff38fa)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13593: 'stock number' should be 'inventory number'
Katrin Fischer [Sun, 18 Jan 2015 19:04:15 +0000 (20:04 +0100)]
Bug 13593: 'stock number' should be 'inventory number'

To make Koha easier to use, we should use terms consistently.
This patch fixes some occurrences of 'stock number' to be
'inventory number' as this is also the term used in the frameworks.

Item search, accessible via the link from staff's advanced search
1) Do a search for items, but choose CSV as output
2) Verify that the header row says 'inventory number'

Acquisition
3) Set AcqCreateItem to 'order'
4) Create a new order, check the labels on the item table in the order

5) Receive the order, check the labels on the item table on receive

6) Set AcqCreateItem to 'receive'
7) Check the item table on receiving an order

Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 9cc7ac68e1c2993b7780a6fe1c361ddd434a595b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13682 - Capitalization: Holds Queue
Marc Véron [Tue, 10 Feb 2015 17:16:45 +0000 (18:16 +0100)]
Bug 13682 - Capitalization: Holds Queue

This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$

To test:
Apply patch
Go to Circulation > Holds queue page
Verify that the capitalization is correct

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 8804598f3dcff3ccacc34723939cf072d8451fac)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13700: Fix item search templates for translation
Julian Maurice [Fri, 13 Feb 2015 12:30:56 +0000 (13:30 +0100)]
Bug 13700: Fix item search templates for translation

Since translator rebuild HTML tags with double quotes for attributes
values, use double quotes in english template too and escape them with
backslash.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
It works well!!

Test:
1) Intall translation  (de-DE, es-ES)
2) to Go to item search, in english, do a search that gives results
3) Switch language, repeat search, result's table does not render
4) Apply patch
5) Install translation again
6) Repeat 3, now results are displayed

No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 39c22b1a6a744d6b4c50c3a4b62295ab3a601636)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoAdding release notes v3.18.04
Chris Cormack [Sun, 22 Feb 2015 23:42:26 +0000 (12:42 +1300)]
Adding release notes

9 years agoBumping version number for release
Chris Cormack [Sun, 22 Feb 2015 23:21:17 +0000 (12:21 +1300)]
Bumping version number for release

9 years agoBug 12948: Use word indexing for language (MARC21)
Zeno Tajoli [Sun, 15 Feb 2015 16:40:06 +0000 (17:40 +0100)]
Bug 12948: Use word indexing for language (MARC21)

 This patch is for MARC21. To test:
1)Setup a site with
 MARC21
2)Insert 2 record, one lang A in 041 and 008 pos
 35-37 an other with lang A in 041 and lang B in 008 pos
 35-37
3)Index them
4)Search in advanced search with filter
 'languare' for lan A. You will see 2 records
5)Search in
 advanced search with filter 'languare' for lan B. You will
 see 0 records
6)Apply the patch
7)Full reindex
8)Search in advanced search
 with filter 'languare' for lan B. You will see 1 records

http://bugs.koha-community.org/show_bug.cgi?id=12948

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I have *not* actually tested this, but the changes are identical to the ones
done for NORMARC, which I have tested, so I think it is safe to sign off. If
anyone disagrees, please reset the bug to "Needs signoff".

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit c29a53ea20d668f135c62abbc7dda1bf282be8f0)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12948: Use word indexing for language (NORMARC)
Zeno Tajoli [Sun, 15 Feb 2015 16:54:48 +0000 (17:54 +0100)]
Bug 12948: Use word indexing for language (NORMARC)

This patch is for Normarc
Same test plan as patch for MARC21, except you need a setup with Normarc.

http://bugs.koha-community.org/show_bug.cgi?id=12948
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
- Added a record with "bul" in 008pos35-37
- Verified that this did not turn up in an advanced search with language =
  Bulgarian
- Applied the patch
- I was testing on a gitified install, so I had to copy the patched index file
  to the right location with this command:

sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \
/etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl

- Did a full reindex
- Verified that the record *did* turn up in an advanced search with language =
  Bulgarian
- Signing off! Thanks Zeno!

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit bf89e306a86c440a3296fc89436ad5e854ea4f34)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13690: use Koha::Schema only when it's needed
Jonathan Druart [Tue, 10 Feb 2015 10:34:10 +0000 (11:34 +0100)]
Bug 13690: use Koha::Schema only when it's needed

This patch makes Koha::Database lazy-load the whole Koha::Schema libraries.
It doesn't seem to have negative effects, and makes scripts not using
DBIx::Class notably faster [1].

Regards

[1] If you read the DBIx::Class::Schema docs, it explains that it it uses
Module::Find to load all schema files...
http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/Schema.pm#load_namespaces

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Happy to sign this one. The only extra comment would be that DBIx::Class
performance issues remain after this patch, but is being handled in a
different bug.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12858 [QA Followup] - Don't call webservice if we have no data
Kyle M Hall [Fri, 20 Feb 2015 12:23:15 +0000 (07:23 -0500)]
Bug 12858 [QA Followup] - Don't call webservice if we have no data

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 79e1008cef66345106328487c712ef6dde7f3507)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12858: Add error handling to Syndetics Index
Martin Renvoize [Tue, 2 Sep 2014 09:14:03 +0000 (09:14 +0000)]
Bug 12858: Add error handling to Syndetics Index

* Syndetics routines include a statement to check that the returned
  content from Syndetics is xml. The get_syndetics_index routine was
  missing this check and so when a 'not found' html page was returned
  the opac-detail page would take a long time to load whilst xml::simple
  attempted to parse the large html document.

  Test Plan
  1. Enable Syndetics indexes on opac.
  2. Head over to an opac-detail page on the opac.
  3. Remove the ISBN from the same item in the staff client.
  4. Reload the opac-detail page for the item noticeing a much slower
  page load.
  5. Apply the patch
  6. Reload the opac-detail page for the item and note that it now laods
  in a reasonable timescale again.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit acc7da6a5f93e12704acdfd7981481c9ef07904b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12669: Centralize the timezone handle into Koha::DateUtils
Jonathan Druart [Tue, 16 Sep 2014 11:15:57 +0000 (13:15 +0200)]
Bug 12669: Centralize the timezone handle into Koha::DateUtils

This patch adds unit tests for the previous changes and centralize the
timezone handle into the Koha::DateUtils module.
Like that the behavior will affect all date manipulations using this
module (should be all dates in Koha).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit f82064286d3bc97031ad784901716a7a327839bc)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12669: Use floating timezone when handling dates without hours, minutes and seconds.
Rolando Isidoro [Fri, 1 Aug 2014 08:42:30 +0000 (09:42 +0100)]
Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds.

Test plan:

1. Create a new serial record or pick an existing one;
2. Add a "New subscription" and set the "First issue publication date"
   and "Frequency" values so that the "Planned date" for a given issue
   hits a day where a transition to Daylight Saving Time (DST) occurs

   ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979)
   ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html
   to find a suitable transition to DST in your timezone in the current year.

3. From the "Subscription detail" page in Koha for the given record click
   the "Serial collection" link on the left side context menu.

Expected result:
Prior to applying the patch the error described in this bug report should occur.
After the patch is applied the "Serial collection" page should load correctly.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e8f9000fcca4fd542f7f82e2288d3a627053dd77)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13679 : Bug in listing overdues
Chris Cormack [Sat, 7 Feb 2015 04:04:40 +0000 (17:04 +1300)]
Bug 13679 : Bug in listing overdues

To test
1/ Create some overdues and some issues due in the future
2/ Run the overdues script
3/ Notice item due in the future is in the list
4/ Apply patch
5/ Run script again
6/ Notice in the future not in the list

Signed-off-by: Nick <Nick@quechelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 07f9dd9f8c2abb43a031c91449661a779ff53746)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13728: koha-translate -l -a shows po files instead of language codes
Tomas Cohen Arazi [Wed, 18 Feb 2015 15:27:20 +0000 (12:27 -0300)]
Bug 13728: koha-translate -l -a shows po files instead of language codes

This patch corrects the call to 'basename' inside the script so it correctly
shows the language code when asked to list the available languages.

To test:
- On a packages install, run:
  $ koha-translate --list --available
=> FAIL: It shows:
am-Ethi-opac-bootstrap.po
ar-Arab-opac-bootstrap.po
az-AZ-opac-bootstrap.po
be-BY-opac-bootstrap.po
ben-opac-bootstrap.po
...

- Apply the patch
- Copy the patched debian/scripts/koha-translate script to your packages setup.
- Run:
  $ koha-translate --list --available
=> SUCCESS: It shows:
am-Ethi
ar-Arab
az-AZ
be-BY
ben
...

- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 6b26f8858e5069a2fae21fb28692a8eeb37fa0a8)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13568 OAI Server doesn't handle properly resumption token
Frédéric Demians [Mon, 12 Jan 2015 11:18:19 +0000 (12:18 +0100)]
Bug 13568 OAI Server doesn't handle properly resumption token

When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't
return proper resumption token. At the end of a result set, OAI server
generates a resumption token even if there isn't anymore records. Consequently,
OAI harverster will send a new request, based on this invalid resumption,
token. OAI Server responds with an empty resultset, which is considered as an
invalid response by most of the harvesters.

TO TEST:

- Find in your DB, a day where a few biblio records have been created. The
  number of created biblios must inferior to OAI-PMH:MaxCount.

- Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server:

  /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09

- At the end of the result, you will see a resumption token which looks like that:

  <resumptionToken cursor="47">marcxml/47/2014-01-09/2014-01-09/</resumptionToken>

  This is wrong. No resumptiion token should be sent since there isn't anymore
  records to harvest.

- Apply the patch.

- Resend the OAI-PMH request. There is no resumption token at the end of the
  result.

- You could test also with ListIdenfiers verb in place of ListRecord.

Signed-off-by: Christophe Brocquet <christophe.brocquet@obspm.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit f1ea9624bd197b04f78750bcc4d8f07ef2f9675d)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoTranslation updates for Koha 3.18.04 release
Bernardo Gonzalez Kriegel [Sun, 22 Feb 2015 22:13:10 +0000 (19:13 -0300)]
Translation updates for Koha 3.18.04 release

9 years agoBug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"
Katrin Fischer [Sun, 8 Feb 2015 15:23:41 +0000 (16:23 +0100)]
Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13352: On editing, prices should not be formatted
Jonathan Druart [Mon, 26 Jan 2015 09:28:27 +0000 (10:28 +0100)]
Bug 13352: On editing, prices should not be formatted

Bug 12979 refactored the way to display prices.
The price format configuration was duplicated everywhere it was used.

All calls looks good except the one in admin/aqbudgetperiods.pl
In this one, the prices are formatted for an edition field (input).
This means the input is incorrectly filled even if the user does not
update the field.

At the end, maybe should we manage formatted prices everywhere, even in
inputs, but it's not in the scope of this bug.

Technically, a new subroutine format_for_editing is added to the
Koha::Number::Price module.
It should be called everywhere a price is displayed in an input field.
At the moment, it only does a sprintf("%.2f"), but it is a first step to
let the number of decimals to display configurable.

To test:
1/ Verify the issue described is fixed (editing a budget with a total
amount > 1000 (With CurrencyFormat is US or FR).
2/ Verify you can edit a fund with a total amount > 1000

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking...
Kyle M Hall [Tue, 20 Jan 2015 15:11:24 +0000 (10:11 -0500)]
Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment

The hbyymmincr autoBarcode builder looks up all barcodes that begin with
any number of letters ( the branchcode ) and a two-digit year directly
afterward ( e.g. MPL15 ), then grabs the last four digits as the
increment counter. The problem is, this does not take months into
account, so unlike the description that says the system is limited to
10,000 items a month, it is limited to 10,000 items per *year*.

This situation can easily be corrected my adding the month into the
lookup ( e.g. MPL1501 ).

Test Plan:
1) Enable autoBarcode, set to hbyymmincr
2) Catalog an item, let the barcode.pl plugin generate
   the next barcode.
3) Catalog an item with the barcode MPL15009999
4) Catalog another item, use the barcode.pl plugin to
   generate the next barcode.
5) Note the barcode is generated ends with '0001' instead of the
   correct increment
6) Apply this patch
7) Repeat step 4
8) Note the barcode now ends with the correct increment

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jeanne Heicher <nppublib@pa.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Problem confirmed - the continuing number bit was not reset
to start counting from 1 again on the beginning of a new month.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit b280b4890c813b5535b6e98b27c390d9af10551a)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13142 - Change "mobile phone" label back to "other phone"
Owen Leonard [Wed, 12 Nov 2014 19:42:37 +0000 (14:42 -0500)]
Bug 13142 - Change "mobile phone" label back to "other phone"

Labeling a phone number field "mobile phone" eliminates the usefulness
of having the labels "primary" and "secondary." Generic labels let the
user populate the fields according to their importance rather than their
type.

To test I recommend editing a patron record so that the values in the
patron record contain a label matching the table column:

borrowers.phone : 555-555-1234 (primary - phone)
borrowers.phonepro : 555-555-5678 (secondary - phonepro)
borrowers.mobile : 555-555-9012 (other - mobile)

View this patron's information in the various affected templates and
verify that the labels correctly match the data:

 - OPAC "your personal details" (opac-memberentry.pl)
 - Submit changes to primary, secondary, and other phone via the OPAC.
   In the staff client, view the confirmation for those changes.
 - Patron details in the staff client (moremember.pl)
 - Patron entry/edit in the staff client (memberentrygen.pl)
 - Patron duplicate confirmation in the staff client
   (you can navigate directly to
   /members/moremember.pl?borrowernumber=XXXX&print=brief)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a7da45099f49093cc950a1392d6488543af5ddd3)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13343: Embed items when send a basket/shelf
Jonathan Druart [Wed, 26 Nov 2014 14:14:59 +0000 (15:14 +0100)]
Bug 13343: Embed items when send a basket/shelf

When a basket/shelf is downloaded, items are embedded, but not when
sending it by email.

We would expect to get the same file.

Test plan:
On Opac and intranet:
1/ Add records with items to your basket and send it by email.
Verify the file contains items.
2/ Add records with items to a list and send it by email.
Verify the file contains items.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a0e5d77a719443c6616194a898795f70d34d6ebc)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing
Kyle M Hall [Tue, 25 Nov 2014 15:16:47 +0000 (10:16 -0500)]
Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing

No matter what the selection of OPACShowHoldQueueDetails is, if it is
enabled it displays a line "Holds and priority:" even if you've opted to
hide one of those!

Test Plan:
1) Apply this patch
2) Test each setting of OPACShowHoldQueueDetails
3) Ensure each setting displays the correct fields ( or lack thereof )

Signed-off-by: Christopher Brannon <cbrannon@debian.localdomain>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 295fb70f62069c0b1fbed2d9bbdf2650f58e488c)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13636 - Staff search results item status incorrect for holds
Kyle M Hall [Wed, 28 Jan 2015 13:31:30 +0000 (08:31 -0500)]
Bug 13636 - Staff search results item status incorrect for holds

Imagine this scenario: we have one record with four items. Two of those
items are checked out, one of those items is a waiting hold, and one of
those items is available. We would expect to see this on the search
results page. Instead, we will see both non-checked out items as
unavailable due to waiting holds.

This is due to a semantic issue GetReserveStatus.
C4::Search::searchResults uses GetReserveStatus to get the reserve
status of each item, but unlike all other calls to the sub, this one
passes in not only itemnumber, but biblionumber.

When no reserve is found for the available item, the subroutine uses the
biblionumber to grab what is essentially an arbitrary reserve to use for
the status. This makes no sense and this functionality should be
entirely removed from the subroutine so regressions like this will be
prevented in the future.

Test Plan:
1) Create one record with 4 items
   a) check two of the items out to patrons
   b) set one of the items as a waiting hold
   c) leave the fourth item as available
2) Run a search where this record will be in the results list
3) Note that the results list 2 items on loan, two unavailable
4) Apply this patch, reload the search results
5) Note that the results list 1 available, 2 on loan, 1 unavailable

Signed-off-by: John Andrews <jandrews@washoecounty.us>
Signed-off-by: Sheila Kearns <sheila.kearns@state.vt.us>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note: This is for the staff search result list!

Works as expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fcaa6f35c080c079ba422a70dec49ca327346c82)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13431 [QA Follow-up]: Shared FastMmap file causes issues
Jacek Ablewicz [Tue, 30 Dec 2014 09:30:30 +0000 (10:30 +0100)]
Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues

1) Removed 'use C4::Context;' because it can lead to introduction
of circular reference in the near future
2) Put fastmmap initialization code into an eval {} block, to catch
various kinds of errors which can still occur during it's init in
some [less usual] Koha setups and/or more unusual circumstances
3) Do not include UID in the sharefile name (it will be constructed
using namespace + database name + database host instead).

Test plan addendum:

   s/and UID//

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit dbf0b358b9362fdf634b47569b1777d7034b17a9)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13431 - Shared FastMmap file causes issues
Jacek Ablewicz [Tue, 16 Dec 2014 11:48:09 +0000 (12:48 +0100)]
Bug 13431 - Shared FastMmap file causes issues

Koha::Cache package does not take into account that, when using
fastmmap caching variant, mmaped cache file created in /tmp
(typically: /tmp/sharefile-koha-koha), would only be further
accessible to the one given OS user - the one which created it.
In many Koha setups, in the circumstances when various system scripts
are executed by 2+ users with diffrent UIDs (like multi-tenant servers,
for example) this may cause many kinds of issues. Observable symptom
is usually the appearance of the below error when searching, or looking
at MARC Framework pages and a few other places:

Open of share file /tmp/sharefile-koha-koha failed: Permission denied
at /usr/lib/perl5/Cache/FastMmap.pm line 640.

This patch:
- disables initialisation of fastmmap caching subsystem unless it is
explicitly requested by the user (CACHING_SYSTEM=fastmmap)
- disables fastmmap cache usage for command line scripts
(i.e. when GATEWAY_INTERFACE environment variable is not defined)
- adds the database name, host name and an ID of the OS user to the
mmaped file name created in /tmp, to prevent various kinds of
unintentional conflicts and/or permission problems from happening

To test:

1) remove the /tmp/sharefile-koha-* file[s] (if any)
2) do something which would lead to its re-creation (e.g., performing
any search in OPAC should be sufficient to cause that)
3) observe that /tmp/sharefile-koha-koha got created
4) remove it
5) apply patch
6) redo step 2)
7) observe that aforementioned file is no longer created in /tmp
8) set CACHING_SYSTEM environment variable to 'fastmmap'
9) redo step 2), observe that /tmp/sharefile-koha-* file got created
and that it's name now contains hostname, database name and UID
10) ensure that everything still works like it should and that there
are no regressions of any kinds anywhere in the system ;)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13670 - Patron holds table not loading when holds tab anchor is used
Kyle M Hall [Thu, 5 Feb 2015 14:21:12 +0000 (09:21 -0500)]
Bug 13670 - Patron holds table not loading when holds tab anchor is used

If a link to a patron record ends with #reserves, the holds tab is selected
on page load, but the holds table does not load.

Test Plan:
1) Build your holds queue
2) From the holds queue report, open any patron link
3) Note the patron's reserves do not load
4) Apply this patch
5) Clear your browser cache
6) Repeat step 2
7) Note the holds table now loads

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 87bcc8b303e506514318814f63c430a3a54f1181)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13319: Fix Koha::Acq::Order should set parent_ordernumber
Jonathan Druart [Fri, 14 Nov 2014 15:18:09 +0000 (16:18 +0100)]
Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber

The tests highligh the problem: if the parent_ordernumber attribute is
not set on inserting an order, the object returned by the method does
not contain the value (undef).

Test plan:
Verify the tests are consistent and
    prove t/db_dependent/Acquisition/CancelReceipt.t
should return green.

You can also verify that receive partially an order and cancel the
receipt work as expected.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit f19a1777a0847ce2dc10b7f259bf76fc2d382d19)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber
Kyle M Hall [Wed, 21 May 2014 18:09:04 +0000 (11:09 -0700)]
Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber

The acquisitions search is exhibiting the same behavior as bug 11410.
Results are always fixed in order of biblionumber, among other possible
issues ( including the ampersand issue ).

Test Plan:
1) From an open basket, choose "Add to basket"
2) Run a search for "From an existing record"
3) Note the "View MARC" URLs are fixed in order of biblionumber
4) Apply this patch
5) Refresh the page
6) Note the results are no longer fixed in order of biblionumber

Signed-off-by: David Cook <dcook@prosentient.com.au>
Works as described.

I think the code could be a bit tidier, but I think it makes sense to
use buildQuery here. It'll detect CCL, CQL, and PQF queries, as well
as parsing a regular keyword search as one would expect when searching
the catalogue.

It also has the added bonus of performing relevance searching,
so long as QueryAutoTruncation is off, and so long as library staff
avoid using the "*" truncation wildcard (see bug 12430).

While there are simpler ways to fix this acq bug, I think this was
probably the best move, as it adds a bit to the consistency of what
librarians can expect from their search results.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Same result with and without the patch but I agree with the changes.
BuildQuery should be called before SimpleSearch if QP is not used.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit dc5b94486304fc5353640c0341cdfa11d3367fb2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBumping db version to 3.18.03.002
Chris Cormack [Sat, 14 Feb 2015 07:11:00 +0000 (20:11 +1300)]
Bumping db version to 3.18.03.002

9 years agoBug - 5511 [Followup]: QA Fixes
Katrin Fischer [Tue, 30 Dec 2014 09:14:15 +0000 (09:14 +0000)]
Bug - 5511 [Followup]: QA Fixes

- Move database update entry to correct spot
- Fix version number in database update
- Fix capitalization in sys pref description
- Fix sequence in sysprefs.sql

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 57d411dcd6a60fa36033a92e6cd1901b0ec7c78d)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug - 5511 [Followup]: Missed Instance
Martin Renvoize [Thu, 11 Dec 2014 13:39:24 +0000 (13:39 +0000)]
Bug - 5511 [Followup]: Missed Instance

There was an instance of the pragma missed which meant the the original
patch set didn't actually solve the problem in a large number of cases

This patch adds in the relevant statement.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d556f6a9f2ead235b9daf9df7217ebf2cd2b2b5c)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug - 5511 [Followup]: Switched defults
Martin Renvoize [Tue, 9 Dec 2014 13:48:29 +0000 (13:48 +0000)]
Bug - 5511 [Followup]: Switched defults

Agree with Chris that the defualt should maintain the higher security
and not reduce it.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 129fb1fbe211b136ccad4d214ee26b94e988e5e5)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug - 5511: Added new system preference: SessionRestrictionByIP
Amit Gupta [Tue, 8 Oct 2013 04:06:59 +0000 (09:36 +0530)]
Bug - 5511: Added new system preference: SessionRestrictionByIP

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2d4d65d526e6f54a40ddec87a6d3207722234fd3)

Conflicts:
installer/data/mysql/updatedatabase.pl

9 years agoBug - 5511: Check for Change in Remote IP address for Session Security. Disable when...
Amit Gupta [Tue, 8 Oct 2013 04:03:54 +0000 (09:33 +0530)]
Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.

To Test:
1) Enable the system preference SessionRestrictionByIP
2) Change your system IP. It will not checkout your system IP or signout.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e3bb1390807578e2b9898723e2816a58f2c01e57)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 11954 - Clean up currency default files
Mark Tompsett [Wed, 19 Nov 2014 18:28:12 +0000 (13:28 -0500)]
Bug 11954 - Clean up currency default files

It makes no sense to have TRUNCATE or foreign key checks.

TEST PLAN
---------
1) Back up your database
2) in an mysql client:
     use kohadata;
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql
     SET FOREIGN_KEY_CHECKS=0;
     TRUNCATE currency;
     source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql
     SET FOREIGN_KEY_CHECKS=1;
     QUIT
   -- These should all work without problem.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 3cf719433597ad6bf558950270cd564a62164ab4)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13298 - Holds ratios report ignores ordered items
Kyle M Hall [Wed, 19 Nov 2014 13:16:17 +0000 (08:16 -0500)]
Bug 13298 - Holds ratios report ignores ordered items

The holds ratio report ignores ordered items. This could cause a library
to inadvertently order more copies of a title than they actually need.
An option should be added to count ordered items ( i.e. any negative
notforloan value ).

Test Plan:
1) Apply this patch
2) Create a record with two items, one regular, one ordered.
3) Place 3 holds on the item
4) Run the reserve ratios report, by default you should see this record
5) Check the new 'include ordered' checkbox, rerun the report
6) Note that record is no longer displayed

Signed-off-by: Heather Braum <hbraum@nekls.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d8e5f0cd9d5926fb3b72e47852eac6b6c4f59be9)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoRevert "Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)""
Chris Cormack [Fri, 13 Feb 2015 01:19:58 +0000 (14:19 +1300)]
Revert "Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)""

This reverts commit 1120246a818e16af04cf155984fec7c44b5ed47c.

9 years agoRevert "Bug 13352: On editing, prices should not be formatted"
Chris Cormack [Fri, 13 Feb 2015 01:19:54 +0000 (14:19 +1300)]
Revert "Bug 13352: On editing, prices should not be formatted"

This reverts commit abc46657e5039ba9d40637624390c0a28a664c8e.

9 years agoBug 13201: GetSuggestion takes suggestionid
Jonathan Druart [Wed, 5 Nov 2014 11:41:13 +0000 (12:41 +0100)]
Bug 13201: GetSuggestion takes suggestionid

Having $ordernumber as the parameter in a function which is
handling suggestions and it is used as a suggestion id is
confusing to the coder and person trying to read the code.
This patch corrects the confusion.

REVISED TEST PLAN
-----------------
1) perldoc C4::Suggestions
   -- notice it says ordernumber for the GetSuggestions example.
2) Ensure you have CPL in your branches table.
3) prove -v t/db_dependent/Suggestions.t
   -- if you have more than 8 itemtypes in your database, two
      tests at the end will fail, but that is not relevant to
      the modified GetSuggestions code.
4) apply patch
5) perldoc C4::Suggestions
   -- notice it is corrected now.
6) prove -v t/db_dependent/Suggestions.t
   -- it should run with the same results as in step 3.
      That is, if you have 8 itemtypes, all pass, otherwise
      those two tests fail.
7) run koha qa test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ddf909ae24df5a3185370f5c4916135bb94b67ae)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13404: [QA Follow-up] Minor rewording of some warnings
Marcel de Rooy [Mon, 9 Feb 2015 08:26:04 +0000 (09:26 +0100)]
Bug 13404: [QA Follow-up] Minor rewording of some warnings

Changes are confirmed with author (Mirko Tietgen). See Bugzilla.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 09edfe8d53f91d150c39be9ec41bc24c82ce93dd)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13404 [QA Followup]
Kyle M Hall [Fri, 2 Jan 2015 02:06:58 +0000 (21:06 -0500)]
Bug 13404 [QA Followup]

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 983f49d7b28e3bf65c799f7ff00d64bdb10429d0)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13404 - More System information about GRS1 vs DOM settings
Mirko Tietgen [Sun, 7 Dec 2014 17:39:51 +0000 (18:39 +0100)]
Bug 13404 - More System information about GRS1 vs DOM settings

System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml.

This patch

- adds warnings about a possible mismatch between these settings and the actual setup
- adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set.

The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 6a68ac3e5ded2e56d9b9de8f6e1a6a9ed49ac327)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13401 - sort branches alphabetically in admin/authorised_values.pl
Fridolin Somers [Fri, 5 Dec 2014 14:50:05 +0000 (15:50 +0100)]
Bug 13401 - sort branches alphabetically in admin/authorised_values.pl

This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages.

Also replaces var $branch (too ambigus) by $branchcode.

Test plan :
- Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch
- Create a new authorized value : admin/authorised_values.pl
- Look at "Libraries limitation" :
=> Without patch branches are sorted by code : Zbranch then Abranch
=> Without patch branches are sorted by name : Abranch then Zbranch
- Select a branch and save
- Re-edit
=> Check the same branch is selected

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit b6aae39c263eee482aaeb574c206fa0c2c69f120)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"
Katrin Fischer [Sun, 8 Feb 2015 15:23:41 +0000 (16:23 +0100)]
Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit bc355fef2455b7b22c29a061db72d07046169738)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13352: On editing, prices should not be formatted
Jonathan Druart [Mon, 26 Jan 2015 09:28:27 +0000 (10:28 +0100)]
Bug 13352: On editing, prices should not be formatted

Bug 12979 refactored the way to display prices.
The price format configuration was duplicated everywhere it was used.

All calls looks good except the one in admin/aqbudgetperiods.pl
In this one, the prices are formatted for an edition field (input).
This means the input is incorrectly filled even if the user does not
update the field.

At the end, maybe should we manage formatted prices everywhere, even in
inputs, but it's not in the scope of this bug.

Technically, a new subroutine format_for_editing is added to the
Koha::Number::Price module.
It should be called everywhere a price is displayed in an input field.
At the moment, it only does a sprintf("%.2f"), but it is a first step to
let the number of decimals to display configurable.

To test:
1/ Verify the issue described is fixed (editing a budget with a total
amount > 1000 (With CurrencyFormat is US or FR).
2/ Verify you can edit a fund with a total amount > 1000

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 945a0f09e73606907d6df72b873e478cc6763c14)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
admin/aqbudgetperiods.pl
t/Prices.t

9 years agoBug 13562: Fix item search on item MARC subfields
Julian Maurice [Wed, 14 Jan 2015 16:00:17 +0000 (17:00 +0100)]
Bug 13562: Fix item search on item MARC subfields

Test plan:
1. Add 4 item search fields (in Administration › Items search fields):
   a. 1 biblio field linked to a DB field
   b. 1 biblio field not linked to a DB field
   c. 1 item field linked to a DB field
   d. 1 item field not linked to a DB field
2. Make sure you have some data in those fields to search on.
3. Go to item search page and do a search using these new fields, make
   sure the result is correct.

Signed-off-by: Nick <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit f70ad43f8fd49ad7fb43697c6953767e534f7368)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13602: (QA followup) take advantage of the defined-or operator
Tomas Cohen Arazi [Mon, 9 Feb 2015 16:32:50 +0000 (13:32 -0300)]
Bug 13602: (QA followup) take advantage of the defined-or operator

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 381de54ed1f56f61f22a682147b67d3902f43604)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13602 - Username/password already exists when editing borrower attributes and...
Olli-Antti Kivilahti [Tue, 20 Jan 2015 14:48:13 +0000 (16:48 +0200)]
Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences

When editing a Patron's messaging preferences or borrower attributes, one cannot
save changes because 'userid' is not given as a parameter.

It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.

REPLICATE THE ISSUE:
1. Find a Borrower.
2. Go to the details-tab.
3. Under "Patron messaging preferences" click edit to edit just the messaging
   preferences.
4. Just save, no need to make any modifications.
5. Observe the error "Username/password already exists"
   This happens to all/most of the sub-forms in the Borrower's Details-view.

AFTER THIS PATCH:
Check_Userid() get the $userid from the new parameters, or if not present, from
the koha.borrowers-table.

TEST FOR REGRESSION:
1. Edit a borrower normally. Notice no errors.
2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
   errors.

DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's
extent without my permission. As long as it makes to Koha I am happy.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 58f7f56b8664810335f60f3fe5e43faa079f33bc)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13638 - Batch patron modification tool missing option to switch language
Owen Leonard [Wed, 28 Jan 2015 17:24:45 +0000 (12:24 -0500)]
Bug 13638 - Batch patron modification tool missing option to switch language

The batch patron modification tool's template was created without the
footer include at the bottom. Without the footer include the language
toolbar will not be displayed.

All page templates should include the global footer include:

[% INCLUDE 'intranet-bottom.inc' %]

To test:
 - Install at least a second language
 - Enable at least 2 languages (language system preference)
 - Go to tools > Batch patron modification
 - Verify that at the bottom of the page the language chooser is shown

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 28af6c4d01e0b1a31dece34031b6379fb9befebc)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13450 [QA Followup] - Remove tab character from start of line
Kyle M Hall [Fri, 30 Jan 2015 12:10:29 +0000 (07:10 -0500)]
Bug 13450 [QA Followup] - Remove tab character from start of line

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fe66114e210885324eb37773e2bd09e7e2190f59)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13450 - Title and breadcrumb of Patron form can look weird in translations
Marc Véron [Mon, 29 Dec 2014 23:04:53 +0000 (00:04 +0100)]
Bug 13450 - Title and breadcrumb of Patron form can look weird in translations

This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability.

Note: It does not change anything in functionallity, it only changes display of strings.

To test:
Apply patch
Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found)
Duplicate a patron
Create a new patron
Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following:
Modify patron Hansli Meier (Juvenile)

(Missing </div> added)

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e2bbdc0b145fba30bd60110ad2d4fd8262107947)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBumping version number to 3.18.03.001
Chris Cormack [Tue, 10 Feb 2015 22:15:02 +0000 (11:15 +1300)]
Bumping version number to 3.18.03.001

9 years agoBug 12860: the export tools explodes if a field is not exported
Jonathan Druart [Thu, 29 Jan 2015 15:18:19 +0000 (16:18 +0100)]
Bug 12860: the export tools explodes if a field is not exported

To reproduce:
1/ Go on tools/export.pl
2/ Export some records and specify you don't want the fields 245 (the
whole field, do not specify a subfield).
3/ Export, BOOM
Software error:
Arguments must be MARC::Field object at /home/koha/src/tools/export.pl line 400.

Test plan:
Apply the patch and confirm the fields 245 are not exported and the
export works as expected.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Export fails to asplode with this patch

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e2968fe0812898d92ce8c63e9c7f0dedd244acc9)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13270: Don't display "vendor note" label if nothing to display
Jonathan Druart [Mon, 17 Nov 2014 16:17:49 +0000 (17:17 +0100)]
Bug 13270: Don't display "vendor note" label if nothing to display

Bug 12111 removes the vendor note edition on receiving.
The label should not be displayed when it's empty.

Test plan:
1/ Receive an order without a vendor note and verify that the label is not
displayed.
2/ Receive an order with a vendor note and verify that the note is
displayed.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, small template change.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 1c62f1a9783bb8a171352e0b66d910056ccfe0d4)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13441 - Branchcodes should not be allowed to have spaces in them
Kyle M Hall [Thu, 1 Jan 2015 21:38:34 +0000 (16:38 -0500)]
Bug 13441 - Branchcodes should not be allowed to have spaces in them

In multiple cases I've seen issues arise in Koha where a librarian
accidentally puts a space at the end of a new branchcode. This of course
causes endless confusion because the branchcode looks perfectly fine in
every case unless you wrap the code with some characters to reveal the
hidden space!

Test Plan:
1) Try creating a new branch with one or more spaces in the branchcode
2) Note you are able to
3) Apply this patch
4) Repeat step 1
5) Note you are no longer able to

Followed test plan with cache cleared. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit a7c41e6073a2719e21f86909a37daab6410b2b96)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 12905: funds with children could not be deleted
Jonathan Druart [Mon, 10 Nov 2014 09:45:25 +0000 (10:45 +0100)]
Bug 12905: funds with children could not be deleted

The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').

This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.

Test plan:
Verify you are not allow to delete a fund with children.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 522e9c5861854fad7c9b292f75ebd19968f5b11c)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 13333: Fix Display basket group for already received orders
Jonathan Druart [Tue, 25 Nov 2014 11:23:45 +0000 (12:23 +0100)]
Bug 13333: Fix Display basket group for already received orders

Bug 11111 adds a basket group column on the parcel page.
But it seems that the already received orders never contain the value
(always 'no basket group').

Test plan:
Receive an order which is in a basket group and verify the basket group
column is correctly filled.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 74640683f0d7f4b9734a69763424b33977f66cfd)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>