]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoFix for Bug 2539 - kohaspsuggest is deprecated, notes outmoded
Owen Leonard [Mon, 22 Aug 2011 20:09:05 +0000 (16:09 -0400)]
Fix for Bug 2539 - kohaspsuggest is deprecated, notes outmoded

Removing unused script.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRevert "Bug 5630 CAS improvements"
Chris Cormack [Fri, 2 Sep 2011 01:22:20 +0000 (13:22 +1200)]
Revert "Bug 5630 CAS improvements"

This reverts commit 9a3950f673c28688a2ead6514c3320e34ec0cc4c.

13 years agoBug 6822: fix RIS export from OPAC
Steven Callender [Tue, 30 Aug 2011 19:19:23 +0000 (15:19 -0400)]
Bug 6822: fix RIS export from OPAC

Prior to this patch, RIS export was producing
effectively empty output.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote-tracking branch 'kc/new/bug_6351' into kcmaster
Chris Cormack [Thu, 1 Sep 2011 09:28:41 +0000 (21:28 +1200)]
Merge remote-tracking branch 'kc/new/bug_6351' into kcmaster

13 years agoBug 6351: Cannot delete library-specific holds polices and checkout limits
Ian Walls [Tue, 30 Aug 2011 17:49:51 +0000 (13:49 -0400)]
Bug 6351: Cannot delete library-specific holds polices and checkout limits

Template::Toolkit scope error on delete links on Checkout Limit by Patron Category
and Holds Policy by Item Type areas.

Testing Results:
Tested adding and removing Checkout Limits by Patron Category - both work
Tested adding and removing Holds Policies by ItemTypes - both work

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6704 : Escaping html in the merging records, so " don't break the merge
Chris Cormack [Mon, 29 Aug 2011 04:46:11 +0000 (16:46 +1200)]
Bug 6704 : Escaping html in the merging records, so " don't break the merge

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6656 : Fix for advanced search not respecting default sort order
Chris Cormack [Mon, 29 Aug 2011 03:35:45 +0000 (15:35 +1200)]
Bug 6656 : Fix for advanced search not respecting default sort order

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6794 : Fixing a bug with member flags in IE
Maxime Pelletier [Fri, 26 Aug 2011 21:09:46 +0000 (09:09 +1200)]
Bug 6794 : Fixing a bug with member flags in IE

Rebased for template toolkit

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
13 years agoBug 5524 : Cant delete list from the second page of lists
Chris Cormack [Fri, 26 Aug 2011 01:42:44 +0000 (13:42 +1200)]
Bug 5524 : Cant delete list from the second page of lists

Includes follow up fixing deleting lists in OPAC

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6528 : Cataloguing search not showing location for available items
Chris Cormack [Mon, 29 Aug 2011 02:14:58 +0000 (14:14 +1200)]
Bug 6528 : Cataloguing search not showing location for available items

Cataloging search now shows holdings information.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6715 - Fix xmlControlfield.js so the xml files are fetched in the correct languag...
preprod34 [Fri, 12 Aug 2011 15:44:33 +0000 (11:44 -0400)]
Bug 6715 - Fix xmlControlfield.js so the xml files are fetched in the correct language directory.

xmlControlfield.js was always fetching the "en" xml file, preventing the translations
from working.

http://bugs.koha-community.org/show_bug.cgi?id=6715

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- Apply patch
- Install language files, example: perl translate install de-DE
- Edit .xml files for value builders 006 and 008
- Test by creating a new record and using value builders

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUpdating about page and history
Chris Cormack [Sun, 28 Aug 2011 07:47:22 +0000 (19:47 +1200)]
Updating about page and history

13 years agoMerge remote-tracking branch 'kc/new/bug_6712' into kcmaster
Chris Cormack [Sun, 28 Aug 2011 07:34:25 +0000 (19:34 +1200)]
Merge remote-tracking branch 'kc/new/bug_6712' into kcmaster

13 years agoMerge remote-tracking branch 'kc/new/bug_6696' into kcmaster
Chris Cormack [Sun, 28 Aug 2011 07:34:18 +0000 (19:34 +1200)]
Merge remote-tracking branch 'kc/new/bug_6696' into kcmaster

13 years agoFix for Bug 6712 - Remove memberofinstitution markup from templates until it can...
Owen Leonard [Thu, 11 Aug 2011 19:21:35 +0000 (15:21 -0400)]
Fix for Bug 6712 - Remove memberofinstitution markup from templates until it can be completed

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
1) Make sure syspref memberofinstitution is turned on
2) Add a new patron of organisation category (example: library)
3) Check that there is no field set 'organisation' showing up
4) Checkout books to any borrower
5) Renew books until no longer possible
6) Scan barcode from renewed book to force renewal
6) Check that the 'no more renewals' message has no empty pull below text message

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6696, New category button broken when no categories defined
Owen Leonard [Wed, 10 Aug 2011 15:44:37 +0000 (11:44 -0400)]
Fix for Bug 6696, New category button broken when no categories defined

The javascript tablesorter will trigger an error if we try
to apply it to a table with no <tbody>. That error prevented
the YUI button script to complete properly, hence the broken
button.

This patch hides the table in cases where there are no
categories and displays an error message instead.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- Deleted all patron categories and checked button was broken
- Applied patch and checked again - button shows up
- Nice: There is a note now that you have to create categories

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6652, Zip showing in funny place on libraries admin
Owen Leonard [Mon, 1 Aug 2011 11:51:18 +0000 (07:51 -0400)]
Fix for Bug 6652, Zip showing in funny place on libraries admin

This fixes display of Zip code relative to the city and state if
you're in the USA and you like to do it this way. At the very
least this matches how we display addresses elsewhere in Koha.

It should be noted that this makes it incorrect for anyone who
wants to see addresses like this:

[name]
[street address]
[postal code + city]

...or any other variation of course.

While I'm in there, also making branch URLs and emails clickable.

Signed-off-by: Nicole Engard <nengard@gmail.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6791 - editing list with apostrophe loses text
Owen Leonard [Fri, 26 Aug 2011 19:14:48 +0000 (15:14 -0400)]
Fix for Bug 6791 - editing list with apostrophe loses text

Markup used single quotes around value attribute. Since single
quotes aren't escaped by the template's HTML filter these
quotes conflicted with the one in the text.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6733 - Change return page after printing routing slip
Colin Campbell [Fri, 26 Aug 2011 16:14:25 +0000 (17:14 +0100)]
Bug 6733 - Change return page after printing routing slip

Previously printing a routing slip returned the user to
the top level in serials this change maintains the context
in the current subscription

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6765: sip2 unicode checksum
Ulrich Kleiber [Fri, 29 Jul 2011 14:35:40 +0000 (16:35 +0200)]
Bug 6765: sip2 unicode checksum

Changes checksum calculation method, as per Dan Scott's fix in openncip.
see http://sourceforge.net/tracker/?func=detail&aid=2925760&group_id=161781&atid=821216

http://bugs.koha-community.org/show_bug.cgi?id=6765
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4419 - cannot change module for notice templates
Owen Leonard [Mon, 22 Aug 2011 15:08:59 +0000 (11:08 -0400)]
Fix for Bug 4419 - cannot change module for notice templates

Adding a hidden form field to contain the original module
so that it can be used in the check for an existing entry.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge branch 'new/bug_4330' into kcmaster
Chris Cormack [Sat, 27 Aug 2011 07:34:36 +0000 (19:34 +1200)]
Merge branch 'new/bug_4330' into kcmaster

13 years agoBug 6662: Remove Dewey Specific References in Sort
Nicole C. Engard [Sat, 20 Aug 2011 23:33:18 +0000 (19:33 -0400)]
Bug 6662: Remove Dewey Specific References in Sort

The sort option used to include tooltips for call number
that were Dewey specific.   This patch removes references
to Fiction and Nonfiction so that it can apply to any
classification.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago6747 Checks in opac-export
Marcel de Rooy [Mon, 22 Aug 2011 12:02:03 +0000 (14:02 +0200)]
6747 Checks in opac-export

Added check on returned marc. If record does not exist, generate 404. (Prevents 500 errors by Googlebot on deleted records.)
Fixed typo, whitespace. Removed if on op=export. Added check on format.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Fri, 26 Aug 2011 03:32:55 +0000 (15:32 +1200)]
Bumping database version

13 years agoBug 5866 : Updated patch to speed up holds awaiting pickup
Chris Cormack [Thu, 25 Aug 2011 03:21:01 +0000 (15:21 +1200)]
Bug 5866 : Updated patch to speed up holds awaiting pickup

This reduced execution time on the report from timeout (1400 holds waiting + 200 holds over) to 6 or so seconds, with 1566 holds over (test data, no holds waiting).

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
13 years agoFix for Bug 4893, Add an input field for Check In on main Staff Client page
Owen Leonard [Mon, 8 Aug 2011 16:36:07 +0000 (12:36 -0400)]
Fix for Bug 4893, Add an input field for Check In on main Staff Client page

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote-tracking branch 'kc/new/bug_6753' into kcmaster
Chris Cormack [Fri, 26 Aug 2011 03:12:32 +0000 (15:12 +1200)]
Merge remote-tracking branch 'kc/new/bug_6753' into kcmaster

13 years agoFollow-up fix for Bug 6753, Markup corrections and improvements for label export...
Owen Leonard [Fri, 19 Aug 2011 14:23:58 +0000 (10:23 -0400)]
Follow-up fix for Bug 6753, Markup corrections and improvements for label export window

Making the same changes to the patron card export window.
Now that all references are removed, the old icons and CSS
have been removed as well.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
13 years agoBug 6748 - Add link to fast add framework while circulating, if a barcode is not...
Chris Cormack [Fri, 19 Aug 2011 03:18:47 +0000 (15:18 +1200)]
Bug 6748 - Add link to fast add framework while circulating, if a barcode is not found

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
13 years agoMerge remote-tracking branch 'kc/new/bug_6726' into kcmaster
Chris Cormack [Fri, 26 Aug 2011 03:01:09 +0000 (15:01 +1200)]
Merge remote-tracking branch 'kc/new/bug_6726' into kcmaster

13 years agoFollow-up fix for Bug 6726 - When SMS is enabled the messaging table is misaligned
Owen Leonard [Wed, 24 Aug 2011 13:50:19 +0000 (09:50 -0400)]
Follow-up fix for Bug 6726 - When SMS is enabled the messaging table is misaligned

Corresponding fix for the OPAC

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFixing typo in history doc
Chris Cormack [Fri, 26 Aug 2011 01:00:54 +0000 (13:00 +1200)]
Fixing typo in history doc

13 years ago150th developer!!!
Chris Cormack [Fri, 26 Aug 2011 00:49:50 +0000 (12:49 +1200)]
150th developer!!!

13 years agoBug 6723 : import-framework-crlf
Ward van Wanrooij [Mon, 15 Aug 2011 12:38:40 +0000 (14:38 +0200)]
Bug 6723 : import-framework-crlf

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
13 years agoBug 6721 - improve searching in the acquisitions system
Srdjan Jankovic [Mon, 15 Aug 2011 06:17:52 +0000 (18:17 +1200)]
Bug 6721 - improve searching in the acquisitions system

This allows a basket to be searched for by name or invoice number from
anywhere in the acquisitions system. It is accessible by clicking on
"orders search", clicking the '[+]' and filling in the basket or invoice
no. fields.

Author:    Srdjan Jankovic <srdjan@catalyst.net.nz>
Author:    Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6562: Silence runtime error in reserve/request.pl
Colin Campbell [Mon, 4 Jul 2011 15:20:59 +0000 (16:20 +0100)]
Bug 6562: Silence runtime error in reserve/request.pl

Not defining action just causes logging of noisy
runtime warnings.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 6538 update letter.pl help file
Nicole C. Engard [Tue, 28 Jun 2011 19:24:45 +0000 (15:24 -0400)]
bug 6538 update letter.pl help file

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6695 - Layout of patron category add/edit form slightly broken
Owen Leonard [Wed, 10 Aug 2011 15:16:42 +0000 (11:16 -0400)]
Fix for Bug 6695 - Layout of patron category add/edit form slightly broken

The markup for the fields for enrollment period "in months" and "until date"
was non-standard I think because the two fields are supposed to be visually
and functionally linked (having the same purpose and being mutually
exclusive).

This patch changes the markup so that the two fields share a fieldset
having "choose one" as the legend. The "hint" is now hidden unless
it is triggered by the javascript validation on submit.

I wanted to trigger the validation of the two fields onblur instead
of just onsubmit, but found that the datepicker widget doesn't
consistently trigger a change or a blur event on that field.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- Layout problems are fixed
- Layout is more clear about choosing either 'In months' or 'Until date'
- Clear error message shows when you enter values in both fields

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow-up to Bug 4868, Improve controls for cloning and deleting subfields
Owen Leonard [Mon, 15 Aug 2011 19:22:21 +0000 (15:22 -0400)]
Follow-up to Bug 4868, Improve controls for cloning and deleting subfields

- Adding similar icons for cloning and deleting tags
- Adding icon for the "Tag editor" links ("...")

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
13 years agoBug 6690: If multiple issues are received in serials-edit.pl, changing the status...
Frédérick Capovilla [Sun, 14 Aug 2011 19:42:52 +0000 (21:42 +0200)]
Bug 6690: If multiple issues are received in serials-edit.pl, changing the status of any issue changes the date of the first issue.

If multiple issues are in the list, changing the status of any issue in
the table would always change the "Expected on" date of the first issue.
Modified the javascript so the date is modified on the correct row.

Reimplementation of Patch for 3.4.x
Patch for 3.2.x from Frédérick Capovilla

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6727 - Change on exporting and importing csv to deal with spurious CR/LF
Salvador Zaragoza Rubio [Fri, 19 Aug 2011 10:33:05 +0000 (12:33 +0200)]
Bug 6727 - Change on exporting and importing csv to deal with spurious CR/LF

Function _export_table_csv modified to remove CR/LF in the data
from the database to built a correct csv file.

Function _import_table_csv modified to deal with CR/LF in the data
field. When a line is found with an unproper end (a data field has not
end quote), it's concatenated to a temporary buffer until the next
line ends ok and then it's proccessed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote-tracking branch 'kc/new/bug_5498' into kcmaster
Chris Cormack [Thu, 25 Aug 2011 00:07:49 +0000 (12:07 +1200)]
Merge remote-tracking branch 'kc/new/bug_5498' into kcmaster

13 years agoFollow-up fix for Bug 5498, Standardize markup and style of pagination menus
Owen Leonard [Fri, 19 Aug 2011 18:40:48 +0000 (14:40 -0400)]
Follow-up fix for Bug 5498, Standardize markup and style of pagination menus

Missed a couple of instances of the pagination menu on the
lists page. Previously the pagination links on the page
listing lists (/cgi-bin/koha/virtualshelves/shelves.pl) was
unstyled. After this patch the links should be styled.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6602 - Reports dictionary doesn't properly recognize text columns
Owen Leonard [Mon, 18 Jul 2011 19:38:13 +0000 (15:38 -0400)]
Fix for Bug 6602 - Reports dictionary doesn't properly recognize text columns

Reports dictionary won't let you set a comparison for MEDIUMTEXT columns. To
test, choose a MEDIUMTEXT column like borrowers.surname in Step 3 of adding
a new dictionary definition. Before the patch, in Step 4 you would not see
any kind of form field for entering a comparison. After patching Step 4 will
offer you a field labeled "Search string matches."

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes described problem with mediumtext columns.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFixing executable bit on koha-httpd.conf
Chris Cormack [Tue, 23 Aug 2011 20:49:13 +0000 (08:49 +1200)]
Fixing executable bit on koha-httpd.conf

13 years agoMerge remote-tracking branch 'kc/new/enh/bug_6540' into kcmaster
Chris Cormack [Tue, 23 Aug 2011 03:52:52 +0000 (15:52 +1200)]
Merge remote-tracking branch 'kc/new/enh/bug_6540' into kcmaster

13 years agoBug 6540 - Followup - koha-create would die without --configfile
Magnus Enger [Mon, 15 Aug 2011 07:00:07 +0000 (09:00 +0200)]
Bug 6540 - Followup - koha-create would die without --configfile

koha-create would fail to check that --configfile was set on the
commandline, before either including it if it existed or dying if
it did not. This patch should make sure the existence of a
configfile is only tested if --config is set.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
This should apply against 3.4 and master.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6726 - When SMS is enabled the messaging table is misaligned
Owen Leonard [Tue, 16 Aug 2011 12:38:21 +0000 (08:38 -0400)]
Fix for Bug 6726 - When SMS is enabled the messaging table is misaligned

The SMS section of the template was commented out in the patch
pushed for Bug 5889, 'Allow message names to be translatable'
with the comment 'fixing columns overflow.' That seems to have been
a cosmetic fix for what I can only imagine was a different bug?

Also fixing a T:T variable scope error.

After applying this patch the "SMS" column in the Patron messaging
preferences should appear when the SMSSendDriver preference is not empty.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6728, Table sorter for receiving acquisitions
Owen Leonard [Wed, 17 Aug 2011 20:04:55 +0000 (16:04 -0400)]
Fix for Bug 6728, Table sorter for receiving acquisitions

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6703 : Link to invoice broken
Chris Cormack [Mon, 22 Aug 2011 02:05:05 +0000 (14:05 +1200)]
Bug 6703 : Link to invoice broken

13 years agoMerge remote-tracking branch 'kc/new/bug_6678' into kcmaster
Chris Cormack [Sun, 21 Aug 2011 07:56:57 +0000 (19:56 +1200)]
Merge remote-tracking branch 'kc/new/bug_6678' into kcmaster

13 years agoBug 6269 - can't undefine a printer profile
Chris Nighswonger [Wed, 17 Aug 2011 15:23:17 +0000 (11:23 -0400)]
Bug 6269 - can't undefine a printer profile

This patch adds a 'No Profile/N/A' selection to the printer profile
drop-down menu along with code to handle the selection of it. This
selection is the default selection for new templates.

Documentation should be updated to reflect this change.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6678 - Fix some problems with the standard NORMARC framework
Magnus Enger [Sun, 7 Aug 2011 21:38:02 +0000 (23:38 +0200)]
Bug 6678 - Fix some problems with the standard NORMARC framework

- Almost all fields are displayed as expanded in the cataloguing screens,
  because hidden=0 when it should be -1
- Koha-specific fields need to be translated
- some unnecessary punctuation should be removed
- problem with encoding - æøå not displayed correctly

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- created a new database  with all nb-NO sample files, no errors reported
- checked the cataloging frameworks for displaying problems
- saved record and created an item - all koha specific fields translated
No problems found.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6753, Markup corrections and improvements for label export window
Owen Leonard [Thu, 18 Aug 2011 20:25:32 +0000 (16:25 -0400)]
Fix for Bug 6753, Markup corrections and improvements for label export window

The most visible change in this patch is the conversion of image-only
links to text links combined with icons. Other changes include
markup corrections and standardization and language corrections.

To test, go to Labels > Manage Batches. Select a batch and click
'Export' to see the revised interface.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6754, Improve breadcrumbs on lists pages
Owen Leonard [Fri, 19 Aug 2011 18:38:37 +0000 (14:38 -0400)]
Fix for Bug 6754, Improve breadcrumbs on lists pages

Breadcrumb navigation on the lists pages should give the user links back to the
category of list they're viewing, public or private.

Patch changes this:

Lists -> Contents of (Your list)

To this:

Lists -> Your lists -> Contents of (Your list)

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6486 - make koha-mysql get installed with the packages
Robin Sheat [Thu, 9 Jun 2011 05:15:09 +0000 (17:15 +1200)]
Bug 6486 - make koha-mysql get installed with the packages

A useful addition I overlooked.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6486 - add the koha-mysql command
Robin Sheat [Thu, 9 Jun 2011 05:00:45 +0000 (17:00 +1200)]
Bug 6486 - add the koha-mysql command

This lets you get into the mysql session for this library instance
really easily. Probably most useful for developers.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote-tracking branch 'kc/new/bug_6458' into kcmaster
Chris Cormack [Thu, 18 Aug 2011 09:13:12 +0000 (21:13 +1200)]
Merge remote-tracking branch 'kc/new/bug_6458' into kcmaster

13 years agoBug 6458 Template Toolkit files test case
Frédéric Demians [Thu, 21 Jul 2011 08:18:29 +0000 (10:18 +0200)]
Bug 6458 Template Toolkit files test case

This test validate Template Toolkit (TT) Koha files.

For the time being an unique validation is done: Test if TT files
contain TT directive within HTML tag. For example:

  <li[% IF

This kind of constuction MUST be avoided because it break Koha
translation process.

This patch transform also translation specific modules into C4 modules
in order to be able to use them in test case:

  C4::TTPaser
  C4::TmplToken
  C4::TmplTokenType

This patch is a Perl adaptation of a Haskell script from Frère Sébastien
Marie.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Notes on testing:
- translate install de-DE - worked ok
- translate update de-DE > translate install de-DE - worked ok
- running the test xt/tt_valid.t - worked ok and pointed out lots of problems.
Found no problems.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6482 - allow the mysql details to be changed during koha-create
Robin Sheat [Wed, 8 Jun 2011 03:10:09 +0000 (15:10 +1200)]
Bug 6482 - allow the mysql details to be changed during koha-create

This allows the database details (username and database name in
particular) to be modified in between a koha-create --request-db and
--populate-db. Most useful when you discover that the username is too
long or something. Now, when populating the database, the connection
information is reloaded from the koha-conf.xml rather than being
generated from the instance name.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6640, Locations not showing in circ reports
Owen Leonard [Tue, 2 Aug 2011 19:23:00 +0000 (15:23 -0400)]
Fix for Bug 6640, Locations not showing in circ reports

An invalid template syntax for defining a variable's default
value is found in the circ report template and several
others:

[% DEFAULT LibraryNameTitle="Koha Online" %]

Based on the T:T docs this appears to be the correct way of defining
a default value:

[% LibraryNameTitle or "Koha Online" %]

Reference:

http://template-toolkit.org/docs/manual/Syntax.html#section_Implicit_Directives_GET_and_SET

Signed-off-by: Nicole Engard <nengard@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6714 : Removed the "en" in some paths of opac.css
preprod34 [Fri, 12 Aug 2011 13:44:51 +0000 (09:44 -0400)]
Bug 6714 : Removed the "en" in some paths of opac.css

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6743 - displayFacetCount not working
Owen Leonard [Wed, 17 Aug 2011 19:40:39 +0000 (15:40 -0400)]
Fix for Bug 6743 - displayFacetCount not working

T:T variable scope error.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6744 - Acknowledge the actual es-ES translators
Tomas Cohen Arazi [Wed, 17 Aug 2011 16:45:34 +0000 (13:45 -0300)]
Bug 6744 - Acknowledge the actual es-ES translators

es-ES translator credits are way outdated as of http://translate.koha-community.org/es/34

Regards
To+

Signed-off-by: Federico Rinaudo <frinaudo@infocpt.com.ar>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Tue, 16 Aug 2011 22:35:52 +0000 (10:35 +1200)]
Bumping database version

13 years agoMerge remote-tracking branch 'kc/new/bug_4002' into kcmaster
Chris Cormack [Tue, 16 Aug 2011 22:34:55 +0000 (10:34 +1200)]
Merge remote-tracking branch 'kc/new/bug_4002' into kcmaster

13 years agobug_4002: issues referential integrity
Paul Poulain [Wed, 3 Aug 2011 09:29:01 +0000 (11:29 +0200)]
bug_4002: issues referential integrity

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5098: Add csv headers in overdues
Julian Maurice [Mon, 4 Apr 2011 14:52:03 +0000 (16:52 +0200)]
Bug 5098: Add csv headers in overdues

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5713 :debug calculation when fines are reversed then re-payed
Brice Sanchez [Tue, 8 Feb 2011 18:01:46 +0000 (13:01 -0500)]
Bug 5713 :debug calculation when fines are reversed then re-payed

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I could not reproduce the calculation bug, but after
applying this patch multiple pay/reverse cycles only
are still only  2 lines in accountlines, which makes the
display a lot less confusing.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6116: Adding a child patron
Christophe Croullebois [Mon, 7 Feb 2011 16:23:39 +0000 (17:23 +0100)]
Bug 6116: Adding a child patron

When adding a patron who is a child, the default library is not set when defining a guarantor, this patch corrects the problem.
More, for children with no guarantors, the default branch is the editing branch.

BibLibre MT5795

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug #6068 - New feature: capability to blanking subfields in BatchMod
Alex Arnaud [Wed, 6 Apr 2011 09:19:57 +0000 (11:19 +0200)]
Bug #6068 - New feature: capability to blanking subfields in BatchMod

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Nicole Engard <nengard@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBugs 6634: manager_id not recorded for payments and rental charges
Ian Walls [Wed, 27 Jul 2011 02:11:42 +0000 (22:11 -0400)]
Bugs 6634: manager_id not recorded for payments and rental charges

Manager_id, the borrowernumber of the staff person doing the action, was not recorded
for payments, rental charges, or rental charges on renewals.  This patch implements that.

This patch also adds the recording of itemnumber in a payment, by taking the itemnumber of
the account that it's paying off.  This addresses bug 2696, though it does not make any
change to the display logic of the Payments line in the staff client.

To test:
1.  Check out an item with an issuing charge
2.  Renew the item
3.  Pay one of the rental charges on the item
4.  Verify in koha.accountlines that each of the three above operations recorded your borrowernumber
in accountlines.manager_id

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug #6139 Automatic incrementation of call number does not work if prefix contains '
Sophie Meynieux [Fri, 8 Apr 2011 10:12:09 +0000 (12:12 +0200)]
Bug #6139 Automatic incrementation of call number does not work if prefix contains '

This patch also fixes giving the first callnumber with a given prefix.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6181: Remove CGI Scolling lists from C4::Budgets
Colin Campbell [Wed, 13 Apr 2011 16:21:47 +0000 (17:21 +0100)]
Bug 6181: Remove CGI Scolling lists from C4::Budgets

As noted on bug 766 more cases of usage of
CGI::scrolling_list were imported into C4::Budgets
Even if we were not trying to remove usage of this
the C4 modules are not the place to generate markup
Most of these routines are noise as they are not used in
any current code but cause confusion and increase
maintenance overhead. They are removed

The sort dropboxes on order create are the only
references in current templates to these routines
they have been replaced by a select list generated
by the markup.
They can probably be removed too but their existence
although the option that causes them to be displayed
seems unlikely to be set. I've left them pending
resolution of some of the inconsistencies and
confusions surrounding Budgts

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6309, subscription table sorter in the opac
Owen Leonard [Thu, 5 May 2011 13:32:06 +0000 (09:32 -0400)]
Fix for Bug 6309, subscription table sorter in the opac

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
13 years agoBug 2629: add char-with-stroke support to word-phrase-utf.chr
Ian Walls [Thu, 21 Jul 2011 14:48:33 +0000 (10:48 -0400)]
Bug 2629: add char-with-stroke support to word-phrase-utf.chr

This patch adds diacritic search support for the following characters-with-stroke:
a,b,c,d,e,h,l,r,t,u,y,z

Handles both uppercase and lowercase mappings.

Also corrects a note in word-phrase-utf.chr:  the 'equivalent' command is NOT for searching,
but rather for sorting.  See Zebra manual: http://www.indexdata.com/zebra/doc/character-map-files.html,
near the bottom.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Some notes:
- Copied the file to my koha-dev folder and reindexed
- Tried some simple searches like: Süden and Suden, schon und schön with success
- Added some of the new characters to a record and tried search with and
  without diacritics (ɨƗʉⱥɆɌ and iiuaer) with success.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5252 - Phone labels on patron creation
Nicole C. Engard [Tue, 9 Aug 2011 15:20:47 +0000 (11:20 -0400)]
Bug 5252 - Phone labels on patron creation

The labels for emails on the patron forms say 'primary' and
'secondary.' This patch does the same thing for the phones.
phone is now 'Primary phone', mobile is now 'Secondary phone',
and 'phonepro' is now 'Other phone'. This way the type of phone
does not matter and the phone that the patron wants to be called
at the most is the 'primary.'

This is just a step in the direction of fixing Bug 5252, not a
complete fix.

This patch also updated a stray reference to Home Email.  Both the
OPAC and staff client are updated with this patch.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6706 : Add Crystal Clear Icon Set
Nicole C. Engard [Wed, 10 Aug 2011 05:21:20 +0000 (01:21 -0400)]
Bug 6706 : Add Crystal Clear Icon Set

The Crystal Clear icon set was created by
Everaldo Coelho, http://www.everaldo.com/
Submitted:  Oct 11 2003
Updated:  Jun 16 2007

Icons were acquired from Wikimedia Commons,
http://commons.wikimedia.org/wiki/Crystal_Clear, 30 Jan 2010.

Added to this set were three images by RayAna Min Park (August 2011):

books-closed.png
books-open-cd.png
books-open.png

All Icons are free software; you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as
published by the Free Software Foundation; either version 2.1 of
the License, or (at your option) any later version.

Additional images are available in the set if libraries feel they
want more.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
13 years agoMerge remote-tracking branch 'kc/new/bug_6476' into kcmaster
Chris Cormack [Sun, 14 Aug 2011 07:55:46 +0000 (19:55 +1200)]
Merge remote-tracking branch 'kc/new/bug_6476' into kcmaster

13 years agoBug 6476: Baker & Taylor Content Cafe link not showing
Ian Walls [Thu, 4 Aug 2011 15:21:01 +0000 (11:21 -0400)]
Bug 6476: Baker & Taylor Content Cafe link not showing

Another T:T issue.  Patch replaces 'BakerTaylorContenturl' with 'BakerTaylorContentURL'
universally in all occurences in the templates (only opac-detail.tt)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6692: Small template change: Set > Set library
Katrin Fischer [Fri, 5 Aug 2011 11:28:27 +0000 (13:28 +0200)]
Bug 6692: Small template change: Set > Set library

Changes the link to change the library from 'Set' to 'Set library'
in the grey toolbar in staff.

13 years agobug 6702 update typo in BiblioAddsAuthorities preference
Nicole C. Engard [Tue, 9 Aug 2011 23:56:26 +0000 (19:56 -0400)]
bug 6702 update typo in BiblioAddsAuthorities preference

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6626 - add sudo as a package dependency
Robin Sheat [Mon, 25 Jul 2011 02:16:30 +0000 (14:16 +1200)]
Bug 6626 - add sudo as a package dependency

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6150 UNIMARC field 225 plugin: allow $a value data entry
Frédéric Demians [Fri, 8 Apr 2011 17:49:33 +0000 (19:49 +0200)]
Bug 6150 UNIMARC field 225 plugin: allow $a value data entry

The current UNIMARC 225 plugin behavior forces cataloguer to select a
collection name in a combo box. The content of this combo box comes from
special EDITORS authorities list which is constructed by a script. So
there is no way to add a new collection directly in biblio data entry
form.

A input box can be added to the plugin form in order to enter by hand a
new collection.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6713, editing matching rules broken
Chris Cormack [Thu, 11 Aug 2011 22:23:59 +0000 (10:23 +1200)]
Bug 6713, editing matching rules broken

Was a template error, but also a bug that had been in there for a
while fixed too

Please test by editing a matching rule, match sure no new match checks
are added, and that the matchpoint components survive.

Then try importing some marc records using that match rule

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago5663: Show control number without organization code in staff URLs
Marcel de Rooy [Thu, 14 Jul 2011 09:46:42 +0000 (11:46 +0200)]
5663: Show control number without organization code in staff URLs

Intranet detail xsl adjusted at 4 places: 773 when leader19=c, 775, 780, 785.

Enable the pref UseControlNumber when testing this patch. And set pref XSLTDetailsDisplay to using XSLT stylesheets.
Test by adding a control number ($w) in abovementioned fields.
Go to staff detail and check if the links work.
Add some orgcode between parentheses or brackets in front of the control number.
Test again in staff detail if the links still work.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6550 - update values for OpacRenewalBranch preference
Nicole C. Engard [Fri, 1 Jul 2011 06:02:04 +0000 (02:02 -0400)]
Bug 6550 - update values for OpacRenewalBranch preference

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6553 : Follow up adding license statements
Chris Cormack [Mon, 1 Aug 2011 09:26:28 +0000 (21:26 +1200)]
Bug 6553 : Follow up adding license statements

http://bugs.koha-community.org/show_bug.cgi?id=6653

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Patch only adds license text.

13 years agoBug 6553 : Fixing authentication issue, there is no reason we should be able to use...
Chris Cormack [Mon, 1 Aug 2011 09:23:45 +0000 (21:23 +1200)]
Bug 6553 : Fixing authentication issue, there is no reason we should be able to use these without authentication

http://bugs.koha-community.org/show_bug.cgi?id=6653

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
13 years agobug 6701 - change timeout to say milliseconds
Nicole C. Engard [Wed, 10 Aug 2011 00:34:08 +0000 (20:34 -0400)]
bug 6701 - change timeout to say milliseconds

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6468 - Authorities browsing error in OPAC
Janusz Kaczmarek [Mon, 6 Jun 2011 13:43:19 +0000 (16:43 +0300)]
Bug 6468 - Authorities browsing error in OPAC

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6461 - BiblioDefaultView has no impact on how record are displayed when going...
Janusz Kaczmarek [Sat, 4 Jun 2011 23:55:30 +0000 (02:55 +0300)]
Bug 6461 - BiblioDefaultView has no impact on how record are displayed when going from results list

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug_6410: correct borrowernumber template var name
Srdjan Jankovic [Wed, 25 May 2011 23:22:03 +0000 (11:22 +1200)]
bug_6410: correct borrowernumber template var name

Conflicts:

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6373 : Corrects a validation problem on addbiblio.pl on IE8
Frédérick Capovilla [Thu, 19 May 2011 14:46:29 +0000 (10:46 -0400)]
Bug 6373 : Corrects a validation problem on addbiblio.pl on IE8

The mandatory fields popup didn't appear when some mandatory fields
weren't filled on IE8. Replacing the "focus" with its JQuery equivalent
corrected the problem.

[EDIT by Owen Leonard] Removed commented line

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Follow-up by owen, that he forgot to upload on bugzilla:

Signed-off patch includes one minor edit: I removed the commented-out line

which the jQuery line replaces. We have git to track changes for us, we don't
have to leave old code in.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 6369 Correct a formatting problem in the pdf generation of basketgroup.pl
Frédérick Capovilla [Wed, 18 May 2011 20:27:20 +0000 (16:27 -0400)]
Bug 6369 Correct a formatting problem in the pdf generation of basketgroup.pl

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6346 - Patron search results should be valigned top
Owen Leonard [Thu, 19 May 2011 19:11:56 +0000 (15:11 -0400)]
Fix for Bug 6346 - Patron search results should be valigned top

I'm going for the nuclear option: Let's valign-top all table cells.
Having vertical-align : middle really only works well if your
table cells have the same height.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6686, Can't delete messages
Owen Leonard [Tue, 9 Aug 2011 20:10:47 +0000 (16:10 -0400)]
Fix for Bug 6686, Can't delete messages

T:T variable scope error which only affected systems
with the AllowAllMessageDeletion preference ON

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 6682: split openlibrary in to two words 'open library'
Nicole C. Engard [Mon, 8 Aug 2011 17:48:49 +0000 (13:48 -0400)]
bug 6682: split openlibrary in to two words 'open library'

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 6291, Cart printing truncated in Firefox
Owen Leonard [Mon, 2 May 2011 19:27:54 +0000 (15:27 -0400)]
Fix for Bug 6291, Cart printing truncated in Firefox

Implementing 100% width and height on <table>,<td>, and <th>
as suggested by this post:

http://www.piglets.org/serendipity/archives/45-Fixing-truncated-printing-with-Firefox.html

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>