]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoBug 3102 Fix Part 2: Fixed terminology on Transfers to Receive.
Nicole Engard [Mon, 18 May 2009 20:49:02 +0000 (15:49 -0500)]
Bug 3102 Fix Part 2: Fixed terminology on Transfers to Receive.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix permissions on new icons
Galen Charlton [Sat, 16 May 2009 01:20:28 +0000 (20:20 -0500)]
fix permissions on new icons

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding 4 additional icons to the bridge set: Software, Audio, Journal, and Realia.
Owen Leonard [Sat, 16 May 2009 00:57:16 +0000 (19:57 -0500)]
Adding 4 additional icons to the bridge set: Software, Audio, Journal, and Realia.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix XHTML errors in z3950_search.tmpl
Galen Charlton [Fri, 15 May 2009 14:59:49 +0000 (09:59 -0500)]
fix XHTML errors in z3950_search.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRevisions to auto-generated authorities patch
Brian Harrington [Wed, 29 Apr 2009 17:37:06 +0000 (13:37 -0400)]
Revisions to auto-generated authorities patch

It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Modified per comments by Joe and Galen to keep SetMarcUnicodeFlag
and move it and the leader set to earlier in the process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoImprove XSLT.pm performances
Frédéric Demians [Fri, 15 May 2009 08:26:33 +0000 (10:26 +0200)]
Improve XSLT.pm performances

This patch is done in the process of understanding what's
going wrong with bug #3226. It improves some processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 1440: Show a list of holidays. Fix for the date formats.
Garry Collum [Fri, 15 May 2009 11:37:50 +0000 (07:37 -0400)]
Bug 1440: Show a list of holidays. Fix for the date formats.

This patch fixes the date formats in the holiday display tables.  They are now based on the syspref for date formats.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG #1277 Enhance: Z39.50 More search criteria
Darrell Ulm [Fri, 15 May 2009 14:27:17 +0000 (10:27 -0400)]
BUG #1277 Enhance: Z39.50 More search criteria

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG 1277 Enhance: Z39.50 More search criteria
Darrell Ulm [Fri, 15 May 2009 14:27:16 +0000 (10:27 -0400)]
BUG 1277 Enhance: Z39.50 More search criteria

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)
Galen Charlton [Thu, 14 May 2009 00:37:17 +0000 (19:37 -0500)]
bug 3223: add 500 and 590 to MARC21 bib Note index (Zebra)

Note: to completely apply this change, ensure that the working
copy of record.abs is updated and rebuild the bib indexes
using rebuild_zebra.pl -b -x -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 1542, fixing filter by area in reports dictionary
Chris Cormack [Thu, 14 May 2009 06:46:56 +0000 (18:46 +1200)]
Bug 1542, fixing filter by area in reports dictionary

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 1440: Show a list of holidays. Second patch.
Garry Collum [Tue, 12 May 2009 20:53:15 +0000 (16:53 -0400)]
Bug 1440: Show a list of holidays. Second patch.

Fixed XHTML error that was introduced in the first patch. Added zebra striping to the tables. Removed an erroneous line with a date experiment that had no affect on the dates.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2505 adding use warnings and fixing warnings in opac-basket.pl
Chris Cormack [Tue, 12 May 2009 10:28:19 +0000 (22:28 +1200)]
Bug 2505 adding use warnings and fixing warnings in opac-basket.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd a date field in news edition, and permit to set the "timestamp" field, that is...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:00 +0000 (11:38 +0100)]
Add a date field in news edition, and permit to set the "timestamp" field, that is the publication date and modify the GetNewsToDisplay to return only news that timestamp is < to current date that permit to publish news later without any action.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMore fixes for Bug 2704, 440 Display Issues
Owen Leonard [Thu, 30 Apr 2009 16:36:19 +0000 (11:36 -0500)]
More fixes for Bug 2704, 440 Display Issues

Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3205: fix another error in the OAI-PMH Identify response
Galen Charlton [Fri, 8 May 2009 16:54:29 +0000 (11:54 -0500)]
bug 3205: fix another error in the OAI-PMH Identify response

The optional description element of an Identify response
can't just be a string.  Identify.description is a container
for one or more elements; see http://www.openarchives.org/OAI/2.0/guidelines.htm

For now, simply commenting it out.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBugfix 3205 - Fix OAI server resonse to Identify request
Frédéric Demians [Fri, 8 May 2009 14:45:45 +0000 (16:45 +0200)]
Bugfix 3205 - Fix OAI server resonse to Identify request

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3130 and general cleanup
Joe Atzberger [Tue, 28 Apr 2009 23:23:36 +0000 (18:23 -0500)]
Bug 3130 and general cleanup

Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional.  jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.

There were several other errors addressed by this patch:
 ~ 13 unused variables deleted.
 ~ regexps run on user-supplied $var before checking $var defined
 ~ decimal ratio prohibited and silently replaced with "3"

I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click.  Hidden .sql div now contains the actual query run,
like the other wizard reports.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG:3072 small work-around patch to restore authorities searching
Mason James [Thu, 2 Apr 2009 05:01:07 +0000 (18:01 +1300)]
BUG:3072 small work-around patch to restore authorities searching

this is a work-around fix, until a future patch arrives to define the missing 'Heading-Main' zebra-index.

for 3.0.x

[RM note: also included in HEAD so that I can include the UNIMARC(A)
 updates by HDL]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUse biblioitems.itemtype as a default for items.itype
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype

This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

[RM note: this patch means that an item's item-level item type,
 once that item is added or updated via additem.pl,
 now cannot be blank or NULL unless the biblio-level item type
 is blank.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3133 - correct typos
Joe Atzberger [Sat, 18 Apr 2009 17:43:06 +0000 (12:43 -0500)]
Bug 3133 - correct typos

This corrects 3 typographical errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModified log reporting to allow multiple modules to be selected.
David Goldfein [Fri, 24 Apr 2009 18:21:24 +0000 (13:21 -0500)]
Modified log reporting to allow multiple modules to be selected.

Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPatch to improve auto-generated MARC21 authorities
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities

This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040.  If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChange typo Localisation to Localization for Bug # 3102
Brendan A. Gallagher [Sat, 18 Apr 2009 20:42:30 +0000 (16:42 -0400)]
Change typo Localisation to Localization for Bug # 3102

[RM note: I think there are a few people who wouldn't
 call "localisation" a typo - such as our UK, NZ,
 Australian, etc. contributors ;-) ].  That said,
 I'm pushing this patch to consistent with the
 general trend of the English varient used on the
 /prog/ templates.  There's no implication that en_US
 is the "correct" version of the language.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFactor common element out of both sides of conditional.
Joe Atzberger [Tue, 7 Apr 2009 22:37:53 +0000 (17:37 -0500)]
Factor common element out of both sides of conditional.

Add placeholder complaint about misuse of TMPL EXPR statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoReformatting receipt template and CSS to be more readable.
Owen Leonard [Sun, 29 Mar 2009 23:46:39 +0000 (18:46 -0500)]
Reformatting receipt template and CSS to be more readable.

A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agochanged OAI-PMH implementation
Galen Charlton [Fri, 24 Apr 2009 16:25:05 +0000 (11:25 -0500)]
changed OAI-PMH implementation

Replaced older OAI-PMH server implementation
with new one by Frédéric Demians.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMulti-bug fix - SetMarcUnicodeFlag for records coming from Koha
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha

This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode.  This should help open the door for reliable
input of diacriticals via acquisitions.

MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.

Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3051) bad support of pagination in auth_finder
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:02:14 +0000 (13:02 +0100)]
(bug #3051) bad support of pagination in auth_finder

This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoorderreceive cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup

Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoacceptorreject.pl cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:54 +0000 (17:37 -0500)]
acceptorreject.pl cleanup

Perltidy the ugly block (still ugly).
Use elsif where appropriate.
Added FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding details to OPAC search results RSS, described in Bug 2973.
Owen Leonard [Thu, 2 Apr 2009 19:06:33 +0000 (14:06 -0500)]
Adding details to OPAC search results RSS, described in Bug 2973.

This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdds a 'New Subscription' option for selection from the detail page of a record.
Joshua Ferraro [Thu, 26 Mar 2009 22:09:44 +0000 (17:09 -0500)]
Adds a 'New Subscription' option for selection from the detail page of a record.

NOTE TO DOCUMENTATION WRITERS: Due to the limitations in the serials module search
interface, some users may find it easier to use the standard catalog search to locate
an item on which to create a subscription record, and then use this new button to
create a subscription from the detail page.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 3062, "place hold on lists different font"
Owen Leonard [Fri, 27 Mar 2009 20:31:52 +0000 (15:31 -0500)]
Fix for Bug 3062, "place hold on lists different font"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 3031, Standardize OPAC login form labels.
Owen Leonard [Wed, 11 Mar 2009 23:52:31 +0000 (18:52 -0500)]
Fix for Bug 3031, Standardize OPAC login form labels.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChanging "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be...
Owen Leonard [Mon, 16 Mar 2009 15:23:41 +0000 (10:23 -0500)]
Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd option to inventory tool to ignore copies on loan
Michael Hafen [Tue, 24 Feb 2009 19:05:50 +0000 (12:05 -0700)]
Add option to inventory tool to ignore copies on loan

This adds an option to the inventory tool causing it to ignore copies
currently on loan.  This is good if you want to do inventory, but don't
want to update the date-last-seen on items currently on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agowhitespace cleanup
John Beppu [Tue, 3 Feb 2009 22:02:05 +0000 (16:02 -0600)]
whitespace cleanup

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofixes SQL typo and return value in GetImportBatchStatus()
Mason James [Mon, 2 Feb 2009 12:33:21 +0000 (01:33 +1300)]
fixes SQL typo and return value in GetImportBatchStatus()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2687: Increased length of borrower attribute fields
Danny Bouman [Wed, 19 Nov 2008 20:58:42 +0000 (15:58 -0500)]
bug 2687: Increased length of borrower attribute fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2505: more warnings fixes in C4/Context.pm
Galen Charlton [Fri, 9 Jan 2009 18:16:43 +0000 (12:16 -0600)]
bug 2505: more warnings fixes in C4/Context.pm

* more portable way to determine uname for
  crash messages
* C4::Context->userenv now returns undef instead
  of 0 if no userenv has been set yet; returning
  undef when necessary is almost always better
  than returning a scalar when a hashref is
  normally expected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoEnable use warnings;, clean up complainy functions, fix a few tab/space formatting...
stan [Thu, 1 Jan 2009 17:39:33 +0000 (12:39 -0500)]
Enable use warnings;, clean up complainy functions, fix a few tab/space formatting issues.

Refactoring KOHAVERSION to be less crufty, enabling use warnings, change formatting slightly in places.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2900: fix GetPendingIssues.
Joe Atzberger [Thu, 8 Jan 2009 03:47:36 +0000 (21:47 -0600)]
Bug 2900: fix GetPendingIssues.

GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2842: ->regexp('syspref') failed for users of iso dateformat.
Joe Atzberger [Thu, 4 Dec 2008 04:33:02 +0000 (22:33 -0600)]
Bug 2842: ->regexp('syspref') failed for users of iso dateformat.

Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoA few more tweaks to the OPAC detail view menu
Owen Leonard [Wed, 31 Dec 2008 20:28:27 +0000 (14:28 -0600)]
A few more tweaks to the OPAC detail view menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 2700, Keeping Data When Adding Multiple Items
Owen Leonard [Tue, 4 Nov 2008 16:21:47 +0000 (10:21 -0600)]
Fix for Bug 2700, Keeping Data When Adding Multiple Items

When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFormatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug...
Owen Leonard [Tue, 21 Oct 2008 16:13:36 +0000 (11:13 -0500)]
Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2856) Activate the duplicate patrons detection and check birthdate only if...
Nahuel ANGELINETTI [Thu, 11 Dec 2008 09:08:15 +0000 (10:08 +0100)]
(bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set

This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to prior patch: remove $toggle from script
Galen Charlton [Wed, 31 Dec 2008 16:10:02 +0000 (10:10 -0600)]
followup to prior patch: remove $toggle from script

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemove "toggle" from template, use loop_context_vars __odd__ instead.
Joe Atzberger [Tue, 30 Dec 2008 17:20:14 +0000 (11:20 -0600)]
Remove "toggle" from template, use loop_context_vars __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2856 followup: remove unconditional warn
Galen Charlton [Mon, 29 Dec 2008 19:53:11 +0000 (13:53 -0600)]
bug 2856 followup: remove unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2856) Activate the duplicate patrons detection and check birthdate only if...
Nahuel ANGELINETTI [Thu, 11 Dec 2008 09:08:15 +0000 (10:08 +0100)]
(bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set

This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }
John Beppu [Mon, 22 Dec 2008 17:07:55 +0000 (11:07 -0600)]
bug 2874 [3/3] flagsrequired => { circulate => "circulate_remaining_permissions" }

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2874 [2/3]: added awareness of circulate/override_renewals subpermission
John Beppu [Mon, 22 Dec 2008 17:07:54 +0000 (11:07 -0600)]
bug 2874 [2/3]: added awareness of circulate/override_renewals subpermission

A few minor whitespace cleanups were thrown in as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2874 [1/3]: schema changes for overriding blocked renewals
John Beppu [Mon, 22 Dec 2008 17:07:53 +0000 (11:07 -0600)]
bug 2874 [1/3]: schema changes for overriding blocked renewals

Two new subpermissions of circulate were added:
- circulate_remaining_permissions
- override_renewals

Also, the following schema alterations were made
- permissions.code      : varchar(30) => varchar(64)
- user_permissions.code : varchar(30) => varchar(64)

  (The reason for this was because "circulate_remaining_permissions"
   was greater than 30 characters long and wouldn't fit.)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoImprovements to offline circ report (linking to title and patron records), and moving...
Owen Leonard [Thu, 2 Oct 2008 20:19:55 +0000 (15:19 -0500)]
Improvements to offline circ report (linking to title and patron records), and moving English strings from the script into the template to allow translation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2867 [2/2]: db changes for single-screen syspref editing
Jesse Weaver [Mon, 10 Nov 2008 22:20:06 +0000 (16:20 -0600)]
bug 2867 [2/2]: db changes for single-screen syspref editing

Database revision 007.

[Includes a correction by Galen Charlton]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2859: add index on bibioitems.issn (DB rev 006)
Chris Cormack [Fri, 4 Sep 2009 04:04:03 +0000 (16:04 +1200)]
bug 2859: add index on bibioitems.issn (DB rev 006)

Because of a query on biblioitems.issn in
C4::Breeding::ImportBreeding(), libraries doing a lot
of bib imports were experiencing performance problems,
which adding an index will alleviate.

A possible longer term solution is to index all
reservoir/import batch records in a Zebra database.

[LL bug 232]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Bumping version number for 3.0.4

Conflicts:

kohaversion.pl

15 years agoAdding some fixing for NoZebra
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:15 +0000 (14:58 +0100)]
Adding some fixing for NoZebra

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: turned on warnings for suggestion/acceptorreject.pl
Galen Charlton [Wed, 10 Dec 2008 23:30:03 +0000 (17:30 -0600)]
bug 2505: turned on warnings for suggestion/acceptorreject.pl

Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: turn on warnings in reviews/reviewswaiting.pl
Galen Charlton [Wed, 10 Dec 2008 23:36:56 +0000 (17:36 -0600)]
bug 2505: turn on warnings in reviews/reviewswaiting.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2848 [2/2]: Letters for holds notifications (DB rev 005)
Jesse Weaver [Fri, 5 Dec 2008 21:11:14 +0000 (15:11 -0600)]
bug 2848 [2/2]: Letters for holds notifications (DB rev 005)

This adds the necessary SQL for holds notifications to work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2848 [1/2]: Send notifications to patrons when hold is received
Jesse Weaver [Fri, 5 Dec 2008 21:11:13 +0000 (15:11 -0600)]
bug 2848 [1/2]: Send notifications to patrons when hold is received

This adds notification code to Reserves.pm to send notifications through email
or SMS to patrons when their hold is filled. It does not send the letter
directly, but instead uses EnqueueLetter. Also, it relies on
EnhancedPatronMessaging being on and the hold notification being turned on for
the specific patron through the 'Messaging' tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2754 Show hold request priority in OPAC
Chris Cormack [Fri, 4 Sep 2009 03:52:09 +0000 (15:52 +1200)]
Bug #2754 Show hold request priority in OPAC

Code changes to display the priority level on holds in OPAC. Turned on/off based on System Preference.  Database changes to systempreferences for both English and French

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed to work with 3.0.4

Conflicts:

admin/systempreferences.pl
installer/data/mysql/en/mandatory/sysprefs.sql
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql

15 years agobug 2613: allow web self-check to accept patron ID
Galen Charlton [Fri, 5 Dec 2008 23:17:02 +0000 (17:17 -0600)]
bug 2613: allow web self-check to accept patron ID

Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.

Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleaning up Self-Checkout interface, adding some basic formatting based on other...
Owen Leonard [Wed, 26 Nov 2008 20:46:07 +0000 (14:46 -0600)]
Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.

Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2825: improving readability of output messages in updatedatabase.pl
Andrew Moore [Wed, 26 Nov 2008 19:22:50 +0000 (13:22 -0600)]
bug 2825: improving readability of output messages in updatedatabase.pl

Two recent changes to updatedatabase.pl don't include newlines at the
end of their status messages. This patch adds them. This is only useful
if you're running this from the command line.

Note: there is an opportunity here to extract some of the simlar logic
from each of these blocks to a function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweaks to display of "views" tabs (MARC, ISBD, etc).
Owen Leonard [Wed, 26 Nov 2008 20:45:58 +0000 (14:45 -0600)]
Tweaks to display of "views" tabs (MARC, ISBD, etc).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix permissions error introduced by previous patch
Galen Charlton [Mon, 1 Dec 2008 16:38:23 +0000 (10:38 -0600)]
fix permissions error introduced by previous patch

Modules in C4 should not be executable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDelete all calls to thesaurus_popup.pl, and no more used plugins.
Nahuel Angelinetti [Mon, 1 Dec 2008 09:06:01 +0000 (10:06 +0100)]
Delete all calls to thesaurus_popup.pl, and no more used plugins.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2787 : Fix Global Due date
Ryan Higgins [Wed, 19 Nov 2008 15:56:12 +0000 (09:56 -0600)]
bug 2787 : Fix Global Due date

This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic.  If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2447: yuipath variable not getting passed to help pages
Jesse Weaver [Wed, 19 Nov 2008 13:58:31 +0000 (14:58 +0100)]
fix for bug 2447: yuipath variable not getting passed to help pages

This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
Ryan Higgins [Wed, 19 Nov 2008 15:55:38 +0000 (09:55 -0600)]
Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.

See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2654: require circulate permission to upload offline circ files
Galen Charlton [Tue, 18 Nov 2008 21:40:18 +0000 (15:40 -0600)]
bug 2654: require circulate permission to upload offline circ files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomoved Test_CSV_Various.t to xt/author
Galen Charlton [Mon, 17 Nov 2008 16:18:38 +0000 (10:18 -0600)]
moved Test_CSV_Various.t to xt/author

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoResults of CSV module analysis, testing various CSV modules and configs.
Joe Atzberger [Fri, 7 Nov 2008 21:49:59 +0000 (15:49 -0600)]
Results of CSV module analysis, testing various CSV modules and configs.

The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode.  Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1891 followup - remove dangling /TMPL_IF
Galen Charlton [Mon, 17 Nov 2008 15:21:33 +0000 (09:21 -0600)]
bug 1891 followup - remove dangling /TMPL_IF

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadding "DROP TABLE" commands to several table definitions in kohastructure.sql
Andrew Moore [Tue, 11 Nov 2008 20:47:51 +0000 (14:47 -0600)]
adding "DROP TABLE" commands to several table definitions in kohastructure.sql

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1891 : bib-level itemtype was required in order to place a hold.
Ryan Higgins [Wed, 12 Nov 2008 03:05:03 +0000 (22:05 -0500)]
bug 1891 : bib-level itemtype was required in order to place a hold.

This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2779: fix template syntax error in OPAC home page
Galen Charlton [Thu, 13 Nov 2008 00:19:20 +0000 (18:19 -0600)]
bug 2779: fix template syntax error in OPAC home page

Fixes cause of following message in Apache log:

[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrecting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Owen Leonard [Mon, 3 Nov 2008 20:07:44 +0000 (14:07 -0600)]
Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSome tab cleaning
Nahuel Angelinetti [Thu, 6 Nov 2008 08:41:48 +0000 (09:41 +0100)]
Some tab cleaning

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding javascript to let user click table cell to check containing checkbox.
Owen Leonard [Thu, 6 Nov 2008 19:04:11 +0000 (13:04 -0600)]
Adding javascript to let user click table cell to check containing checkbox.

This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoOverhaul of cover images. Replaces Amazon's "no cover" image with styled text, addres...
Owen Leonard [Mon, 27 Oct 2008 16:55:13 +0000 (11:55 -0500)]
Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCirc cleanup.
Joe Atzberger [Thu, 30 Oct 2008 05:14:25 +0000 (00:14 -0500)]
Circ cleanup.

Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agofollowup - make barcode_to_borrowernumber an internal function
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:52 +0000 (14:34 -0600)]
followup - make barcode_to_borrowernumber an internal function

Set this function apart with _ since it is not OO like the rest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd fine amount to display on circ pages.
Michael Hafen [Tue, 14 Oct 2008 20:36:42 +0000 (14:36 -0600)]
Add fine amount to display on circ pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2682: followup - only do lc() on $op once
Galen Charlton [Thu, 23 Oct 2008 21:07:19 +0000 (16:07 -0500)]
bug 2682: followup - only do lc() on $op once

Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on...
Owen Leonard [Wed, 15 Oct 2008 15:36:32 +0000 (10:36 -0500)]
Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUnravelling links in masthead. Regularize logic and improve readability.
Joe Atzberger [Fri, 19 Sep 2008 21:24:22 +0000 (16:24 -0500)]
Unravelling links in masthead. Regularize logic and improve readability.

Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2543: report output by tabulation a bit too literal
Jesse Weaver [Wed, 10 Sep 2008 00:31:31 +0000 (19:31 -0500)]
fix for bug 2543: report output by tabulation a bit too literal

This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup 5 to renewal limit override
Galen Charlton [Wed, 22 Oct 2008 23:11:31 +0000 (18:11 -0500)]
followup 5 to renewal limit override

With removal of content_hidden CSS class from
the circ templates, undoing change to staff-global.css

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup 4 to renewal limit override
Galen Charlton [Wed, 22 Oct 2008 23:11:30 +0000 (18:11 -0500)]
followup 4 to renewal limit override

* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
  items for a renew or return do not affect
  the override renewal limit checkbox

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup 3 to to renewal limit override
Galen Charlton [Wed, 22 Oct 2008 23:11:29 +0000 (18:11 -0500)]
followup 3 to to renewal limit override

style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllow renewal limits to be overridden
Michael Hafen [Wed, 22 Oct 2008 23:11:26 +0000 (18:11 -0500)]
Allow renewal limits to be overridden

Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoSteamlining javascript for cloning additem block and tweaking style.
Owen Leonard [Thu, 16 Oct 2008 15:45:29 +0000 (10:45 -0500)]
Steamlining javascript for cloning additem block and tweaking style.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2692: remove escape="url" from opac-facets.inc
Galen Charlton [Wed, 22 Oct 2008 20:22:46 +0000 (15:22 -0500)]
bug 2692: remove escape="url" from opac-facets.inc

Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTwo template bug-fixes: removing debugging output from opac-detail.tmpl, and turning...
Owen Leonard [Tue, 14 Oct 2008 18:50:47 +0000 (13:50 -0500)]
Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - use &amp; in place of &
Galen Charlton [Thu, 16 Oct 2008 20:45:41 +0000 (15:45 -0500)]
followup - use &amp; in place of &

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug in 'Add/Change link to item details...' I missed Previous checkouts area
Michael Hafen [Tue, 7 Oct 2008 17:30:27 +0000 (11:30 -0600)]
bug in 'Add/Change link to item details...' I missed Previous checkouts area

This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>