Owen Leonard [Sat, 10 May 2008 15:18:02 +0000 (10:18 -0500)]
Finishing adding additional markup for increased flexibility in stylesheet customization. Patch also includes some markup corrections, but shouldn't result in any visual changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 10 May 2008 15:17:54 +0000 (10:17 -0500)]
Changes to enable more flexibility in template customization. Container divs allow for graphical deliniation of logical screen areas.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Fri, 9 May 2008 23:08:13 +0000 (18:08 -0500)]
test suite: new tests for installer
Added tests of loading the DB initialization and
sampple data SQL scripts for every language
and MARC flavour combination defined in
installer/data/{dbms}. Errors that the
new test class should catch include:
* SQL syntax errors in kohastructure.sql
* SQL errors in the sample data
For each language and MARC flavour combination,
all mandatory and optional scripts are loaded.
As of this commit, several errors are reported
by this test class; these will be fixed separately.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Fri, 9 May 2008 23:08:12 +0000 (18:08 -0500)]
test suite refactoring
Moved routines to clear and create database and manage
zebraqueue_daemon.pl to KohaTest.pm so that they're
available to test classes - needed for installation
and upgrade tests in particular.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Fri, 9 May 2008 23:08:11 +0000 (18:08 -0500)]
C4::Installer - new method to get available MARC frameworks
For use by test suite; not a user-visible change.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 9 May 2008 20:06:26 +0000 (15:06 -0500)]
Bug 2094: fixing two bugs in lost items report
* I guess the limit by item type was never working. I made it look for the right database column
* I fixed the error that was returned with no items were returned.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 9 May 2008 19:03:28 +0000 (14:03 -0500)]
Bug 2094: cleanup of lost items report
Just some code cleanup of C4::Items::GetLostItems and reports/itemslist.pl.
Some whitespace changes, perltidy, and documentation improvements.
Also, I rewrote and SQL statement to try to reduce possibilities of SQL injection attacks.
No documentation or functional changes necessary with this patch.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 9 May 2008 19:03:27 +0000 (14:03 -0500)]
Bug 2094: implementing ability to select particular lost status in the lost items report
This patch adds a drop-down to the lost items report to let the user select a
particular lost status to display. Only items with that particluar lost status
will be dispolayed.
The documentation for the lost items report on the staff client will need to be slightly adjusted.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 9 May 2008 17:28:56 +0000 (12:28 -0500)]
Bug 2047: another fix for error during search when there is no MARC::Record
This is another fix for a bug that was introduced while adding this feature.
I believe that either this patch or the one at:
http://lists.koha.org/pipermail/koha-patches/2008-May/000309.html
should be applied.
In the case that GetMarcBiblio or GetMarcStructure does not return a true value,
this returns without further processing.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Thu, 8 May 2008 13:10:37 +0000 (08:10 -0500)]
bug 2088: test suite refactoring to deal with t/override_context_prefs.pm
Some minor changes to get the test suite working a bit better:
I removed a superfluous method from t/lib/KohaTest.pm.
I made each barcode for the items added in KohaTest.pm unique so that they would actually get inserted.
Then, I removed t/override_context_prefs.pm. If you need that functionality, you're a database
dependent test and should be a module in t/lib.
So, I deleted all of the trivial .t tests that just 'use'd their modules and had no other
tests and replaced them with lib/KohaTest/*pm modules that do a little bit more checking
on those modules.
I removed the references to override_context_prefs.pm in all of the other .t modules.
They all pass now with no override_context_prefs.pm module.
The database_depenedent.pl test script still does not pass entirely. There's a problem with the zebra index
not being reset each time that the tables are truncated. I'll get to that.
no functional or documentation changes here.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 8 May 2008 10:12:35 +0000 (05:12 -0500)]
Tweaking display of "action" links in search results
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 8 May 2008 10:12:26 +0000 (05:12 -0500)]
Fixing a couple of bugs, including Bug 2080, OPAC Lists : No way to remove biblios from list.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 8 May 2008 10:12:18 +0000 (05:12 -0500)]
Fix for Bug 2086, Filter Button Misleading. This moves the filter form into the left-hand sidebar.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 8 May 2008 10:12:09 +0000 (05:12 -0500)]
Adding RSS icon to search results (Fix for Bug 2078, RSS Icon on OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 8 May 2008 10:11:58 +0000 (05:11 -0500)]
Removing table sorting pending change to this page to allow paged display
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 8 May 2008 06:06:44 +0000 (01:06 -0500)]
Wrapper for Koha's use of HTML::Scrubber, with test script on usage.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 7 May 2008 20:23:25 +0000 (15:23 -0500)]
bug 2083: requiring that the test database have a different name from the production database
This patch requires that the test database name be different from the production database name.
The object here is to prevent people from specifying the same database for both, and then
losing all of their data in the production database.
This may cause problems for people who want to do that, though I consider that bad practice.
It may also cause problems for people if they have two different servers, each with identically
named database, and they want to use one for testing and the other for production. If we ever
find that someone like that exists, we can deal with that case.
I don't think there are any necessary documentation changes here yet since we're recommending
that users answer "no" to the question about setting up a test database.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 7 May 2008 19:38:43 +0000 (14:38 -0500)]
guided reports: make it possible to delete saved reports
Fixed JavaScript error that prevented user from deleting
a saved SQL.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 7 May 2008 18:50:37 +0000 (13:50 -0500)]
bug 2087: test cases for misc/cronjobs/longoverdue.pl
I'm adding some functional tests that demonstrate that long_overdue.pl does what we think it does.
These tests don't actually work since override_context_prefs.pm gets in the way of C4::Context::preference. I opened up bug 2088 to address that.
There are no functional or documentation changes due to this patch.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:26 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)
Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.
The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.
virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring
The following missing columns were added:
deletedbiblioitems.marcxml
deleteditems.itype
The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:
subscription.monthlength
deleteditems.marc
aqbooksellers.name
NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Wed, 7 May 2008 09:04:14 +0000 (11:04 +0200)]
Addressing bug 1782
Adding New Systempreference AddPatronLists
This systempreference allow administrator to choose if patrons are created on categorycode lists or category_type ones.
Overloading GetBorrowerCategory so that if no parameter provided, it returns the list of category records
Changing memberentry.pl in order to use the categorycode when provided.
Bug Fixing Circulation.pl so that doesnot come up with Error 500
with no category selected for GetBorrowerCategory
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:29 +0000 (10:04 -0500)]
kohabug 2076: add DB schema creation scripts from past versions
For test cases to be written soon, added kohastructure.sql (or equivalent)
from the following versions:
2.2.9
3.0-alpha
3.0-beta (note that schema for 3.0-beta2 is the same)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:28 +0000 (10:04 -0500)]
kohabug 2076: updated 2.2 -> 3.0 upgrade
Numerous changes to update22to30.pl to help ensure
that a database upgraded from 2.2.9 to 3.0 will have
a DB schema identical to that of a new installation.
These changes were testing by starting from an empty database,
loading koha.mysql from the 2.2.9 package, then running
update22to30.pl
move_marc_to_authheader.pl
move_marc_to_biblioitems.pl
dropping the following tables:
marc_subfield_table
auth_subfield_table
marc_biblio
marc_blob_subfield
auth_word
biblioanalysis
borexp
catalogueentry
charges
itemsprices
marc_word
marcrecorddone
sessionqueries
uploadedmarc
users
websites
z3950queue
z3950results
updatedatabase.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:27 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of kohastructure.sql
Changes to kohastructure.sql to sync with changes
made via updatedatabase.pl:
aqbooksellers.name (DB rev 042)
subscription.serialsadditems (DB rev 071)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:26 +0000 (10:04 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)
Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.
The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.
virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring
The following missing columns were added:
deletedbiblioitems.marcxml
deleteditems.itype
The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:
subscription.monthlength
deleteditems.marc
aqbooksellers.name
NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 5 May 2008 15:04:25 +0000 (10:04 -0500)]
kohabug 2076 - make biblioitems.marc longblob during upgrade
Change to match 3.0 definition of that column.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
NCE [Tue, 6 May 2008 11:30:17 +0000 (07:30 -0400)]
Fixing RSS <link>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Tue, 6 May 2008 11:24:50 +0000 (06:24 -0500)]
Removing obsolete RSS <link> tags and the scripts
Owen Leonard [Fri, 2 May 2008 19:20:47 +0000 (14:20 -0500)]
Tab fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:28 +0000 (19:03 +0200)]
synch'ing opac display with staff for scanIndexes
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Fri, 2 May 2008 17:03:27 +0000 (19:03 +0200)]
Bug fixing : loading page macles would not load existing values for macles
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:26 +0000 (19:03 +0200)]
Adding subfield filter to ISBD
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Fri, 2 May 2008 17:03:24 +0000 (19:03 +0200)]
Debugging Macles
say you want to edit 6 fields 630:
Provided you have those in your catalogue frameworks, you just selet 6 values and it puts values into that.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:23 +0000 (19:03 +0200)]
ordering by biblioitemnumber for best performance
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:22 +0000 (19:03 +0200)]
reserve at itemlevel was displayed only if item-level_itype
This patch just moves the checkbox out of the <tmpl_if item-level_itypes>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:21 +0000 (19:03 +0200)]
french translation (updated)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:20 +0000 (19:03 +0200)]
french translation updated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Fri, 2 May 2008 17:03:19 +0000 (19:03 +0200)]
bugfix : html mistake
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Darrell Ulm [Thu, 1 May 2008 16:37:51 +0000 (12:37 -0400)]
Intranet callnumber search link simple fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Darrell Ulm [Thu, 1 May 2008 14:42:19 +0000 (10:42 -0400)]
Link to Intranet Similar Items Fixed (simple), pointed to OPAC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 1 May 2008 15:24:32 +0000 (17:24 +0200)]
missing )
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 1 May 2008 15:24:31 +0000 (17:24 +0200)]
BUGFIX : bump to 056 was wrong when marcflavour = UNIMARC
The 652 field don't exist in UNIMARC. So linking the new enumchron to a 952 field automatically should be done only for marc21
For UNIMARC, i map it to 995$v, which has been introduced in the last release of the "recommandation 995"
adding the 995$v as well for installer
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Thu, 1 May 2008 17:17:06 +0000 (12:17 -0500)]
kohabug 2076 - add browser if necessary (DB rev 078)
Ensure that the browser table is added during an upgrade
from 2.2.9.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Thu, 1 May 2008 16:52:30 +0000 (11:52 -0500)]
kohabug 2076 - add authorised_values.imageurl
The column was added in updatedatabase.pl rev 075
but not added to kohastructure.sql.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Thu, 1 May 2008 16:41:33 +0000 (11:41 -0500)]
kohabug 2076 - remove three tables (DB rev 077)
Removed the categorytable, mediatypetable, and subcategorytable
tables. These three tables appear to be from an incomplete
patch from pre-git that defined these tables to implement
additional search limits, and are not present in the 2.2.9
package. In 3.0, these tables did nothing - the only code that
referred to them are incomplete admin editors that lack HTML
templates and are not referred to anywhere.
The updatedatabase.pl logic to remove these tables is conservative;
the tables are dropped only if they exist and are all empty. Effectively,
this means that they'll be dropped if you've been running a fresh install
of 3.0 from git or the alphas or betas; if you've upgraded your database
from 2.2.9, these tables likely weren't in your database to begin with.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Thu, 1 May 2008 16:41:32 +0000 (11:41 -0500)]
added three tables to kohastructure.sql
tags_all, tags_approval, tags_index; for those tracking
git HEAD, these were already added via updatedatabase.pl
DB rev 073, so there's no DB bump for this patch.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 1 May 2008 13:07:07 +0000 (08:07 -0500)]
Some minor markup changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 1 May 2008 13:06:55 +0000 (08:06 -0500)]
Adding more details to cart's verbose view. Adding auto-print to cart print view (Addresses Bug 2070)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 1 May 2008 23:55:13 +0000 (18:55 -0500)]
Fixing bug 1629: RSS Feeds of Search Results in OPAC
Joshua Ferraro [Thu, 1 May 2008 03:04:27 +0000 (22:04 -0500)]
Changing label from Overlay? to Match? since overlay is no longer
the only operation
Galen Charlton [Wed, 30 Apr 2008 22:09:14 +0000 (17:09 -0500)]
kohabug 2026 - HTML-escape comments
This is a partial, perhaps temporary fix. "<", ">",
and "&" characters in patron comments (AKA reviews)
are converted to "<", ">", and "&" to avoid
certain attacks, e.g., a user entering a <script> tag
in a comment.
A more permanent fix should scrub all (or perhaps just
unsafe) tags from submitted comments entirely.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 30 Apr 2008 20:45:44 +0000 (15:45 -0500)]
staging import - enhance record overlay behavior
Enhanced the ability of catalogers to specify how
bib and item records should be added, replaced, or
ignored during a staging import.
When an import batch of bib records is staged and commit,
the user can now explicitly specify what should occur
when an incoming bib record has, or does not have, a match
with a record already in the database. The options are:
if match found (overlay_action):
create_new (just add the incoming record)
replace (replace the matched record with the incoming one)
use_template (option not implemented)
ignore (do nothing with the incoming bib; however, the
items attached to it may still be processed
based on the item action)
if no match is found (nomatch_action):
create_new (just add the incoming record)
ignore (do nothing with the incoming bib; in this
case, any items attached to it will be
ignored since there will be nothing to
attach them to)
The following options for handling items embedded in the
bib record are now available:
always_add (add the items to the new or replaced bib)
add_only_if_match (add the items only if the incoming bib
matches an existing bib)
add_only_if_add (add the items only if the incoming bib
does *not* match an existing bib)
ignore (ignore the items entirely)
With these changes, it is now possible to support the following use cases:
[1] A library joining an existing Koha database wishes to add their
items to existing bib records if they match, but does not want
to overlay the bib records themselves.
[2] A library wants to load a file of records, but only handle
the new ones, not ones that are already in the database.
[3] A library wants to load a file of records, but only
handle the ones that match existing records (e.g., if
the records are coming back from an authority control vendor).
Documentation changes:
* See description above; also, screenshots of the 'stage MARC records
for import' and 'manage staged MARC records' should be updated.
Test cases:
* Added test cases to exercise staging and committing import batches.
UI changes:
* The pages for staging and managing import batches now have
controls for setting the overlay action, action if no match,
and item action separately.
* in the manage import batch tool, user is notified when they
change overlay action, no-match action, and item action
* HTML for manage import batch tool now uses fieldsets
Database changes (DB rev 076):
* added import_batches.item_action
* added import_batches.nomatch_action
* added 'ignore' as a valid value for import_batches.overlay_action
* added 'ignored' as a valid value for import_records.status
* added 'status' as a valid value for import_items.status
API changes:
* new accessor routines for C4::ImportBatch
GetImportBatchNoMatchAction
SetImportBatchNoMatchAction
GetImportBatchItemAction
SetImportBatchItemAction
* new internal functions for C4::ImportBatch to
determine how a given bib and item are to be
processed, based on overlay_action, nomatch_action,
and item_action:
_get_commit_action
_get_revert_action
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 30 Apr 2008 20:45:43 +0000 (15:45 -0500)]
test framework - two improvements
[1] When running the database-dependent tests (cd t, make test),
all tables in the test database are dropped prior to running
the installer and test cases. This means that the test
database will start with a clean slate.
[2] It is now possible to specify a single test class to run,
to avoid having to run all of them:
cd t
make test TEST_CLASS=Search
To run all DB-dependent tests, just do the usual
cd t
make test
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 30 Apr 2008 20:45:42 +0000 (15:45 -0500)]
added reindexing routine to KohaTest
KohaTest->reindex_marc() does a full Zebra reindexing of
bib and authority records and clears zebraqueue. It is
meant for use in test classes that do a lot of bib, authority,
and/or item record changes that would be slowed down by
waiting for zebraqueue_daemon.
Also adjusted list of tables that are automatically truncated.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 1 May 2008 02:07:29 +0000 (21:07 -0500)]
Adding authorised value icons display in the search results
pages.
Andrew Moore [Tue, 29 Apr 2008 23:20:26 +0000 (18:20 -0500)]
Bug 2047: adding images to arbitrary authorized values
I've refactored the subs I added in the previous commit so that they make a little
more sense and are in better places in the code base. I was really hoping to make use
of existing subs, but they all seemed so specific to particular uses.
The icons now show up on the OPAC item details page.
TODO: The icons still don't show up in the OPAC search results page.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Apr 2008 23:20:25 +0000 (18:20 -0500)]
bug 2047: adding icons to authorized values
This patch adds the ability to associate icon images with authorized values.
They're not displayed anywhere yet, though. There's also a database update
in here. I took version "3.00.00.075", but I can change that later if it gets
taken before I commit these patches.
DOCUMENTATION CHANGES: When you add or edit authorized values, you can now
associate image icons with them. These icons come from the same icon sets
that you can have with your itemtypes, such as media type. They don't show
up anywhere yet, but that's coming. Keep an eye on
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2047
for more updates.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Apr 2008 23:20:24 +0000 (18:20 -0500)]
bug 2047: refactoring icon manipulation logic
I'm extracting some of the icon manipulation logic so that I can get to it from the authorized values pages.
There should be no functionality or documentation changes with this commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 1 May 2008 00:47:25 +0000 (19:47 -0500)]
Adding Fedora installation documentation
Owen Leonard [Tue, 29 Apr 2008 19:53:47 +0000 (14:53 -0500)]
Re-structuring shelf browser markup for improved robustness; Including GoogleJackets js only if pref is turned on.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 29 Apr 2008 19:53:18 +0000 (14:53 -0500)]
Fixes for Bug 2067 (terminology consistency)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 29 Apr 2008 19:53:06 +0000 (14:53 -0500)]
Making label toolbars more consistent
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Tue, 29 Apr 2008 15:20:55 +0000 (10:20 -0500)]
BUGFIX labels - Adding labels was failing because of faulty "type" selection.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Tue, 29 Apr 2008 13:31:04 +0000 (08:31 -0500)]
Fixes for interface bugs 2064, 2065, 2066
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 28 Apr 2008 21:05:01 +0000 (16:05 -0500)]
More labels repair: FIXME's added, warns $debug-ified.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 28 Apr 2008 20:31:27 +0000 (15:31 -0500)]
BUGFIX - get_batches argument counterproductive. NONE of the Labels code
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 28 Apr 2008 18:22:56 +0000 (13:22 -0500)]
BUGFIX: $item is reference to hashref, not reference to hash.
In fact, the double reference is useless overkill for this and another arg.
This patch relieves the error seen in logs as:
label-print-pdf.pl: Not a HASH reference at /home/atz/koha/production/intranet/modules/C4/Labels.pm line 1007., referer: http://staff-atz.dev.kohalibrary.com/cgi-bin/koha/labels/label-manager.pl?type=labels
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Sat, 26 Apr 2008 08:05:32 +0000 (10:05 +0200)]
Add a new Debian package and GoogleJacket on OPAC detail page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Wed, 23 Apr 2008 15:08:22 +0000 (17:08 +0200)]
fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Wed, 23 Apr 2008 15:08:22 +0000 (17:08 +0200)]
fixed langauge typo
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:42:29 +0000 (15:42 -0500)]
Minor change to improve compatibility with IE7
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:42:20 +0000 (15:42 -0500)]
Some fixes for bug Bug 2056, No Claim Letter Note Should Stand Out, and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:42:13 +0000 (15:42 -0500)]
Changes to improve compatibility with Internet Explorer 6 and 7
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:42:05 +0000 (15:42 -0500)]
Removing duplicate NPL itemtype image icons from the staff client
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:41:59 +0000 (15:41 -0500)]
Another OPAC popup page requiring ID
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Sat, 26 Apr 2008 20:41:54 +0000 (15:41 -0500)]
Adding a couple missing variables for opac login screen (opacheader,OpacUserCSS); Minor tweak to OPAC tags on opac-detail
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 25 Apr 2008 20:28:14 +0000 (15:28 -0500)]
Normalizing s/On loan/Checked out/
Andrew Moore [Fri, 25 Apr 2008 16:17:02 +0000 (11:17 -0500)]
bug 2058: removing spurious warnings from C4::Items::AddItem
just remove a couple unnecessary warn statements.
no documentation or functionality changes.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Polytechnic University Koha Installation [Fri, 25 Apr 2008 16:40:42 +0000 (12:40 -0400)]
Split Location and Call Number on OPAC detail page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Fri, 25 Apr 2008 08:00:34 +0000 (10:00 +0200)]
Add Debian packaged Image::Magick Perl module to Debian install
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frère Sébastien Marie [Fri, 25 Apr 2008 06:43:28 +0000 (08:43 +0200)]
name error "opac-bottom.inc" in template
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 25 Apr 2008 00:14:40 +0000 (19:14 -0500)]
Removing duplicate itemtype icons.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:21:13 +0000 (14:21 -0500)]
Adding show/hide function to add tag form; fixing bug in series search link (Thanks Tim!)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:21:03 +0000 (14:21 -0500)]
Tweaking returns interface and jquery-ing inline javascript.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:20:53 +0000 (14:20 -0500)]
Enabling OPACURLOpenInNewWindow preference for "Search for this title in..." links
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:20:46 +0000 (14:20 -0500)]
Fix for bug 2043 (Language Issues - OPAC)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:20:36 +0000 (14:20 -0500)]
Fix for Bug 2042 (Language Issues - Administration (pt 2)). Also adding tablesorter.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:20:29 +0000 (14:20 -0500)]
Minor markup changes, validation corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Apr 2008 19:20:17 +0000 (14:20 -0500)]
Adding IDs to popups to add flexibility to customization.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 24 Apr 2008 18:38:21 +0000 (13:38 -0500)]
fixing anonymous permissions access to zebra via Z39.50
and SRU
Andrew Moore [Thu, 24 Apr 2008 16:34:26 +0000 (11:34 -0500)]
bug 2044: adding database change for itemtype icon change
This is the database update change to take into account the rearrangement of the
itemtype icons directory.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Thu, 24 Apr 2008 15:30:57 +0000 (10:30 -0500)]
Bug 2044: allowing multiuple icon sets
I've rearranged the two directories where media type icons live.
I've also added two more collections of icons, one from
http://apps.carleton.edu/campus/library/bridge_icons/
and one from liblime (Tina). The first has a license restriction that I added
to the "Licenses" tab on the "About" page.
Then, I've adjusted the Item Types Administration page so that it can deal
with multiple collections of icons.
I also added a test script to verify that the two identical icon directories
are actually identical.
DOCUMENTATION CHANGE: It's possible that we need to add something to the administration
documentation to indicate how you can add more sets of icons if you want. You simply add
directory to koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/ and to
koha-tmpl/opac-tmpl/prog/itemtypeimg. The icons should start showing up.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Thu, 24 Apr 2008 08:34:06 +0000 (10:34 +0200)]
Minor indexing bug : Title series indexed as Title
410$t is now indexed as Title-series UNIMARC
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Thu, 24 Apr 2008 07:29:35 +0000 (09:29 +0200)]
unlocking table when adding/updating authorities is finished.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Wed, 23 Apr 2008 18:03:30 +0000 (20:03 +0200)]
Add MARC21 (English) to fr-FR installation
With this addition, it's possible to install Koha in French (fr-FR) and
having the English MARC21 framework. It would be desirable if someone
(a French Canadian?) translate this into French.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 23 Apr 2008 22:22:50 +0000 (17:22 -0500)]
Fix default value for TagsExternalDictionary to be null,
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 23 Apr 2008 17:03:57 +0000 (12:03 -0500)]
Revised suggestions management interface, allows setting of one reason for all suggestions in a particular category (pending/accepted/rejected).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 23 Apr 2008 17:03:40 +0000 (12:03 -0500)]
Some style changes following up on recent fix for Bug 2019. Hopefully improves readability. Converted up.png from 24-bit to 8-bit for IE6-friendliness (doesn't require alpha transparency).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Thu, 24 Apr 2008 03:44:32 +0000 (22:44 -0500)]
Validation of opac results and detail pages, normalization
of XSL stylesheets and display
Joshua Ferraro [Wed, 23 Apr 2008 21:00:46 +0000 (16:00 -0500)]
Improvements to the results display in the OPAC, merging style
between the XSL and non-XSL stuff. Refining style of tags display,
adding back links to place hold, add to list, and add to cart on
results page