]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoStrings integrated to js could not be translated.
Henri-Damien LAURENT [Fri, 13 Feb 2009 15:04:10 +0000 (16:04 +0100)]
Strings integrated to js could not be translated.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2952 followup
Galen Charlton [Thu, 12 Feb 2009 23:04:20 +0000 (17:04 -0600)]
bug 2952 followup

The feature in question is described in bug 2952; to
summarize the enhancement, which the earlier patch
description did not do, the list of bibs in an
import record batch now includes a column linking
each import record to the bib that was actually created
or updated when the import batch was committed.

The improvements in this patch are:

* If bib in import batch has not been committed, it
  has not been linked to a matching new or updated bib.
  In that case, do not create a link to a guaranteed
  404 (/cgi-bin/koha/catalogue/detail.pl?biblionumber=)

* When reverting an import batch, set matched_biblionumber
  to NULL for affected records - otherwise, the Bib
  column will include links to bibs that may no longer
  exist.

* Fixed a minor HTML validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2952: 1 char typo
Mason James [Tue, 10 Feb 2009 02:38:15 +0000 (15:38 +1300)]
bug 2952: 1 char typo

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agopatch for feature 2952 - v3
Mason James [Tue, 10 Feb 2009 01:48:26 +0000 (14:48 +1300)]
patch for feature 2952 - v3

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2956) fix another results calculation
Nahuel ANGELINETTI [Thu, 12 Feb 2009 14:58:35 +0000 (15:58 +0100)]
(bug #2956) fix another results calculation

this patch fix more about 4XX plugin, for results display and calculation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoThai Opac updates
Chris Cormack [Mon, 16 Feb 2009 02:42:31 +0000 (15:42 +1300)]
Thai Opac updates

15 years agoTurkish intranet, Marathi Opac and Thai Opac
Chris Cormack [Sat, 14 Feb 2009 03:34:53 +0000 (16:34 +1300)]
Turkish intranet, Marathi Opac and Thai Opac

15 years agoUpdated thai opac
Chris Cormack [Fri, 13 Feb 2009 07:31:24 +0000 (20:31 +1300)]
Updated thai opac

15 years agoUpdating credits
Chris Cormack [Thu, 12 Feb 2009 08:48:26 +0000 (21:48 +1300)]
Updating credits

15 years agoFixed turkish file
Chris Cormack [Thu, 12 Feb 2009 00:28:02 +0000 (13:28 +1300)]
Fixed turkish file

15 years agokohabug 2955 (2/2) GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 17:15:00 +0000 (12:15 -0500)]
kohabug 2955 (2/2) GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by dateaccessioned.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFollowup previous patch bug 2955 :
Henri-Damien LAURENT [Wed, 11 Feb 2009 17:31:44 +0000 (18:31 +0100)]
Followup previous patch bug 2955 :

Some calls to GetMarcFromKohaField would not tell which framework to
use.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agokohabug 2955 GetMarcFromKohaField now requires $framework
Chris Nighswonger [Wed, 11 Feb 2009 16:44:12 +0000 (11:44 -0500)]
kohabug 2955 GetMarcFromKohaField now requires $framework

Failure to pass the $framework parameter by barcode.pl causes
GetMarcFromKohaField to return 0,0 which breaks the value builder. The
patch
submitted corrects this.

This patch is build against the current 3.1.x HEAD, however, this bug
also
affects the 3.0.x codebase and should be applied there as well.

fbcbug 4

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fixing : Modifying a patron would not show his information
Henri-Damien LAURENT [Wed, 11 Feb 2009 15:53:10 +0000 (16:53 +0100)]
Bug Fixing : Modifying a patron would not show his information

15 years agoImproving translation : some js strings were not taken into po files
Henri-Damien LAURENT [Wed, 11 Feb 2009 13:11:18 +0000 (14:11 +0100)]
Improving translation : some js strings were not taken into po files

15 years agoFrench opac updates
Chris Cormack [Wed, 11 Feb 2009 08:25:23 +0000 (21:25 +1300)]
French opac updates

15 years agoRussian and Ukranian SQL files
Chris Cormack [Wed, 11 Feb 2009 08:24:19 +0000 (21:24 +1300)]
Russian and Ukranian SQL files

15 years agoUpdated translation notes
Chris Cormack [Tue, 10 Feb 2009 06:53:53 +0000 (19:53 +1300)]
Updated translation notes

15 years agoRussian, Ukranian and Turkish translations
Chris Cormack [Tue, 10 Feb 2009 06:16:16 +0000 (19:16 +1300)]
Russian, Ukranian and Turkish translations

15 years agoFollowup : updating circulation.tmpl
Henri-Damien LAURENT [Mon, 9 Feb 2009 16:10:22 +0000 (17:10 +0100)]
Followup : updating circulation.tmpl

summary checkouts were displayed even with no borrowers.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago"Cart" translation updated
Henri-Damien LAURENT [Mon, 9 Feb 2009 15:16:26 +0000 (16:16 +0100)]
"Cart" translation updated

"Cart" translation in french is replaced with Panier

15 years agoBug Fixing : updating circulation.tmpl
John Soros [Mon, 9 Feb 2009 10:35:21 +0000 (11:35 +0100)]
Bug Fixing : updating circulation.tmpl

problem with displaying circulation page

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMore norwegian updates
Chris Cormack [Mon, 9 Feb 2009 06:21:29 +0000 (19:21 +1300)]
More norwegian updates

15 years agoNorwegian updates
Chris Cormack [Sun, 8 Feb 2009 17:57:42 +0000 (06:57 +1300)]
Norwegian updates

15 years agoNZ English intranet updates
Chris Cormack [Sat, 7 Feb 2009 05:18:15 +0000 (18:18 +1300)]
NZ English intranet updates

15 years agoUpdated Credits and lots of updates to the po files
Chris Cormack [Fri, 6 Feb 2009 18:48:03 +0000 (07:48 +1300)]
Updated Credits and lots of updates to the po files

15 years agoFrench intranet v3.00.01.005
Chris Cormack [Thu, 5 Feb 2009 07:25:34 +0000 (20:25 +1300)]
French intranet

15 years agopo updates
Henri-Damien LAURENT [Tue, 3 Feb 2009 14:09:42 +0000 (15:09 +0100)]
po updates

15 years agoAdding credits to OpenNCIP and nots to release notes about platforms
Henri-Damien LAURENT [Tue, 3 Feb 2009 14:07:32 +0000 (15:07 +0100)]
Adding credits to OpenNCIP and nots to release notes about platforms

15 years agoChanging nongnu.org to lists.koha.org
Henri-Damien LAURENT [Tue, 3 Feb 2009 11:16:31 +0000 (12:16 +0100)]
Changing nongnu.org to lists.koha.org

15 years agoUpdating translation Minor correction to Release notes
Henri-Damien LAURENT [Tue, 3 Feb 2009 11:15:16 +0000 (12:15 +0100)]
Updating translation Minor correction to  Release notes

15 years agoAdding a translation note.
Henri-Damien LAURENT [Tue, 3 Feb 2009 10:34:37 +0000 (11:34 +0100)]
Adding a translation note.

15 years agoBug 2940 - private shelf (list) display error on 2nd and subsequent pages.
Joe Atzberger [Mon, 2 Feb 2009 20:36:19 +0000 (14:36 -0600)]
Bug 2940 - private shelf (list) display error on 2nd and subsequent pages.

The before/after URL for the 2nd page of list elements:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?display=privateshelves?viewshelf=120&itemoff=2
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?viewshelf=120&display=privateshelves&itemoff=2

The change in query string arguments is incidental, the prevention of multiple "?" is essential.

15 years agoGerman updates
Chris Cormack [Tue, 3 Feb 2009 08:41:17 +0000 (21:41 +1300)]
German updates

15 years agoFollowup: Adding AllowNotForLoanOverride
Henri-Damien LAURENT [Mon, 2 Feb 2009 17:02:48 +0000 (18:02 +0100)]
Followup: Adding AllowNotForLoanOverride

an orphan bracket was lost in the file.

15 years agoAdding release notes for 3.0.1
Henri-Damien LAURENT [Mon, 2 Feb 2009 15:30:25 +0000 (16:30 +0100)]
Adding release notes for 3.0.1

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoFollowup : Adding System Preference AllowNotForLoanOverride
Henri-Damien LAURENT [Mon, 2 Feb 2009 15:06:21 +0000 (16:06 +0100)]
Followup : Adding System Preference AllowNotForLoanOverride

this system preference was created but not added to system preferences
Changing the kohaversion in kohaversion script

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoUpdating French translations
Henri-Damien LAURENT [Mon, 2 Feb 2009 15:07:36 +0000 (16:07 +0100)]
Updating French translations

Staff trnalstaions update

15 years agoAdding System Preference AllowNotForLoanOverride
Henri-Damien LAURENT [Mon, 2 Feb 2009 15:06:21 +0000 (16:06 +0100)]
Adding System Preference AllowNotForLoanOverride

this system preference was created but not added to system preferences

15 years agoUpdated translations for French, German and Croation
Chris Cormack [Sun, 1 Feb 2009 10:42:01 +0000 (23:42 +1300)]
Updated translations for French, German and Croation

15 years ago(bug #2937) use check_date in C4::Serials::hassubscriptionexpired
Nahuel ANGELINETTI [Fri, 30 Jan 2009 15:48:02 +0000 (16:48 +0100)]
(bug #2937) use check_date in C4::Serials::hassubscriptionexpired

This patch change the date check in hassubscriptionexpired to use Date_Calc::check_date

15 years agoNeeded authorised values list for french frameworks.
Henri-Damien LAURENT [Fri, 30 Jan 2009 14:10:54 +0000 (15:10 +0100)]
Needed authorised values list for french frameworks.

15 years agoAdding some null words and mappings for Œ œ
Henri-Damien LAURENT [Wed, 28 Jan 2009 16:39:10 +0000 (17:39 +0100)]
Adding some null words and mappings for Œ œ

15 years agoBug Fixing duplicate = in labels management.
Henri-Damien LAURENT [Wed, 28 Jan 2009 14:18:41 +0000 (15:18 +0100)]
Bug Fixing duplicate = in labels management.

15 years agoRevert "more readable version of the init and new sub"
Henri-Damien LAURENT [Wed, 28 Jan 2009 13:55:47 +0000 (14:55 +0100)]
Revert "more readable version of the init and new sub"

This reverts commit 5a74b4fa0cf79163755560daed640ead85fa0b71.

15 years agoRevert "Bug Fixing : Sub Output was mistakenly removed."
Henri-Damien LAURENT [Wed, 28 Jan 2009 13:54:56 +0000 (14:54 +0100)]
Revert "Bug Fixing : Sub Output was mistakenly removed."

This reverts commit cf355ab195e19c7d9ac37f6fc563141b5190a231.

15 years agoBug Fixing : Sub Output was mistakenly removed.
Henri-Damien LAURENT [Tue, 27 Jan 2009 15:32:53 +0000 (16:32 +0100)]
Bug Fixing : Sub Output was mistakenly removed.

15 years agoFrench OPAC translation Update
Henri-Damien LAURENT [Fri, 23 Jan 2009 17:41:19 +0000 (18:41 +0100)]
French OPAC translation Update

15 years agoReverting from MARC::File::XML parser forcing
Henri-Damien LAURENT [Fri, 23 Jan 2009 17:38:37 +0000 (18:38 +0100)]
Reverting from MARC::File::XML parser forcing

15 years agoAuthtypecode return an warning even if subfield is ignored
Nahuel ANGELINETTI [Thu, 22 Jan 2009 10:51:39 +0000 (11:51 +0100)]
Authtypecode return an warning even if subfield is ignored

this patch just add a condition to the sql request to return a warning
only if authtypecode is not in an ignored subfield.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoBugfix #2921 OPACAmazonContent syspref not used
Frederic Demians [Wed, 21 Jan 2009 08:01:52 +0000 (09:01 +0100)]
Bugfix #2921 OPACAmazonContent syspref not used

In opac-results.tmpl and opac-detail.tmpl, AmazonContent is used
rather than OPACAmazonContent to enable/disable Amazon book jacket.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoMinor rework of template js.
Joe Atzberger [Wed, 21 Jan 2009 01:18:25 +0000 (19:18 -0600)]
Minor rework of template js.

Lines explicitly ended with semicolons.  Allow some better behavior if TMPL_VAR's
are undefined or zero.

Note FIXME added.  I believe this is part of the fragmentary integration of
Katipo code for GST.  Would be obliged if someone with access there can confirm.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoTrivial comment typos corrected.
Joe Atzberger [Wed, 21 Jan 2009 01:18:24 +0000 (19:18 -0600)]
Trivial comment typos corrected.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoBasic cleanup of fixup_cardnumber
Joe Atzberger [Wed, 21 Jan 2009 01:18:23 +0000 (19:18 -0600)]
Basic cleanup of fixup_cardnumber

Avoid warning on syspref "checkdigit" undefined.
Functionality essentially unchanged.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoPrevent js failure if syspref "gist" is undefined.
Joe Atzberger [Wed, 21 Jan 2009 01:18:22 +0000 (19:18 -0600)]
Prevent js failure if syspref "gist" is undefined.

The javascript is malformed and therefore fails the onsubmit check if
gist does not receive a value.  This patch allows failover to default 0.
Also removed an unused dbh.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoBlock warning on detail.pl.
Joe Atzberger [Wed, 21 Jan 2009 01:18:20 +0000 (19:18 -0600)]
Block warning on detail.pl.

If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:

    detail.pl: Use of uninitialized value in multiplication (*)
    at /home/user/kohaclone/catalogue/detail.pl line 228.

So the important part of this patch is || 0 on the $average_rating assignment.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #2917) editing authority marc field structure doesn't workl
Nahuel ANGELINETTI [Tue, 20 Jan 2009 12:46:58 +0000 (13:46 +0100)]
(bug #2917) editing authority marc field structure doesn't workl

This patch add a field in the ->execute() statement which was missing.
The sql request have 8 args, and only 7 was passed.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoAutoselect marcflavour in marc import
Nahuel ANGELINETTI [Tue, 20 Jan 2009 14:59:23 +0000 (15:59 +0100)]
Autoselect marcflavour in marc import

This patch is writted by Paul Poulain.
It auto-select the marcflavour from syspref in the stage marc import.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoCorrect capitalization on CGI::Session::Serialize::yaml
Joe Atzberger [Sat, 17 Jan 2009 00:31:55 +0000 (18:31 -0600)]
Correct capitalization on CGI::Session::Serialize::yaml

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoFixes command-line 'number' arg in bulkauthimport.pl.
Mason James [Fri, 16 Jan 2009 10:07:12 +0000 (23:07 +1300)]
Fixes command-line 'number' arg in bulkauthimport.pl.

for HEAD and 3.0.x

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agofix to remove blank newlines from labels
Mason James [Fri, 16 Jan 2009 08:16:27 +0000 (21:16 +1300)]
fix to remove blank newlines from labels

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago_set_defaults_for_add easier to read
Marc Chantreux [Fri, 16 Jan 2009 09:23:27 +0000 (09:23 +0000)]
_set_defaults_for_add easier to read

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agomore readable version of the init and new sub
Marc Chantreux [Thu, 15 Jan 2009 23:18:06 +0000 (23:18 +0000)]
more readable version of the init and new sub

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #2914) improve the deletion
Nahuel ANGELINETTI [Thu, 15 Jan 2009 08:49:48 +0000 (09:49 +0100)]
(bug #2914) improve the deletion

this patch disable the button to delete all of items if there is no item attached to the marc record.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #2914) delete all items of a notice
Nahuel ANGELINETTI [Wed, 14 Jan 2009 15:07:34 +0000 (16:07 +0100)]
(bug #2914) delete all items of a notice

This patch allow the librarian to delete all items attached to a notice in one click.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #2913) show "--" on repeated fields
Nahuel ANGELINETTI [Wed, 14 Jan 2009 12:26:51 +0000 (13:26 +0100)]
(bug #2913) show "--" on repeated fields

This patch just transform the script to set the field title as "--" if it was already shown.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoFormat marc notes
Nahuel ANGELINETTI [Tue, 13 Jan 2009 10:33:54 +0000 (11:33 +0100)]
Format marc notes

this patch add a filter to notes, it transform \n in <br />

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoCorrection: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only...
Owen Leonard [Mon, 12 Jan 2009 14:55:21 +0000 (08:55 -0600)]
Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on).

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoBasic reformat of section in Search.pm
Joe Atzberger [Fri, 9 Jan 2009 21:42:27 +0000 (15:42 -0600)]
Basic reformat of section in Search.pm

In for loops, replace all-inclusive conditional blocks like:
    for (@foo) {
        if (test) {
            block;
        }
    }

with conditional use of "next":
    for (@foo) {
        test or next;
        block;
    }

This reduces the number of unnecessarily nested blocks, and the
overall number of lines.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #1578) change the shelf COinS support
Nahuel ANGELINETTI [Fri, 9 Jan 2009 10:36:47 +0000 (11:36 +0100)]
(bug #1578) change the shelf COinS support

this change the old COinS support, and now use C4::Biblio::GetCOinSBiblio().

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoAdd mc-loc definition for ccl.properties.
Ryan Higgins [Thu, 8 Jan 2009 18:03:42 +0000 (13:03 -0500)]
Add mc-loc definition for ccl.properties.

Advances search limit by shelving location doesn't work due to
missing ccl definition in default installation.  Once updated,
the zebradb will need to be reindexed.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agobug 2505: enable warnings for labels/label-print-pdf.pl
Galen Charlton [Mon, 5 Jan 2009 22:33:57 +0000 (16:33 -0600)]
bug 2505: enable warnings for labels/label-print-pdf.pl

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #2893) Allow loan forcing if a syspref is set
Nahuel ANGELINETTI [Fri, 2 Jan 2009 15:55:32 +0000 (16:55 +0100)]
(bug #2893) Allow loan forcing if a syspref is set

If the syspref 'AllowNotForLoanForcing'(YESNO) is set to YES, the librarian is able to force a loan on an item set as "not for
loan".
If the item is not for loan and the syspref is set to YES, koha will ask to the librarian if he really want to check-out it,
else do nothing.

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years ago(bug #1578) Add the (quasi)full COinS(Zotero) support
Nahuel ANGELINETTI [Fri, 2 Jan 2009 14:39:35 +0000 (15:39 +0100)]
(bug #1578) Add the (quasi)full COinS(Zotero) support

this patch do a lot of things :
 * Add the function GetCOinSBiblio in C4::Biblio, return the COinS value that must be put in a span title
   This will be usefull for OpenURL support.

 * Replace the span in opac-detail, and put the var get from GetCOinSBiblio
 * Fix an <img> tag that wasn't autoclosed
 * Add the COinS in search result
 * Full COinS support of UNIMARC, the MARC21 support should be improved to provide all kind of document types

Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
15 years agoUpdating updatedatabse in order to work in any installs
Henri-Damien LAURENT [Tue, 20 Jan 2009 21:41:32 +0000 (22:41 +0100)]
Updating updatedatabse in order to work in any installs

15 years ago(bug #2909) fix the attachment base64 encoding
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:45:53 +0000 (10:45 +0100)]
(bug #2909) fix the attachment base64 encoding

this patch change the attachment encoding, else if the file is too large, koha throws an error.
This solution was found on koha list in a Joshua's e-mail

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUnescape some double quotes, that make a validation error.
Nahuel ANGELINETTI [Wed, 7 Jan 2009 15:23:14 +0000 (16:23 +0100)]
Unescape some double quotes, that make a validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2904) support of 856$u and 856$z in UNIMARC
Nahuel ANGELINETTI [Fri, 9 Jan 2009 09:54:30 +0000 (10:54 +0100)]
(bug #2904) support of 856$u and 856$z in UNIMARC

This patch change the linktext as the label of the link(in 856$z), and set the url from the 856$u.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2902 Public shelves do not display when user not logged in.
Allen Reinmeyer [Fri, 9 Jan 2009 02:11:02 +0000 (20:11 -0600)]
Bug 2902 Public shelves do not display when user not logged in.

An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPrevent multiple warnings per notice filling cron logs.
Henri-Damien LAURENT [Tue, 20 Jan 2009 18:46:43 +0000 (19:46 +0100)]
Prevent multiple warnings per notice filling cron logs.

If a value being substituted in was NULL, then warnings like this
would be emailed to the crontab owner (or MAILTO):

Use of uninitialized value in substitution (s///) at /home/user/kohaclone/C4/Letters.pm line 508.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:

C4/Letters.pm

15 years agobug 2505: more warnings fixes in C4/Context.pm
Galen Charlton [Fri, 9 Jan 2009 18:16:43 +0000 (12:16 -0600)]
bug 2505: more warnings fixes in C4/Context.pm

* more portable way to determine uname for
  crash messages
* C4::Context->userenv now returns undef instead
  of 0 if no userenv has been set yet; returning
  undef when necessary is almost always better
  than returning a scalar when a hashref is
  normally expected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnable use warnings;, clean up complainy functions, fix a few tab/space formatting...
stan [Thu, 1 Jan 2009 17:39:33 +0000 (12:39 -0500)]
Enable use warnings;, clean up complainy functions, fix a few tab/space formatting issues.

Refactoring KOHAVERSION to be less crufty, enabling use warnings, change formatting slightly in places.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWEBSERVER_HOST and WEBSERVER_HOST added
Marc Chantreux [Thu, 8 Jan 2009 01:02:07 +0000 (01:02 +0000)]
WEBSERVER_HOST and WEBSERVER_HOST added

comments added too

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to patch for bug 2900
Galen Charlton [Thu, 8 Jan 2009 20:18:24 +0000 (14:18 -0600)]
followup to patch for bug 2900

Previous patch broke date comparison that sets
overdue flag - now that ISO-formatted date
strings are being compared, must use "it"
instead of "<".

"2009-01-02" lt "2009-01-08" is true
"2009-01-02" <  "2009-01-08" is *false*

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2900: fix GetPendingIssues.
Joe Atzberger [Thu, 8 Jan 2009 03:47:36 +0000 (21:47 -0600)]
Bug 2900: fix GetPendingIssues.

GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2747: avoid warning if items.itype is NULL
Galen Charlton [Wed, 7 Jan 2009 21:32:35 +0000 (15:32 -0600)]
bug 2747: avoid warning if items.itype is NULL

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2747 for staff interface itemtype display.
Joe Atzberger [Wed, 7 Jan 2009 20:57:28 +0000 (14:57 -0600)]
Bug 2747 for staff interface itemtype display.

Prefer accuracy over graphical icon.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoGetAuthValCode calls were positioned inside the loop,
Joe Atzberger [Wed, 7 Jan 2009 20:57:29 +0000 (14:57 -0600)]
GetAuthValCode calls were positioned inside the loop,

despite the same values being supplied each time.  Then
the conditional assignments would repeat the same calls again!
That means execution was liable to query the DB at least once
and as many as four times per item.  With a large number of items
this is an unnecessary burden.  By moving the calls outside
the loop, we can guarantee that we never have to call the DB for
that info more than twice (once for lost, once for damaged).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agojavascript redirect when selecting a patron on circulation.pl Patron Selection Screen
Michael Hafen [Wed, 27 Aug 2008 22:46:57 +0000 (16:46 -0600)]
javascript redirect when selecting a patron on circulation.pl Patron Selection Screen

This adds a little javascript to the Patron Selection form input after searching for a patron to check out to.
On click it redirects to checking out to the clicked patron.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPut patron Privilege 'updatecharges' to use on fines pages
Michael Hafen [Thu, 13 Nov 2008 23:11:35 +0000 (16:11 -0700)]
Put patron Privilege 'updatecharges' to use on fines pages

This changes the flags required for the fines pages to include the
updatecharges flag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoa more readable way to test an array size.
Nahuel Angelinetti [Wed, 15 Oct 2008 09:03:25 +0000 (11:03 +0200)]
a more readable way to test an array size.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings for admin/authorized_values.pl
Galen Charlton [Wed, 7 Jan 2009 01:43:35 +0000 (19:43 -0600)]
bug 2505: enable warnings for admin/authorized_values.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoauthorized_values cleanup
Joe Atzberger [Fri, 12 Dec 2008 21:28:01 +0000 (15:28 -0600)]
authorized_values cleanup

Moving towards being able to enable warnings.  Use one dbh, and stop
redeclaring it in each conditional chunk.  ($sth still need to be cleaned.)
Toggle in script removed (tmpl should use loop context var __odd__).
$sth->finish calls removed where unnecessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoREFACTOR: correcting indirect object method syntax
Andrew Moore [Wed, 17 Dec 2008 22:31:25 +0000 (16:31 -0600)]
REFACTOR: correcting indirect object method syntax

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2505: turning on "warnings" in catalogue/detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:46 +0000 (16:32 -0600)]
Bug 2505: turning on "warnings" in catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoProviding options for adding to order when existing record search has failed.
Owen Leonard [Wed, 31 Dec 2008 20:28:38 +0000 (14:28 -0600)]
Providing options for adding to order when existing record search has failed.

I've duplicated the "Add to Order" block on the search results page to display after a user has searched for an existing record to add to an order. This block is displayed whether or not results were found on the assumption that a non-empty result set may not contain the desired result. Changes to neworderbiblio.pl allow supplier name to appear in breadcrumb nav.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agopatch followup: restore test in GetMarcItem
Galen Charlton [Wed, 7 Jan 2009 00:54:08 +0000 (18:54 -0600)]
patch followup: restore test in GetMarcItem

Change made to GetMarcItem to quell a warning
changed sense of a test; defined($foo) is *not*
the same as $foo ne ''.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: more warnings fixes to C4/Biblio.pm
Galen Charlton [Tue, 6 Jan 2009 14:59:09 +0000 (08:59 -0600)]
bug 2505: more warnings fixes to C4/Biblio.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2700, Keeping Data When Adding Multiple Items
Owen Leonard [Tue, 4 Nov 2008 16:21:47 +0000 (10:21 -0600)]
Fix for Bug 2700, Keeping Data When Adding Multiple Items

When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2505: adding warnings to C4/Biblio.pm
Andrew Moore [Wed, 17 Dec 2008 22:28:04 +0000 (16:28 -0600)]
Bug 2505: adding warnings to C4/Biblio.pm

I added 'use warnings' to C4::Biblio and made a handful of changes to
reduce the number of warnings emitted.

One notable spot is the change in the regex in
C4::Biblio::GetNoZebraIndexes. I have replaced the parens with a character
class. The parens change the way 'split' works, making it return elements
for each delimiter. We did not want those elements returned, and they
only resulted in "'' => undef" being added to the final hash. They also
resulted in two "undefined" warnings for each pass through the loop. I've
included a simple test for this function.

There may be a few warnings still emitted in spots, but either I haven't
seen them yet, or I have chosen to not fix them yet because they require
too much change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>