Bug 30742: Remove 'bad_bibs' and send a list of holdable bibs
authorNick Clemens <nick@bywatersolutions.com>
Fri, 13 May 2022 15:23:30 +0000 (15:23 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 1 Jun 2022 16:29:32 +0000 (13:29 -0300)
commit503a7f0ab10b6689c2ac6e42f7f788d383575028
tree09efa5343b849a7599c2d617f26803f738649717
parent1c1c1e19f5529b5728ed7770a030feabf1a9b8df
Bug 30742: Remove 'bad_bibs' and send a list of holdable bibs

Currently place request gets a list of bad_bibs that is created via javascript on the
template. It ignores this list

Ths patch instead doesn't add info for bad bibs, and provides a list of the bibs that
can be held

To test:
1 - Attempt multi hold with some items that can be held, and one that cannot due to notforloan
2 - Fill in pickup locations and place hold
3 - Note hold is place on bib with no avilable items and hsows twice in results
4 - Apply patch
5 - repeat with another patron
6 - Note no aidditonal hold on record with notforloan items
7 - Note with with not for loan items appears only once in results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
reserve/placerequest.pl