]> git.koha-community.org Git - koha.git/commit
Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 May 2018 14:13:20 +0000 (16:13 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 5 Jun 2018 10:43:02 +0000 (11:43 +0100)
commit66f5b793ed8e52372466122263cac0ddd84dea63
tree2876cfa44a4b807c9f9fd7727675fed86ec361e8
parentddc2f3f7eef9702a88cc0326724583c94dcd3d59
Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm

Comparisons like $a eq undef should normally raise a warning like:
    Use of uninitialized value in string eq at ...
But unfortunately we still suppress warnings here and there.

Test plan:
[1] Just read this patch and confirm the small changes.
[2] Git grep on "eq undef" and do not find other occurrences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passes test plan and QA tools. Searching works correctly.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Search.pm