From 0acd6c823aa0f8e45ae6dcb39bb6f18e45a745ea Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 10 Jan 2020 11:48:09 +0100
Subject: [PATCH] Bug 24200: Try to fix random failures from
 Borrower_PrevCheckout.t

It failed inconsistently, let's try to use build_sample_item and see if
it fixes the random failures.

Test plan:
 % prove t/db_dependent/Patron/Borrower_PrevCheckout.t
must return green

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit d5e9dc31ca66cff586125d1bbcff8de8bc089387)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 t/db_dependent/Patron/Borrower_PrevCheckout.t | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/t/db_dependent/Patron/Borrower_PrevCheckout.t b/t/db_dependent/Patron/Borrower_PrevCheckout.t
index dc53e65b46..8bd882cd86 100644
--- a/t/db_dependent/Patron/Borrower_PrevCheckout.t
+++ b/t/db_dependent/Patron/Borrower_PrevCheckout.t
@@ -234,12 +234,12 @@ map {
 # $patron, $different_patron, $items (same bib number), $different_item
 my $patron = $builder->build({source => 'Borrower'});
 my $patron_d = $builder->build({source => 'Borrower'});
-my $item_1 = $builder->build({source => 'Item'});
-my $item_2 = $builder->build({
-    source => 'Item',
-    value => { biblionumber => $item_1->{biblionumber} },
-});
-my $item_d = $builder->build({source => 'Item'});
+
+my $biblio = $builder->build_sample_biblio;
+$biblio->serial(0)->store;
+my $item_1 = $builder->build_sample_item({biblionumber => $biblio->biblionumber})->unblessed;
+my $item_2 = $builder->build_sample_item({biblionumber => $biblio->biblionumber})->unblessed;
+my $item_d = $builder->build_sample_item->unblessed;
 
 ## Testing Sub
 sub test_it {
-- 
2.39.2