From 0b35290011a48938b55a069c2e44eee688bf70c8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 14 Jan 2014 12:21:43 +0100 Subject: [PATCH] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer Updated number of tests to 68, tests and QA script all happy now. Looked at a few pages in aquisition using GetOrder as well. Signed-off-by: Galen Charlton --- C4/Acquisition.pm | 2 ++ t/db_dependent/Acquisition.t | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 6446a07267..33aa8e3c08 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -1102,6 +1102,8 @@ C<$order> are fields from the biblio, biblioitems, aqorders tables of the Koha d sub GetOrder { my ($ordernumber) = @_; + return unless $ordernumber; + my $dbh = C4::Context->dbh; my $query = qq{SELECT aqorders.*, diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t index 185b7ac526..f2ee82097b 100755 --- a/t/db_dependent/Acquisition.t +++ b/t/db_dependent/Acquisition.t @@ -8,7 +8,7 @@ use POSIX qw(strftime); use C4::Bookseller qw( GetBookSellerFromId ); -use Test::More tests => 66; +use Test::More tests => 68; BEGIN { use_ok('C4::Acquisition'); @@ -840,4 +840,9 @@ is( $order3->{'quantityreceived'}, 2, 'Order not split up' ); is( $order3->{'quantity'}, 2, '2 items on order' ); is( $order3->{'budget_id'}, $budgetid2, 'Budget has changed' ); +my $nonexistent_order = GetOrder(); +is( $nonexistent_order, undef, 'GetOrder returns undef if no ordernumber is given' ); +$nonexistent_order = GetOrder( 424242424242 ); +is( $nonexistent_order, undef, 'GetOrder returns undef if a nonexistent ordernumber is given' ); + $dbh->rollback; -- 2.39.5