From 0f8792961cbe6b35a2042b9dc8005578d66b111b Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 23 Mar 2016 14:57:41 -0300 Subject: [PATCH] Bug 16136: Koha::Patron contains 'return undef' and fails critic tests This patch fixes this issue. To test: - Run $ TEST_QA=1 prove t/00-testcritic.t => FAIL: Koha::Patron makes the tests fail. - Apply the patch - Run $ TEST_QA=1 prove t/00-testcritic.t => SUCCESS: tests PASS - Sign off Regards Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher --- Koha/Patron.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Patron.pm b/Koha/Patron.pm index 684f274cbf..68cb822232 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -45,7 +45,7 @@ Returns a Koha::Patron object for this patron's guarantor sub guarantor { my ( $self ) = @_; - return undef unless $self->guarantorid(); + return unless $self->guarantorid(); return Koha::Patrons->find( $self->guarantorid() ); } @@ -79,7 +79,7 @@ sub siblings { my $guarantor = $self->guarantor; - return undef unless $guarantor; + return unless $guarantor; return Koha::Patrons->search( { -- 2.39.5