From 12939c7583d4091dda639e630bb9080d008af2f1 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 16 Feb 2023 16:11:23 +0000 Subject: [PATCH] Bug 32878: (QA follow-up) Correct unit test After the patch we fail on renewing a not for loan item with an item level hold. I don't find justification for why this should be renewable, so I just change the test expectation This needs another QA eye Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Circulation.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index a0fb5e8dad..ba4c34f5c4 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -672,7 +672,7 @@ subtest "CanBookBeRenewed tests" => sub { # Items can't fill hold for reasons $item_1->notforloan(1)->store; ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1); - is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block'); + is( $renewokay, 0, 'Cannot renew, item is marked not for loan, but an item specific hold always blocks'); $item_1->set({notforloan => 0, itype => $itemtype })->store; # FIXME: Add more for itemtype not for loan etc. -- 2.20.1