From 12969850e8d2b89896c1dde4bbab728b3700e4e2 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 21 Jun 2023 13:30:57 +0000 Subject: [PATCH] Bug 34066: Datatable options don't fully translate on list of saved reports This patch corrects the DataTable option for defining an alternate language string when no records are returned by a table filter. An obsolete version of the option name was breaking the existing custom option supplied by our datatables.js To test, apply the patch and go to Reports -> Use saved.. - In the DataTable of existing reports, all the DataTable controls should look correct. - In the filter field at the top of the table, enter a string which will not be found. You should see a message, "No matching reports found." - Install another language if necessary, and switch to that language. - The labels on all the DataTable controls should show the terms which have been translated for that language. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e26d7c783eb8c70d318e402e3a90930afcff44cd) Signed-off-by: Fridolin Somers --- .../prog/en/modules/reports/guided_reports_start.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 73806e8361..5b76c7dd4f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1907,9 +1907,10 @@ 'bAutoWidth': false, 'sPaginationType': 'full', 'aaSorting': [[ 1, "asc" ]], - 'oLanguage': { - 'sZeroRecords': _("No matching reports found") - } + "language": { + "zeroRecords": _("No matching reports found") + }, + }, table_settings); $("#tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) { -- 2.39.5