From 1543db81c7e6ba0c8501cf19452ba3d08f842680 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 3 Mar 2016 11:35:14 +0000 Subject: [PATCH] Bug 15968: Unnecessary loop in C4::Templates MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. Test plan: Do some clicks on the interface, everything should be ok. Signed-off-by: Frédéric Demians Perl idiosyncratic way of merging hash, clearer, if not quicker (not verified) Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 9be221b14eee137f4143e4a2243eadfb03fcfbbc) Signed-off-by: Julian Maurice --- C4/Templates.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/C4/Templates.pm b/C4/Templates.pm index 4f23dc700c..b3d7edf9a9 100644 --- a/C4/Templates.pm +++ b/C4/Templates.pm @@ -112,9 +112,7 @@ sub output { C4::Context->preference('opaclayoutstylesheet'); # add variables set via param to $vars for processing - for my $k ( keys %{ $self->{VARS} } ) { - $vars->{$k} = $self->{VARS}->{$k}; - } + $vars = { %$vars, %{ $self->{VARS} } }; my $data; binmode( STDOUT, ":utf8" ); -- 2.39.5