From 1575f81c8bcdbea3ba2f3bccf67c81e5da067af3 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 26 Jan 2023 15:08:24 +0000 Subject: [PATCH] Bug 32979: Add Test::Exception to Logger.t Test plan: Run t/Logger.t Note: Run under koha user, not root. Root wont have the permission failure which is tested. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 2cdc018c810667681e88fbff9a9aca5720b816e6) --- t/Logger.t | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/Logger.t b/t/Logger.t index 870ecd9029..b51acd2aea 100755 --- a/t/Logger.t +++ b/t/Logger.t @@ -24,6 +24,7 @@ use t::lib::Mocks; use File::Temp qw/tempfile/; use Test::More tests => 1; use Test::Warn; +use Test::Exception; subtest 'Test01 -- Simple tests for Koha::Logger' => sub { plan tests => 10; @@ -31,8 +32,7 @@ subtest 'Test01 -- Simple tests for Koha::Logger' => sub { my $ret; t::lib::Mocks::mock_config('log4perl_conf', undef); - eval { Koha::Logger->get }; - ok( $@, 'Logger did not init correctly without config'); + throws_ok { Koha::Logger->get } qr/Configuration not defined/, 'Logger did not init correctly without config'; my $log = mytempfile(); my $config_file = mytempfile( <<"HERE" @@ -48,8 +48,7 @@ HERE t::lib::Mocks::mock_config('log4perl_conf', $config_file); system("chmod 400 $log"); - eval { Koha::Logger->get }; - ok( $@, 'Logger did not init correctly without permission'); + throws_ok { Koha::Logger->get } qr/Permission denied/, 'Logger did not init correctly without permission'; system("chmod 700 $log"); my $logger = Koha::Logger->get( { interface => 'intranet' } ); -- 2.20.1