From 186b635a75c4e67b20d6fd80d9fee3a8cb3cd2cb Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 24 Jun 2015 14:54:36 -0300 Subject: [PATCH] Bug 13014: (QA followup) have new warnings tested Signed-off-by: Tomas Cohen Arazi --- t/db_dependent/Suggestions.t | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t index df8e93b8e5..29e59bb2f7 100644 --- a/t/db_dependent/Suggestions.t +++ b/t/db_dependent/Suggestions.t @@ -365,7 +365,7 @@ $suggestion = GetSuggestion($my_suggestionid_test_budgetid); is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' ); subtest 'GetUnprocessedSuggestions' => sub { - plan tests => 9; + plan tests => 11; $dbh->do(q|DELETE FROM suggestions|); my $my_suggestionid = NewSuggestion($my_suggestion); my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions; @@ -380,11 +380,15 @@ subtest 'GetUnprocessedSuggestions' => sub { $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions; is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' ); - ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ); + warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) } + 'No suggestions REJECTED letter transported by email', + 'Warning raised if no REJECTED letter by email'; $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions; is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' ); - ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); + warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); } + 'No suggestions ASKED letter transported by email', + 'Warning raised if no ASKED letter by email'; $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions; is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' ); $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4); -- 2.39.5