From 18962c1237f4f975d4322e1657e4a9cd95188106 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 1 Dec 2023 16:34:28 +0000
Subject: [PATCH] Bug 35450: Preservation system preferences should authval
 dropdowns

This patch updates two preservation module system preferences so that
they offer dropdowns of "Not for loan" values instead of requiring entry
of a specific code.

The patch also adds a missing "." at the end of one preference
description.

To test, apply the patch and restart services.

- Go to Administration -> System preferences.
- Search for "preservation"
- Check that the "PreservationNotForLoanDefaultTrainIn" and
  "PreservationNotForLoanWaitingListIn" preferences have dropdowns
  offering "Not for loan" values.
- Confirm that your choices are correctly saved.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 20d0d94f22aeab3c71d22b6a99fbfa4421e1f40d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/admin/preferences/preservation.pref   | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/preservation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/preservation.pref
index 0a3eb22c95..76484b52bd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/preservation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/preservation.pref
@@ -9,8 +9,12 @@ Preservation:
         -
             - Use the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">NOT_LOAN</a> authorized value
             - pref: PreservationNotForLoanWaitingListIn
-            - to apply to items added to the waiting list
+              choices: authval
+              source: NOT_LOAN
+            - to apply to items added to the waiting list.
         -
             - Use the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">NOT_LOAN</a> authorized value
             - pref: PreservationNotForLoanDefaultTrainIn
-            - to apply to items added to a train
+              choices: authval
+              source: NOT_LOAN
+            - to apply to items added to a train.
-- 
2.20.1