From 1e9caf3ba64b2af90a333d30a06502b221d8af8f Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 13 Aug 2021 17:00:38 -0300 Subject: [PATCH] Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt index caa13006ac..bfcd0e073d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt @@ -3,6 +3,7 @@ [% USE Branches %] [% USE KohaDates %] [% USE TablesSettings %] +[% USE ItemTypes %] [% INCLUDE 'doc-head-open.inc' %] Your holds history › [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog [% INCLUDE 'doc-head-close.inc' %] @@ -66,6 +67,7 @@ [% IF !holds %] You have never placed a hold from this library. [% ELSE %] + [% SET show_itemtype_column = Koha.Preference('AllowHoldItemTypeSelection') %]
-- 2.39.5