From 2923a5cbb0e8cd2f9ab8ec9f93b5cc40bb5ba641 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 19 Nov 2021 14:54:58 +0100 Subject: [PATCH] Bug 29040: Remove warning from the itemtype edit view Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. We are expecting "intranet" or "opac, here we sent undef which raises a warning. For no change in behaviour we can send "both" (or whatever different than "intranet" and "opac"). Test plan: Hit /cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK Notice that the warning does no longer appear in the logs with the patch applied. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall --- admin/itemtypes.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl index 8652c3de9f..975064af9a 100755 --- a/admin/itemtypes.pl +++ b/admin/itemtypes.pl @@ -60,7 +60,7 @@ if ( $op eq 'add_form' ) { my $parent_types = Koha::ItemTypes->search({parent_type=>undef,itemtype => {'!='=>$itemtype_code}}); my $imagesets = C4::Koha::getImageSets( checked => ( $itemtype ? $itemtype->imageurl : undef ) ); my $searchcategory = GetAuthorisedValues("ITEMTYPECAT"); - my $translated_languages = C4::Languages::getTranslatedLanguages( undef , C4::Context->preference('template') ); + my $translated_languages = C4::Languages::getTranslatedLanguages( "both", C4::Context->preference('template') ); $template->param( itemtype => $itemtype, parent_type => $parent_type, -- 2.39.5