From 2b800a467f8277c014c8cbe35893119a4f0dbb24 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 15 Jul 2021 13:00:14 +0000 Subject: [PATCH] Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted) https://bugs.koha-community.org/show_bug.cgi?id=28690 Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js index 22badd189d..cb841c3e3c 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js @@ -86,7 +86,7 @@ function Check(f) { } else { alertString2 = MSG_FORM_NOT_SUBMITTED; alertString2 += "\n------------------------------------------------------------------------------------\n"; - alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_mandatory); + alertString2 += "\n- " + MSG_MANDATORY_FIELDS_EMPTY.format(total_mandatory); } if(total_important > 0){ if( !alertString2 ){ -- 2.39.5