From 2f4f4bdff6b0e9b708f90839e17eab2a4359c531 Mon Sep 17 00:00:00 2001 From: Ian Walls Date: Mon, 22 Mar 2010 17:46:55 +0000 Subject: [PATCH] Fixes bug 4326: Items marked as returned yesterday Signed-off-by: Galen Charlton --- C4/Circulation.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 77650a0fab..e3a37fa5e6 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1477,10 +1477,12 @@ sub AddReturn { # case of a return of document (deal with issues and holdingbranch) if ($doreturn) { $borrower or warn "AddReturn without current borrower"; - my $circControlBranch = _GetCircControlBranch($item,$borrower); + my $circControlBranch; if ($dropbox) { - # don't allow dropbox mode to create an invalid entry in issues (issuedate > returndate) FIXME: actually checks eq, not gt - undef($dropbox) if ( $item->{'issuedate'} eq C4::Dates->today('iso') ); + # define circControlBranch only if dropbox mode is set + # don't allow dropbox mode to create an invalid entry in issues (issuedate > today) + # FIXME: check issuedate > returndate, factoring in holidays + $circControlBranch = _GetCircControlBranch($item,$borrower) unless ( $item->{'issuedate'} eq C4::Dates->today('iso') );; } if ($borrowernumber) { -- 2.39.2