From 311fe87b31b9a65974e6020df301408251659e79 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 9 Oct 2018 18:05:04 +0000
Subject: [PATCH] Bug 21505: Box around 'Additional fields' does not contain
 the fields

This patch modifies the subscription detail page markup to eliminate a
confusing bordered <legend> tag. It is replaced with an <hr> to
delineate the sections and an <h3> tag to serve as the heading.

To test, apply the patch and regenerate the staff client CSS.

 - Configure one or more additional subscription fields.
 - View the detail page for a subscription and confirm that the
   "Additional fields" section is clearly labeled.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss       | 1 +
 .../prog/en/modules/serials/subscription-detail.tt           | 5 +++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
index 8fc90585be..f2780db11c 100644
--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
@@ -413,6 +413,7 @@ h6 {
 
 hr {
     clear: both;
+    margin: 1em 0;
 }
 
 p {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
index 3a7dd03525..a2cb7d48fd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
@@ -119,11 +119,12 @@
      </div>
      </div>
 
-     [% IF additional_fields_for_subscription %]
+    [% IF additional_fields_for_subscription %]
+    <hr>
     <div class="row">
       <div class="col-sm-6">
+        <h3>Additional fields:</h3>
         <div class="rows">
-          <legend>Additional fields:</legend>
           <ol>
             [% FOR field IN additional_fields_for_subscription %]
               <li>
-- 
2.20.1