From 34673bf4efcad5746e16a1bf29d849b024497dd1 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Jean-Andr=C3=A9=20Santoni?= <jeanandre.santoni@biblibre.com>
Date: Fri, 26 Feb 2010 12:32:53 +0100
Subject: [PATCH] Checks serials item form

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
---
 .../prog/en/modules/serials/serials-edit.tmpl | 43 ++++++++-----------
 1 file changed, 19 insertions(+), 24 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
index c2b724b3e4..d8a2d1a21c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tmpl
@@ -37,29 +37,6 @@ function barcode_check(){
     }
     <!--/TMPL_IF-->
 }
-
-function Check(f) {
-    var total_errors=0;
-//	alert(f.field_value.length);
-    for (i=0 ; i<f.field_value.length ; i++) {
-//	alert (f.field_value[i].value);
-        if (f.field_value[i].value.length==0 && f.mandatory[i].value==1) {
-            document.getElementById("error"+i).style.backgroundColor="#FF0000";
-            total_errors++;
-        } else {
-//			document.getElementById("error"+i).style.backgroundColor="#FFFFFF";
-        }
-    }
-    var alertString2;
-    if (total_errors==0) {
-        document.f.submit();
-    } else {
-        alertString2  = _("Form not submitted because of the following problem(s)");
-        alertString2 += "\n------------------------------------------------------------------------------------\n";
-        alertString2 += "\n- "+ total_errors+_(" mandatory fields empty (see bold subfields)");
-        alert(alertString2);
-    }
-}
 function unHideItems(index,labelindex, serialId) {
 	subfield = document.getElementById(index);
 	subfield.style.display = 'block';
@@ -156,6 +133,24 @@ function CloneSubfield(index){
     // insert this line on the page
     original.parentNode.insertBefore(clone,original.nextSibling);
 }
+$(document).ready(function() {
+	$("form#serials_edit").submit(function() {
+	    var total_errors = 0;
+        $(".subfield_line:visible", this).each(function() {
+            if ($("*[name=field_value]", this).val().length == 0 &&
+                $("*[name=mandatory]", this).val() == 1) {
+                total_errors++;
+            }
+        });
+        if ( total_errors > 0 ) {
+            var mes  = _("Form not submitted because of the following problem(s)");
+            mes += "\n------------------------------------------------------------------------------------\n";
+            mes += "\n- "+ total_errors+_(" mandatory fields empty (see bold subfields)");
+            alert(mes);
+            return false;
+        }
+    });
+});
 //]]>
 </script>
 <style type="text/css">#serials_edit fieldset.rows label, #serials_edit fieldset.rows span.label {
@@ -424,7 +419,7 @@ function CloneSubfield(index){
 <!-- /TMPL_LOOP -->
 
 </table>
-    <fieldset class="action"><input type="submit" value="Save"  class="button" accesskey="w" /> <!--onclick="Check(this.form)" --></fieldset>
+    <fieldset class="action"><input type="submit" value="Save"  class="button" accesskey="w" />
 </form>
 
 </div>
-- 
2.39.2