From 364844cfd75bc2fdc188147993344bd63eb5d0a9 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 4 Mar 2016 12:29:03 -0500
Subject: [PATCH] Bug 15983: Use Font Awesome icons in serial numbering pattern
 deletion confirmation dialog

If you try to delete a serial numbering pattern which is in use by an
existing subscription you will be shown a confirmation dialog. This
dialog should use Font Awesome icons.

Other minor changes:

- Added "action" attributes to <form>s to fix validation errors.
- Added "alert" class to confirmation dialogs so that they correctly
  styled.

To test, apply the patch and go to Serials -> Numbering patterns.

- Click "Delete" on a numbering pattern which is in use by a
  subscription.
- Verify that the confirmation dialog is styled correctly.
- Test that the "No, do not delete" button works correctly.
- Test that the "Yes, delete" button deletes the correct numbering
  pattern.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---
 .../modules/serials/subscription-numberpatterns.tt | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
index 07c1f0d2b3..e1a15e2eb4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
@@ -91,14 +91,14 @@ $(document).ready(function(){
           [% IF (new) %]
             <h1>New numbering pattern</h1>
             [% IF (error_existing_numberpattern) %]
-              <div class="dialog">
+              <div class="dialog alert">
                 <p>A pattern with this name already exists.</p>
               </div>
             [% END %]
           [% ELSE %]
             <h1>Modify pattern: [% label %]</h1>
             [% IF (error_existing_numberpattern) %]
-              <div class="dialog">
+              <div class="dialog alert">
                 <p>Another pattern with this name already exists.</p>
               </div>
             [% END %]
@@ -278,7 +278,7 @@ $(document).ready(function(){
       [% ELSE %]
         <h1>Numbering patterns</h1>
         [% IF still_used %]
-            <div class="dialog">
+            <div class="dialog alert">
                 <p>
                     This pattern is still used by [% subscriptions.size %]
                     subscription(s). Do you still want to delete it?
@@ -292,14 +292,14 @@ $(document).ready(function(){
                     [% END %]
                 </ul>
 
-                <form action="" method="get">
+                <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="get">
                     <input type="hidden" name="op" value="del" />
                     <input type="hidden" name="confirm" value="1" />
                     <input type="hidden" name="id" value="[% id %]" />
-                    <input type="submit" class="approve" value="Yes, delete" />
+                    <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button>
                 </form>
-                <form action="" method="get">
-                    <input type="submit" class="deny" value="No, don't delete" />
+                <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="get">
+                    <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
                 </form>
             </div>
         [% END %]
-- 
2.39.5