From 365bde387743acbaa09f0d3f0cb93235f5845159 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 21 Apr 2022 18:17:41 +0000
Subject: [PATCH] Bug 28138: (follow-up) Add empty option to payment type
 selection

This patch adds an empty <option> to the "Payment type" selection when
paying fine. This forces the user to actively make a selection. I've
also added the text "None selected" to the other empty <option> on the
page for consistency.

To test, apply the patch and test the pay fine interface with and
without the RequirePaymentType preference enabled. When enabled the
payment type should be required and it should default to "None
selected."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc
index cc1ef8a0cb..e71b3fc8ee 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc
@@ -9,6 +9,7 @@
         [% IF Koha.Preference('UseCashRegisters') || Koha.Preference('RequirePaymentType') %]
             <label for="[% type | html %]_type" class="required">[% IF type == 'payment' %]Payment[% ELSE %]Transaction[% END %] type: </label>
             <select name="[% type | html %]_type" id="[% type | html %]_type" class="required" required="required">
+                <option value="">None selected</option>
                 [% IF type == 'refund' %]
                 <option value="AC">Account credit</option>
                 [% END %]
@@ -20,7 +21,7 @@
         [%- ELSE -%]
             <label for="[% type | html %]_type">[% IF type == 'payment' %]Payment[% ELSE %]Transaction[% END %] type: </label>
             <select name="[% type | html %]_type" id="[% type | html %]_type">
-                <option value=""></option>
+                <option value="">None selected</option>
                 [% IF type == 'refund' %]
                 <option value="AC">Account credit</option>
                 [% END %]
-- 
2.39.5