From 3b4564001d571304490fe81dbd92e656fc9ad53e Mon Sep 17 00:00:00 2001 From: Hector Castro Date: Tue, 19 Jul 2016 14:58:58 -0600 Subject: [PATCH] Bug 16944: Add "email" and "url" classes when edit or create a vendor MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When edit or create a new vendor the two fields "email" and "website" don't test if the data provided is right. When you add a direction like "koha-community.org" without the protocol "https" the program redirect to an 404 error. To reproduce the issue: 1-Go to Acquisition and create a new Vendor 2-Fill the field Website with koha-community.org 3-Use an email without at sing (@) 4-Notice that there is no error 5-Save 6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1) 7-Click in Website: koha-community.org -> redirect to an 404 error 8-Notice the bad mailto: To test: -Apply patch -Reproduce step 1 to 8 with the same vendor or create a new one -Enter multiple wrong and valid urls -Enter urls with and without protocols http, https, ftp -Enter wrong and valid emails NOTE: The classes used are taken from 'branches.tt' Signed-off-by: Liz Rea no longer allows entering of improper website urls or incomplete email addresses. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 71d20a8c3b48a4dd1c7fb569b3baf2352d9757ac) Signed-off-by: Frédéric Demians --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt index 72302da81d..02e143af7b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt @@ -13,7 +13,7 @@
  • -
  • +
  • @@ -188,7 +188,7 @@ function delete_contact(ev) {
  • -
  • +
  • -- 2.39.5