From 3cf3782a6097067d57030772417c3a2fe5cc9566 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 9 Sep 2019 16:58:04 +0000 Subject: [PATCH] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. Signed-off-by: Lucas Gass Signed-off-by: Bouzid Fergani Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 075261645e1650629038c9a09e8d9e387bcc5474) Signed-off-by: Fridolin Somers --- .../prog/en/modules/catalogue/itemsearch.tt | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index a220e1c4f8..7adecfe6ac 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -457,15 +457,16 @@ } } }); - $('#itemsearchform').submit(function() { - var searchform = $(this); - var format = searchform.find('input[name="format"]:checked').val(); - if (format == 'html') { + }); + + $('#itemsearchform').submit(function() { + var searchform = $(this); + var format = searchform.find('input[name="format"]:checked').val(); + if (format == 'html') { submitForm(searchform); $("#item-search-block").hide(); return false; - } - }); + } }); }); -- 2.39.5