From 3d1556dafa7cd09614f86512cae8fa2e215d9ab7 Mon Sep 17 00:00:00 2001 From: Andreas Roussos Date: Mon, 13 Dec 2021 07:49:07 +0100 Subject: [PATCH] Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps Signed-off-by: Katrin Fischer Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt index 02f0bbac29..833c27a020 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt @@ -41,7 +41,7 @@ [% END %] [% END %]
- [% IF ( suggestion && suggestions_count ) %] + [% IF ( suggestions_count || all_pendingsuggestions ) %]
[% ELSE %]
@@ -58,7 +58,7 @@
-[% IF ( CAN_user_suggestions_suggestions_manage && suggestion && suggestions_count ) %] +[% IF ( CAN_user_suggestions_suggestions_manage && ( suggestions_count || all_pendingsuggestions ) ) %]
-- 2.39.5