From 44f9e34f0272801ff2f5977a0df454d918d02a83 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 24 Oct 2019 14:15:41 +0000 Subject: [PATCH] Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson (cherry picked from commit 1fa36b1d94e0ae03e8913cdfc66edf91e99ec066) Signed-off-by: Lucas Gass --- .../prog/css/src/staff-global.scss | 20 +++++++++++-------- .../prog/en/modules/cataloguing/editor.tt | 2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 6c04d6bd60..c35b9d674f 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -2397,14 +2397,6 @@ li { padding: 5px 25em 0 0; } } - - .dropdown-header { - border-top: 1px solid #EEE; - color: #000; - font-weight: bold; - padding-left: 10px; - } - } #search-facets { @@ -3315,6 +3307,18 @@ video { // Bootstrap overrides +.dropdown-header { + border-top: 1px solid #EEE; + color: #000; + font-weight: bold; + margin-top: 5px; + padding-left: 10px; + + &:first-child { + border-top: 0; + } +} + nav { background: #E6F0F2 none; border: 0; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt index d313fd982a..f082404965 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt @@ -46,7 +46,7 @@