From 484d4cbbdd203578062f2dd6e15af788a0f7c1e0 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 7 Nov 2017 15:29:56 +0100 Subject: [PATCH] Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy Signed-off-by: Grace Smyth Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt index 1ff0968c4a..346b36d7dc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt @@ -347,11 +347,14 @@ if( $("#uploadbarcodes").val() ) { $("#setdate").prop('disabled',false); $("#compareinv2barcd").prop('disabled',false); + $("#compareinv2barcd").attr('checked',true); // default $("#dont_checkin").prop('disabled',false); if( $("#compareinv2barcd").attr('checked') ) { $("fieldset#optionalfilters").show(); + $("#ignoreissued").attr('checked',true); // default } else { $("fieldset#optionalfilters").hide(); + $("#ignoreissued").attr('checked',false); } } else { $("#setdate").prop('disabled',true); @@ -365,7 +368,9 @@ $("#compareinv2barcd").click(function() { if( $("#compareinv2barcd").attr('checked') ) { $("fieldset#optionalfilters").show(); + $("#ignoreissued").attr('checked',true); // default } else { + $("#ignoreissued").attr('checked',false); $("fieldset#optionalfilters").hide(); } }); -- 2.39.5