From 486f81be1013a8389a620bd14d3a29849038d455 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 12 Sep 2023 16:20:39 +0000 Subject: [PATCH] Bug 34769: Improve translation of title tags: Patron lists This patch updates patron lists templates so that title tags can be more easily translated. Some templates have been updated for consistency as well: Harmonizing page title, breaddrumb navigation, and page headers. To test, apply the patch and confirm that the following pages have the correct title tags: - Tools -> Patron lists - New patron list - View patron list - Edit patron list Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- .../prog/en/modules/patron_lists/add-modify.tt | 14 ++++---------- .../prog/en/modules/patron_lists/list.tt | 6 +----- .../prog/en/modules/patron_lists/lists.tt | 2 +- 3 files changed, 6 insertions(+), 16 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt index 142efe84a3..7cc644537e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt @@ -5,7 +5,7 @@ [% INCLUDE 'doc-head-open.inc' %] [% FILTER collapse %] [% IF list.patron_list_id %] - [% t("Modify patron list") | html %] + [% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %] [% ELSE %] [% t("New patron list") | html %] [% END %] › @@ -31,7 +31,7 @@ [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] [% IF list.patron_list_id %] - <span>Modify patron list</span> + [% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %] [% ELSE %] <span>New patron list</span> [% END %] @@ -44,7 +44,7 @@ <div class="col-sm-6 col-sm-offset-3 col-md-6 col-md-offset-3"> <h1> [% IF list.patron_list_id %] - <span>Modify patron list</span> + [% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %] [% ELSE %] <span>New patron list</span> [% END %] @@ -53,13 +53,7 @@ <form method="post" action="/cgi-bin/koha/patron_lists/add-modify.pl" class="validated"> <fieldset class="rows"> - <legend> - [% IF list.patron_list_id %] - <span>Modify patron list</span> - [% ELSE %] - <span>Create a new patron list</span> - [% END %] - </legend> + <legend class="sr-only">Patron list details</legend> <ol> <li> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt index be8c885b87..575b6394a3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt @@ -7,7 +7,6 @@ [% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'columns_settings.inc' %] <title>[% FILTER collapse %] - [% t("Add patrons") | html %] › [% list.name | html %] › [% t("Patron lists") | html %] › [% t("Tools") | html %] › @@ -44,11 +43,8 @@ [% WRAPPER breadcrumb_item %] <a href="lists.pl">Patron lists</a> [% END %] - [% WRAPPER breadcrumb_item %] - <a href="/cgi-bin/koha/patron_lists/list.pl?patron_list_id=[% list.id | uri %]">[% list.name | html %]</a> - [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - <span>Add patrons</span> + [% list.name | html %] [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt index 2404e9cd07..2866a8b04d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt @@ -39,7 +39,7 @@ </div> </div> - <h1>Your patron lists</h1> + <h1>Patron lists</h1> [% IF ( lists ) %] -- 2.39.2