From 4b22dff729dd9be1992553492bba662f65940154 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 13 Apr 2023 14:38:58 +0100 Subject: [PATCH] Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6f68b350ba24acbcd94179b6f005949a2f1f908f) Signed-off-by: Matt Blenkinsop --- t/cypress/integration/ERM/Agreements_spec.ts | 38 ++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/t/cypress/integration/ERM/Agreements_spec.ts b/t/cypress/integration/ERM/Agreements_spec.ts index cd7689c31e..3a3954f00d 100644 --- a/t/cypress/integration/ERM/Agreements_spec.ts +++ b/t/cypress/integration/ERM/Agreements_spec.ts @@ -156,6 +156,44 @@ describe("Agreement CRUD operations", () => { cy.intercept("GET", "/api/v1/erm/agreements/*", agreement); cy.visit("/cgi-bin/koha/erm/agreements"); cy.get("#agreements_list").contains("Showing 1 to 1 of 1 entries"); + cy.get(".filters").find("label").should(($labels) => { + expect($labels).to.have.length(2) + expect($labels.eq(0)).to.contain('Filter by expired') + expect($labels.eq(1)).to.contain('Show mine only') + }); // Filter options appear + + // Test filtering + cy.intercept("GET", "/api/v1/erm/agreements?max_expiration_date=*", []).as("getActiveAgreements"); + cy.get("#expired_filter").check(); + cy.get("#filter_table").click(); + cy.wait('@getActiveAgreements') + .its('request.url') + .should('include', 'max_expiration_date='+dates["today_iso"]); // Defaults to today + cy.get("#max_expiration_date_filter").should("have.value", dates["today_iso"]); // Input box reflects default + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated + + // Now test that the url for this particular state works + cy.visit("/cgi-bin/koha/erm/agreements?by_expired=true"); + cy.wait('@getActiveAgreements').its('request.url').should('include', 'max_expiration_date='+dates["today_iso"]); + + // Now test with a user entered date + cy.get("#max_expiration_date_filter+input").click({ force: true }); + cy.get(".flatpickr-calendar") + .eq(0) + .find("span.today") + .next("span") + .click(); // select tomorrow + cy.get("#filter_table").click(); + cy.wait('@getActiveAgreements').its('request.url').should('include', 'max_expiration_date='+dates["tomorrow_iso"]); + cy.get("#max_expiration_date_filter").should("have.value", dates["tomorrow_iso"]); + // Assert that browser url changed again to reflect the user entered date + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date="+dates["tomorrow_iso"]); + + // Now test that the url for the updated state works + cy.visit("/cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date="+dates["tomorrow_iso"]); + cy.wait('@getActiveAgreements').its('request.url').should('include', 'max_expiration_date='+dates["tomorrow_iso"]); + + // Test filter button with show mine_only ticked }); it("Add agreement", () => { -- 2.39.5