From 4b5570c6aa4f22b8f6734178f72e0a5212324296 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 22 Oct 2019 11:51:54 +0200
Subject: [PATCH] Bug 23594: Fix [un]checkall links
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../prog/en/modules/suggestion/suggestion.tt              | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index 075b7c62a9..11a5cbfe2d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -498,7 +498,7 @@
 <form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#tab_[% loop.count %]">
 
 [% IF ( suggestion.suggestions_loop ) %]
-<p><a class="checkall" href="#">Check all</a> | <a name="uncheckall" href="#">Uncheck all</a></p>
+<p><a class="checkall" href="#">Check all</a> | <a class="uncheckall" href="#">Uncheck all</a></p>
     <table id="table_[% loop.count %]" class="sorted">
         <thead>
             <tr>
@@ -856,11 +856,13 @@
                 [% END %]
 
                 $(".checkall").click(function(e){
-                    $(this).parent(form).checkCheckboxes();
+                    e.preventDefault();
+                    $(this).parents('form').checkCheckboxes();
                     return false;
                 });
                 $(".uncheckall").click(function(e){
-                    $(this).parent(form).unCheckCheckboxes();
+                    e.preventDefault();
+                    $(this).parents('form').unCheckCheckboxes();
                     return false;
                 });
                 $(".other_reason").hide();
-- 
2.39.5