From 4c68cebdef064a59cdd690f7492884c6d48dd765 Mon Sep 17 00:00:00 2001 From: Thomas Date: Wed, 14 Jan 2015 23:26:36 +0000 Subject: [PATCH] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. Signed-off-by: Katrin Fischer The page requires borrowers permission, so the link should act accordingly. Signed-off-by: Jonathan Druart Same problem for Fines, Circulation history, Notices and Statistics tabs. circ-menu.tt is only used from the Fines tab (which is not accessible), to it's not useful to add this check to it. But for the consistency, it makes sense. follow-up coming. Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 2fe0a6857c..d93b49468b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -83,7 +83,10 @@ [% IF EnableBorrowerFiles %] [% IF ( borrower_files ) %]
  • [% ELSE %]
  • [% END %]Files
    • [% END %] - [% IF ( suggestionsview ) %]
  • [% ELSE %]
  • [% END %]Purchase suggestions
    • + + [% IF ( CAN_user_borrowers ) %] + [% IF ( suggestionsview ) %]
  • [% ELSE %]
  • [% END %]Purchase suggestions
    • + [% END %] [% END %] -- 2.39.5