From 4f9fa72828ddeccc31a541de6065a05e6c72f697 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 19 Jul 2023 09:32:15 +0200
Subject: [PATCH] Bug 34075: Improve JS code

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/authorities/detail.tt      | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
index cb5fca30f6..ed8462716d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
@@ -136,18 +136,18 @@
     <script>
         $(document).ready(function() {
             if( $("#authoritiestabs .tab-pane.active").length < 1 ){
+                let tab_object;
+
                 [% SET DefaultAuthorityTab = Koha.Preference('DefaultAuthorityTab') %]
                 [% IF DefaultAuthorityTab %]
-                    let default_tab = "#tab" + [% DefaultAuthorityTab | html %] + "XX-tab";
-                    let tab_object = $("#authoritiestabs "+default_tab)
-                    if( tab_object.length > 0 ){
-                        tab_object.tab("show");
-                    } else {
-                        $("#authoritiestabs a:first").tab("show");
-                    }
-                [% ELSE %]
-                    $("#authoritiestabs a:first").tab("show");
+                    tab_object = $("#authoritiestabs #tab[% DefaultAuthorityTab | html %]XX-tab");
                 [% END %]
+
+                if( tab_object.length > 0 ){
+                    tab_object.tab("show");
+                } else {
+                    $("#authoritiestabs a:first").tab("show");
+                }
             }
 
             var editAuth = $("#editAuth");
-- 
2.20.1