From 55439f8994d89c22b62233a5b180d864705a6174 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 30 Mar 2015 10:16:31 -0400 Subject: [PATCH] Bug 13919: Renewal possible with item level hold on item MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- C4/Circulation.pm | 87 +++++++++++++++++++++++++---------------------- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index dd237342d4..d3f8668d33 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2667,53 +2667,60 @@ sub CanBookBeRenewed { { my $schema = Koha::Database->new()->schema(); - # Get all other items that could possibly fill reserves - my @itemnumbers = $schema->resultset('Item')->search( - { - biblionumber => $resrec->{biblionumber}, - onloan => undef, - -not => { itemnumber => $itemnumber } - }, - { columns => 'itemnumber' } - )->get_column('itemnumber')->all(); - - # Get all other reserves that could have been filled by this item - my @borrowernumbers; - while (1) { - my ( $reserve_found, $reserve, undef ) = - C4::Reserves::CheckReserves( $itemnumber, undef, undef, - \@borrowernumbers ); - - if ($reserve_found) { - push( @borrowernumbers, $reserve->{borrowernumber} ); - } - else { - last; - } + my $item_holds = $schema->resultset('Reserve')->search( { itemnumber => $itemnumber, found => undef } )->count(); + if ($item_holds) { + # There is an item level hold on this item, no other item can fill the hold + $resfound = 1; } + else { - # If the count of the union of the lists of reservable items for each borrower - # is equal or greater than the number of borrowers, we know that all reserves - # can be filled with available items. We can get the union of the sets simply - # by pushing all the elements onto an array and removing the duplicates. - my @reservable; - foreach my $b (@borrowernumbers) { - my ( $borr ) = C4::Members::GetMemberDetails( $b ); - foreach my $i (@itemnumbers) { - my $item = GetItem($i); - if ( IsAvailableForItemLevelRequest($item, $borr) - && CanItemBeReserved( $b, $i ) - && !IsItemOnHoldAndFound($i) ) + # Get all other items that could possibly fill reserves + my @itemnumbers = $schema->resultset('Item')->search( { - push( @reservable, $i ); + biblionumber => $resrec->{biblionumber}, + onloan => undef, + -not => { itemnumber => $itemnumber } + }, + { columns => 'itemnumber' } + )->get_column('itemnumber')->all(); + + # Get all other reserves that could have been filled by this item + my @borrowernumbers; + while (1) { + my ( $reserve_found, $reserve, undef ) = + C4::Reserves::CheckReserves( $itemnumber, undef, undef, \@borrowernumbers ); + + if ($reserve_found) { + push( @borrowernumbers, $reserve->{borrowernumber} ); + } + else { + last; + } + } + + # If the count of the union of the lists of reservable items for each borrower + # is equal or greater than the number of borrowers, we know that all reserves + # can be filled with available items. We can get the union of the sets simply + # by pushing all the elements onto an array and removing the duplicates. + my @reservable; + foreach my $b (@borrowernumbers) { + my ($borr) = C4::Members::GetMemberDetails($b); + foreach my $i (@itemnumbers) { + my $item = GetItem($i); + if ( IsAvailableForItemLevelRequest( $item, $borr ) + && CanItemBeReserved( $b, $i ) + && !IsItemOnHoldAndFound($i) ) + { + push( @reservable, $i ); + } } } - } - @reservable = uniq(@reservable); + @reservable = uniq(@reservable); - if ( @reservable >= @borrowernumbers ) { - $resfound = 0; + if ( @reservable >= @borrowernumbers ) { + $resfound = 0; + } } } -- 2.39.5